Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 13, 2015, 10:57 a.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Changes --- Addresses Bernd's and Tim's issues. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs (updated) - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto a4a9c6f3afa2441e958e472b264c57b5c5d18eb1 include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2 src/Makefile.am 111aed92820689b12ee4073269ce34db7be30960 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 579c009a1b43bc25c294366de29a56dacc734791 src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/master/master.hpp 4e2947003247c3d7bf407d6d709faf2e878418f3 src/master/master.cpp 398203d9367f85340166e66ecc34b9a33dd81048 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp 422ebd17da045002294e67027e9ebe1377bc53cd src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 13, 2015, 1:20 p.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Changes --- Fixed Typo. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs (updated) - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto a4a9c6f3afa2441e958e472b264c57b5c5d18eb1 include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2 src/Makefile.am 111aed92820689b12ee4073269ce34db7be30960 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 579c009a1b43bc25c294366de29a56dacc734791 src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/master/master.hpp 4e2947003247c3d7bf407d6d709faf2e878418f3 src/master/master.cpp 398203d9367f85340166e66ecc34b9a33dd81048 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp 422ebd17da045002294e67027e9ebe1377bc53cd src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review95249 --- Ship it! Fix minor typo, then ship it! (We know that this is not the eventual intended shape of authz, but it is a self-contained, consistent step in the right direction.) include/mesos/authorizer/authorizer.hpp (line 61) https://reviews.apache.org/r/36048/#comment150104 s/is/if - Bernd Mathiske On Aug. 13, 2015, 1:57 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 13, 2015, 1:57 a.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto a4a9c6f3afa2441e958e472b264c57b5c5d18eb1 include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2 src/Makefile.am 111aed92820689b12ee4073269ce34db7be30960 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 579c009a1b43bc25c294366de29a56dacc734791 src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/master/master.hpp 4e2947003247c3d7bf407d6d709faf2e878418f3 src/master/master.cpp 398203d9367f85340166e66ecc34b9a33dd81048 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp 422ebd17da045002294e67027e9ebe1377bc53cd src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 13, 2015, 7:08 p.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Changes --- Addresses Tim's issues. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs (updated) - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto a4a9c6f3afa2441e958e472b264c57b5c5d18eb1 include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2 src/Makefile.am 111aed92820689b12ee4073269ce34db7be30960 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 579c009a1b43bc25c294366de29a56dacc734791 src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/master/master.hpp 4e2947003247c3d7bf407d6d709faf2e878418f3 src/master/master.cpp 398203d9367f85340166e66ecc34b9a33dd81048 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp 422ebd17da045002294e67027e9ebe1377bc53cd src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
On Aug. 13, 2015, 6:43 p.m., Timothy Chen wrote: src/authorizer/authorizer.cpp, line 19 https://reviews.apache.org/r/36048/diff/18/?file=1039308#file1039308line19 Is this our new style guide rule too to put this up before all other imports? Otherwise I would have still sort it the way we used to It comes from the google style guide, which we are taking more seriously: the first include should be that of the companion header. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review95271 --- On Aug. 13, 2015, 7:08 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 13, 2015, 7:08 p.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto a4a9c6f3afa2441e958e472b264c57b5c5d18eb1 include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2 src/Makefile.am 111aed92820689b12ee4073269ce34db7be30960 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 579c009a1b43bc25c294366de29a56dacc734791 src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/master/master.hpp 4e2947003247c3d7bf407d6d709faf2e878418f3 src/master/master.cpp 398203d9367f85340166e66ecc34b9a33dd81048 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp 422ebd17da045002294e67027e9ebe1377bc53cd src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
On Aug. 13, 2015, 8:06 p.m., Till Toenshoff wrote: Thanks for your patience Alexander - I know it has been a long journey - in the end, I think things are in great shape minus some nits I just discovered on my final pass. Please note that I will commit while fixing the noted issues but I will leave them open for your attention :) - close once you saw them. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review95266 --- On Aug. 13, 2015, 5:08 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 13, 2015, 5:08 p.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto a4a9c6f3afa2441e958e472b264c57b5c5d18eb1 include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2 src/Makefile.am 111aed92820689b12ee4073269ce34db7be30960 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 579c009a1b43bc25c294366de29a56dacc734791 src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/master/master.hpp 4e2947003247c3d7bf407d6d709faf2e878418f3 src/master/master.cpp 398203d9367f85340166e66ecc34b9a33dd81048 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp 422ebd17da045002294e67027e9ebe1377bc53cd src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review95266 --- Ship it! Thanks for your patience Alexander - I know it has been a long journey - in the end, I think things are in great shape minus some nits I just discovered on my final pass. include/mesos/authorizer/authorizer.proto (line 85) https://reviews.apache.org/r/36048/#comment150212 This iff did suprise me for a moment. if and only if was meant, learned something new :) - thanks for pointing this out Alexander. src/authorizer/authorizer.hpp (line 26) https://reviews.apache.org/r/36048/#comment150219 Missing: `#include stout/nothing.hpp` `#include stout/option.hpp` - will add these while committing. src/authorizer/authorizer.cpp (line 30) https://reviews.apache.org/r/36048/#comment150221 Not used - will remove while committing. src/local/local.cpp (line 41) https://reviews.apache.org/r/36048/#comment150222 `#include stout/nothing.hpp` missing - will add while committing. src/tests/mesos.hpp (line 53) https://reviews.apache.org/r/36048/#comment150224 `#include stout/nothing.hpp` missing - will add while committing. - Till Toenshoff On Aug. 13, 2015, 5:08 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 13, 2015, 5:08 p.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto a4a9c6f3afa2441e958e472b264c57b5c5d18eb1 include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2 src/Makefile.am 111aed92820689b12ee4073269ce34db7be30960 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 579c009a1b43bc25c294366de29a56dacc734791 src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/master/master.hpp 4e2947003247c3d7bf407d6d709faf2e878418f3 src/master/master.cpp 398203d9367f85340166e66ecc34b9a33dd81048 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp 422ebd17da045002294e67027e9ebe1377bc53cd src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 12, 2015, 4:56 p.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs (updated) - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto 8a423a56a341e380434e7df91868f1813024840c include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2 src/Makefile.am 07502f0f5523b972888ceab9cf3af309c8441d7f src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 579c009a1b43bc25c294366de29a56dacc734791 src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/master/master.hpp 4e2947003247c3d7bf407d6d709faf2e878418f3 src/master/master.cpp 398203d9367f85340166e66ecc34b9a33dd81048 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp 422ebd17da045002294e67027e9ebe1377bc53cd src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review95096 --- include/mesos/authorizer/authorizer.hpp (line 139) https://reviews.apache.org/r/36048/#comment149911 Space between operator and src/authorizer/authorizer.hpp (line 43) https://reviews.apache.org/r/36048/#comment149912 Why removed Owned? src/authorizer/authorizer.cpp (line 229) https://reviews.apache.org/r/36048/#comment149913 What's the reason to move this logic from create to initialize? - Timothy Chen On Aug. 12, 2015, 2:56 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 12, 2015, 2:56 p.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto 8a423a56a341e380434e7df91868f1813024840c include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2 src/Makefile.am 07502f0f5523b972888ceab9cf3af309c8441d7f src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 579c009a1b43bc25c294366de29a56dacc734791 src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/master/master.hpp 4e2947003247c3d7bf407d6d709faf2e878418f3 src/master/master.cpp 398203d9367f85340166e66ecc34b9a33dd81048 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp 422ebd17da045002294e67027e9ebe1377bc53cd src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review95106 --- Good points Alex, can you leave comments on this in the code of to why this is being done differently? - Timothy Chen On Aug. 12, 2015, 2:56 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 12, 2015, 2:56 p.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto 8a423a56a341e380434e7df91868f1813024840c include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2 src/Makefile.am 07502f0f5523b972888ceab9cf3af309c8441d7f src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 579c009a1b43bc25c294366de29a56dacc734791 src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/master/master.hpp 4e2947003247c3d7bf407d6d709faf2e878418f3 src/master/master.cpp 398203d9367f85340166e66ecc34b9a33dd81048 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp 422ebd17da045002294e67027e9ebe1377bc53cd src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
On Aug. 12, 2015, 5:57 p.m., Timothy Chen wrote: include/mesos/authorizer/authorizer.hpp, line 139 https://reviews.apache.org/r/36048/diff/16/?file=1038383#file1038383line139 Space between operator and The rule changed, we no longer put spaces between operators. Check commit 888e56e and review https://reviews.apache.org/r/37013 also the mail list had a vote on it. On Aug. 12, 2015, 5:57 p.m., Timothy Chen wrote: src/authorizer/authorizer.hpp, line 71 https://reviews.apache.org/r/36048/diff/16/?file=1038388#file1038388line71 Why removed Owned? The reason is that we want to modularize the `Authorizer` interface, so instances can be called through `templatetypename T TryT* ModuleManager::create(const string name)`. Mostly for testing reasons, there are some constraints on how create should look, among them returning `TryT*` and being default constructible. On Aug. 12, 2015, 5:57 p.m., Timothy Chen wrote: src/authorizer/authorizer.cpp, line 246 https://reviews.apache.org/r/36048/diff/16/?file=1038389#file1038389line246 What's the reason to move this logic from create to initialize? As mentioned before, default implementations of modules are required to be default destructible, which makes passing construction parameters quite complicated. I filled a JIRA ([MESOS-3072](https://issues.apache.org/jira/browse/MESOS-3072)) on the matter. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review95096 --- On Aug. 12, 2015, 4:56 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 12, 2015, 4:56 p.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto 8a423a56a341e380434e7df91868f1813024840c include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2 src/Makefile.am 07502f0f5523b972888ceab9cf3af309c8441d7f src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 579c009a1b43bc25c294366de29a56dacc734791 src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/master/master.hpp 4e2947003247c3d7bf407d6d709faf2e878418f3 src/master/master.cpp 398203d9367f85340166e66ecc34b9a33dd81048 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp 422ebd17da045002294e67027e9ebe1377bc53cd src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
On Aug. 12, 2015, 6:04 a.m., Bernd Mathiske wrote: include/mesos/authorizer/authorizer.hpp, line 49 https://reviews.apache.org/r/36048/diff/15/?file=1036353#file1036353line49 If this is only relevant for the default implementation, then this method should be declared there, not here. Well. I can see why we need this method declared here. It becomes clear in the subsequent patch: we have a module system structure that requires it. Can you maybe explain in your comment here what the reason for declaring a method that is only used in one case is? - Bernd --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review95079 --- On Aug. 10, 2015, 7:35 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 10, 2015, 7:35 a.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807 include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2 src/Makefile.am 942003149b071a322933e2c085d9122903f69713 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 1702b07d11c578cfee31871521106501c8eec357 src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/master/master.hpp 10cc100b1cf10aa7a8a9979a2562a9c5a9e55bd6 src/master/master.cpp 08dd34d9d18f547c6e8d04caf9e39a2b3ffc5f63 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp 422ebd17da045002294e67027e9ebe1377bc53cd src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review95079 --- include/mesos/authorizer/authorizer.hpp (line 48) https://reviews.apache.org/r/36048/#comment149893 What does initializing an instance with ACLs mean? include/mesos/authorizer/authorizer.hpp (line 49) https://reviews.apache.org/r/36048/#comment149899 If this is only relevant for the default implementation, then this method should be declared there, not here. include/mesos/authorizer/authorizer.hpp (line 56) https://reviews.apache.org/r/36048/#comment149892 s/is/if include/mesos/authorizer/authorizer.hpp (line 68) https://reviews.apache.org/r/36048/#comment149894 the ACLs - which ACLs? s/it/this method include/mesos/authorizer/authorizer.hpp (line 69) https://reviews.apache.org/r/36048/#comment149895 You mean I can get authorized just by retrying? Please describe this some other way! include/mesos/authorizer/authorizer.hpp (line 76) https://reviews.apache.org/r/36048/#comment149896 What ACLs? include/mesos/authorizer/authorizer.hpp (line 78) https://reviews.apache.org/r/36048/#comment149897 How does mere repetition lead to success here? include/mesos/authorizer/authorizer.hpp (line 84) https://reviews.apache.org/r/36048/#comment149898 s/launch/run - Bernd Mathiske On Aug. 10, 2015, 7:35 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 10, 2015, 7:35 a.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807 include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2 src/Makefile.am 942003149b071a322933e2c085d9122903f69713 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 1702b07d11c578cfee31871521106501c8eec357 src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/master/master.hpp 10cc100b1cf10aa7a8a9979a2562a9c5a9e55bd6 src/master/master.cpp 08dd34d9d18f547c6e8d04caf9e39a2b3ffc5f63 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp 422ebd17da045002294e67027e9ebe1377bc53cd src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 12, 2015, 3:52 p.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807 include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2 src/Makefile.am 942003149b071a322933e2c085d9122903f69713 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 1702b07d11c578cfee31871521106501c8eec357 src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/master/master.hpp 10cc100b1cf10aa7a8a9979a2562a9c5a9e55bd6 src/master/master.cpp 08dd34d9d18f547c6e8d04caf9e39a2b3ffc5f63 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp 422ebd17da045002294e67027e9ebe1377bc53cd src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 10, 2015, 4:35 p.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Changes --- mcpark changes. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs (updated) - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807 include/mesos/type_utils.hpp 6ff061c94e9d3dbb55bd047840b2012d11e3a0f2 src/Makefile.am 942003149b071a322933e2c085d9122903f69713 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 1702b07d11c578cfee31871521106501c8eec357 src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/master/master.hpp 10cc100b1cf10aa7a8a9979a2562a9c5a9e55bd6 src/master/master.cpp 08dd34d9d18f547c6e8d04caf9e39a2b3ffc5f63 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp 422ebd17da045002294e67027e9ebe1377bc53cd src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 6, 2015, 1:59 p.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs (updated) - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba include/mesos/type_utils.hpp f1cb5e279073c5195fc41dada307a10d00c84955 src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3 src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/master/master.hpp 30a2550c606ca528ec5b69fc9efedd698d67c5f2 src/master/master.cpp 50b98248463fc4cd48962890c14c7ad64f2b6f43 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b src/tests/mesos.hpp 20418d4fbd2f4ae35ee0c707472cbf37125883b0 src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
On Aug. 3, 2015, 4:20 p.m., Bernd Mathiske wrote: include/mesos/authorizer/authorizer.proto, line 28 https://reviews.apache.org/r/36048/diff/11/?file=1017127#file1017127line28 What is local authorization? Link or explanation, please! Added the sentence `(See authorization.md file in the docs)`. Is that enough? On Aug. 3, 2015, 4:20 p.m., Bernd Mathiske wrote: src/tests/authorization_tests.cpp, line 48 https://reviews.apache.org/r/36048/diff/11/?file=1017141#file1017141line48 Please stick to Owned as before. Less probability of mistakes (even though I don't see any in the present code). Cannot be done since `ModuleManager` which is the instantiation usage in the next patch returns an `TryT*`. I will however store the pointer in an `Owned`. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review93900 --- On Aug. 4, 2015, 4:13 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 4, 2015, 4:13 p.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba include/mesos/type_utils.hpp 86b37ca1f63e4687af4e86731dceeb1c9c219c5e src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b src/tests/mesos.hpp 93d87c78e5665b8104dbbc3d1e8c92e515cc67ab src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 5, 2015, 11:04 a.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Changes --- Reviewer's issues. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs (updated) - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba include/mesos/type_utils.hpp 86b37ca1f63e4687af4e86731dceeb1c9c219c5e src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 76e70801925041f08bc94f0ca18c86f1a573b2b3 src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/master/master.hpp e44174976aa64176916827bec4c911333c9a91db src/master/master.cpp 5aa0a5410804fe16abd50b6953f1ffe46a019ecf src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b src/tests/mesos.hpp 20418d4fbd2f4ae35ee0c707472cbf37125883b0 src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 4, 2015, 4:13 p.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Changes --- Rebase, changes requested by reviewers. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs (updated) - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba include/mesos/type_utils.hpp 86b37ca1f63e4687af4e86731dceeb1c9c219c5e src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b src/tests/mesos.hpp 93d87c78e5665b8104dbbc3d1e8c92e515cc67ab src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review94059 --- include/mesos/authorizer/authorizer.hpp (line 83) https://reviews.apache.org/r/36048/#comment148560 If the request satifies the ACLs, it returns true. There's another one below. include/mesos/authorizer/authorizer.hpp (line 91) https://reviews.apache.org/r/36048/#comment148561 s/the ACL/the ACLs to be consistent with the paragraph above. - Jan Schlicht On Aug. 4, 2015, 4:13 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 4, 2015, 4:13 p.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba include/mesos/type_utils.hpp 86b37ca1f63e4687af4e86731dceeb1c9c219c5e src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b src/tests/mesos.hpp 93d87c78e5665b8104dbbc3d1e8c92e515cc67ab src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
On Aug. 3, 2015, 12:36 p.m., Kapil Arya wrote: I have a stupid question. Why shouldn't the authorizer.{hpp,proto} file be placed inside `include/mesos/master/` instead since the authorizer is only for the master. Does it make sense to do that? If it does, then should we also move src/authorize inside src/master? Bernd Mathiske wrote: It's not intended to stay just for master. We are working on generalizing how all this works for all kinds of endpoints in all kinds of Mesos components: https://docs.google.com/document/d/1kM3_f7DSqXcE2MuERrLTGp_XMC6ss2wmpkNYDCY5rOM/edit Well, this doc is about authn. But authz is supposed to follow suit eventually. - Bernd --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review93951 --- On Aug. 3, 2015, 2:47 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 3, 2015, 2:47 a.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto cb24125a3f05e0d38fb22e481a15ceb21f882d27 include/mesos/type_utils.hpp 86b37ca1f63e4687af4e86731dceeb1c9c219c5e src/Makefile.am e2cbd1524f25b3e3a9419af6bdf8cc6e5022a784 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 6f5ca02c52462495b84e77525a6c88299746ece2 src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b src/tests/mesos.hpp 23d9841c7cfb16abef89a53d29a256a2c5e94b52 src/tests/mesos.cpp f09ef0f99573716de8905f49dcc0c9df20e31ea9 Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
On Aug. 3, 2015, 12:36 p.m., Kapil Arya wrote: I have a stupid question. Why shouldn't the authorizer.{hpp,proto} file be placed inside `include/mesos/master/` instead since the authorizer is only for the master. Does it make sense to do that? If it does, then should we also move src/authorize inside src/master? It's not intended to stay just for master. We are working on generalizing how all this works for all kinds of endpoints in all kinds of Mesos components: https://docs.google.com/document/d/1kM3_f7DSqXcE2MuERrLTGp_XMC6ss2wmpkNYDCY5rOM/edit - Bernd --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review93951 --- On Aug. 3, 2015, 2:47 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 3, 2015, 2:47 a.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto cb24125a3f05e0d38fb22e481a15ceb21f882d27 include/mesos/type_utils.hpp 86b37ca1f63e4687af4e86731dceeb1c9c219c5e src/Makefile.am e2cbd1524f25b3e3a9419af6bdf8cc6e5022a784 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 6f5ca02c52462495b84e77525a6c88299746ece2 src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b src/tests/mesos.hpp 23d9841c7cfb16abef89a53d29a256a2c5e94b52 src/tests/mesos.cpp f09ef0f99573716de8905f49dcc0c9df20e31ea9 Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review93907 --- include/mesos/authorizer/authorizer.hpp (line 24) https://reviews.apache.org/r/36048/#comment148334 I just realized that we always uppercase this sentence -- not sure I like it but for consistency, please adapt. - Till Toenshoff On Aug. 3, 2015, 9:47 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 3, 2015, 9:47 a.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto cb24125a3f05e0d38fb22e481a15ceb21f882d27 include/mesos/type_utils.hpp 86b37ca1f63e4687af4e86731dceeb1c9c219c5e src/Makefile.am e2cbd1524f25b3e3a9419af6bdf8cc6e5022a784 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 6f5ca02c52462495b84e77525a6c88299746ece2 src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b src/tests/mesos.hpp 23d9841c7cfb16abef89a53d29a256a2c5e94b52 src/tests/mesos.cpp f09ef0f99573716de8905f49dcc0c9df20e31ea9 Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review93884 --- Ship it! I think this looks ready for landing after fixing the remaining minor issues. src/authorizer/authorizer.hpp (line 60) https://reviews.apache.org/r/36048/#comment148300 Add a comment please on what we do with this flag and why a Once or alike won't do. src/authorizer/authorizer.cpp (line 236) https://reviews.apache.org/r/36048/#comment148301 s/LocalAuthorizer/local authorizer/ src/local/local.cpp (line 224) https://reviews.apache.org/r/36048/#comment148302 Seems a failure to instantiate the authorizer should not be connected to the settings on --acls - we should get rid of the (see --acls flag), no? src/tests/cluster.hpp (line 60) https://reviews.apache.org/r/36048/#comment148305 I think this should move up, a couple of lines, above files/files.hpp src/tests/cluster.hpp (line 359) https://reviews.apache.org/r/36048/#comment148306 --acls has no influence on the instantiation as commented above, please remove that part from the message. - Till Toenshoff On Aug. 3, 2015, 9:47 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 3, 2015, 9:47 a.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto cb24125a3f05e0d38fb22e481a15ceb21f882d27 include/mesos/type_utils.hpp 86b37ca1f63e4687af4e86731dceeb1c9c219c5e src/Makefile.am e2cbd1524f25b3e3a9419af6bdf8cc6e5022a784 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 6f5ca02c52462495b84e77525a6c88299746ece2 src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b src/tests/mesos.hpp 23d9841c7cfb16abef89a53d29a256a2c5e94b52 src/tests/mesos.cpp f09ef0f99573716de8905f49dcc0c9df20e31ea9 Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review93912 --- src/authorizer/authorizer.cpp (line 209) https://reviews.apache.org/r/36048/#comment148352 I stumbled over this syntax. While it's valid C++11, I'd suggest using `Authorizer* local = new LocalAuthorizer` as that's easier to grok. - Jan Schlicht On Aug. 3, 2015, 11:47 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 3, 2015, 11:47 a.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto cb24125a3f05e0d38fb22e481a15ceb21f882d27 include/mesos/type_utils.hpp 86b37ca1f63e4687af4e86731dceeb1c9c219c5e src/Makefile.am e2cbd1524f25b3e3a9419af6bdf8cc6e5022a784 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 6f5ca02c52462495b84e77525a6c88299746ece2 src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b src/tests/mesos.hpp 23d9841c7cfb16abef89a53d29a256a2c5e94b52 src/tests/mesos.cpp f09ef0f99573716de8905f49dcc0c9df20e31ea9 Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review93900 --- include/mesos/authorizer/authorizer.hpp (line 34) https://reviews.apache.org/r/36048/#comment148318 Note to all: this interface is in flux. It WILL change soon. I could start criticizing it here, but it is consistent with existing code and we should make the interface content a subsequent, separate issue. Here, we focus on the modularization per se. include/mesos/authorizer/authorizer.hpp (line 37) https://reviews.apache.org/r/36048/#comment148319 Can we have doxygen for this whole interface and every item in it, please? include/mesos/authorizer/authorizer.proto (line 28) https://reviews.apache.org/r/36048/#comment148317 What is local authorization? Link or explanation, please! src/authorizer/authorizer.cpp (line 236) https://reviews.apache.org/r/36048/#comment148320 s/ACL's/ACLs src/master/main.cpp (line 307) https://reviews.apache.org/r/36048/#comment148323 --acls has no influence on the instantiation as commented above, please remove that part from the message. src/master/master.hpp (line 77) https://reviews.apache.org/r/36048/#comment148324 // Forward declaration. src/tests/authorization_tests.cpp (line 48) https://reviews.apache.org/r/36048/#comment148329 Please stick to Owned as before. Less probability of mistakes (even though I don't see any in the present code). - Bernd Mathiske On Aug. 3, 2015, 2:47 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 3, 2015, 2:47 a.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto cb24125a3f05e0d38fb22e481a15ceb21f882d27 include/mesos/type_utils.hpp 86b37ca1f63e4687af4e86731dceeb1c9c219c5e src/Makefile.am e2cbd1524f25b3e3a9419af6bdf8cc6e5022a784 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 6f5ca02c52462495b84e77525a6c88299746ece2 src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b src/tests/mesos.hpp 23d9841c7cfb16abef89a53d29a256a2c5e94b52 src/tests/mesos.cpp f09ef0f99573716de8905f49dcc0c9df20e31ea9 Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review93951 --- I have a stupid question. Why shouldn't the authorizer.{hpp,proto} file be placed inside `include/mesos/master/` instead since the authorizer is only for the master. Does it make sense to do that? If it does, then should we also move src/authorize inside src/master? - Kapil Arya On Aug. 3, 2015, 5:47 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 3, 2015, 5:47 a.m.) Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil Arya, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto cb24125a3f05e0d38fb22e481a15ceb21f882d27 include/mesos/type_utils.hpp 86b37ca1f63e4687af4e86731dceeb1c9c219c5e src/Makefile.am e2cbd1524f25b3e3a9419af6bdf8cc6e5022a784 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 6f5ca02c52462495b84e77525a6c88299746ece2 src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b src/tests/mesos.hpp 23d9841c7cfb16abef89a53d29a256a2c5e94b52 src/tests/mesos.cpp f09ef0f99573716de8905f49dcc0c9df20e31ea9 Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 20, 2015, 11 p.m.) Review request for mesos, Adam B, Alexander Rukletsov, Kapil Arya, and Till Toenshoff. Changes --- Till's review. Rebase Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs (updated) - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto cb24125a3f05e0d38fb22e481a15ceb21f882d27 include/mesos/type_utils.hpp 86b37ca1f63e4687af4e86731dceeb1c9c219c5e src/Makefile.am e2cbd1524f25b3e3a9419af6bdf8cc6e5022a784 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 6f5ca02c52462495b84e77525a6c88299746ece2 src/master/main.cpp fd4de4d0d9c3e9617408022d10b5e161bdc911e1 src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b src/tests/mesos.hpp 23d9841c7cfb16abef89a53d29a256a2c5e94b52 src/tests/mesos.cpp f09ef0f99573716de8905f49dcc0c9df20e31ea9 Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 7, 2015, 9:33 a.m.) Review request for mesos, Adam B and Till Toenshoff. Changes --- No longer pointing to the JIRA epic. Bugs: MESOS-2946 https://issues.apache.org/jira/browse/MESOS-2946 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto 3dd4a5b7a4b3bc56bdc690d6adf05f88c0d28273 include/mesos/type_utils.hpp e7bfe8ca60af945e76b5d85ab37cc97b17ff1b4a src/Makefile.am addb63f615f16ae6b25f745b2e79fd9fc0e27851 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 2be613b2e4c913b74c12d0d8f2d0e25da3cd3656 src/master/main.cpp 2624b7ea4920a534c98f5dfbf9286c54c50f11a9 src/master/master.hpp fb4d6fac85e284987ec8fbf6949b5023875573fb src/master/master.cpp c5a4875f0d43c5091ae9a52c6b1d04105dfa3914 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp cfe7ef0c7a6dc62cddc3e5f5b5b28c8bcb2bed26 src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 6, 2015, 2:38 p.m.) Review request for mesos, Adam B and Till Toenshoff. Changes --- Fixed a bug when some operations and a deallocation would be applied to a `nullptr`. Bugs: MESOS-2945 https://issues.apache.org/jira/browse/MESOS-2945 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs (updated) - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto 3dd4a5b7a4b3bc56bdc690d6adf05f88c0d28273 include/mesos/type_utils.hpp e7bfe8ca60af945e76b5d85ab37cc97b17ff1b4a src/Makefile.am addb63f615f16ae6b25f745b2e79fd9fc0e27851 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 2be613b2e4c913b74c12d0d8f2d0e25da3cd3656 src/master/main.cpp 2624b7ea4920a534c98f5dfbf9286c54c50f11a9 src/master/master.hpp fb4d6fac85e284987ec8fbf6949b5023875573fb src/master/master.cpp c5a4875f0d43c5091ae9a52c6b1d04105dfa3914 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp cfe7ef0c7a6dc62cddc3e5f5b5b28c8bcb2bed26 src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 6, 2015, 5:41 p.m.) Review request for mesos, Adam B and Till Toenshoff. Changes --- Properly use of includes. Bugs: MESOS-2945 https://issues.apache.org/jira/browse/MESOS-2945 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs (updated) - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto 3dd4a5b7a4b3bc56bdc690d6adf05f88c0d28273 include/mesos/type_utils.hpp e7bfe8ca60af945e76b5d85ab37cc97b17ff1b4a src/Makefile.am addb63f615f16ae6b25f745b2e79fd9fc0e27851 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 2be613b2e4c913b74c12d0d8f2d0e25da3cd3656 src/master/main.cpp 2624b7ea4920a534c98f5dfbf9286c54c50f11a9 src/master/master.hpp fb4d6fac85e284987ec8fbf6949b5023875573fb src/master/master.cpp c5a4875f0d43c5091ae9a52c6b1d04105dfa3914 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp cfe7ef0c7a6dc62cddc3e5f5b5b28c8bcb2bed26 src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 6, 2015, 4:18 p.m.) Review request for mesos, Adam B and Till Toenshoff. Changes --- Fixes small style issue. Bugs: MESOS-2945 https://issues.apache.org/jira/browse/MESOS-2945 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs (updated) - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto 3dd4a5b7a4b3bc56bdc690d6adf05f88c0d28273 include/mesos/type_utils.hpp e7bfe8ca60af945e76b5d85ab37cc97b17ff1b4a src/Makefile.am addb63f615f16ae6b25f745b2e79fd9fc0e27851 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 2be613b2e4c913b74c12d0d8f2d0e25da3cd3656 src/master/main.cpp 2624b7ea4920a534c98f5dfbf9286c54c50f11a9 src/master/master.hpp fb4d6fac85e284987ec8fbf6949b5023875573fb src/master/master.cpp c5a4875f0d43c5091ae9a52c6b1d04105dfa3914 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp cfe7ef0c7a6dc62cddc3e5f5b5b28c8bcb2bed26 src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 3, 2015, 3:15 p.m.) Review request for mesos and Till Toenshoff. Changes --- `LocalAuthorizer::create()` no longer is able to return a nullptr, instead is set's the returned `TryAllocator*` to error, so it is consistent with the behavior in `ModuleManager`. Bugs: MESOS-2945 https://issues.apache.org/jira/browse/MESOS-2945 Repository: mesos Description --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs (updated) - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto 3dd4a5b7a4b3bc56bdc690d6adf05f88c0d28273 include/mesos/type_utils.hpp e7bfe8ca60af945e76b5d85ab37cc97b17ff1b4a src/Makefile.am addb63f615f16ae6b25f745b2e79fd9fc0e27851 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 2be613b2e4c913b74c12d0d8f2d0e25da3cd3656 src/master/main.cpp 2624b7ea4920a534c98f5dfbf9286c54c50f11a9 src/master/master.hpp fb4d6fac85e284987ec8fbf6949b5023875573fb src/master/master.cpp c5a4875f0d43c5091ae9a52c6b1d04105dfa3914 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp cfe7ef0c7a6dc62cddc3e5f5b5b28c8bcb2bed26 src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 3, 2015, 9:49 a.m.) Review request for mesos and Till Toenshoff. Changes --- Updated summary. Summary (updated) - Updated authorizer to allow for modularized implementations. Bugs: MESOS-2945 https://issues.apache.org/jira/browse/MESOS-2945 Repository: mesos Description --- Breaks the declaration of the `Authorizer` interface and its default implementation `LocalAuthorizer` in different files. Makes the `Authorizer` interface declaration public. Following the patter in the `Authenticator` it generates a default constructor which is required when writing a `TypeTest` in a follow up patch, and an `initialize` method. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto 3dd4a5b7a4b3bc56bdc690d6adf05f88c0d28273 include/mesos/type_utils.hpp e7bfe8ca60af945e76b5d85ab37cc97b17ff1b4a src/Makefile.am addb63f615f16ae6b25f745b2e79fd9fc0e27851 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 2be613b2e4c913b74c12d0d8f2d0e25da3cd3656 src/master/main.cpp 2624b7ea4920a534c98f5dfbf9286c54c50f11a9 src/master/master.hpp fb4d6fac85e284987ec8fbf6949b5023875573fb src/master/master.cpp c5a4875f0d43c5091ae9a52c6b1d04105dfa3914 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp cfe7ef0c7a6dc62cddc3e5f5b5b28c8bcb2bed26 src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36048: Updated authorizer to allow for modularized implementations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 3, 2015, 9:56 a.m.) Review request for mesos and Till Toenshoff. Changes --- updated description. Bugs: MESOS-2945 https://issues.apache.org/jira/browse/MESOS-2945 Repository: mesos Description (updated) --- Splits and updates the original declaration of the `Authorizer` into its interface and a default implementation, the `LocalAuthorizer`. Following the pattern of the modularized `Authenticator`, it generates a default constructor which is required when writing a `TYPED_TEST` in a follow up patch. Additionally, an initialize method has been added, needed for passing in the current ACL definitions as provided via flags. Other changes are just updates to allow for compilation. Diffs - include/mesos/authorizer/authorizer.hpp PRE-CREATION include/mesos/authorizer/authorizer.proto PRE-CREATION include/mesos/mesos.proto 3dd4a5b7a4b3bc56bdc690d6adf05f88c0d28273 include/mesos/type_utils.hpp e7bfe8ca60af945e76b5d85ab37cc97b17ff1b4a src/Makefile.am addb63f615f16ae6b25f745b2e79fd9fc0e27851 src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 src/examples/persistent_volume_framework.cpp c6d6ed337bfca91dc146cb31298cabebdbb13509 src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f src/master/http.cpp 2be613b2e4c913b74c12d0d8f2d0e25da3cd3656 src/master/main.cpp 2624b7ea4920a534c98f5dfbf9286c54c50f11a9 src/master/master.hpp fb4d6fac85e284987ec8fbf6949b5023875573fb src/master/master.cpp c5a4875f0d43c5091ae9a52c6b1d04105dfa3914 src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/cluster.hpp cfe7ef0c7a6dc62cddc3e5f5b5b28c8bcb2bed26 src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3 src/tests/mesos.cpp 5eab6dea6058865847425ab8d31708c92c6f098a Diff: https://reviews.apache.org/r/36048/diff/ Testing --- make check Thanks, Alexander Rojas