Re: Review Request 36755: Passed env vars returned by Isolator::prepare() to executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36755/#review93313 --- Ship it! Ship It! - Jie Yu On July 28, 2015, 12:02 a.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36755/ --- (Updated July 28, 2015, 12:02 a.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Bugs: MESOS-3133 https://issues.apache.org/jira/browse/MESOS-3133 Repository: mesos Description --- Append the environment variables returned by Isolator::prepare() to the list of environment variables being passed to the executor. Added a test to verify that the executor is launched with the said environment variables. Diffs - src/slave/containerizer/mesos/containerizer.cpp 11eedf30674b326ea3e1f6f71d27f9eb54126368 src/tests/containerizer/containerizer_tests.cpp a44b6e887c37e55213db068a95ab3e73a033e1ea Diff: https://reviews.apache.org/r/36755/diff/ Testing --- make check with an added test. Thanks, Kapil Arya
Re: Review Request 36755: Passed env vars returned by Isolator::prepare() to executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36755/#review93055 --- Ship it! src/tests/containerizer_tests.cpp (line 311) https://reviews.apache.org/r/36755/#comment147322 s/e/v/ at least and 'variable' even better! - Benjamin Hindman On July 26, 2015, 6:49 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36755/ --- (Updated July 26, 2015, 6:49 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Bugs: MESOS-3133 https://issues.apache.org/jira/browse/MESOS-3133 Repository: mesos Description --- Append the environment variables returned by Isolator::prepare() to the list of environment variables being passed to the executor. Added a test to verify that the executor is launched with the said environment variables. Diffs - src/slave/containerizer/mesos/containerizer.cpp 11eedf30674b326ea3e1f6f71d27f9eb54126368 src/tests/containerizer/containerizer_tests.cpp a44b6e887c37e55213db068a95ab3e73a033e1ea Diff: https://reviews.apache.org/r/36755/diff/ Testing --- make check with an added test. Thanks, Kapil Arya
Re: Review Request 36755: Passed env vars returned by Isolator::prepare() to executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36755/ --- (Updated July 27, 2015, 8:02 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Changes --- renamed variable. Bugs: MESOS-3133 https://issues.apache.org/jira/browse/MESOS-3133 Repository: mesos Description --- Append the environment variables returned by Isolator::prepare() to the list of environment variables being passed to the executor. Added a test to verify that the executor is launched with the said environment variables. Diffs (updated) - src/slave/containerizer/mesos/containerizer.cpp 11eedf30674b326ea3e1f6f71d27f9eb54126368 src/tests/containerizer/containerizer_tests.cpp a44b6e887c37e55213db068a95ab3e73a033e1ea Diff: https://reviews.apache.org/r/36755/diff/ Testing --- make check with an added test. Thanks, Kapil Arya
Re: Review Request 36755: Passed env vars returned by Isolator::prepare() to executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36755/ --- (Updated July 26, 2015, 2:49 p.m.) Review request for mesos, Benjamin Hindman and Jie Yu. Changes --- rebased Bugs: MESOS-3133 https://issues.apache.org/jira/browse/MESOS-3133 Repository: mesos Description --- Append the environment variables returned by Isolator::prepare() to the list of environment variables being passed to the executor. Added a test to verify that the executor is launched with the said environment variables. Diffs (updated) - src/slave/containerizer/mesos/containerizer.cpp 11eedf30674b326ea3e1f6f71d27f9eb54126368 src/tests/containerizer/containerizer_tests.cpp a44b6e887c37e55213db068a95ab3e73a033e1ea Diff: https://reviews.apache.org/r/36755/diff/ Testing --- make check with an added test. Thanks, Kapil Arya
Re: Review Request 36755: Passed env vars returned by Isolator::prepare() to executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36755/ --- (Updated July 24, 2015, 6:05 p.m.) Review request for mesos and Jie Yu. Bugs: MESOS-3133 https://issues.apache.org/jira/browse/MESOS-3133 Repository: mesos Description --- Append the environment variables returned by Isolator::prepare() to the list of environment variables being passed to the executor. Added a test to verify that the executor is launched with the said environment variables. Diffs (updated) - src/slave/containerizer/mesos/containerizer.cpp 11eedf30674b326ea3e1f6f71d27f9eb54126368 src/tests/containerizer_tests.cpp 9508613619de1e1b5bfdb30ce063975bd3bdb8ef Diff: https://reviews.apache.org/r/36755/diff/ Testing --- make check with an added test. Thanks, Kapil Arya
Review Request 36755: Passed env vars returned by Isolator::prepare() to executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36755/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3133 https://issues.apache.org/jira/browse/MESOS-3133 Repository: mesos Description --- Append the environment variables returned by Isolator::prepare() to the list of environment variables being passed to the executor. Added a test to verify that the executor is launched with the said environment variables. Diffs - src/slave/containerizer/mesos/containerizer.cpp 609620c4322e41562597ee682b311cd320bca6d2 src/tests/containerizer_tests.cpp 88c46e7214f4d92b7d6a9b433a3a0497681dc6db Diff: https://reviews.apache.org/r/36755/diff/ Testing --- make check with an added test. Thanks, Kapil Arya
Re: Review Request 36755: Passed env vars returned by Isolator::prepare() to executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36755/#review92856 --- Patch looks great! Reviews applied: [36718, 36754, 36755] All tests passed. - Mesos ReviewBot On July 24, 2015, 12:20 a.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36755/ --- (Updated July 24, 2015, 12:20 a.m.) Review request for mesos and Jie Yu. Bugs: MESOS-3133 https://issues.apache.org/jira/browse/MESOS-3133 Repository: mesos Description --- Append the environment variables returned by Isolator::prepare() to the list of environment variables being passed to the executor. Added a test to verify that the executor is launched with the said environment variables. Diffs - src/slave/containerizer/mesos/containerizer.cpp 609620c4322e41562597ee682b311cd320bca6d2 src/tests/containerizer_tests.cpp 88c46e7214f4d92b7d6a9b433a3a0497681dc6db Diff: https://reviews.apache.org/r/36755/diff/ Testing --- make check with an added test. Thanks, Kapil Arya
