Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-09-28 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/#review100824
---


Haosdent, are you going to close these two now that they have been 
(effectively) submitted?

- Joseph Wu


On Sept. 15, 2015, 8:51 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37275/
> ---
> 
> (Updated Sept. 15, 2015, 8:51 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Generate make batch file to build project in windows.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/37275/diff/
> 
> 
> Testing
> ---
> 
> # Build steps:
> cmake ..  -DREBUNDLED=FALSE
> make
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-09-16 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/#review99188
---


Patch looks great!

Reviews applied: [37273, 37275]

All tests passed.

- Mesos ReviewBot


On Sept. 16, 2015, 3:51 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37275/
> ---
> 
> (Updated Sept. 16, 2015, 3:51 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Generate make batch file to build project in windows.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/37275/diff/
> 
> 
> Testing
> ---
> 
> # Build steps:
> cmake ..  -DREBUNDLED=FALSE
> make
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-09-15 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/
---

(Updated Sept. 16, 2015, 3:51 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.


Repository: mesos


Description
---

Generate make batch file to build project in windows.


Diffs
-

  CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
  cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 

Diff: https://reviews.apache.org/r/37275/diff/


Testing (updated)
---

# Build steps:
cmake ..  -DREBUNDLED=FALSE
make


Thanks,

haosdent huang

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-09-15 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/#review99116
---


Patch looks great!

Reviews applied: [37273, 37275]

All tests passed.

- Mesos ReviewBot


On Sept. 15, 2015, 6:42 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37275/
> ---
> 
> (Updated Sept. 15, 2015, 6:42 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Generate make batch file to build project in windows.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/37275/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-09-15 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/
---

(Updated Sept. 16, 2015, 2:55 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.


Changes
---

Use CMAKE_BUILD_TYPE as build params and make it pass in Windows 7 +  Visual 
Studio 2015


Repository: mesos


Description
---

Generate make batch file to build project in windows.


Diffs (updated)
-

  CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
  cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 

Diff: https://reviews.apache.org/r/37275/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-09-15 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/
---

(Updated Sept. 15, 2015, 6:42 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.


Repository: mesos


Description
---

Generate make batch file to build project in windows.


Diffs (updated)
-

  CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
  cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 

Diff: https://reviews.apache.org/r/37275/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-09-15 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/
---

(Updated Sept. 15, 2015, 3:16 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.


Changes
---

Use MESOS as VS_BUILD_CMD directly.


Repository: mesos


Description
---

Generate make batch file to build project in windows.


Diffs (updated)
-

  CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
  cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 

Diff: https://reviews.apache.org/r/37275/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-09-15 Thread haosdent huang 


> On Sept. 11, 2015, 10:49 p.m., Alex Clemmer wrote:
> > cmake/MesosConfigure.cmake, line 121
> > 
> >
> > Let me just double check that I understand this code. We're building a 
> > `make.bat` file, but not because we use it here -- it's so others can 
> > include it when they make Mesos from a different VS solution, right?

Yes.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/#review98701
---


On Sept. 5, 2015, 12:45 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37275/
> ---
> 
> (Updated Sept. 5, 2015, 12:45 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Generate make batch file to build project in windows.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/37275/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-09-15 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/
---

(Updated Sept. 15, 2015, 2:19 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.


Changes
---

Update according @Alex's reviews


Repository: mesos


Description
---

Generate make batch file to build project in windows.


Diffs (updated)
-

  CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
  cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 

Diff: https://reviews.apache.org/r/37275/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-09-11 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/#review98701
---



CMakeLists.txt (line 24)


See note in previous review -- I'd rather uppercase the project name in the 
`VS_BUILD_CMD` than have this floating around in global CMake scope.



CMakeLists.txt (line 44)


Ah. I should have alphabetized these when I wrote them. Could we 
alphabetize them now?



cmake/MesosConfigure.cmake (line 121)


Let me just double check that I understand this code. We're building a 
`make.bat` file, but not because we use it here -- it's so others can include 
it when they make Mesos from a different VS solution, right?


- Alex Clemmer


On Sept. 5, 2015, 12:45 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37275/
> ---
> 
> (Updated Sept. 5, 2015, 12:45 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Generate make batch file to build project in windows.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/37275/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-09-05 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/#review97864
---


Patch looks great!

Reviews applied: [37273, 37275]

All tests passed.

- Mesos ReviewBot


On Sept. 5, 2015, 12:45 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37275/
> ---
> 
> (Updated Sept. 5, 2015, 12:45 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Generate make batch file to build project in windows.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/37275/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-09-05 Thread haosdent huang 


> On Aug. 31, 2015, 6:50 p.m., Joseph Wu wrote:
> > cmake/MesosConfigure.cmake, line 125
> > 
> >
> > Why do you need this?  (If you do need it, comment why.)
> > 
> > It doesn't look like the inputs have any semicolons.

Because cmake convert list [a, b, c] to string "a;b;c". When we write a string 
to file, need replace ";" to " " first.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/#review97113
---


On Sept. 4, 2015, 4:24 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37275/
> ---
> 
> (Updated Sept. 4, 2015, 4:24 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Generate make batch file to build project in windows.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/37275/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-09-05 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/
---

(Updated Sept. 5, 2015, 12:40 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.


Changes
---

Update according @kaysoky reviews


Repository: mesos


Description
---

Generate make batch file to build project in windows.


Diffs (updated)
-

  CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
  cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 

Diff: https://reviews.apache.org/r/37275/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-09-05 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/
---

(Updated Sept. 5, 2015, 12:45 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.


Repository: mesos


Description
---

Generate make batch file to build project in windows.


Diffs (updated)
-

  CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
  cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 

Diff: https://reviews.apache.org/r/37275/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-08-31 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/#review97113
---



cmake/MesosConfigure.cmake (line 76)


This comment doesn't need to change.  If anything, you could add an extra 
line, like:
```
Your version of MSVC is ${MSVC_VERSION}.
```
Or:
```
Mesos does not support compiling on MSVC version ${MSVC_VERSION}, which is 
earlier than version 1900.
```



cmake/MesosConfigure.cmake (line 125)


Why do you need this?  (If you do need it, comment why.)

It doesn't look like the inputs have any semicolons.


- Joseph Wu


On Aug. 30, 2015, 6:42 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37275/
> ---
> 
> (Updated Aug. 30, 2015, 6:42 a.m.)
> 
> 
> Review request for mesos and Alex Clemmer.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Generate make batch file to build project in windows.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/37275/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-08-30 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/
---

(Updated Aug. 30, 2015, 1:42 p.m.)


Review request for mesos and Alex Clemmer.


Summary (updated)
-

[2/2]Generate make batch file to build project in windows.


Repository: mesos


Description
---

Generate make batch file to build project in windows.


Diffs
-

  CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
  cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 

Diff: https://reviews.apache.org/r/37275/diff/


Testing
---


Thanks,

haosdent huang