Re: Review Request 39623: CMake: Added protobuf compilation to Windows builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39623/#review110321 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 16, 2015, 9:13 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39623/ > --- > > (Updated Nov. 16, 2015, 9:13 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > --- > > CMake: Added protobuf compilation to Windows builds. > > > Diffs > - > > src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 > > Diff: https://reviews.apache.org/r/39623/diff/ > > > Testing > --- > > `make check` from CMake on OS X 10.10. > `make check` from Autotools on OS X 10.10. > Ran `check` project in VS on Windows 10. > > PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH > into my Ubuntu box to test this from Ubuntu > > > Thanks, > > Alex Clemmer > >
Re: Review Request 39623: CMake: Added protobuf compilation to Windows builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39623/ --- (Updated Nov. 16, 2015, 9:13 a.m.) Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- CMake: Added protobuf compilation to Windows builds. Diffs (updated) - src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 Diff: https://reviews.apache.org/r/39623/diff/ Testing --- `make check` from CMake on OS X 10.10. `make check` from Autotools on OS X 10.10. Ran `check` project in VS on Windows 10. PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu Thanks, Alex Clemmer
Re: Review Request 39623: CMake: Added protobuf compilation to Windows builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39623/#review104775 --- Ship it! Double-checked non-Windows builds. - Joseph Wu On Oct. 29, 2015, 10:58 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39623/ > --- > > (Updated Oct. 29, 2015, 10:58 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > --- > > CMake: Added protobuf compilation to Windows builds. > > > Diffs > - > > src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289 > > Diff: https://reviews.apache.org/r/39623/diff/ > > > Testing > --- > > `make check` from CMake on OS X 10.10. > `make check` from Autotools on OS X 10.10. > Ran `check` project in VS on Windows 10. > > PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH > into my Ubuntu box to test this from Ubuntu > > > Thanks, > > Alex Clemmer > >
Re: Review Request 39623: CMake: Added protobuf compilation to Windows builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39623/ --- (Updated Oct. 30, 2015, 5:58 a.m.) Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- CMake: Added protobuf compilation to Windows builds. Diffs (updated) - src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289 Diff: https://reviews.apache.org/r/39623/diff/ Testing --- `make check` from CMake on OS X 10.10. `make check` from Autotools on OS X 10.10. Ran `check` project in VS on Windows 10. PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu Thanks, Alex Clemmer
Re: Review Request 39623: CMake: Added protobuf compilation to Windows builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39623/#review103901 --- Patch looks great! Reviews applied: [39537, 39538, 39539, 39540, 39541, 39383, 39559, 39219, 39560, 39583, 39584, 39620, 39621, 39622, 39623] All tests passed. - Mesos ReviewBot On Oct. 24, 2015, 4:33 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39623/ > --- > > (Updated Oct. 24, 2015, 4:33 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > --- > > CMake: Added protobuf compilation to Windows builds. > > > Diffs > - > > src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd > > Diff: https://reviews.apache.org/r/39623/diff/ > > > Testing > --- > > `make check` from CMake on OS X 10.10. > `make check` from Autotools on OS X 10.10. > Ran `check` project in VS on Windows 10. > > PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH > into my Ubuntu box to test this from Ubuntu > > > Thanks, > > Alex Clemmer > >
Review Request 39623: CMake: Added protobuf compilation to Windows builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39623/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- CMake: Added protobuf compilation to Windows builds. Diffs - src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd Diff: https://reviews.apache.org/r/39623/diff/ Testing --- `make check` from CMake on OS X 10.10. `make check` from Autotools on OS X 10.10. Ran `check` project in VS on Windows 10. PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu Thanks, Alex Clemmer
