Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-28 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40944/#review112045
---


Patch looks great!

Reviews applied: [40944]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 28, 2015, 6:31 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40944/
> ---
> 
> (Updated Dec. 28, 2015, 6:31 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed protobuf parse failure when pulling a docker image.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 7cdb15b9529eab82867b3470a016bb8ad09ff250 
>   src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
> 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 
>   src/slave/containerizer/mesos/provisioner/docker/v2.proto 
> fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98 
> 
> Diff: https://reviews.apache.org/r/40944/diff/
> 
> 
> Testing
> ---
> 
> make check(ubuntu14.04 + clang3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-28 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40944/
---

(Updated Dec. 28, 2015, 10:31 a.m.)


Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen.


Repository: mesos


Description
---

Fixed protobuf parse failure when pulling a docker image.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
7cdb15b9529eab82867b3470a016bb8ad09ff250 
  src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
5bbd98cb1c5f3aefd9050859d066b43360e6eb75 
  src/slave/containerizer/mesos/provisioner/docker/v2.proto 
fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 
  src/tests/containerizer/provisioner_docker_tests.cpp 
bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98 

Diff: https://reviews.apache.org/r/40944/diff/


Testing
---

make check(ubuntu14.04 + clang3.6)


Thanks,

Gilbert Song

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-22 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40944/#review111726
---

Ship it!


Ship It!


src/slave/containerizer/mesos/provisioner/docker/spec.cpp (line 117)


We should elaborate more here: "Failed to parse v1Compatbility json: "..



src/slave/containerizer/mesos/provisioner/docker/spec.cpp (line 125)


I would make the error message more exact (Parsing v1Compatibility protobuf 
failed:).



src/slave/containerizer/mesos/provisioner/docker/spec.cpp (line 129)


We never expect this to happen right? Let's make this a CHECK instead since 
this is a programming error not a user input error.


- Timothy Chen


On Dec. 20, 2015, 1:43 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40944/
> ---
> 
> (Updated Dec. 20, 2015, 1:43 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed protobuf parse failure when pulling a docker image.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 7cdb15b9529eab82867b3470a016bb8ad09ff250 
>   src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
> 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 
>   src/slave/containerizer/mesos/provisioner/docker/v2.proto 
> fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 7c1197ed03df8b5d77d26307560535f9ff5bf350 
> 
> Diff: https://reviews.apache.org/r/40944/diff/
> 
> 
> Testing
> ---
> 
> make check(ubuntu14.04 + clang3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-19 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40944/#review111398
---


Patch looks great!

Reviews applied: [40944]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 20, 2015, 1:43 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40944/
> ---
> 
> (Updated Dec. 20, 2015, 1:43 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed protobuf parse failure when pulling a docker image.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 7cdb15b9529eab82867b3470a016bb8ad09ff250 
>   src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
> 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 
>   src/slave/containerizer/mesos/provisioner/docker/v2.proto 
> fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 7c1197ed03df8b5d77d26307560535f9ff5bf350 
> 
> Diff: https://reviews.apache.org/r/40944/diff/
> 
> 
> Testing
> ---
> 
> make check(ubuntu14.04 + clang3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-19 Thread Gilbert Song 


> On Dec. 18, 2015, 5:22 p.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/provisioner/docker/message.proto, line 72
> > 
> >
> > I think we should make this optional as well, since technically we 
> > don't really require this.

Totally agreed.


> On Dec. 18, 2015, 5:22 p.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/provisioner/docker/spec.cpp, line 79
> > 
> >
> > Formatting seems a bit odd,
> > Can you do:
> > 
> > Try v1Compat = JSON::parse(
> >   stringify(manife);

Sure. It looks better now, and it should be four spaces before `stringify` I am 
assuming.


> On Dec. 18, 2015, 5:22 p.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/provisioner/docker/spec.cpp, line 87
> > 
> >
> > Shouldn't this fit in the same line?

Unfortunately not. :(

We may still be able to make it look better. Here is my change:

Try v1Compatibility =
  protobuf::parse(
  v1Compat.get());


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40944/#review111333
---


On Dec. 19, 2015, 5:43 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40944/
> ---
> 
> (Updated Dec. 19, 2015, 5:43 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed protobuf parse failure when pulling a docker image.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 7cdb15b9529eab82867b3470a016bb8ad09ff250 
>   src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
> 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 
>   src/slave/containerizer/mesos/provisioner/docker/v2.proto 
> fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 7c1197ed03df8b5d77d26307560535f9ff5bf350 
> 
> Diff: https://reviews.apache.org/r/40944/diff/
> 
> 
> Testing
> ---
> 
> make check(ubuntu14.04 + clang3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-19 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40944/
---

(Updated Dec. 19, 2015, 5:43 p.m.)


Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen.


Repository: mesos


Description
---

Fixed protobuf parse failure when pulling a docker image.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
7cdb15b9529eab82867b3470a016bb8ad09ff250 
  src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
5bbd98cb1c5f3aefd9050859d066b43360e6eb75 
  src/slave/containerizer/mesos/provisioner/docker/v2.proto 
fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 
  src/tests/containerizer/provisioner_docker_tests.cpp 
7c1197ed03df8b5d77d26307560535f9ff5bf350 

Diff: https://reviews.apache.org/r/40944/diff/


Testing
---

make check(ubuntu14.04 + clang3.6)


Thanks,

Gilbert Song

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-18 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40944/#review111333
---



src/slave/containerizer/mesos/provisioner/docker/message.proto (line 72)


I think we should make this optional as well, since technically we don't 
really require this.



src/slave/containerizer/mesos/provisioner/docker/spec.cpp (line 79)


Formatting seems a bit odd,
Can you do:

Try v1Compat = JSON::parse(
  stringify(manife);



src/slave/containerizer/mesos/provisioner/docker/spec.cpp (line 87)


Shouldn't this fit in the same line?


- Timothy Chen


On Dec. 9, 2015, 6:36 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40944/
> ---
> 
> (Updated Dec. 9, 2015, 6:36 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed protobuf parse failure when pulling a docker image.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/message.proto 
> 824a788af0d2c779a2ca82a69ba65b6361154038 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 89f61c20e52e5eff8d8e92748f03b3b461516cd2 
>   src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
> 1f05c75dc9473bd5e4c0d3f74fa0ef996b96a84e 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> c63bf53fee40ef12536a16e11f4d5224c4e4278e 
> 
> Diff: https://reviews.apache.org/r/40944/diff/
> 
> 
> Testing
> ---
> 
> make check(ubuntu14.04 + clang3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-09 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40944/#review109614
---


Patch looks great!

Reviews applied: [40944]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 9, 2015, 6:36 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40944/
> ---
> 
> (Updated Dec. 9, 2015, 6:36 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed protobuf parse failure when pulling a docker image.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/message.proto 
> 824a788af0d2c779a2ca82a69ba65b6361154038 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 89f61c20e52e5eff8d8e92748f03b3b461516cd2 
>   src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
> 1f05c75dc9473bd5e4c0d3f74fa0ef996b96a84e 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> c63bf53fee40ef12536a16e11f4d5224c4e4278e 
> 
> Diff: https://reviews.apache.org/r/40944/diff/
> 
> 
> Testing
> ---
> 
> make check(ubuntu14.04 + clang3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-09 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40944/
---

(Updated Dec. 9, 2015, 10:36 a.m.)


Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen.


Repository: mesos


Description
---

Fixed protobuf parse failure when pulling a docker image.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/message.proto 
824a788af0d2c779a2ca82a69ba65b6361154038 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
89f61c20e52e5eff8d8e92748f03b3b461516cd2 
  src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
1f05c75dc9473bd5e4c0d3f74fa0ef996b96a84e 
  src/tests/containerizer/provisioner_docker_tests.cpp 
c63bf53fee40ef12536a16e11f4d5224c4e4278e 

Diff: https://reviews.apache.org/r/40944/diff/


Testing
---

make check(ubuntu14.04 + clang3.6)


Thanks,

Gilbert Song

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-04 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40944/#review109072
---



src/slave/containerizer/mesos/provisioner/docker/message.proto (line 68)


Let's add a TODO as discussed here, that we should make protobuf::parse 
support nested parsing in the future.


- Timothy Chen


On Dec. 4, 2015, 7:01 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40944/
> ---
> 
> (Updated Dec. 4, 2015, 7:01 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed protobuf parse failure when pulling a docker image.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/message.proto 
> 824a788af0d2c779a2ca82a69ba65b6361154038 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 89f61c20e52e5eff8d8e92748f03b3b461516cd2 
>   src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
> 1f05c75dc9473bd5e4c0d3f74fa0ef996b96a84e 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> c63bf53fee40ef12536a16e11f4d5224c4e4278e 
> 
> Diff: https://reviews.apache.org/r/40944/diff/
> 
> 
> Testing
> ---
> 
> make check(ubuntu14.04 + clang3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-04 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40944/#review109042
---


Patch looks great!

Reviews applied: [40944]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 4, 2015, 7:01 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40944/
> ---
> 
> (Updated Dec. 4, 2015, 7:01 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed protobuf parse failure when pulling a docker image.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/message.proto 
> 824a788af0d2c779a2ca82a69ba65b6361154038 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 89f61c20e52e5eff8d8e92748f03b3b461516cd2 
>   src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
> 1f05c75dc9473bd5e4c0d3f74fa0ef996b96a84e 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> c63bf53fee40ef12536a16e11f4d5224c4e4278e 
> 
> Diff: https://reviews.apache.org/r/40944/diff/
> 
> 
> Testing
> ---
> 
> make check(ubuntu14.04 + clang3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-04 Thread Gilbert Song 


> On Dec. 4, 2015, 10:46 a.m., Jojy Varghese wrote:
> > src/slave/containerizer/mesos/provisioner/docker/message.proto, line 68
> > 
> >
> > Might be easy to read/understand if we name the fields as 
> > rawV1CompatibilityString and the the actual parsed field as v1Compatibility 
> > to match their semantics.

In order to make use of protobuf::parse, we must have protobuf msg name exactly 
matched as JSON field. And that is the reason why we have below comments for 
vaCompat optional field. :)


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40944/#review109010
---


On Dec. 4, 2015, 11:01 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40944/
> ---
> 
> (Updated Dec. 4, 2015, 11:01 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed protobuf parse failure when pulling a docker image.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/message.proto 
> 824a788af0d2c779a2ca82a69ba65b6361154038 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 89f61c20e52e5eff8d8e92748f03b3b461516cd2 
>   src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
> 1f05c75dc9473bd5e4c0d3f74fa0ef996b96a84e 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> c63bf53fee40ef12536a16e11f4d5224c4e4278e 
> 
> Diff: https://reviews.apache.org/r/40944/diff/
> 
> 
> Testing
> ---
> 
> make check(ubuntu14.04 + clang3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-04 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40944/
---

(Updated Dec. 4, 2015, 11:01 a.m.)


Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen.


Repository: mesos


Description
---

Fixed protobuf parse failure when pulling a docker image.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/message.proto 
824a788af0d2c779a2ca82a69ba65b6361154038 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
89f61c20e52e5eff8d8e92748f03b3b461516cd2 
  src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
1f05c75dc9473bd5e4c0d3f74fa0ef996b96a84e 
  src/tests/containerizer/provisioner_docker_tests.cpp 
c63bf53fee40ef12536a16e11f4d5224c4e4278e 

Diff: https://reviews.apache.org/r/40944/diff/


Testing
---

make check(ubuntu14.04 + clang3.6)


Thanks,

Gilbert Song

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-04 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40944/#review109010
---



src/slave/containerizer/mesos/provisioner/docker/message.proto (line 68)


Might be easy to read/understand if we name the fields as 
rawV1CompatibilityString and the the actual parsed field as v1Compatibility to 
match their semantics.


- Jojy Varghese


On Dec. 4, 2015, 6:44 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40944/
> ---
> 
> (Updated Dec. 4, 2015, 6:44 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed protobuf parse failure when pulling a docker image.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/message.proto 
> 824a788af0d2c779a2ca82a69ba65b6361154038 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 89f61c20e52e5eff8d8e92748f03b3b461516cd2 
>   src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
> 1f05c75dc9473bd5e4c0d3f74fa0ef996b96a84e 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> c63bf53fee40ef12536a16e11f4d5224c4e4278e 
> 
> Diff: https://reviews.apache.org/r/40944/diff/
> 
> 
> Testing
> ---
> 
> make check(ubuntu14.04 + clang3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-04 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40944/
---

(Updated Dec. 4, 2015, 10:44 a.m.)


Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen.


Repository: mesos


Description
---

Fixed protobuf parse failure when pulling a docker image.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/message.proto 
824a788af0d2c779a2ca82a69ba65b6361154038 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
89f61c20e52e5eff8d8e92748f03b3b461516cd2 
  src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
1f05c75dc9473bd5e4c0d3f74fa0ef996b96a84e 
  src/tests/containerizer/provisioner_docker_tests.cpp 
c63bf53fee40ef12536a16e11f4d5224c4e4278e 

Diff: https://reviews.apache.org/r/40944/diff/


Testing
---

make check(ubuntu14.04 + clang3.6)


Thanks,

Gilbert Song

Re: Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-03 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40944/
---

(Updated Dec. 3, 2015, 5:40 p.m.)


Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen.


Changes
---

Add comments to protobuf field v1Compat.


Repository: mesos


Description
---

Fixed protobuf parse failure when pulling a docker image.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/message.proto 
824a788af0d2c779a2ca82a69ba65b6361154038 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
89f61c20e52e5eff8d8e92748f03b3b461516cd2 
  src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
1f05c75dc9473bd5e4c0d3f74fa0ef996b96a84e 
  src/tests/containerizer/provisioner_docker_tests.cpp 
c63bf53fee40ef12536a16e11f4d5224c4e4278e 

Diff: https://reviews.apache.org/r/40944/diff/


Testing
---

make check(ubuntu14.04 + clang3.6)


Thanks,

Gilbert Song

Review Request 40944: Fixed protobuf parse failure when pulling a docker image.

2015-12-03 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40944/
---

Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen.


Repository: mesos


Description
---

Fixed protobuf parse failure when pulling a docker image.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/message.proto 
824a788af0d2c779a2ca82a69ba65b6361154038 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
89f61c20e52e5eff8d8e92748f03b3b461516cd2 
  src/slave/containerizer/mesos/provisioner/docker/spec.cpp 
1f05c75dc9473bd5e4c0d3f74fa0ef996b96a84e 
  src/tests/containerizer/provisioner_docker_tests.cpp 
c63bf53fee40ef12536a16e11f4d5224c4e4278e 

Diff: https://reviews.apache.org/r/40944/diff/


Testing
---

make check(ubuntu14.04 + clang3.6)


Thanks,

Gilbert Song