Re: Review Request 42236: Added a utility function to create https URI.

[Jie Yu]

> On Jan. 13, 2016, 9:11 p.m., Timothy Chen wrote:
> > src/uri/schemes/http.hpp, line 54
> > 
> >
> > Should we provide the default port for https here?

Nope. Tools (e.g., curl) will figure out the default. I don't want to duplicate 
the logics here.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42236/#review114278
---


On Jan. 13, 2016, 6:22 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42236/
> ---
> 
> (Updated Jan. 13, 2016, 6:22 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a utility function to create https URI.
> 
> 
> Diffs
> -
> 
>   src/uri/schemes/http.hpp 84a80b91ee664c29eed69f94d505aad45be326cf 
> 
> Diff: https://reviews.apache.org/r/42236/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 42236: Added a utility function to create https URI.

[Jie Yu]

> On Jan. 13, 2016, 7:05 p.m., Gilbert Song wrote:
> > LGTM! Just consider whether or not we should put it as `https.hpp` under 
> > `schemes` directory.

I prefer not. https is http + ssl. Also, they might share some functions in the 
future.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42236/#review114257
---


On Jan. 13, 2016, 6:22 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42236/
> ---
> 
> (Updated Jan. 13, 2016, 6:22 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a utility function to create https URI.
> 
> 
> Diffs
> -
> 
>   src/uri/schemes/http.hpp 84a80b91ee664c29eed69f94d505aad45be326cf 
> 
> Diff: https://reviews.apache.org/r/42236/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 42236: Added a utility function to create https URI.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42236/
---

(Updated Jan. 17, 2016, 9:51 p.m.)


Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy 
Chen.


Changes
---

Rebased.


Bugs: MESOS-4296
https://issues.apache.org/jira/browse/MESOS-4296


Repository: mesos


Description
---

Added a utility function to create https URI.


Diffs (updated)
-

  src/uri/schemes/http.hpp 84a80b91ee664c29eed69f94d505aad45be326cf 

Diff: https://reviews.apache.org/r/42236/diff/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 42236: Added a utility function to create https URI.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42236/#review114278
---

Ship it!


Ship It!


src/uri/schemes/http.hpp (line 54)


Should we provide the default port for https here?


- Timothy Chen


On Jan. 13, 2016, 6:22 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42236/
> ---
> 
> (Updated Jan. 13, 2016, 6:22 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a utility function to create https URI.
> 
> 
> Diffs
> -
> 
>   src/uri/schemes/http.hpp 84a80b91ee664c29eed69f94d505aad45be326cf 
> 
> Diff: https://reviews.apache.org/r/42236/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 42236: Added a utility function to create https URI.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42236/#review114257
---

Ship it!


LGTM! Just consider whether or not we should put it as `https.hpp` under 
`schemes` directory.

- Gilbert Song


On Jan. 12, 2016, 10:22 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42236/
> ---
> 
> (Updated Jan. 12, 2016, 10:22 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and 
> Timothy Chen.
> 
> 
> Bugs: MESOS-4296
> https://issues.apache.org/jira/browse/MESOS-4296
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a utility function to create https URI.
> 
> 
> Diffs
> -
> 
>   src/uri/schemes/http.hpp 84a80b91ee664c29eed69f94d505aad45be326cf 
> 
> Diff: https://reviews.apache.org/r/42236/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Review Request 42236: Added a utility function to create https URI.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42236/
---

Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy 
Chen.


Bugs: MESOS-4296
https://issues.apache.org/jira/browse/MESOS-4296


Repository: mesos


Description
---

Added a utility function to create https URI.


Diffs
-

  src/uri/schemes/http.hpp 84a80b91ee664c29eed69f94d505aad45be326cf 

Diff: https://reviews.apache.org/r/42236/diff/


Testing
---

make check


Thanks,

Jie Yu