Re: Review Request 42247: Made sure the container launcher terminated before we leave the test.

2016-01-31 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42247/#review117165
---


Ship it!




Ship It!

- Till Toenshoff


On Jan. 25, 2016, 2:35 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42247/
> ---
> 
> (Updated Jan. 25, 2016, 2:35 p.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Till Toenshoff.
> 
> 
> Bugs: MESOS-4329
> https://issues.apache.org/jira/browse/MESOS-4329
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Waiting for the launch result is not enough as it is unrelated to
> whether the launched container has terminated. If we do not wait for
> that the global teardown might find it still running and fail the tests
> (this can happen if we e.g., execute this test in isolation).
> 
> Also aline the name of the launch result to follow the canonical
> scheme.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp e943ab99baf3d74679a5da89a89f6a4b7ead 
> 
> Diff: https://reviews.apache.org/r/42247/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X 10.10.5)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 42247: Made sure the container launcher terminated before we leave the test.

2016-01-25 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42247/#review116093
---


Ship it!




Ship It!

- Guangya Liu


On 一月 25, 2016, 2:35 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42247/
> ---
> 
> (Updated 一月 25, 2016, 2:35 p.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Till Toenshoff.
> 
> 
> Bugs: MESOS-4329
> https://issues.apache.org/jira/browse/MESOS-4329
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Waiting for the launch result is not enough as it is unrelated to
> whether the launched container has terminated. If we do not wait for
> that the global teardown might find it still running and fail the tests
> (this can happen if we e.g., execute this test in isolation).
> 
> Also aline the name of the launch result to follow the canonical
> scheme.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp e943ab99baf3d74679a5da89a89f6a4b7ead 
> 
> Diff: https://reviews.apache.org/r/42247/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X 10.10.5)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 42247: Made sure the container launcher terminated before we leave the test.

2016-01-25 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42247/
---

(Updated Jan. 25, 2016, 3:35 p.m.)


Review request for mesos, Jan Schlicht and Till Toenshoff.


Changes
---

Addressed comments and fix language issues in the commit_msg.


Bugs: MESOS-4329
https://issues.apache.org/jira/browse/MESOS-4329


Repository: mesos


Description (updated)
---

Waiting for the launch result is not enough as it is unrelated to
whether the launched container has terminated. If we do not wait for
that the global teardown might find it still running and fail the tests
(this can happen if we e.g., execute this test in isolation).

Also aline the name of the launch result to follow the canonical
scheme.


Diffs (updated)
-

  src/tests/slave_tests.cpp e943ab99baf3d74679a5da89a89f6a4b7ead 

Diff: https://reviews.apache.org/r/42247/diff/


Testing
---

make check (OS X 10.10.5)


Thanks,

Benjamin Bannier

Re: Review Request 42247: Made sure the container launcher terminated before we leave the test.

2016-01-25 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42247/#review116097
---



Patch looks great!

Reviews applied: [42247]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 25, 2016, 2:35 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42247/
> ---
> 
> (Updated Jan. 25, 2016, 2:35 p.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Till Toenshoff.
> 
> 
> Bugs: MESOS-4329
> https://issues.apache.org/jira/browse/MESOS-4329
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Waiting for the launch result is not enough as it is unrelated to
> whether the launched container has terminated. If we do not wait for
> that the global teardown might find it still running and fail the tests
> (this can happen if we e.g., execute this test in isolation).
> 
> Also aline the name of the launch result to follow the canonical
> scheme.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp e943ab99baf3d74679a5da89a89f6a4b7ead 
> 
> Diff: https://reviews.apache.org/r/42247/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X 10.10.5)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 42247: Made sure the container launcher terminated before we leave the test.

2016-01-24 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42247/#review116054
---




src/tests/slave_tests.cpp (line 704)


Replace `///` with `//`


- Guangya Liu


On 一月 18, 2016, 11:14 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42247/
> ---
> 
> (Updated 一月 18, 2016, 11:14 a.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Till Toenshoff.
> 
> 
> Bugs: MESOS-4329
> https://issues.apache.org/jira/browse/MESOS-4329
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Waiting for the launch result is not enough as it is unrelated to
> whether the launched container has terminated. If we do not wait for
> that the global teardown might find it still running and fail the tests
> (this can happen if we e.g., execute this test in isolation).
> 
> Also along the name of the launch result to following the canonical
> scheme.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 7fe566770bbd802111885de061a53a3edf914840 
> 
> Diff: https://reviews.apache.org/r/42247/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X 10.10.5)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 42247: Made sure the container launcher terminated before we leave the test.

2016-01-18 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42247/#review115003
---


Patch looks great!

Reviews applied: [42247]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 18, 2016, 11:14 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42247/
> ---
> 
> (Updated Jan. 18, 2016, 11:14 a.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Till Toenshoff.
> 
> 
> Bugs: MESOS-4329
> https://issues.apache.org/jira/browse/MESOS-4329
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Waiting for the launch result is not enough as it is unrelated to
> whether the launched container has terminated. If we do not wait for
> that the global teardown might find it still running and fail the tests
> (this can happen if we e.g., execute this test in isolation).
> 
> Also along the name of the launch result to following the canonical
> scheme.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 7fe566770bbd802111885de061a53a3edf914840 
> 
> Diff: https://reviews.apache.org/r/42247/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X 10.10.5)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 42247: Made sure the container launcher terminated before we leave the test.

2016-01-18 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42247/
---

Review request for mesos and Till Toenshoff.


Bugs: MESOS-4329
https://issues.apache.org/jira/browse/MESOS-4329


Repository: mesos


Description
---

Waiting for the launch result is not enough as it is unrelated to
whether the launched container has terminated. If we do not wait for
that the global teardown might find it still running and fail the tests
(this can happen if we e.g., execute this test in isolation).


Diffs
-

  src/tests/slave_tests.cpp 076660daf025d6fd5065cd0c1930f17ecc5ca5aa 

Diff: https://reviews.apache.org/r/42247/diff/


Testing
---

make check (OS X 10.10.5)


Thanks,

Benjamin Bannier

Re: Review Request 42247: Made sure the container launcher terminated before we leave the test.

2016-01-18 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42247/#review114983
---

Ship it!


Ship It!

- Jan Schlicht


On Jan. 18, 2016, 11:42 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42247/
> ---
> 
> (Updated Jan. 18, 2016, 11:42 a.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Till Toenshoff.
> 
> 
> Bugs: MESOS-4329
> https://issues.apache.org/jira/browse/MESOS-4329
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Waiting for the launch result is not enough as it is unrelated to
> whether the launched container has terminated. If we do not wait for
> that the global teardown might find it still running and fail the tests
> (this can happen if we e.g., execute this test in isolation).
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 076660daf025d6fd5065cd0c1930f17ecc5ca5aa 
> 
> Diff: https://reviews.apache.org/r/42247/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X 10.10.5)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 42247: Made sure the container launcher terminated before we leave the test.

2016-01-18 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42247/
---

(Updated Jan. 18, 2016, 12:14 p.m.)


Review request for mesos, Jan Schlicht and Till Toenshoff.


Changes
---

Rename result to launch to follow canonical naming scheme.


Bugs: MESOS-4329
https://issues.apache.org/jira/browse/MESOS-4329


Repository: mesos


Description (updated)
---

Waiting for the launch result is not enough as it is unrelated to
whether the launched container has terminated. If we do not wait for
that the global teardown might find it still running and fail the tests
(this can happen if we e.g., execute this test in isolation).

Also along the name of the launch result to following the canonical
scheme.


Diffs (updated)
-

  src/tests/slave_tests.cpp 7fe566770bbd802111885de061a53a3edf914840 

Diff: https://reviews.apache.org/r/42247/diff/


Testing
---

make check (OS X 10.10.5)


Thanks,

Benjamin Bannier