Review Request 44239: Introduced copy fetcher plugin for file URIs.

2016-03-01 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44239/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-4834
https://issues.apache.org/jira/browse/MESOS-4834


Repository: mesos


Description
---

This change adds support for fetching `file` URIs using the fetcher plugin
framework.


Diffs
-

  src/CMakeLists.txt 0832f1e9a850cc0d2c1112a446f0daf0190f8d7f 
  src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
  src/tests/uri_fetcher_tests.cpp dcfba784d6ae49b8181b5a69dc00e82854ac4ff1 
  src/uri/fetcher.hpp 5bc9703b76457413b5841710e0313f8bfa9047a1 
  src/uri/fetcher.cpp 2d8d5b18b7a9b55be52288f17e85d6c406cfef88 
  src/uri/fetchers/copy.hpp PRE-CREATION 
  src/uri/fetchers/copy.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44239/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 44239: Introduced copy fetcher plugin for file URIs.

2016-03-01 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44239/#review121571
---



Patch looks great!

Reviews applied: [44239]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 2, 2016, 12:13 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44239/
> ---
> 
> (Updated March 2, 2016, 12:13 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4834
> https://issues.apache.org/jira/browse/MESOS-4834
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds support for fetching `file` URIs using the fetcher plugin
> framework.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 0832f1e9a850cc0d2c1112a446f0daf0190f8d7f 
>   src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
>   src/tests/uri_fetcher_tests.cpp dcfba784d6ae49b8181b5a69dc00e82854ac4ff1 
>   src/uri/fetcher.hpp 5bc9703b76457413b5841710e0313f8bfa9047a1 
>   src/uri/fetcher.cpp 2d8d5b18b7a9b55be52288f17e85d6c406cfef88 
>   src/uri/fetchers/copy.hpp PRE-CREATION 
>   src/uri/fetchers/copy.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44239/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 44239: Introduced copy fetcher plugin for file URIs.

2016-03-02 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44239/#review121655
---




src/uri/fetchers/copy.cpp (line 72)


Printing the `uri` in the failure may help improve the debug ability?



src/uri/fetchers/copy.cpp (line 88)


Add a log here?

VLOG(1) << "Copying '" << uri.path() << "' to '" << directory << "'";


- Guangya Liu


On 三月 2, 2016, 12:13 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44239/
> ---
> 
> (Updated 三月 2, 2016, 12:13 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4834
> https://issues.apache.org/jira/browse/MESOS-4834
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds support for fetching `file` URIs using the fetcher plugin
> framework.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 0832f1e9a850cc0d2c1112a446f0daf0190f8d7f 
>   src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
>   src/tests/uri_fetcher_tests.cpp dcfba784d6ae49b8181b5a69dc00e82854ac4ff1 
>   src/uri/fetcher.hpp 5bc9703b76457413b5841710e0313f8bfa9047a1 
>   src/uri/fetcher.cpp 2d8d5b18b7a9b55be52288f17e85d6c406cfef88 
>   src/uri/fetchers/copy.hpp PRE-CREATION 
>   src/uri/fetchers/copy.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44239/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 44239: Introduced copy fetcher plugin for file URIs.

2016-03-02 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44239/
---

(Updated March 2, 2016, 9:44 p.m.)


Review request for mesos and Jie Yu.


Changes
---

review addressed.


Bugs: MESOS-4834
https://issues.apache.org/jira/browse/MESOS-4834


Repository: mesos


Description
---

This change adds support for fetching `file` URIs using the fetcher plugin
framework.


Diffs (updated)
-

  src/CMakeLists.txt 0832f1e9a850cc0d2c1112a446f0daf0190f8d7f 
  src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
  src/tests/uri_fetcher_tests.cpp dcfba784d6ae49b8181b5a69dc00e82854ac4ff1 
  src/uri/fetcher.hpp 5bc9703b76457413b5841710e0313f8bfa9047a1 
  src/uri/fetcher.cpp 2d8d5b18b7a9b55be52288f17e85d6c406cfef88 
  src/uri/fetchers/copy.hpp PRE-CREATION 
  src/uri/fetchers/copy.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44239/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 44239: Introduced copy fetcher plugin for file URIs.

2016-03-02 Thread Jojy Varghese 


> On March 2, 2016, 3:26 p.m., Guangya Liu wrote:
> > src/uri/fetchers/copy.cpp, line 72
> > 
> >
> > Printing the `uri` in the failure may help improve the debug ability?

The pattern is same as all other fetchers. Will drop this issue.


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44239/#review121655
---


On March 2, 2016, 12:13 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44239/
> ---
> 
> (Updated March 2, 2016, 12:13 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4834
> https://issues.apache.org/jira/browse/MESOS-4834
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds support for fetching `file` URIs using the fetcher plugin
> framework.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 0832f1e9a850cc0d2c1112a446f0daf0190f8d7f 
>   src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
>   src/tests/uri_fetcher_tests.cpp dcfba784d6ae49b8181b5a69dc00e82854ac4ff1 
>   src/uri/fetcher.hpp 5bc9703b76457413b5841710e0313f8bfa9047a1 
>   src/uri/fetcher.cpp 2d8d5b18b7a9b55be52288f17e85d6c406cfef88 
>   src/uri/fetchers/copy.hpp PRE-CREATION 
>   src/uri/fetchers/copy.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44239/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 44239: Introduced copy fetcher plugin for file URIs.

2016-03-02 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44239/#review121758
---


Fix it, then Ship it!





src/uri/fetchers/copy.cpp (line 85)


Why do you need this?



src/uri/fetchers/copy.cpp (line 87)


Copying uri xxx to 'directory'



src/uri/fetchers/copy.cpp (lines 132 - 137)


Why do you need this?


- Jie Yu


On March 2, 2016, 9:44 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44239/
> ---
> 
> (Updated March 2, 2016, 9:44 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4834
> https://issues.apache.org/jira/browse/MESOS-4834
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds support for fetching `file` URIs using the fetcher plugin
> framework.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 0832f1e9a850cc0d2c1112a446f0daf0190f8d7f 
>   src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
>   src/tests/uri_fetcher_tests.cpp dcfba784d6ae49b8181b5a69dc00e82854ac4ff1 
>   src/uri/fetcher.hpp 5bc9703b76457413b5841710e0313f8bfa9047a1 
>   src/uri/fetcher.cpp 2d8d5b18b7a9b55be52288f17e85d6c406cfef88 
>   src/uri/fetchers/copy.hpp PRE-CREATION 
>   src/uri/fetchers/copy.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44239/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 44239: Introduced copy fetcher plugin for file URIs.

2016-03-02 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44239/
---

(Updated March 3, 2016, 1:47 a.m.)


Review request for mesos and Jie Yu.


Changes
---

review addressed.


Bugs: MESOS-4834
https://issues.apache.org/jira/browse/MESOS-4834


Repository: mesos


Description
---

This change adds support for fetching `file` URIs using the fetcher plugin
framework.


Diffs (updated)
-

  src/CMakeLists.txt 0832f1e9a850cc0d2c1112a446f0daf0190f8d7f 
  src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
  src/tests/uri_fetcher_tests.cpp dcfba784d6ae49b8181b5a69dc00e82854ac4ff1 
  src/uri/fetcher.hpp 5bc9703b76457413b5841710e0313f8bfa9047a1 
  src/uri/fetcher.cpp 2d8d5b18b7a9b55be52288f17e85d6c406cfef88 
  src/uri/fetchers/copy.hpp PRE-CREATION 
  src/uri/fetchers/copy.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44239/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 44239: Introduced copy fetcher plugin for file URIs.

2016-03-02 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44239/
---

(Updated March 3, 2016, 2:02 a.m.)


Review request for mesos and Jie Yu.


Changes
---

fixed patch.


Bugs: MESOS-4834
https://issues.apache.org/jira/browse/MESOS-4834


Repository: mesos


Description
---

This change adds support for fetching `file` URIs using the fetcher plugin
framework.


Diffs (updated)
-

  src/CMakeLists.txt 0832f1e9a850cc0d2c1112a446f0daf0190f8d7f 
  src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
  src/tests/uri_fetcher_tests.cpp dcfba784d6ae49b8181b5a69dc00e82854ac4ff1 
  src/uri/fetcher.hpp 5bc9703b76457413b5841710e0313f8bfa9047a1 
  src/uri/fetcher.cpp 2d8d5b18b7a9b55be52288f17e85d6c406cfef88 
  src/uri/fetchers/copy.hpp PRE-CREATION 
  src/uri/fetchers/copy.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44239/diff/


Testing
---

make check.


Thanks,

Jojy Varghese