subject:"Review Request 44441\: Treated command as executable value and arguments in mesos\-execute."

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-29 Thread Guangya Liu



> On 四月 2, 2016, 2:38 p.m., haosdent huang wrote:
> > src/cli/execute.cpp, line 283
> > 
> >
> > How to handle those command parameters contains "," here? For example, 
> > if user want to try "cat 'a,b'".
> 
> Alexander Rukletsov wrote:
> Yeah, and if the user wants "echo 'hello world'"? I'm fine with 
> consolidating command and arguments flag, but let's make sure we parse it 
> correcly. Maybe we can do it the way docker does? I.e. `["command", "arg1", 
> "arg2", ...]`; we can leverage our JSON parser for this, I believe 
> `tockenize()` is not enough. Also, I would like us manually test various 
> inputs and capture them in the testing done section. We may later want to 
> automate these tests in a staging cluster.
> 
> Guangya Liu wrote:
> Yes, I will test more cases. 
> 
> @haosdent, for your case, you should run the command as 
> `--command="cat,/etc/passwd,/etc/passwd"`
> 
> @Alexr, does the strings::tokenize(command.get(), ",") enough? Why need 
> JSON parser?
> 
> Guangya Liu wrote:
> @alexr, one question for your comments above:
> 
> `I.e. ["command", "arg1", "arg2", ...]; we can leverage our JSON parser 
> for this`
> 
> Do you mean using JSON parser parse the `["command", "arg1", "arg2", 
> ...]`? I think that the JSON does not support such format. What about enable 
> `command` flag set the following JSON:
> 
> {
> "command" : "cmd",
> "args": "["arg1", "arg2", "arg3,arg3"]"
> }

Alex, any comments for this? I was blocked here and want to get some comments 
from you. Thanks.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126690
---


On 四月 13, 2016, 2:47 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated 四月 13, 2016, 2:47 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 306779f5227248a9f1d67b6c50854ec47dd59cd5 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 5) 
> root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busy

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-28 Thread Guangya Liu



> On 四月 2, 2016, 2:38 p.m., haosdent huang wrote:
> > src/cli/execute.cpp, line 283
> > 
> >
> > How to handle those command parameters contains "," here? For example, 
> > if user want to try "cat 'a,b'".
> 
> Alexander Rukletsov wrote:
> Yeah, and if the user wants "echo 'hello world'"? I'm fine with 
> consolidating command and arguments flag, but let's make sure we parse it 
> correcly. Maybe we can do it the way docker does? I.e. `["command", "arg1", 
> "arg2", ...]`; we can leverage our JSON parser for this, I believe 
> `tockenize()` is not enough. Also, I would like us manually test various 
> inputs and capture them in the testing done section. We may later want to 
> automate these tests in a staging cluster.
> 
> Guangya Liu wrote:
> Yes, I will test more cases. 
> 
> @haosdent, for your case, you should run the command as 
> `--command="cat,/etc/passwd,/etc/passwd"`
> 
> @Alexr, does the strings::tokenize(command.get(), ",") enough? Why need 
> JSON parser?

@alexr, one question for your comments above:

`I.e. ["command", "arg1", "arg2", ...]; we can leverage our JSON parser for 
this`

Do you mean using JSON parser parse the `["command", "arg1", "arg2", ...]`? I 
think that the JSON does not support such format. What about enable `command` 
flag set the following JSON:

{
"command" : "cmd",
"args": "["arg1", "arg2", "arg3,arg3"]"
}


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126690
---


On 四月 13, 2016, 2:47 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated 四月 13, 2016, 2:47 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 306779f5227248a9f1d67b6c50854ec47dd59cd5 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 5) 
> root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="echo, hello,world"
> I0410 21:09:57.914875 10649 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '11a3bd6c-be66-46d6-a5a

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-27 Thread Guangya Liu



> On 四月 13, 2016, 10:29 a.m., Alexander Rukletsov wrote:
> > src/cli/execute.cpp, lines 103-104
> > 
> >
> > Why have you removed the TODO without adding a word about how `command` 
> > works wiht containers?

Alex, does the comments for the command OK? I was only highlighting executable 
and shell command but not entrypoint. I have append some comments at 
https://reviews.apache.org/r/45926/ , can you please take a look? I think that 
entrypoint does not fit into the comments well, `the entrypoint can be only 
specified in a docker image but not a command`.

"If 'shell' is true, the command will be launched via shell\n"
"(i.e., /bin/sh -c 'command'). The 'command' specified will\n"
"be treated as the shell command.\n"
"If 'shell' is false, the command will be launched by passing\n"
"arguments to an executable. The 'command' specified will be\n"
"treated as the filename of the executable and the 'arguments'\n"
"to the executable. This is similar to how POSIX exec families\n"
"launch processes (i.e.,execlp(value, arg(0), arg(1), ...)).")


> On 四月 13, 2016, 10:29 a.m., Alexander Rukletsov wrote:
> > src/cli/execute.cpp, line 341
> > 
> >
> > I'm confused. I thought we've agreed during the offline discussion that 
> > we need to parse command properly and that `tokenize` is error-prone in 
> > this case.

After check with Gilbert, I will try to add a new flag named as `arguments` and 
using JSON to do the parsing.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review128646
---


On 四月 13, 2016, 2:47 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated 四月 13, 2016, 2:47 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 306779f5227248a9f1d67b6c50854ec47dd59cd5 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 5) 
> root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=bu

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-13 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review128680
---



Patch looks great!

Reviews applied: [1]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 13, 2016, 2:47 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated April 13, 2016, 2:47 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 306779f5227248a9f1d67b6c50854ec47dd59cd5 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 5) 
> root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="echo, hello,world"
> I0410 21:09:57.914875 10649 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0007
> task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> From sandbox stdout:
> [echo, echo,  hello, world]
>  hello world
>  
> 6) root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="echo, hello world"
> I0410 21:09:53.783275 10581 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0006
> task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> From sandbox stdout:
> [echo, echo,  hello world]
>  hello world
>  
> 7)root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command=""I0413 10:45:13.365993 18037 
> scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '0cae04e2-e47a-4297-86c3-e370e95fa350-0001'
> Submitted task 'test_mesos' to agen

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-13 Thread Alexander Rukletsov


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review128646
---




src/cli/execute.cpp 


Why have you removed the TODO without adding a word about how `command` 
works wiht containers?



src/cli/execute.cpp (line 339)


I'm confused. I thought we've agreed during the offline discussion that we 
need to parse command properly and that `tokenize` is error-prone in this case.


- Alexander Rukletsov


On April 13, 2016, 2:47 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated April 13, 2016, 2:47 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 306779f5227248a9f1d67b6c50854ec47dd59cd5 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 5) 
> root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="echo, hello,world"
> I0410 21:09:57.914875 10649 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0007
> task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> From sandbox stdout:
> [echo, echo,  hello, world]
>  hello world
>  
> 6) root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="echo, hello world"
> I0410 21:09:53.783275 10581 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0006
> task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> From sandbox stdout:
> [echo, echo,  hello world]
>  hello world
>  
> 7)root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-12 Thread Guangya Liu



> On 四月 3, 2016, 9:49 a.m., Alexander Rukletsov wrote:
> > src/cli/execute.cpp, line 104
> > 
> >
> > Do we introduce 'arguments' flag? It looks like you treat 'command' 
> > flag as command + arguments. This comment is misleading.
> 
> Guangya Liu wrote:
> There is no `argument` flag now, I was following the comments here 
> https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L427-L439
>  , the `command` will be composed by arguments and executable. What do you 
> think? Do you think we need to add a new flag `argument` for this? That may 
> make the logic a bit complex for end user.

Alex, I think that do not intend to add an `argument` flag.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126719
---


On 四月 13, 2016, 2:47 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated 四月 13, 2016, 2:47 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 306779f5227248a9f1d67b6c50854ec47dd59cd5 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 5) 
> root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="echo, hello,world"
> I0410 21:09:57.914875 10649 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0007
> task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> From sandbox stdout:
> [echo, echo,  hello, world]
>  hello world
>  
> 6) root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="echo, hello world"
> I0410 21:09:53.783275 10581 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0006
> task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
> Recei

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-12 Thread Guangya Liu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/
---

(Updated 四月 13, 2016, 2:47 a.m.)


Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
and Jie Yu.


Bugs: MESOS-4882
https://issues.apache.org/jira/browse/MESOS-4882


Repository: mesos


Description
---

Treated command as executable value and arguments in mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp 306779f5227248a9f1d67b6c50854ec47dd59cd5 

Diff: https://reviews.apache.org/r/1/diff/


Testing (updated)
---

1) with docker entry point
root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell
I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
Received status update TASK_RUNNING for task test_mesos

2) With command 1
root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell  --command="ls,/etc/passwd"
I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos

3) With command 2
root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos

4) With command 3
root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos

5) 
root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell  --command="echo, hello,world"
I0410 21:09:57.914875 10649 scheduler.cpp:175] Version: 0.29.0
Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0007
task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos

>From sandbox stdout:
[echo, echo,  hello, world]
 hello world
 
6) root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell  --command="echo, hello world"
I0410 21:09:53.783275 10581 scheduler.cpp:175] Version: 0.29.0
Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0006
task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos

>From sandbox stdout:
[echo, echo,  hello world]
 hello world
 
7)root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell  --command=""I0413 10:45:13.365993 18037 
scheduler.cpp:175] Version: 0.29.0
Subscribed with ID '0cae04e2-e47a-4297-86c3-e370e95fa350-0001'
Submitted task 'test_mesos' to agent '0cae04e2-e47a-4297-86c3-e370e95fa350-S0'
Received status update TASK_RUNNING for task 'test_mesos'
  source: SOURCE_EXECUTOR


Thanks,

Guangya Liu

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-11 Thread Alexander Rukletsov


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review128216
---




src/cli/execute.cpp (line 306)


Let's write a comment here why `command` can be `None`.


- Alexander Rukletsov


On April 10, 2016, 1:12 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated April 10, 2016, 1:12 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 763dd26c359d1dd92c6e0365e4808b673efb1f40 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 5) 
> root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="echo, hello,world"
> I0410 21:09:57.914875 10649 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0007
> task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> From sandbox stdout:
> [echo, echo,  hello, world]
>  hello world
>  
> 6) root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="echo, hello world"
> I0410 21:09:53.783275 10581 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0006
> task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> From sandbox stdout:
> [echo, echo,  hello world]
>  hello world
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-10 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review128041
---



Patch looks great!

Reviews applied: [1]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 10, 2016, 1:12 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated April 10, 2016, 1:12 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 763dd26c359d1dd92c6e0365e4808b673efb1f40 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 5) 
> root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="echo, hello,world"
> I0410 21:09:57.914875 10649 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0007
> task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> From sandbox stdout:
> [echo, echo,  hello, world]
>  hello world
>  
> 6) root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="echo, hello world"
> I0410 21:09:53.783275 10581 scheduler.cpp:175] Version: 0.29.0
> Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0006
> task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> From sandbox stdout:
> [echo, echo,  hello world]
>  hello world
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-10 Thread Guangya Liu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/
---

(Updated 四月 10, 2016, 1:12 p.m.)


Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
and Jie Yu.


Bugs: MESOS-4882
https://issues.apache.org/jira/browse/MESOS-4882


Repository: mesos


Description
---

Treated command as executable value and arguments in mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp 763dd26c359d1dd92c6e0365e4808b673efb1f40 

Diff: https://reviews.apache.org/r/1/diff/


Testing (updated)
---

1) with docker entry point
root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell
I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
Received status update TASK_RUNNING for task test_mesos

2) With command 1
root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell  --command="ls,/etc/passwd"
I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos

3) With command 2
root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos

4) With command 3
root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos

5) 
root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell  --command="echo, hello,world"
I0410 21:09:57.914875 10649 scheduler.cpp:175] Version: 0.29.0
Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0007
task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos

>From sandbox stdout:
[echo, echo,  hello, world]
 hello world
 
6) root@mesos002:~/src/mesos/m2/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell  --command="echo, hello world"
I0410 21:09:53.783275 10581 scheduler.cpp:175] Version: 0.29.0
Subscribed with ID '11a3bd6c-be66-46d6-a5a5-8e9b635940fe-0006
task test_mesos submitted to agent 7419ec23-763d-441f-b5d4-6d9222a1cfc9-S0
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos

>From sandbox stdout:
[echo, echo,  hello world]
 hello world


Thanks,

Guangya Liu

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-10 Thread Alexander Rukletsov


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review128027
---




src/cli/execute.cpp (line 94)


You lost a period : )


- Alexander Rukletsov


On April 3, 2016, 1:42 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated April 3, 2016, 1:42 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-08 Thread Guangya Liu



> On 四月 4, 2016, 6:13 p.m., Gilbert Song wrote:
> > src/cli/execute.cpp, line 287
> > 
> >
> > This is incorrect. We handle this merging operation in runtime isolator.
> 
> Tim Anderegg wrote:
> I was testing out a similar implementation of this feature on my own 
> machine, but using AppC instead of Docker.  Since AppC has no runtime 
> isolator in Mesos (yet), I think it would make sense to support merging the 
> arguments within mesos-execute to enable easy testing of container images 
> that have no runtime isolator, no?  Would the Docker runtime isolator 
> properly handle the arguments if they came pre-merged?

@Gilbert, I think that the command was hanlded here 
https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/isolators/docker/runtime.cpp#L282-L285
 in runtime isolator, does it do the merge work? I think the runtime isolator 
only did merge work for runtime configuration from docker image, right?

@Tim, +1, and there is also a jira tracing the AppC run time isolator 
https://issues.apache.org/jira/browse/MESOS-4778


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126880
---


On 四月 3, 2016, 1:42 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated 四月 3, 2016, 1:42 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-07 Thread Tim Anderegg



> On April 4, 2016, 6:13 p.m., Gilbert Song wrote:
> > src/cli/execute.cpp, line 287
> > 
> >
> > This is incorrect. We handle this merging operation in runtime isolator.

I was testing out a similar implementation of this feature on my own machine, 
but using AppC instead of Docker.  Since AppC has no runtime isolator in Mesos 
(yet), I think it would make sense to support merging the arguments within 
mesos-execute to enable easy testing of container images that have no runtime 
isolator, no?  Would the Docker runtime isolator properly handle the arguments 
if they came pre-merged?


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126880
---


On April 3, 2016, 1:42 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated April 3, 2016, 1:42 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-04 Thread Gilbert Song


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126880
---




src/cli/execute.cpp (line 284)


Could you test --command="sh,-c,echo 'hello world'"
and
--command="sh,-c,echo 'hello,world'"

It seems to me that maybe we should add a flag for arguement, since that is 
identical to developer's behavior on writting a framework. Also, tokenize seems 
not sufficient enough to me. Let's discuss today.



src/cli/execute.cpp (line 287)


This is incorrect. We handle this merging operation in runtime isolator.


- Gilbert Song


On April 3, 2016, 6:42 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated April 3, 2016, 6:42 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-03 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126731
---



Patch looks great!

Reviews applied: [1]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 3, 2016, 1:42 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated April 3, 2016, 1:42 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-03 Thread Guangya Liu



> On 四月 3, 2016, 9:52 a.m., Alexander Rukletsov wrote:
> > src/cli/execute.cpp, line 283
> > 
> >
> > According to "testing done" section, the separator is comma. How come 
> > here is space?
> > 
> > Also, pretty please update the flag description with the *actual* 
> > format, separators and example!

Will update later.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126720
---


On 四月 3, 2016, 1:42 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated 四月 3, 2016, 1:42 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
> and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> 1) with docker entry point
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell
> I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> 
> 2) With command 1
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd"
> I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 3) With command 2
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
> I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 4) With command 3
> root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
> --master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
> --containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
> I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
> Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
> task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-03 Thread Guangya Liu



> On 四月 3, 2016, 9:49 a.m., Alexander Rukletsov wrote:
> > src/cli/execute.cpp, line 104
> > 
> >
> > Do we introduce 'arguments' flag? It looks like you treat 'command' 
> > flag as command + arguments. This comment is misleading.

There is no `argument` flag now, I was following the comments here 
https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L427-L439 
, the `command` will be composed by arguments and executable. What do you 
think? Do you think we need to add a new flag `argument` for this? That may 
make the logic a bit complex for end user.


> On 四月 3, 2016, 9:49 a.m., Alexander Rukletsov wrote:
> > src/cli/execute.cpp, line 282
> > 
> >
> > Can we set `CommandInfo.value` outisde the loop and avoid this flag?

Here I need to get the first token as the value, so may not able to move this 
out of the loop, do you have any other idea for moving this out?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126719
---


On 四月 2, 2016, 3:01 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated 四月 2, 2016, 3:01 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos 
> --docker_image=busybox:latest --containerizer=mesos --no-shell  
> --command="ls,/etc/passwd" 
> I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
> I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at 
> master@192.168.56.12:5050
> I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. 
> Attempting to register without authentication
> I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with 
> a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
> I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 
> 'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-03 Thread Guangya Liu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/
---

(Updated 四月 3, 2016, 1:42 p.m.)


Review request for mesos, Alexander Rukletsov, Gilbert Song, haosdent huang, 
and Jie Yu.


Bugs: MESOS-4882
https://issues.apache.org/jira/browse/MESOS-4882


Repository: mesos


Description
---

Treated command as executable value and arguments in mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 

Diff: https://reviews.apache.org/r/1/diff/


Testing (updated)
---

1) with docker entry point
root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell
I0403 21:35:42.949331 12369 scheduler.cpp:172] Version: 0.29.0
Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-
task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
Received status update TASK_RUNNING for task test_mesos

2) With command 1
root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell  --command="ls,/etc/passwd"
I0403 21:36:55.703246 12483 scheduler.cpp:172] Version: 0.29.0
Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0001
task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos

3) With command 2
root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell  --command="ls,/etc/passwd,/etc/passwd"
I0403 21:37:22.901828 12548 scheduler.cpp:172] Version: 0.29.0
Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0002
task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos

4) With command 3
root@mesos002:~/src/mesos/m1/mesos/build# ./src/mesos-execute 
--master=192.168.56.12:5050  --name=test_mesos --docker_image=busybox:latest 
--containerizer=mesos --no-shell  --command="cat,/etc/passwd,/etc/passwd"
I0403 21:39:35.986281 12651 scheduler.cpp:172] Version: 0.29.0
Subscribed with ID '70abe267-a808-43fa-a1db-512af35d8ad4-0003
task test_mesos submitted to agent 030ca997-9310-48bb-973f-d53136022537-S0
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos


Thanks,

Guangya Liu

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-03 Thread Guangya Liu



> On 四月 2, 2016, 2:38 p.m., haosdent huang wrote:
> > src/cli/execute.cpp, line 283
> > 
> >
> > How to handle those command parameters contains "," here? For example, 
> > if user want to try "cat 'a,b'".
> 
> Alexander Rukletsov wrote:
> Yeah, and if the user wants "echo 'hello world'"? I'm fine with 
> consolidating command and arguments flag, but let's make sure we parse it 
> correcly. Maybe we can do it the way docker does? I.e. `["command", "arg1", 
> "arg2", ...]`; we can leverage our JSON parser for this, I believe 
> `tockenize()` is not enough. Also, I would like us manually test various 
> inputs and capture them in the testing done section. We may later want to 
> automate these tests in a staging cluster.

Yes, I will test more cases. 

@haosdent, for your case, you should run the command as 
`--command="cat,/etc/passwd,/etc/passwd"`

@Alexr, does the strings::tokenize(command.get(), ",") enough? Why need JSON 
parser?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126690
---


On 四月 2, 2016, 3:01 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated 四月 2, 2016, 3:01 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos 
> --docker_image=busybox:latest --containerizer=mesos --no-shell  
> --command="ls,/etc/passwd" 
> I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
> I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at 
> master@192.168.56.12:5050
> I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. 
> Attempting to register without authentication
> I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with 
> a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
> I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 
> 'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-03 Thread Alexander Rukletsov



> On April 2, 2016, 2:38 p.m., haosdent huang wrote:
> > src/cli/execute.cpp, line 283
> > 
> >
> > How to handle those command parameters contains "," here? For example, 
> > if user want to try "cat 'a,b'".

Yeah, and if the user wants "echo 'hello world'"? I'm fine with consolidating 
command and arguments flag, but let's make sure we parse it correcly. Maybe we 
can do it the way docker does? I.e. `["command", "arg1", "arg2", ...]`; we can 
leverage our JSON parser for this, I believe `tockenize()` is not enough. Also, 
I would like us manually test various inputs and capture them in the testing 
done section. We may later want to automate these tests in a staging cluster.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126690
---


On April 2, 2016, 3:01 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated April 2, 2016, 3:01 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos 
> --docker_image=busybox:latest --containerizer=mesos --no-shell  
> --command="ls,/etc/passwd" 
> I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
> I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at 
> master@192.168.56.12:5050
> I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. 
> Attempting to register without authentication
> I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with 
> a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
> I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 
> 'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-03 Thread Alexander Rukletsov


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126720
---




src/cli/execute.cpp (line 283)


According to "testing done" section, the separator is comma. How come here 
is space?

Also, pretty please update the flag description with the *actual* format, 
separators and example!


- Alexander Rukletsov


On April 2, 2016, 3:01 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated April 2, 2016, 3:01 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos 
> --docker_image=busybox:latest --containerizer=mesos --no-shell  
> --command="ls,/etc/passwd" 
> I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
> I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at 
> master@192.168.56.12:5050
> I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. 
> Attempting to register without authentication
> I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with 
> a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
> I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 
> 'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-03 Thread Alexander Rukletsov


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126719
---




src/cli/execute.cpp (line 104)


Do we introduce 'arguments' flag? It looks like you treat 'command' flag as 
command + arguments. This comment is misleading.



src/cli/execute.cpp (line 282)


Can we set `CommandInfo.value` outisde the loop and avoid this flag?



src/cli/execute.cpp (line 283)


Command can be `None` in case of docker with set entripoint.


- Alexander Rukletsov


On April 2, 2016, 3:01 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated April 2, 2016, 3:01 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos 
> --docker_image=busybox:latest --containerizer=mesos --no-shell  
> --command="ls,/etc/passwd" 
> I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
> I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at 
> master@192.168.56.12:5050
> I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. 
> Attempting to register without authentication
> I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with 
> a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
> I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 
> 'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-02 Thread Guangya Liu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/
---

(Updated 四月 2, 2016, 3:01 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-4882
https://issues.apache.org/jira/browse/MESOS-4882


Repository: mesos


Description
---

Treated command as executable value and arguments in mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 

Diff: https://reviews.apache.org/r/1/diff/


Testing
---

./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos 
--docker_image=busybox:latest --containerizer=mesos --no-shell  
--command="ls,/etc/passwd" 
I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at 
master@192.168.56.12:5050
I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. Attempting 
to register without authentication
I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with 
a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos
I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 
'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'


Thanks,

Guangya Liu

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-02 Thread haosdent huang



> On April 2, 2016, 2:38 p.m., haosdent huang wrote:
> >

By the way, use comma "," as delimiter looks a bit wired. Usually we use space 
or tab " ", right?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126690
---


On March 31, 2016, 1:03 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated March 31, 2016, 1:03 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos 
> --docker_image=busybox:latest --containerizer=mesos --no-shell  
> --command="ls,/etc/passwd" 
> I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
> I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at 
> master@192.168.56.12:5050
> I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. 
> Attempting to register without authentication
> I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with 
> a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
> I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 
> 'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-04-02 Thread haosdent huang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126690
---




src/cli/execute.cpp (line 283)


How to handle those command parameters contains "," here? For example, if 
user want to try "cat 'a,b'".


- haosdent huang


On March 31, 2016, 1:03 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated March 31, 2016, 1:03 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos 
> --docker_image=busybox:latest --containerizer=mesos --no-shell  
> --command="ls,/etc/passwd" 
> I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
> I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at 
> master@192.168.56.12:5050
> I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. 
> Attempting to register without authentication
> I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with 
> a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
> I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 
> 'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-03-30 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review126244
---



Patch looks great!

Reviews applied: [1]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 31, 2016, 1:03 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated March 31, 2016, 1:03 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos 
> --docker_image=busybox:latest --containerizer=mesos --no-shell  
> --command="ls,/etc/passwd" 
> I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
> I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at 
> master@192.168.56.12:5050
> I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. 
> Attempting to register without authentication
> I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with 
> a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
> I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 
> 'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-03-30 Thread Guangya Liu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/
---

(Updated 三月 31, 2016, 1:03 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Rebase


Bugs: MESOS-4882
https://issues.apache.org/jira/browse/MESOS-4882


Repository: mesos


Description
---

Treated command as executable value and arguments in mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp af62f41622e1c43acd8f257c54f8754162c433b8 

Diff: https://reviews.apache.org/r/1/diff/


Testing
---

./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos 
--docker_image=busybox:latest --containerizer=mesos --no-shell  
--command="ls,/etc/passwd" 
I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at 
master@192.168.56.12:5050
I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. Attempting 
to register without authentication
I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with 
a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos
I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 
'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'


Thanks,

Guangya Liu

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-03-09 Thread Gilbert Song


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review122740
---


Ship it!




Ship It!

- Gilbert Song


On March 7, 2016, 9:17 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated March 7, 2016, 9:17 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos 
> --docker_image=busybox:latest --containerizer=mesos --no-shell  
> --command="ls,/etc/passwd" 
> I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
> I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at 
> master@192.168.56.12:5050
> I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. 
> Attempting to register without authentication
> I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with 
> a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
> I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 
> 'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-03-08 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review122487
---



Patch looks great!

Reviews applied: [1]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 8, 2016, 5:17 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated March 8, 2016, 5:17 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos 
> --docker_image=busybox:latest --containerizer=mesos --no-shell  
> --command="ls,/etc/passwd" 
> I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
> I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at 
> master@192.168.56.12:5050
> I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. 
> Attempting to register without authentication
> I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with 
> a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
> I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 
> 'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-03-07 Thread Guangya Liu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/
---

(Updated 三月 8, 2016, 5:17 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-4882
https://issues.apache.org/jira/browse/MESOS-4882


Repository: mesos


Description
---

Treated command as executable value and arguments in mesos-execute.


Diffs (updated)
-

  src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 

Diff: https://reviews.apache.org/r/1/diff/


Testing
---

./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos 
--docker_image=busybox:latest --containerizer=mesos --no-shell  
--command="ls,/etc/passwd" 
I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at 
master@192.168.56.12:5050
I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. Attempting 
to register without authentication
I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with 
a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos
I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 
'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'


Thanks,

Guangya Liu

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-03-07 Thread Guangya Liu



> On 三月 7, 2016, 4:48 p.m., Gilbert Song wrote:
> > Hi Guangya, Thanks for taking this on. My main consideration about this 
> > patch is making distinction between shell command v.s. non-shell command. 
> > We have two choices:
> > 
> > 1. Following your current implementation, the description of the `command` 
> > flag should be updated, because people may not know they should use 
> > `--command=value,argv1,argv1` as non-shell command.
> > 2. Or we should make user specifying `value` and `argv` explicitly, by 
> > making them as flags.
> > 
> > We should find out which is better.

I think that option 1 is better as it does not introduce new parameter and also 
easy to be extended to support both shell and no shell command


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review122305
---


On 三月 7, 2016, 8:05 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated 三月 7, 2016, 8:05 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos 
> --docker_image=busybox:latest --containerizer=mesos --no-shell  
> --command="ls,/etc/passwd" 
> I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
> I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at 
> master@192.168.56.12:5050
> I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. 
> Attempting to register without authentication
> I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with 
> a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
> I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 
> 'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-03-07 Thread Gilbert Song


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review122305
---



Hi Guangya, Thanks for taking this on. My main consideration about this patch 
is making distinction between shell command v.s. non-shell command. We have two 
choices:

1. Following your current implementation, the description of the `command` flag 
should be updated, because people may not know they should use 
`--command=value,argv1,argv1` as non-shell command.
2. Or we should make user specifying `value` and `argv` explicitly, by making 
them as flags.

We should find out which is better.

- Gilbert Song


On March 7, 2016, 12:05 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated March 7, 2016, 12:05 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos 
> --docker_image=busybox:latest --containerizer=mesos --no-shell  
> --command="ls,/etc/passwd" 
> I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
> I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at 
> master@192.168.56.12:5050
> I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. 
> Attempting to register without authentication
> I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with 
> a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
> I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 
> 'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-03-07 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/#review122273
---



Patch looks great!

Reviews applied: [1]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 7, 2016, 8:05 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1/
> ---
> 
> (Updated March 7, 2016, 8:05 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4882
> https://issues.apache.org/jira/browse/MESOS-4882
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Treated command as executable value and arguments in mesos-execute.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 
> 
> Diff: https://reviews.apache.org/r/1/diff/
> 
> 
> Testing
> ---
> 
> ./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos 
> --docker_image=busybox:latest --containerizer=mesos --no-shell  
> --command="ls,/etc/passwd" 
> I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
> I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at 
> master@192.168.56.12:5050
> I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. 
> Attempting to register without authentication
> I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with 
> a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
> task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
> Received status update TASK_RUNNING for task test_mesos
> Received status update TASK_FINISHED for task test_mesos
> I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
> I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 
> 'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-03-07 Thread Guangya Liu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1/
---

Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-4882
https://issues.apache.org/jira/browse/MESOS-4882


Repository: mesos


Description
---

Treated command as executable value and arguments in mesos-execute.


Diffs
-

  src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e 

Diff: https://reviews.apache.org/r/1/diff/


Testing
---

./src/mesos-execute --master=192.168.56.12:5050  --name=test_mesos 
--docker_image=busybox:latest --containerizer=mesos --no-shell  
--command="ls,/etc/passwd" 
I0307 15:48:09.834506 27450 sched.cpp:222] Version: 0.29.0
I0307 15:48:09.841404 27468 sched.cpp:326] New master detected at 
master@192.168.56.12:5050
I0307 15:48:09.843992 27468 sched.cpp:336] No credentials provided. Attempting 
to register without authentication
I0307 15:48:09.848901 27468 sched.cpp:703] Framework registered with 
a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
Framework registered with a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001
task test_mesos submitted to slave 6fa2afa1-768b-4f2e-9c69-9f1017634e72-S2
Received status update TASK_RUNNING for task test_mesos
Received status update TASK_FINISHED for task test_mesos
I0307 15:48:10.284418 27466 sched.cpp:1903] Asked to stop the driver
I0307 15:48:10.284494 27466 sched.cpp:1143] Stopping framework 
'a767db64-1bc8-4d7a-9eb5-90ee1f4ab8cf-0001'


Thanks,

Guangya Liu

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

Review Request 44441: Treated command as executable value and arguments in mesos-execute.

34 matches

Site Navigation

Mail list logo

Footer information