Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44975/#review125792
---


Ship it!




Thanks! Kevin and I made some minor style adjustments and will get this 
committed shortly.

- Ben Mahler


On March 21, 2016, 6:14 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44975/
> ---
> 
> (Updated March 21, 2016, 6:14 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Felix Abecassis, Kevin Klues, and 
> Niklas Nielsen.
> 
> 
> Bugs: MESOS-3368
> https://issues.apache.org/jira/browse/MESOS-3368
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added cgroups test cases for cgroups device support: DevicesTest.Parse
> and CgroupsAnyHierarchyDevicesTest.ROOT_CGROUPS_Devices
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_tests.cpp 
> acaed9b3f8a04964092cef413133834d0cf5a145 
> 
> Diff: https://reviews.apache.org/r/44975/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44975/#review124518
---



Patch looks great!

Reviews applied: [44974, 44975]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 21, 2016, 6:14 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44975/
> ---
> 
> (Updated March 21, 2016, 6:14 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Felix Abecassis, Kevin Klues, and 
> Niklas Nielsen.
> 
> 
> Bugs: MESOS-3368
> https://issues.apache.org/jira/browse/MESOS-3368
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added cgroups test cases for cgroups device support: DevicesTest.Parse
> and CgroupsAnyHierarchyDevicesTest.ROOT_CGROUPS_Devices
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_tests.cpp 
> acaed9b3f8a04964092cef413133834d0cf5a145 
> 
> Diff: https://reviews.apache.org/r/44975/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44975/
---

(Updated March 21, 2016, 6:14 a.m.)


Review request for mesos, Ben Mahler, Felix Abecassis, Kevin Klues, and Niklas 
Nielsen.


Bugs: MESOS-3368
https://issues.apache.org/jira/browse/MESOS-3368


Repository: mesos


Description (updated)
---

Added cgroups test cases for cgroups device support: DevicesTest.Parse
and CgroupsAnyHierarchyDevicesTest.ROOT_CGROUPS_Devices


Diffs (updated)
-

  src/tests/containerizer/cgroups_tests.cpp 
acaed9b3f8a04964092cef413133834d0cf5a145 

Diff: https://reviews.apache.org/r/44975/diff/


Testing
---

make check


Thanks,

Abhishek Dasgupta

Review Request 44975: Updated cgroups test cases for cgroups device support.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44975/
---

Review request for mesos, Ben Mahler, Felix Abecassis, Kevin Klues, and Niklas 
Nielsen.


Bugs: MESOS-3368
https://issues.apache.org/jira/browse/MESOS-3368


Repository: mesos


Description
---

Updated cgroups test cases for cgroups device support.


Diffs
-

  src/tests/containerizer/cgroups_tests.cpp 
acaed9b3f8a04964092cef413133834d0cf5a145 

Diff: https://reviews.apache.org/r/44975/diff/


Testing
---

make check


Thanks,

Abhishek Dasgupta

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44975/#review124104
---




src/tests/containerizer/cgroups_tests.cpp (lines 1347 - 1349)


This comment doesn't make clear the real reason this is necessary.

The reason is that without first clearing out the `"a *:* rwm"`, no matter 
how many devices you write to `devices.deny`, they will never show up in 
`devices.list` (because it's a whitelist).  The cgroups driver for this is very 
simple and will only add/remove the **exact** entries you write to the 
respective `devices.allow` and `devices.deny` file.  So tpo get **any** devices 
to ever show up in `devices.list`, you first have to clear out the `"a *:* 
rwm"` entry and then start allowing/denying devices explicitly.



src/tests/containerizer/cgroups_tests.cpp (lines 1350 - 1353)


I probably wouldn't embed the `deny()` call inside the `CHECK_SOME()` call. 
 I'd break them out into two separate calls as the rest of the cod ein this 
file does.



src/tests/containerizer/cgroups_tests.cpp (line 1356)


You shouldn't need the `std::` here.



src/tests/containerizer/cgroups_tests.cpp (lines 1357 - 1358)


Why the newline here?



src/tests/containerizer/cgroups_tests.cpp (lines 1360 - 1368)


This pattern doesn't look very mesos-like to me. I'll defer to @bmahler or 
@nnielson for suggestions here.


- Kevin Klues


On March 17, 2016, 7:35 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44975/
> ---
> 
> (Updated March 17, 2016, 7:35 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Felix Abecassis, Kevin Klues, and 
> Niklas Nielsen.
> 
> 
> Bugs: MESOS-3368
> https://issues.apache.org/jira/browse/MESOS-3368
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated cgroups test cases for cgroups device support.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_tests.cpp 
> acaed9b3f8a04964092cef413133834d0cf5a145 
> 
> Diff: https://reviews.apache.org/r/44975/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44975/#review124110
---



Patch looks great!

Reviews applied: [44974, 44975]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 17, 2016, 7:35 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44975/
> ---
> 
> (Updated March 17, 2016, 7:35 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Felix Abecassis, Kevin Klues, and 
> Niklas Nielsen.
> 
> 
> Bugs: MESOS-3368
> https://issues.apache.org/jira/browse/MESOS-3368
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated cgroups test cases for cgroups device support.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_tests.cpp 
> acaed9b3f8a04964092cef413133834d0cf5a145 
> 
> Diff: https://reviews.apache.org/r/44975/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44975/#review124417
---



Patch looks great!

Reviews applied: [44974, 44975]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 18, 2016, 9:35 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44975/
> ---
> 
> (Updated March 18, 2016, 9:35 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Felix Abecassis, Kevin Klues, and 
> Niklas Nielsen.
> 
> 
> Bugs: MESOS-3368
> https://issues.apache.org/jira/browse/MESOS-3368
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated cgroups test cases to include two test cases 
> CgroupsAnyHierarchyDevicesTest.ParseTest and 
> CgroupsAnyHierarchyDevicesTest.ROOT_CGROUPS_Devices in order to test device 
> support in cgroup.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_tests.cpp 
> acaed9b3f8a04964092cef413133834d0cf5a145 
> 
> Diff: https://reviews.apache.org/r/44975/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44975/
---

(Updated March 18, 2016, 9:35 a.m.)


Review request for mesos, Ben Mahler, Felix Abecassis, Kevin Klues, and Niklas 
Nielsen.


Changes
---

Addressed feedbacks on revision 1


Bugs: MESOS-3368
https://issues.apache.org/jira/browse/MESOS-3368


Repository: mesos


Description (updated)
---

Updated cgroups test cases to include two test cases 
CgroupsAnyHierarchyDevicesTest.ParseTest and 
CgroupsAnyHierarchyDevicesTest.ROOT_CGROUPS_Devices in order to test device 
support in cgroup.


Diffs (updated)
-

  src/tests/containerizer/cgroups_tests.cpp 
acaed9b3f8a04964092cef413133834d0cf5a145 

Diff: https://reviews.apache.org/r/44975/diff/


Testing
---

make check


Thanks,

Abhishek Dasgupta

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44975/#review124375
---



I ran the review by Ben again and sat with him to rework it to his 
satisfaction. The commit can be found on this branch:
https://github.com/klueska-mesosphere/mesos/commits/r/a10gupta/cgroups-devices

If you just apply the patch as is, Ben says he will get it committed early next 
week.

- Kevin Klues


On March 18, 2016, 9:35 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44975/
> ---
> 
> (Updated March 18, 2016, 9:35 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Felix Abecassis, Kevin Klues, and 
> Niklas Nielsen.
> 
> 
> Bugs: MESOS-3368
> https://issues.apache.org/jira/browse/MESOS-3368
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated cgroups test cases to include two test cases 
> CgroupsAnyHierarchyDevicesTest.ParseTest and 
> CgroupsAnyHierarchyDevicesTest.ROOT_CGROUPS_Devices in order to test device 
> support in cgroup.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cgroups_tests.cpp 
> acaed9b3f8a04964092cef413133834d0cf5a145 
> 
> Diff: https://reviews.apache.org/r/44975/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>