Re: Review Request 49402: Added tests for IP based certificate validation.

2016-07-04 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49402/
---

(Updated July 4, 2016, 4:30 p.m.)


Review request for mesos, Adam B, Albert Strasheim, Artem Harutyunyan, Joris 
Van Remoortere, and Lukas Loesche.


Changes
---

Fixed omission from manual rebase.


Bugs: MESOS-5724
https://issues.apache.org/jira/browse/MESOS-5724


Repository: mesos


Description
---

see summary.


Diffs (updated)
-

  3rdparty/libprocess/include/process/ssl/gtest.hpp 
5435ddda1fd7dfcff1a0b28f2abe35feb707ceeb 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
6fc90380fcc1d6c645d639edddba4b641f0fd624 

Diff: https://reviews.apache.org/r/49402/diff/


Testing
---

make check on OSX and various linux distros.


Thanks,

Till Toenshoff

Re: Review Request 49402: Added tests for IP based certificate validation.

2016-06-30 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49402/
---

(Updated July 1, 2016, 12:51 a.m.)


Review request for mesos, Adam B, Albert Strasheim, Artem Harutyunyan, Joris 
Van Remoortere, and Lukas Loesche.


Changes
---

Replaced copy tests by parameterized versions of the originals.


Bugs: MESOS-5724
https://issues.apache.org/jira/browse/MESOS-5724


Repository: mesos


Description
---

see summary.


Diffs (updated)
-

  3rdparty/libprocess/include/process/ssl/gtest.hpp 
5435ddda1fd7dfcff1a0b28f2abe35feb707ceeb 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
cf0119d1266cb81aa5fc7a86e034ba302892d44f 

Diff: https://reviews.apache.org/r/49402/diff/


Testing
---

make check on OSX and various linux distros.


Thanks,

Till Toenshoff

Re: Review Request 49402: Added tests for IP based certificate validation.

2016-06-30 Thread Till Toenshoff 


> On June 30, 2016, 4:03 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/src/tests/ssl_tests.cpp, lines 781-783
> > 
> >
> > Let's parameterize the existing tests these are copied from since the 
> > logical behavior doesn't change.

Great idea - should have had it myself when feeling icky about a complete 
copy - thanks!


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49402/#review140177
---


On June 30, 2016, 12:19 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49402/
> ---
> 
> (Updated June 30, 2016, 12:19 a.m.)
> 
> 
> Review request for mesos, Adam B, Albert Strasheim, Artem Harutyunyan, Joris 
> Van Remoortere, and Lukas Loesche.
> 
> 
> Bugs: MESOS-5724
> https://issues.apache.org/jira/browse/MESOS-5724
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> cf0119d1266cb81aa5fc7a86e034ba302892d44f 
> 
> Diff: https://reviews.apache.org/r/49402/diff/
> 
> 
> Testing
> ---
> 
> make check on OSX and various linux distros.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 49402: Added tests for IP based certificate validation.

2016-06-30 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49402/#review140177
---


Fix it, then Ship it!





3rdparty/libprocess/src/tests/ssl_tests.cpp (lines 781 - 783)


Let's parameterize the existing tests these are copied from since the 
logical behavior doesn't change.


- Joris Van Remoortere


On June 30, 2016, 12:19 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49402/
> ---
> 
> (Updated June 30, 2016, 12:19 a.m.)
> 
> 
> Review request for mesos, Adam B, Albert Strasheim, Artem Harutyunyan, Joris 
> Van Remoortere, and Lukas Loesche.
> 
> 
> Bugs: MESOS-5724
> https://issues.apache.org/jira/browse/MESOS-5724
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> cf0119d1266cb81aa5fc7a86e034ba302892d44f 
> 
> Diff: https://reviews.apache.org/r/49402/diff/
> 
> 
> Testing
> ---
> 
> make check on OSX and various linux distros.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Review Request 49402: Added tests for IP based certificate validation.

2016-06-29 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49402/
---

Review request for mesos, Adam B, Albert Strasheim, Artem Harutyunyan, Joris 
Van Remoortere, and Lukas Loesche.


Bugs: MESOS-5724
https://issues.apache.org/jira/browse/MESOS-5724


Repository: mesos


Description
---

see summary.


Diffs
-

  3rdparty/libprocess/src/tests/ssl_tests.cpp 
cf0119d1266cb81aa5fc7a86e034ba302892d44f 

Diff: https://reviews.apache.org/r/49402/diff/


Testing
---

make check on OSX and various linux distros.


Thanks,

Till Toenshoff