Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

2016-12-05 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54352/
---

(Updated Dec. 5, 2016, 10:05 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Fixed syntax error in last patch.


Bugs: MESOS-6689
https://issues.apache.org/jira/browse/MESOS-6689


Repository: mesos


Description
---

Added removal of unix domain socket path in IOSwitchboard::cleanup.


Diffs (updated)
-

  src/slave/containerizer/mesos/io/switchboard.cpp 
e340a56219b6ee913c015793c02e9798fda5584e 

Diff: https://reviews.apache.org/r/54352/diff/


Testing
---

GTEST_FILTER="" make -j check
sudo src/mesos-tests


Thanks,

Kevin Klues

Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

2016-12-05 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54352/
---

(Updated Dec. 5, 2016, 9:40 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Updated based on Jie's comments.


Bugs: MESOS-6689
https://issues.apache.org/jira/browse/MESOS-6689


Repository: mesos


Description
---

Added removal of unix domain socket path in IOSwitchboard::cleanup.


Diffs (updated)
-

  src/slave/containerizer/mesos/io/switchboard.cpp 
4258e861357225d7f9613b66f66121e28961dbf1 

Diff: https://reviews.apache.org/r/54352/diff/


Testing
---

GTEST_FILTER="" make -j check
sudo src/mesos-tests


Thanks,

Kevin Klues

Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

2016-12-05 Thread Kevin Klues 


> On Dec. 5, 2016, 6:39 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/io/switchboard.cpp, line 539
> > 
> >
> > We should not capture 'this' without a defer. Either use a 'defer' 
> > here, or capture `flags.runtime_dir`.

Duh. That was a stupid mistake.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54352/#review158033
---


On Dec. 5, 2016, 7:10 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54352/
> ---
> 
> (Updated Dec. 5, 2016, 7:10 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6689
> https://issues.apache.org/jira/browse/MESOS-6689
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added removal of unix domain socket path in IOSwitchboard::cleanup.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 
> d5211b98616e72a27ca6b472a5ee83505c227f22 
> 
> Diff: https://reviews.apache.org/r/54352/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="" make -j check
> sudo src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

2016-12-05 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54352/#review158033
---


Fix it, then Ship it!





src/slave/containerizer/mesos/io/switchboard.cpp (line 539)


We should not capture 'this' without a defer. Either use a 'defer' here, or 
capture `flags.runtime_dir`.


- Jie Yu


On Dec. 5, 2016, 7:10 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54352/
> ---
> 
> (Updated Dec. 5, 2016, 7:10 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6689
> https://issues.apache.org/jira/browse/MESOS-6689
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added removal of unix domain socket path in IOSwitchboard::cleanup.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 
> d5211b98616e72a27ca6b472a5ee83505c227f22 
> 
> Diff: https://reviews.apache.org/r/54352/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="" make -j check
> sudo src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

2016-12-04 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54352/
---

(Updated Dec. 5, 2016, 7:10 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased on master.


Bugs: MESOS-6689
https://issues.apache.org/jira/browse/MESOS-6689


Repository: mesos


Description
---

Added removal of unix domain socket path in IOSwitchboard::cleanup.


Diffs (updated)
-

  src/slave/containerizer/mesos/io/switchboard.cpp 
d5211b98616e72a27ca6b472a5ee83505c227f22 

Diff: https://reviews.apache.org/r/54352/diff/


Testing
---

GTEST_FILTER="" make -j check
sudo src/mesos-tests


Thanks,

Kevin Klues

Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

2016-12-04 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54352/#review157961
---




src/slave/containerizer/mesos/io/switchboard.cpp (lines 407 - 417)


I would probably wait until the io switchboard process has been terminated. 
Otherwise, rm here might get EBUSY?

In other words, move this logic to `status.then`



src/slave/containerizer/mesos/io/switchboard.cpp (line 416)


I would still LOG(ERROR) if rm fails.


- Jie Yu


On Dec. 5, 2016, 12:39 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54352/
> ---
> 
> (Updated Dec. 5, 2016, 12:39 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-6689
> https://issues.apache.org/jira/browse/MESOS-6689
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added removal of unix domain socket path in IOSwitchboard::cleanup.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 
> 778367a268ec350ed438bc9fe9d359d63bdb5503 
> 
> Diff: https://reviews.apache.org/r/54352/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="" make -j check
> sudo src/mesos-tests
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

2016-12-04 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54352/
---

(Updated Dec. 5, 2016, 12:39 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-6689
https://issues.apache.org/jira/browse/MESOS-6689


Repository: mesos


Description
---

Added removal of unix domain socket path in IOSwitchboard::cleanup.


Diffs
-

  src/slave/containerizer/mesos/io/switchboard.cpp 
778367a268ec350ed438bc9fe9d359d63bdb5503 

Diff: https://reviews.apache.org/r/54352/diff/


Testing
---

GTEST_FILTER="" make -j check
sudo src/mesos-tests


Thanks,

Kevin Klues

Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

2016-12-04 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54352/
---

Review request for mesos and Jie Yu.


Bugs: 6689
https://issues.apache.org/jira/browse/6689


Repository: mesos


Description
---

Added removal of unix domain socket path in IOSwitchboard::cleanup.


Diffs
-

  src/slave/containerizer/mesos/io/switchboard.cpp 
778367a268ec350ed438bc9fe9d359d63bdb5503 

Diff: https://reviews.apache.org/r/54352/diff/


Testing
---

GTEST_FILTER="" make -j check
sudo src/mesos-tests


Thanks,

Kevin Klues