Re: Review Request 58013: WIN32: Add compile/link flags to improve incremental link times.
> On March 29, 2017, 6:53 p.m., Joseph Wu wrote: > > After double-checking what these flags actually do, I'm going to > > add some more information to the commit description: > > ``` > > The `/Zc:inline` flag tells the compiler to generate object files > > but exclude symbols that are either unreferenced or have internal > > linkage only. This leads to smaller object files and faster linking. > > See: https://msdn.microsoft.com/en-us/library/dn642448.aspx > > > > The `/debug:FASTLINK` flag changes how the linker generates > > program database files (PDB). Instead of making a full copy of any > > related debug information used by the library, this option instead > > creates indexes to other PDBs, thereby cutting down on link-time > > code generation. This only affects DEBUG builds. > > See: https://msdn.microsoft.com/en-us/library/xe4t6fc1.aspx > > ``` > > Andrew Schwartzmeyer wrote: > Yes please :) Nit pick on title: I've been following the seeming convention of `Windows: ` prefix instead of `WIN32: `. Joe, can you fix this when you commit? - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58013/#review170443 --- On March 29, 2017, 12:55 a.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58013/ > --- > > (Updated March 29, 2017, 12:55 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-7226 > https://issues.apache.org/jira/browse/MESOS-7226 > > > Repository: mesos > > > Description > --- > > When working on precompiled headers, we recognized that adding > some compile/link flags resulted in a 20% reduction in incremental > linkage time. This is NOT directly dependent on precompiled headers > (the improvement comes regardless of PCH). > > > Diffs > - > > cmake/CompilationConfigure.cmake 5936be07557395ad08b06aa376b5a29f9b11c143 > > > Diff: https://reviews.apache.org/r/58013/diff/1/ > > > Testing > --- > > Testing done at end of chain > > > Thanks, > > Jeff Coffler > >
Re: Review Request 58013: WIN32: Add compile/link flags to improve incremental link times.
> On March 29, 2017, 6:53 p.m., Joseph Wu wrote: > > After double-checking what these flags actually do, I'm going to > > add some more information to the commit description: > > ``` > > The `/Zc:inline` flag tells the compiler to generate object files > > but exclude symbols that are either unreferenced or have internal > > linkage only. This leads to smaller object files and faster linking. > > See: https://msdn.microsoft.com/en-us/library/dn642448.aspx > > > > The `/debug:FASTLINK` flag changes how the linker generates > > program database files (PDB). Instead of making a full copy of any > > related debug information used by the library, this option instead > > creates indexes to other PDBs, thereby cutting down on link-time > > code generation. This only affects DEBUG builds. > > See: https://msdn.microsoft.com/en-us/library/xe4t6fc1.aspx > > ``` Yes please :) - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58013/#review170443 --- On March 29, 2017, 12:55 a.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58013/ > --- > > (Updated March 29, 2017, 12:55 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-7226 > https://issues.apache.org/jira/browse/MESOS-7226 > > > Repository: mesos > > > Description > --- > > When working on precompiled headers, we recognized that adding > some compile/link flags resulted in a 20% reduction in incremental > linkage time. This is NOT directly dependent on precompiled headers > (the improvement comes regardless of PCH). > > > Diffs > - > > cmake/CompilationConfigure.cmake 5936be07557395ad08b06aa376b5a29f9b11c143 > > > Diff: https://reviews.apache.org/r/58013/diff/1/ > > > Testing > --- > > Testing done at end of chain > > > Thanks, > > Jeff Coffler > >
Re: Review Request 58013: WIN32: Add compile/link flags to improve incremental link times.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58013/#review170443 --- Ship it! After double-checking what these flags actually do, I'm going to add some more information to the commit description: ``` The `/Zc:inline` flag tells the compiler to generate object files but exclude symbols that are either unreferenced or have internal linkage only. This leads to smaller object files and faster linking. See: https://msdn.microsoft.com/en-us/library/dn642448.aspx The `/debug:FASTLINK` flag changes how the linker generates program database files (PDB). Instead of making a full copy of any related debug information used by the library, this option instead creates indexes to other PDBs, thereby cutting down on link-time code generation. This only affects DEBUG builds. See: https://msdn.microsoft.com/en-us/library/xe4t6fc1.aspx ``` - Joseph Wu On March 28, 2017, 5:55 p.m., Jeff Coffler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58013/ > --- > > (Updated March 28, 2017, 5:55 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-7226 > https://issues.apache.org/jira/browse/MESOS-7226 > > > Repository: mesos > > > Description > --- > > When working on precompiled headers, we recognized that adding > some compile/link flags resulted in a 20% reduction in incremental > linkage time. This is NOT directly dependent on precompiled headers > (the improvement comes regardless of PCH). > > > Diffs > - > > cmake/CompilationConfigure.cmake 5936be07557395ad08b06aa376b5a29f9b11c143 > > > Diff: https://reviews.apache.org/r/58013/diff/1/ > > > Testing > --- > > Testing done at end of chain > > > Thanks, > > Jeff Coffler > >
Review Request 58013: WIN32: Add compile/link flags to improve incremental link times.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58013/ --- Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li Li. Bugs: MESOS-7226 https://issues.apache.org/jira/browse/MESOS-7226 Repository: mesos Description --- When working on precompiled headers, we recognized that adding some compile/link flags resulted in a 20% reduction in incremental linkage time. This is NOT directly dependent on precompiled headers (the improvement comes regardless of PCH). Diffs - cmake/CompilationConfigure.cmake 5936be07557395ad08b06aa376b5a29f9b11c143 Diff: https://reviews.apache.org/r/58013/diff/1/ Testing --- Testing done at end of chain Thanks, Jeff Coffler
