Review Request 58725: Fetching docker image manifests with 'Accept' header.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/
---

Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-7427
https://issues.apache.org/jira/browse/MESOS-7427


Repository: mesos


Description
---

Added 'Accept: application/vnd.docker.distribution.manifest.v1+json'
to the headers of HTTP requests for fetching manifests from any Docker
registry. Some registry services (e.g., Amazon ECR) check the 'Accept'
field strictly and reject the requests if it is not specified.


Diffs
-

  src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 


Diff: https://reviews.apache.org/r/58725/diff/1/


Testing
---

sudo make check
Manually tested on a local docker private registry and an Amazon ECR repository.


Thanks,

Chun-Hung Hsiao

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/#review173063
---




src/uri/fetchers/docker.cpp
Lines 474 (patched)


Please fix the indentation.



src/uri/fetchers/docker.cpp
Lines 476 (patched)


Could you paste the link to the docker doc for `Accept` header.


- Gilbert Song


On April 25, 2017, 5:30 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58725/
> ---
> 
> (Updated April 25, 2017, 5:30 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7427
> https://issues.apache.org/jira/browse/MESOS-7427
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'Accept: application/vnd.docker.distribution.manifest.v1+json'
> to the headers of HTTP requests for fetching manifests from any Docker
> registry. Some registry services (e.g., Amazon ECR) check the 'Accept'
> field strictly and reject the requests if it is not specified.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 
> 
> 
> Diff: https://reviews.apache.org/r/58725/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> Manually tested on a local docker private registry and an Amazon ECR 
> repository.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/
---

(Updated April 26, 2017, 6:20 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Addressed Gilbert's comments.


Bugs: MESOS-7427
https://issues.apache.org/jira/browse/MESOS-7427


Repository: mesos


Description
---

Added 'Accept: application/vnd.docker.distribution.manifest.v1+json'
to the headers of HTTP requests for fetching manifests from any Docker
registry. Some registry services (e.g., Amazon ECR) check the 'Accept'
field strictly and reject the requests if it is not specified.


Diffs (updated)
-

  src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 


Diff: https://reviews.apache.org/r/58725/diff/2/

Changes: https://reviews.apache.org/r/58725/diff/1-2/


Testing
---

sudo make check
Manually tested on a local docker private registry and an Amazon ECR repository.


Thanks,

Chun-Hung Hsiao

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/#review173083
---


Fix it, then Ship it!




Have you tested with all registries that we support?


src/uri/fetchers/docker.cpp
Lines 472 (patched)


one line above.



src/uri/fetchers/docker.cpp
Lines 504-505 (patched)


I'd introduce:
```
class Headers {
public:
  http::Headers operator+(const http::Headers& that) const;
}
```

so that you can do:
```
curl(manifestUri, authHeaders + manifestHeaders)
```


- Jie Yu


On April 26, 2017, 6:20 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58725/
> ---
> 
> (Updated April 26, 2017, 6:20 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7427
> https://issues.apache.org/jira/browse/MESOS-7427
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'Accept: application/vnd.docker.distribution.manifest.v1+json'
> to the headers of HTTP requests for fetching manifests from any Docker
> registry. Some registry services (e.g., Amazon ECR) check the 'Accept'
> field strictly and reject the requests if it is not specified.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 
> 
> 
> Diff: https://reviews.apache.org/r/58725/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> Manually tested on a local docker private registry and an Amazon ECR 
> repository.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

[Chun-Hung Hsiao]

> On April 26, 2017, 7:28 p.m., Jie Yu wrote:
> > Have you tested with all registries that we support?

I've run the unit tests, which should cover all supported public registries.
Also manually tested on a local private registry and Amazen ECR.


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/#review173083
---


On April 26, 2017, 6:20 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58725/
> ---
> 
> (Updated April 26, 2017, 6:20 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7427
> https://issues.apache.org/jira/browse/MESOS-7427
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'Accept: application/vnd.docker.distribution.manifest.v1+json'
> to the headers of HTTP requests for fetching manifests from any Docker
> registry. Some registry services (e.g., Amazon ECR) check the 'Accept'
> field strictly and reject the requests if it is not specified.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 
> 
> 
> Diff: https://reviews.apache.org/r/58725/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> Manually tested on a local docker private registry and an Amazon ECR 
> repository.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/
---

(Updated April 26, 2017, 10:27 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Addressed Jie's comments.


Bugs: MESOS-7427
https://issues.apache.org/jira/browse/MESOS-7427


Repository: mesos


Description
---

Added 'Accept: application/vnd.docker.distribution.manifest.v1+json'
to the headers of HTTP requests for fetching manifests from any Docker
registry. Some registry services (e.g., Amazon ECR) check the 'Accept'
field strictly and reject the requests if it is not specified.


Diffs (updated)
-

  src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 


Diff: https://reviews.apache.org/r/58725/diff/3/

Changes: https://reviews.apache.org/r/58725/diff/2-3/


Testing
---

sudo make check
Manually tested on a local docker private registry and an Amazon ECR repository.


Thanks,

Chun-Hung Hsiao

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

[Chun-Hung Hsiao]

> On April 26, 2017, 7:28 p.m., Jie Yu wrote:
> > src/uri/fetchers/docker.cpp
> > Lines 504-505 (patched)
> > 
> >
> > I'd introduce:
> > ```
> > class Headers {
> > public:
> >   http::Headers operator+(const http::Headers& that) const;
> > }
> > ```
> > 
> > so that you can do:
> > ```
> > curl(manifestUri, authHeaders + manifestHeaders)
> > ```

Fixed in https://reviews.apache.org/r/58753/.


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/#review173083
---


On April 26, 2017, 10:27 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58725/
> ---
> 
> (Updated April 26, 2017, 10:27 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7427
> https://issues.apache.org/jira/browse/MESOS-7427
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'Accept: application/vnd.docker.distribution.manifest.v1+json'
> to the headers of HTTP requests for fetching manifests from any Docker
> registry. Some registry services (e.g., Amazon ECR) check the 'Accept'
> field strictly and reject the requests if it is not specified.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 
> 
> 
> Diff: https://reviews.apache.org/r/58725/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> Manually tested on a local docker private registry and an Amazon ECR 
> repository.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/#review173122
---


Ship it!




Ship It!

- Gilbert Song


On April 26, 2017, 3:27 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58725/
> ---
> 
> (Updated April 26, 2017, 3:27 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7427
> https://issues.apache.org/jira/browse/MESOS-7427
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'Accept: application/vnd.docker.distribution.manifest.v1+json'
> to the headers of HTTP requests for fetching manifests from any Docker
> registry. Some registry services (e.g., Amazon ECR) check the 'Accept'
> field strictly and reject the requests if it is not specified.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 
> 
> 
> Diff: https://reviews.apache.org/r/58725/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> Manually tested on a local docker private registry and an Amazon ECR 
> repository.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/#review173140
---



Do you know if an old registry (< 2.3) will be OK with this header that it does 
not understand? Can you confirm?

- Jie Yu


On April 26, 2017, 10:27 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58725/
> ---
> 
> (Updated April 26, 2017, 10:27 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7427
> https://issues.apache.org/jira/browse/MESOS-7427
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'Accept: application/vnd.docker.distribution.manifest.v1+json'
> to the headers of HTTP requests for fetching manifests from any Docker
> registry. Some registry services (e.g., Amazon ECR) check the 'Accept'
> field strictly and reject the requests if it is not specified.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 
> 
> 
> Diff: https://reviews.apache.org/r/58725/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> Manually tested on a local docker private registry and an Amazon ECR 
> repository.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

[Ilya Pronin]

> On April 27, 2017, 1:46 a.m., Jie Yu wrote:
> > Do you know if an old registry (< 2.3) will be OK with this header that it 
> > does not understand? Can you confirm?

Shall we include all content types that we currently support? (Can be splitted 
into multiple `Accept` fields)
```
Accept: application/vnd.docker.distribution.manifest.v1+json,
application/vnd.docker.distribution.manifest.v1+prettyjws,
application/json
```


- Ilya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/#review173140
---


On April 26, 2017, 11:27 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58725/
> ---
> 
> (Updated April 26, 2017, 11:27 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7427
> https://issues.apache.org/jira/browse/MESOS-7427
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'Accept: application/vnd.docker.distribution.manifest.v1+json'
> to the headers of HTTP requests for fetching manifests from any Docker
> registry. Some registry services (e.g., Amazon ECR) check the 'Accept'
> field strictly and reject the requests if it is not specified.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 
> 
> 
> Diff: https://reviews.apache.org/r/58725/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> Manually tested on a local docker private registry and an Amazon ECR 
> repository.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

[Chun-Hung Hsiao]

> On April 27, 2017, 12:46 a.m., Jie Yu wrote:
> > Do you know if an old registry (< 2.3) will be OK with this header that it 
> > does not understand? Can you confirm?
> 
> Ilya Pronin wrote:
> Shall we include all content types that we currently support? (Can be 
> splitted into multiple `Accept` fields)
> ```
> Accept: application/vnd.docker.distribution.manifest.v1+json,
> application/vnd.docker.distribution.manifest.v1+prettyjws,
> application/json
> ```

I tried but Amazon ECR would reject the header because it's check uses the 
following regex: `\w{1,127}\/[-+.\w]{1,127}]`, so only one MIME type is allowed 
for ECR.


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/#review173140
---


On April 26, 2017, 10:27 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58725/
> ---
> 
> (Updated April 26, 2017, 10:27 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7427
> https://issues.apache.org/jira/browse/MESOS-7427
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'Accept: application/vnd.docker.distribution.manifest.v1+json'
> to the headers of HTTP requests for fetching manifests from any Docker
> registry. Some registry services (e.g., Amazon ECR) check the 'Accept'
> field strictly and reject the requests if it is not specified.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 
> 
> 
> Diff: https://reviews.apache.org/r/58725/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> Manually tested on a local docker private registry and an Amazon ECR 
> repository.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/
---

(Updated May 1, 2017, 5:24 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

More manual tests


Bugs: MESOS-7427
https://issues.apache.org/jira/browse/MESOS-7427


Repository: mesos


Description
---

Added 'Accept: application/vnd.docker.distribution.manifest.v1+json'
to the headers of HTTP requests for fetching manifests from any Docker
registry. Some registry services (e.g., Amazon ECR) check the 'Accept'
field strictly and reject the requests if it is not specified.


Diffs
-

  src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 


Diff: https://reviews.apache.org/r/58725/diff/3/


Testing (updated)
---

sudo make check
Manually tested on the following registries:
1. Local docker private registries with the following version:
   2.0.1, 2.1.1, 2.2.1, 2.3.1, 2.4.1, 2.5.1, 2.6.1
2. Amazon ECR repository


Thanks,

Chun-Hung Hsiao

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

[Chun-Hung Hsiao]

> On April 27, 2017, 12:46 a.m., Jie Yu wrote:
> > Do you know if an old registry (< 2.3) will be OK with this header that it 
> > does not understand? Can you confirm?
> 
> Ilya Pronin wrote:
> Shall we include all content types that we currently support? (Can be 
> splitted into multiple `Accept` fields)
> ```
> Accept: application/vnd.docker.distribution.manifest.v1+json,
> application/vnd.docker.distribution.manifest.v1+prettyjws,
> application/json
> ```
> 
> Chun-Hung Hsiao wrote:
> I tried but Amazon ECR would reject the header because it's check uses 
> the following regex: `\w{1,127}\/[-+.\w]{1,127}]`, so only one MIME type is 
> allowed for ECR.

Also, setting `Accept` to just `application/json` would make ECR to return a 
Schema 2 manifest instead of a Schema 1 one.


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/#review173140
---


On May 1, 2017, 5:24 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58725/
> ---
> 
> (Updated May 1, 2017, 5:24 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7427
> https://issues.apache.org/jira/browse/MESOS-7427
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'Accept: application/vnd.docker.distribution.manifest.v1+json'
> to the headers of HTTP requests for fetching manifests from any Docker
> registry. Some registry services (e.g., Amazon ECR) check the 'Accept'
> field strictly and reject the requests if it is not specified.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 
> 
> 
> Diff: https://reviews.apache.org/r/58725/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> Manually tested on the following registries:
> 1. Local docker private registries with the following version:
>2.0.1, 2.1.1, 2.2.1, 2.3.1, 2.4.1, 2.5.1, 2.6.1
> 2. Amazon ECR repository
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

[Chun-Hung Hsiao]

> On April 27, 2017, 12:46 a.m., Jie Yu wrote:
> > Do you know if an old registry (< 2.3) will be OK with this header that it 
> > does not understand? Can you confirm?
> 
> Ilya Pronin wrote:
> Shall we include all content types that we currently support? (Can be 
> splitted into multiple `Accept` fields)
> ```
> Accept: application/vnd.docker.distribution.manifest.v1+json,
> application/vnd.docker.distribution.manifest.v1+prettyjws,
> application/json
> ```
> 
> Chun-Hung Hsiao wrote:
> I tried but Amazon ECR would reject the header because it's check uses 
> the following regex: `\w{1,127}\/[-+.\w]{1,127}]`, so only one MIME type is 
> allowed for ECR.
> 
> Chun-Hung Hsiao wrote:
> Also, setting `Accept` to just `application/json` would make ECR to 
> return a Schema 2 manifest instead of a Schema 1 one.

For ECR, if there is a signed manifest, requesting 
`application/vnd.docker.distribution.manifest.v1+json` will receive the signed 
one.


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/#review173140
---


On May 1, 2017, 5:24 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58725/
> ---
> 
> (Updated May 1, 2017, 5:24 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7427
> https://issues.apache.org/jira/browse/MESOS-7427
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'Accept: application/vnd.docker.distribution.manifest.v1+json'
> to the headers of HTTP requests for fetching manifests from any Docker
> registry. Some registry services (e.g., Amazon ECR) check the 'Accept'
> field strictly and reject the requests if it is not specified.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 
> 
> 
> Diff: https://reviews.apache.org/r/58725/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> Manually tested on the following registries:
> 1. Local docker private registries with the following version:
>2.0.1, 2.1.1, 2.2.1, 2.3.1, 2.4.1, 2.5.1, 2.6.1
> 2. Amazon ECR repository
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/#review173488
---



Patch looks great!

Reviews applied: [58753, 58725]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 1, 2017, 5:24 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58725/
> ---
> 
> (Updated May 1, 2017, 5:24 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7427
> https://issues.apache.org/jira/browse/MESOS-7427
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'Accept: application/vnd.docker.distribution.manifest.v1+json'
> to the headers of HTTP requests for fetching manifests from any Docker
> registry. Some registry services (e.g., Amazon ECR) check the 'Accept'
> field strictly and reject the requests if it is not specified.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 
> 
> 
> Diff: https://reviews.apache.org/r/58725/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> Manually tested on the following registries:
> 1. Local docker private registries with the following version:
>2.0.1, 2.1.1, 2.2.1, 2.3.1, 2.4.1, 2.5.1, 2.6.1
> 2. Amazon ECR repository
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/#review174087
---


Ship it!




Ship It!

- Jie Yu


On May 1, 2017, 5:24 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58725/
> ---
> 
> (Updated May 1, 2017, 5:24 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-7427
> https://issues.apache.org/jira/browse/MESOS-7427
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'Accept: application/vnd.docker.distribution.manifest.v1+json'
> to the headers of HTTP requests for fetching manifests from any Docker
> registry. Some registry services (e.g., Amazon ECR) check the 'Accept'
> field strictly and reject the requests if it is not specified.
> 
> 
> Diffs
> -
> 
>   src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 
> 
> 
> Diff: https://reviews.apache.org/r/58725/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> Manually tested on the following registries:
> 1. Local docker private registries with the following version:
>2.0.1, 2.1.1, 2.2.1, 2.3.1, 2.4.1, 2.5.1, 2.6.1
> 2. Amazon ECR repository
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>