Re: Review Request 59599: Added 'type' and 'name' fields to ResourceProviderInfo.

2017-06-30 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59599/#review179385
---


Ship it!




Ship It!

- Benjamin Bannier


On June 26, 2017, 6:30 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59599/
> ---
> 
> (Updated June 26, 2017, 6:30 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, 
> Joseph Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-7560
> https://issues.apache.org/jira/browse/MESOS-7560
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'type' and 'name' fields to ResourceProviderInfo.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 38449da44a5288afc7e2ef17ef5e1380ecabd5d2 
>   include/mesos/v1/mesos.proto 81eca47ce1074f5e522a0410f01ab2b2cfc76aa2 
> 
> 
> Diff: https://reviews.apache.org/r/59599/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 59599: Added 'type' and 'name' fields to ResourceProviderInfo.

2017-06-25 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59599/
---

(Updated June 26, 2017, 4:30 a.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, 
Joseph Wu, and Jan Schlicht.


Changes
---

Rebased.


Bugs: MESOS-7560
https://issues.apache.org/jira/browse/MESOS-7560


Repository: mesos


Description
---

Added 'type' and 'name' fields to ResourceProviderInfo.


Diffs (updated)
-

  include/mesos/mesos.proto 38449da44a5288afc7e2ef17ef5e1380ecabd5d2 
  include/mesos/v1/mesos.proto 81eca47ce1074f5e522a0410f01ab2b2cfc76aa2 


Diff: https://reviews.apache.org/r/59599/diff/3/

Changes: https://reviews.apache.org/r/59599/diff/2-3/


Testing
---

make check


Thanks,

Jie Yu

Re: Review Request 59599: Added 'type' and 'name' fields to ResourceProviderInfo.

2017-06-22 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59599/#review178732
---



LGTM so far. Having some patch using this functionality immediately following 
would be great.

- Benjamin Bannier


On June 9, 2017, 1:18 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59599/
> ---
> 
> (Updated June 9, 2017, 1:18 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao, 
> Joseph Wu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-7560
> https://issues.apache.org/jira/browse/MESOS-7560
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'type' and 'name' fields to ResourceProviderInfo.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5f80170fcd3c05add8b6e9e3107cff062818c1dc 
>   include/mesos/v1/mesos.proto 4b528751006f709f841e44f48c9f5c2dc035b402 
> 
> 
> Diff: https://reviews.apache.org/r/59599/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 59599: Added 'type' and 'name' fields to ResourceProviderInfo.

2017-06-08 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59599/
---

(Updated June 8, 2017, 11:17 p.m.)


Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Joseph Wu, and Jan 
Schlicht.


Changes
---

Rebased.


Bugs: MESOS-7560
https://issues.apache.org/jira/browse/MESOS-7560


Repository: mesos


Description
---

Added 'type' and 'name' fields to ResourceProviderInfo.


Diffs (updated)
-

  include/mesos/mesos.proto 5f80170fcd3c05add8b6e9e3107cff062818c1dc 
  include/mesos/v1/mesos.proto 4b528751006f709f841e44f48c9f5c2dc035b402 


Diff: https://reviews.apache.org/r/59599/diff/2/

Changes: https://reviews.apache.org/r/59599/diff/1-2/


Testing
---

make check


Thanks,

Jie Yu

Review Request 59599: Added 'type' and 'name' fields to ResourceProviderInfo.

2017-05-25 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59599/
---

Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Joseph Wu, and Jan 
Schlicht.


Bugs: MESOS-7560
https://issues.apache.org/jira/browse/MESOS-7560


Repository: mesos


Description
---

Added 'type' and 'name' fields to ResourceProviderInfo.


Diffs
-

  include/mesos/mesos.proto b063ddaca60398db0ca8ef8a6a41e472b9f4a404 
  include/mesos/v1/mesos.proto bc7dbe0d99de6e5a23b842751fce43896a6fcce9 


Diff: https://reviews.apache.org/r/59599/diff/1/


Testing
---

make check


Thanks,

Jie Yu