Re: Review Request 62381: Removed `docker exec` when performing health checks in docker executor.

2017-09-28 Thread Gaston Kleiman 


> On Sept. 19, 2017, 4:13 p.m., Gaston Kleiman wrote:
> > src/tests/health_check_tests.cpp
> > Lines 1121 (patched)
> > 
> >
> > I think that we have to use `TEST_F_TEMP_DISABLED_ON_WINDOWS` here.
> 
> Andrei Budnik wrote:
> This test passes on Windows. Is it really necessary to use 
> `TEST_F_TEMP_DISABLED_ON_WINDOWS`?

Ok, I didn't know if/how Docker works on Windows, dropping this issue =).


- Gaston


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62381/#review185744
---


On Sept. 18, 2017, 10:21 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62381/
> ---
> 
> (Updated Sept. 18, 2017, 10:21 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, haosdent huang, and Lukas Loesche.
> 
> 
> Bugs: MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-4812
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Mesos can enter namespaces via `setns` for launched subprocesses, hence
> we got rid of `docker exec` for command health checks. This change
> leads to more stable command health checks by making them independent
> from docker daemon that might hang. Also, this commit fixes the issue
> with incorrect escaping of quote characters in command health checks.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
>   src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 
> 
> 
> Diff: https://reviews.apache.org/r/62381/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 62381: Removed `docker exec` when performing health checks in docker executor.

2017-09-28 Thread Andrei Budnik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62381/#review186559
---




src/docker/executor.cpp
Line 609 (original)


`docker exec` is needed for Windows.


- Andrei Budnik


On Sept. 18, 2017, 5:21 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62381/
> ---
> 
> (Updated Sept. 18, 2017, 5:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston 
> Kleiman, haosdent huang, and Lukas Loesche.
> 
> 
> Bugs: MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-4812
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Mesos can enter namespaces via `setns` for launched subprocesses, hence
> we got rid of `docker exec` for command health checks. This change
> leads to more stable command health checks by making them independent
> from docker daemon that might hang. Also, this commit fixes the issue
> with incorrect escaping of quote characters in command health checks.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
>   src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 
> 
> 
> Diff: https://reviews.apache.org/r/62381/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 62381: Removed `docker exec` when performing health checks in docker executor.

2017-09-25 Thread Andrei Budnik 


> On Sept. 19, 2017, 11:13 p.m., Gastón Kleiman wrote:
> > src/tests/health_check_tests.cpp
> > Lines 1121 (patched)
> > 
> >
> > I think that we have to use `TEST_F_TEMP_DISABLED_ON_WINDOWS` here.

This test passes on Windows. Is it really necessary to use 
`TEST_F_TEMP_DISABLED_ON_WINDOWS`?


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62381/#review185744
---


On Sept. 18, 2017, 5:21 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62381/
> ---
> 
> (Updated Sept. 18, 2017, 5:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gastón 
> Kleiman, haosdent huang, and Lukas Loesche.
> 
> 
> Bugs: MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-4812
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Mesos can enter namespaces via `setns` for launched subprocesses, hence
> we got rid of `docker exec` for command health checks. This change
> leads to more stable command health checks by making them independent
> from docker daemon that might hang. Also, this commit fixes the issue
> with incorrect escaping of quote characters in command health checks.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
>   src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 
> 
> 
> Diff: https://reviews.apache.org/r/62381/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 62381: Removed `docker exec` when performing health checks in docker executor.

2017-09-21 Thread Andrei Budnik 


> On Sept. 19, 2017, 11:13 p.m., Gastón Kleiman wrote:
> > src/docker/executor.cpp
> > Line 590 (original), 596 (patched)
> > 
> >
> > We should check with Andrew Schwarztmeyer to see what to do on Windows.
> 
> Alexander Rukletsov wrote:
> And at least shorten the scope of the #ifdef to filtering available 
> namespaces.

Why we should shorten it? Do we expect that Windows will support namespaces 
someday?


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62381/#review185744
---


On Sept. 18, 2017, 5:21 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62381/
> ---
> 
> (Updated Sept. 18, 2017, 5:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, haosdent 
> huang, and Lukas Loesche.
> 
> 
> Bugs: MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-4812
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Mesos can enter namespaces via `setns` for launched subprocesses, hence
> we got rid of `docker exec` for command health checks. This change
> leads to more stable command health checks by making them independent
> from docker daemon that might hang. Also, this commit fixes the issue
> with incorrect escaping of quote characters in command health checks.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
>   src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 
> 
> 
> Diff: https://reviews.apache.org/r/62381/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 62381: Removed `docker exec` when performing health checks in docker executor.

2017-09-21 Thread Alexander Rukletsov 


> On Sept. 19, 2017, 11:13 p.m., Gastón Kleiman wrote:
> > src/docker/executor.cpp
> > Line 590 (original), 596 (patched)
> > 
> >
> > We should check with Andrew Schwarztmeyer to see what to do on Windows.

And at least shorten the scope of the #ifdef to filtering available namespaces.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62381/#review185744
---


On Sept. 18, 2017, 5:21 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62381/
> ---
> 
> (Updated Sept. 18, 2017, 5:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, haosdent 
> huang, and Lukas Loesche.
> 
> 
> Bugs: MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-4812
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Mesos can enter namespaces via `setns` for launched subprocesses, hence
> we got rid of `docker exec` for command health checks. This change
> leads to more stable command health checks by making them independent
> from docker daemon that might hang. Also, this commit fixes the issue
> with incorrect escaping of quote characters in command health checks.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
>   src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 
> 
> 
> Diff: https://reviews.apache.org/r/62381/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 62381: Removed `docker exec` when performing health checks in docker executor.

2017-09-19 Thread Gastón Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62381/#review185744
---




src/docker/executor.cpp
Line 590 (original), 596 (patched)


We should check with Andrew Schwarztmeyer to see what to do on Windows.



src/tests/health_check_tests.cpp
Lines 1121 (patched)


I think that we have to use `TEST_F_TEMP_DISABLED_ON_WINDOWS` here.



src/tests/health_check_tests.cpp
Lines 1162 (patched)


s/EXPECT_NE(0u, offers.get().size());/ASSERT_FALSE(offers->>empty());/


- Gastón Kleiman


On Sept. 18, 2017, 5:21 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62381/
> ---
> 
> (Updated Sept. 18, 2017, 5:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, haosdent 
> huang, and Lukas Loesche.
> 
> 
> Bugs: MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-4812
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Mesos can enter namespaces via `setns` for launched subprocesses, hence
> we got rid of `docker exec` for command health checks. This change
> leads to more stable command health checks by making them independent
> from docker daemon that might hang. Also, this commit fixes the issue
> with incorrect escaping of quote characters in command health checks.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
>   src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 
> 
> 
> Diff: https://reviews.apache.org/r/62381/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 62381: Removed `docker exec` when performing health checks in docker executor.

2017-09-19 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62381/#review185690
---



Patch looks great!

Reviews applied: [62381]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 18, 2017, 5:21 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62381/
> ---
> 
> (Updated Sept. 18, 2017, 5:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, haosdent 
> huang, and Lukas Loesche.
> 
> 
> Bugs: MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-4812
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Mesos can enter namespaces via `setns` for launched subprocesses, hence
> we got rid of `docker exec` for command health checks. This change
> leads to more stable command health checks by making them independent
> from docker daemon that might hang. Also, this commit fixes the issue
> with incorrect escaping of quote characters in command health checks.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
>   src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 
> 
> 
> Diff: https://reviews.apache.org/r/62381/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 62381: Removed `docker exec` when performing health checks in docker executor.

2017-09-18 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62381/#review185622
---



FAIL: Some Mesos tests failed.

Reviews applied: `['62381']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62381

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62381/logs/mesos-tests-stdout.log):

```
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/0
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (239 ms)
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/1
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (257 ms)
[--] 30 tests from ContentType/SchedulerTest (25468 ms total)

[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (952 
ms)
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 
(1018 ms)
[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (2049 ms 
total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (144 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (154 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (333 ms 
total)

[--] Global test environment tear-down
[==] 627 tests from 66 test cases ran. (346444 ms total)
[  PASSED  ] 626 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ContentType/MasterAPITest.EventAuthorizationFiltering/1, where 
GetParam() = application/json

 1 FAILED TEST
  YOU HAVE 174 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62381/logs/mesos-tests-stderr.log):

```
I0918 20:15:15.129381 20048 master.cpp:8418] Removing framework 
1d91d741-8216-4725-96b3-9211950d051a- (default)
I0918 20:15:15.130378 20048 master.cpp:3267] Deactivating framework 
1d91d741-8216-4725-96b3-9211950d051a- (default)
I0918 20:15:15.130378 19020 hierarchical.cpp:412] Deactivated framework 
1d91d741-8216-4725-96b3-9211950d051a-
I0918 20:15:15.130378 17216 slave.cpp:3235] Shutting down framework 
1d91d741-8216-4725-96b3-9211950d051a-
I0918 20:15:15.130378 20048 master.cpp:8993] Updating the state of task 
e2e6acbd-c12d-4aaf-b75a-ab9fcb6cb2d0 of framework 
1d91d741-8216-4725-96b3-9211950d051a- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0918 20:15:15.131378 17216 slave.cpp:5731] Shutting down executor 'default' of 
framework 1d91d741-8216-4725-96b3-9211950d051a- (via HTTP)
I0918 20:15:15.139425 20048 master.cpp:9087] Removing task 
e2e6acbd-c12d-4aaf-b75a-ab9fcb6cb2d0 with resources 
[{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}]
 of framework 1d91d741-8216-4725-96b3-9211950d051a- on agent 
1d91d741-8216-4725-96b3-9211950d051a-S0 at slave(254)@10.3.1.5:51096 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0918 20:15:15.158382 20048 master.cpp:9116] Removing executor 'default' with 
resources [] of framework 1d91d741-8216-4725-96b3-9211950d051a- on agent 
1d91d741-8216-4725-96b3-9211950d051a-S0 at slave(254)@10.3.1.5:51096 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0918 20:15:15.161382 19988 hierarchical.cpp:355] Removed framework 
1d91d741-8216-4725-96b3-9211950d051a-
E0918 20:15:15.162381 19692 scheduler.cpp:649] End-Of-File received from 
master. The master closed the event stream
I0918 20:15:15.172384 19692 scheduler.cpp:444] Re-detecting master
I0918 20:15:15.174382 19020 scheduler.cpp:470] New master detected at 
master@10.3.1.5:51096
I0918 20:15:15.188383 19988 slave.cpp:5407] Executor 'default' of framework 
1d91d741-8216-4725-96b3-9211950d051a- exited with status 0
I0918 20:15:15.188383 19988 slave.cpp:5511] Cleaning up executor 'default' of 
framework 1d91d741-8216-4725-96b3-9211950d051a- (via HTTP)
W0918 20:15:15.188383 19692 master.cpp:7021] Ignoring unknown exited executor 
'default' of framework 1d91d741-8216-4725-96b3-9211950d051a- on agent 
1d91d

Re: Review Request 62381: Removed `docker exec` when performing health checks in docker executor.

2017-09-18 Thread Andrei Budnik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62381/
---

(Updated Sept. 18, 2017, 5:21 p.m.)


Review request for mesos, Alexander Rukletsov, Gastón Kleiman, haosdent huang, 
and Lukas Loesche.


Changes
---

Fixed build on Mac and Windows.


Bugs: MESOS-4812
https://issues.apache.org/jira/browse/MESOS-4812


Repository: mesos


Description
---

Mesos can enter namespaces via `setns` for launched subprocesses, hence
we got rid of `docker exec` for command health checks. This change
leads to more stable command health checks by making them independent
from docker daemon that might hang. Also, this commit fixes the issue
with incorrect escaping of quote characters in command health checks.


Diffs (updated)
-

  src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
  src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 


Diff: https://reviews.apache.org/r/62381/diff/2/

Changes: https://reviews.apache.org/r/62381/diff/1-2/


Testing
---

internal CI


Thanks,

Andrei Budnik

Re: Review Request 62381: Removed `docker exec` when performing health checks in docker executor.

2017-09-18 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62381/#review185570
---



Patch looks great!

Reviews applied: [62381]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 18, 2017, 12:27 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62381/
> ---
> 
> (Updated Sept. 18, 2017, 12:27 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, haosdent 
> huang, and Lukas Loesche.
> 
> 
> Bugs: MESOS-4812
> https://issues.apache.org/jira/browse/MESOS-4812
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Mesos can enter namespaces via `setns` for launched subprocesses, hence
> we got rid of `docker exec` for command health checks. This change
> leads to more stable command health checks by making them independent
> from docker daemon that might hang. Also, this commit fixes the issue
> with incorrect escaping of quote characters in command health checks.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
>   src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 
> 
> 
> Diff: https://reviews.apache.org/r/62381/diff/1/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 62381: Removed `docker exec` when performing health checks in docker executor.

2017-09-18 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62381/#review185548
---



FAIL: Mesos tests failed to build.

Reviews applied: `['62381']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62381

Relevant logs:

- 
[mesos-tests-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62381/logs/mesos-tests-build-cmake-stdout.log):

```


"C:\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"C:\mesos\src\checks\mesos-tcp-connect.vcxproj" (default target) (26) ->
  C:\mesos\mesos\src\checks\tcp_connect.cpp(93): warning C4244: 'initializing': 
conversion from 'SOCKET' to 'int', possible loss of data 
[C:\mesos\src\checks\mesos-tcp-connect.vcxproj]


"C:\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"C:\mesos\src\tests\test-helper.vcxproj" (default target) (28) ->
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\mesos\mesos\src\tests\active_user_test_helper.cpp) 
[C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(436): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\mesos\mesos\src\tests\active_user_test_helper.cpp) 
[C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\mesos\mesos\src\tests\http_server_test_helper.cpp) 
[C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(436): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\mesos\mesos\src\tests\http_server_test_helper.cpp) 
[C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\src\tests\resources_utils.cpp(93): warning C4267: 'argument': 
conversion from 'size_t' to 'int', possible loss of data 
[C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\mesos\mesos\src\tests\flags.cpp) [C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(436): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\mesos\mesos\src\tests\flags.cpp) [C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\mesos\mesos\src\tests\utils.cpp) [C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(436): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\mesos\mesos\src\tests\utils.cpp) [C:\mesos\src\tests\test-helper.vcxproj]


"C:\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"C:\mesos\src\docker\mesos-docker-executor.vcxproj" (default target) (24) ->
(ClCompile target) -> 
  C:\mesos\mesos\src\linux/ns.hpp(22): fatal error C1189: #error:  
"linux/ns.hpp is only available on Linux systems." 
[C:\mesos\src\docker\mesos-docker-executor.vcxproj]

141 Warning(s)
1 Error(s)

Time Elapsed 00:38:37.69
```

- 
[mesos-tests-CMakeOutput.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62381/logs/mesos-tests-CMakeOutput.log):

```
  Creating directory "C:\mesos\CMakeFiles\CMakeTmp\Debug\".

  Creating directory "cmTC_2e741.dir\Debug\cmTC_2e741.tlog\".

InitializeBuildStatus:

  Creating "cmTC_2e741.dir\Debug\cmTC_2e741.tlog\unsuccessfulbuild" because 
"AlwaysCreate" was specified.

ClCompile:

  C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64\CL.exe /c /Zi 
/W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D 
COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 
/MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR 
/Fo"cmTC_2e741.dir\Debug\" /Fd"cmTC_2e741.dir\Debug\vc141.pdb" /Gd /TP 
/errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\src.cxx

  Microsoft (R) C/C++ Optimizing Compiler Version 19.10.25019 for x64

  Copyright (C) Microsoft Corporation.  All rights reserved.

  

  cl /c /Zi /W3 /WX- /diagnostics:classic /Od /Ob0 /D WIN32 /D _WINDOWS /D 
COMPILER_SUPPORTS_CXX11 /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /EHsc /RTC1 
/MDd /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR 
/Fo"cmTC_2e741.dir\Debug\" /Fd"cmTC_2e741.dir\Debug\vc141.pdb" /Gd /TP 
/errorReport:queue C:\mesos\CMakeFiles\CMakeTmp\src.cxx

  src.cxx

  

Link:

  C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Communit

Review Request 62381: Removed `docker exec` when performing health checks in docker executor.

2017-09-18 Thread Andrei Budnik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62381/
---

Review request for mesos, Alexander Rukletsov, Gastón Kleiman, haosdent huang, 
and Lukas Loesche.


Bugs: MESOS-4812
https://issues.apache.org/jira/browse/MESOS-4812


Repository: mesos


Description
---

Mesos can enter namespaces via `setns` for launched subprocesses, hence
we got rid of `docker exec` for command health checks. This change
leads to more stable command health checks by making them independent
from docker daemon that might hang. Also, this commit fixes the issue
with incorrect escaping of quote characters in command health checks.


Diffs
-

  src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
  src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 


Diff: https://reviews.apache.org/r/62381/diff/1/


Testing
---

internal CI


Thanks,

Andrei Budnik