Re: Review Request 65350: Modified `cgroups::prepare` to check nested cgroups support only once.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65350/#review200131 --- Thanks for all efforts on this issue, Andrei. However, adding a mutex lock does not seem a clean fix to me. Please see my comment for details https://issues.apache.org/jira/browse/MESOS-8489?focusedCommentId=16417999&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16417999 - Gilbert Song On March 12, 2018, 7:50 a.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65350/ > --- > > (Updated March 12, 2018, 7:50 a.m.) > > > Review request for mesos, Alexander Rukletsov, Gilbert Song, Jie Yu, and Till > Toenshoff. > > > Bugs: MESOS-8489 > https://issues.apache.org/jira/browse/MESOS-8489 > > > Repository: mesos > > > Description > --- > > This patch modifies `cgroup::prepare` function to save the results of > a test for a nested cgroups support in a hashmap to reuse it in the > future. > > Besides optimization, this patch fixes flaky > `LinuxCapabilitiesIsolatorFlagsTest.ROOT_IsolatorFlags` test. There > was a race condition between two starting agents, where the first > agent could detect `test` orphaned container while iterating over > `/sys/fs/cgroup/freezer/mesos/` cgroup, because the second agent > is calling `cgroup::prepare` during its initialization. This patch > fixes the test, because it won't create a `test` cgroup in > `cgroups::prepare` as this test has already been passed during the > initialization of the first agent and the result is stored in hashmap. > > > Diffs > - > > src/linux/cgroups.cpp 682b288da8d56a623ef32cf6f0beecd9fc327622 > > > Diff: https://reviews.apache.org/r/65350/diff/2/ > > > Testing > --- > > sudo make check (Fedora 25) > internal CI > > > Thanks, > > Andrei Budnik > >
Re: Review Request 65350: Modified `cgroups::prepare` to check nested cgroups support only once.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65350/#review199026 --- Patch looks great! Reviews applied: [65350] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 12, 2018, 2:50 p.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65350/ > --- > > (Updated March 12, 2018, 2:50 p.m.) > > > Review request for mesos, Alexander Rukletsov, Gilbert Song, Jie Yu, and Till > Toenshoff. > > > Bugs: MESOS-8489 > https://issues.apache.org/jira/browse/MESOS-8489 > > > Repository: mesos > > > Description > --- > > This patch modifies `cgroup::prepare` function to save the results of > a test for a nested cgroups support in a hashmap to reuse it in the > future. > > Besides optimization, this patch fixes flaky > `LinuxCapabilitiesIsolatorFlagsTest.ROOT_IsolatorFlags` test. There > was a race condition between two starting agents, where the first > agent could detect `test` orphaned container while iterating over > `/sys/fs/cgroup/freezer/mesos/` cgroup, because the second agent > is calling `cgroup::prepare` during its initialization. This patch > fixes the test, because it won't create a `test` cgroup in > `cgroups::prepare` as this test has already been passed during the > initialization of the first agent and the result is stored in hashmap. > > > Diffs > - > > src/linux/cgroups.cpp 682b288da8d56a623ef32cf6f0beecd9fc327622 > > > Diff: https://reviews.apache.org/r/65350/diff/2/ > > > Testing > --- > > sudo make check (Fedora 25) > internal CI > > > Thanks, > > Andrei Budnik > >
Re: Review Request 65350: Modified `cgroups::prepare` to check nested cgroups support only once.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65350/#review199023 --- PASS: Mesos patch 65350 was successfully built and tested. Reviews applied: `['65350']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65350 - Mesos Reviewbot Windows On Jan. 26, 2018, 2:17 p.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65350/ > --- > > (Updated Jan. 26, 2018, 2:17 p.m.) > > > Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-8489 > https://issues.apache.org/jira/browse/MESOS-8489 > > > Repository: mesos > > > Description > --- > > This patch modifies `cgroup::prepare` function to save the results of > a test for a nested cgroups support in a hashmap to reuse it in the > future. > > Besides optimization, this patch fixes flaky > `LinuxCapabilitiesIsolatorFlagsTest.ROOT_IsolatorFlags` test. There > was a race condition between two starting agents, where the first > agent could detect `test` orphaned container while iterating over > `/sys/fs/cgroup/freezer/mesos/` cgroup, because the second agent > is calling `cgroup::prepare` during its initialization. This patch > fixes the test, because it won't create a `test` cgroup in > `cgroups::prepare` as this test has already been passed during the > initialization of the first agent and the result is stored in hashmap. > > > Diffs > - > > src/linux/cgroups.cpp 682b288da8d56a623ef32cf6f0beecd9fc327622 > > > Diff: https://reviews.apache.org/r/65350/diff/2/ > > > Testing > --- > > sudo make check (Fedora 25) > internal CI > > > Thanks, > > Andrei Budnik > >
Re: Review Request 65350: Modified `cgroups::prepare` to check nested cgroups support only once.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65350/#review196354 --- PASS: Mesos patch 65350 was successfully built and tested. Reviews applied: `['65350']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65350 - Mesos Reviewbot Windows On Jan. 26, 2018, 2:17 p.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65350/ > --- > > (Updated Jan. 26, 2018, 2:17 p.m.) > > > Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-8489 > https://issues.apache.org/jira/browse/MESOS-8489 > > > Repository: mesos > > > Description > --- > > This patch modifies `cgroup::prepare` function to save the results of > a test for a nested cgroups support in a hashmap to reuse it in the > future. > > Besides optimization, this patch fixes flaky > `LinuxCapabilitiesIsolatorFlagsTest.ROOT_IsolatorFlags` test. There > was a race condition between two starting agents, where the first > agent could detect `test` orphaned container while iterating over > `/sys/fs/cgroup/freezer/mesos/` cgroup, because the second agent > is calling `cgroup::prepare` during its initialization. This patch > fixes the test, because it won't create a `test` cgroup in > `cgroups::prepare` as this test has already been passed during the > initialization of the first agent and the result is stored in hashmap. > > > Diffs > - > > src/linux/cgroups.cpp cdd0f40ec5748b909e529f21b15523122bf90d41 > > > Diff: https://reviews.apache.org/r/65350/diff/1/ > > > Testing > --- > > sudo make check (Fedora 25) > internal CI > > > Thanks, > > Andrei Budnik > >
Re: Review Request 65350: Modified `cgroups::prepare` to check nested cgroups support only once.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65350/#review196349 --- FAIL: Failed to get dependent review IDs for the current patch. Failed command: `python.exe C:\Users\mesos\AppData\Local\Temp\tmp2C66.tmp\Mesos\utils\get-review-ids.py -r 65350 -o C:\Users\mesos\AppData\Local\Temp\mesos_dependent_review_ids` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65350 Relevant logs: - [get-review-ids-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65350/logs/get-review-ids-stderr.log): ``` C:\Python27\python.exe: can't open file 'C:\Users\mesos\AppData\Local\Temp\tmp2C66.tmp\Mesos\utils\get-review-ids.py': [Errno 2] No such file or directory ``` - Mesos Reviewbot Windows On Jan. 26, 2018, 2:17 p.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65350/ > --- > > (Updated Jan. 26, 2018, 2:17 p.m.) > > > Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-8489 > https://issues.apache.org/jira/browse/MESOS-8489 > > > Repository: mesos > > > Description > --- > > This patch modifies `cgroup::prepare` function to save the results of > a test for a nested cgroups support in a hashmap to reuse it in the > future. > > Besides optimization, this patch fixes flaky > `LinuxCapabilitiesIsolatorFlagsTest.ROOT_IsolatorFlags` test. There > was a race condition between two starting agents, where the first > agent could detect `test` orphaned container while iterating over > `/sys/fs/cgroup/freezer/mesos/` cgroup, because the second agent > is calling `cgroup::prepare` during its initialization. This patch > fixes the test, because it won't create a `test` cgroup in > `cgroups::prepare` as this test has already been passed during the > initialization of the first agent and the result is stored in hashmap. > > > Diffs > - > > src/linux/cgroups.cpp cdd0f40ec5748b909e529f21b15523122bf90d41 > > > Diff: https://reviews.apache.org/r/65350/diff/1/ > > > Testing > --- > > sudo make check (Fedora 25) > internal CI > > > Thanks, > > Andrei Budnik > >
Review Request 65350: Modified `cgroups::prepare` to check nested cgroups support only once.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65350/ --- Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu. Bugs: MESOS-8489 https://issues.apache.org/jira/browse/MESOS-8489 Repository: mesos Description --- This patch modifies `cgroup::prepare` function to save the results of a test for a nested cgroups support in a hashmap to reuse it in the future. Besides optimization, this patch fixes flaky `LinuxCapabilitiesIsolatorFlagsTest.ROOT_IsolatorFlags` test. There was a race condition between two starting agents, where the first agent could detect `test` orphaned container while iterating over `/sys/fs/cgroup/freezer/mesos/` cgroup, because the second agent is calling `cgroup::prepare` during its initialization. This patch fixes the test, because it won't create a `test` cgroup in `cgroups::prepare` as this test has already been passed during the initialization of the first agent and the result is stored in hashmap. Diffs - src/linux/cgroups.cpp cdd0f40ec5748b909e529f21b15523122bf90d41 Diff: https://reviews.apache.org/r/65350/diff/1/ Testing --- sudo make check (Fedora 25) internal CI Thanks, Andrei Budnik
