Review Request 66384: Link libm in ZooKeeper build on FreeBSD.

2018-03-31 Thread David Forsythe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66384/
---

Review request for mesos.


Bugs: MESOS-4176
https://issues.apache.org/jira/browse/MESOS-4176


Repository: mesos


Description
---

Link libm in ZooKeeper build on FreeBSD.


Diffs
-

  3rdparty/zookeeper-3.4.8.patch 2eaa056dd5668d5842b5b59a42f83ae307d4aef0 


Diff: https://reviews.apache.org/r/66384/diff/1/


Testing
---


Thanks,

David Forsythe

Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.

2018-04-02 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66384/#review200289
---




3rdparty/zookeeper-3.4.8.patch
Line 154 (original), 154 (patched)


LGTM



3rdparty/zookeeper-3.4.8.patch
Lines 870-873 (original), 870-872 (patched)


This is funny, what did this get diffed against? I might have screwed up in 
my original diff...


- Andrew Schwartzmeyer


On March 31, 2018, 7:32 p.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66384/
> ---
> 
> (Updated March 31, 2018, 7:32 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-4176
> https://issues.apache.org/jira/browse/MESOS-4176
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Link libm in ZooKeeper build on FreeBSD.
> 
> 
> Diffs
> -
> 
>   3rdparty/zookeeper-3.4.8.patch 2eaa056dd5668d5842b5b59a42f83ae307d4aef0 
> 
> 
> Diff: https://reviews.apache.org/r/66384/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.

2018-04-02 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66384/#review200292
---




3rdparty/zookeeper-3.4.8.patch
Line 154 (original), 154 (patched)


Also, if this change should go upstream to ZooKeeper (looks to me like it 
should) then let's make sure it does. Their process is [pretty 
similar](https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute).

If you don't want to, I can upstream it.


- Andrew Schwartzmeyer


On March 31, 2018, 7:32 p.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66384/
> ---
> 
> (Updated March 31, 2018, 7:32 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-4176
> https://issues.apache.org/jira/browse/MESOS-4176
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Link libm in ZooKeeper build on FreeBSD.
> 
> 
> Diffs
> -
> 
>   3rdparty/zookeeper-3.4.8.patch 2eaa056dd5668d5842b5b59a42f83ae307d4aef0 
> 
> 
> Diff: https://reviews.apache.org/r/66384/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.

2018-04-02 Thread David Forsythe 


> On April 2, 2018, 5:02 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/zookeeper-3.4.8.patch
> > Lines 870-873 (original), 870-872 (patched)
> > 
> >
> > This is funny, what did this get diffed against? I might have screwed 
> > up in my original diff...

I used the archive in the repo. I don't know what the workflow for changes like 
this is supposed to look like, but this is as close as I could get.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66384/#review200289
---


On April 1, 2018, 2:32 a.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66384/
> ---
> 
> (Updated April 1, 2018, 2:32 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-4176
> https://issues.apache.org/jira/browse/MESOS-4176
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Link libm in ZooKeeper build on FreeBSD.
> 
> 
> Diffs
> -
> 
>   3rdparty/zookeeper-3.4.8.patch 2eaa056dd5668d5842b5b59a42f83ae307d4aef0 
> 
> 
> Diff: https://reviews.apache.org/r/66384/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.

2018-04-02 Thread David Forsythe 


> On April 2, 2018, 5:06 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/zookeeper-3.4.8.patch
> > Line 154 (original), 154 (patched)
> > 
> >
> > Also, if this change should go upstream to ZooKeeper (looks to me like 
> > it should) then let's make sure it does. Their process is [pretty 
> > similar](https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute).
> > 
> > If you don't want to, I can upstream it.

I can add it to my todo list.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66384/#review200292
---


On April 1, 2018, 2:32 a.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66384/
> ---
> 
> (Updated April 1, 2018, 2:32 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-4176
> https://issues.apache.org/jira/browse/MESOS-4176
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Link libm in ZooKeeper build on FreeBSD.
> 
> 
> Diffs
> -
> 
>   3rdparty/zookeeper-3.4.8.patch 2eaa056dd5668d5842b5b59a42f83ae307d4aef0 
> 
> 
> Diff: https://reviews.apache.org/r/66384/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.

2018-04-03 Thread Andrew Schwartzmeyer 


> On April 2, 2018, 10:06 a.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/zookeeper-3.4.8.patch
> > Line 154 (original), 154 (patched)
> > 
> >
> > Also, if this change should go upstream to ZooKeeper (looks to me like 
> > it should) then let's make sure it does. Their process is [pretty 
> > similar](https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute).
> > 
> > If you don't want to, I can upstream it.
> 
> David Forsythe wrote:
> I can add it to my todo list.

FWIW I can review/shepherd over on ZooKeeper too, though I can't commit 
directly (yet). Michael is pretty good about it though.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66384/#review200292
---


On March 31, 2018, 7:32 p.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66384/
> ---
> 
> (Updated March 31, 2018, 7:32 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-4176
> https://issues.apache.org/jira/browse/MESOS-4176
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Link libm in ZooKeeper build on FreeBSD.
> 
> 
> Diffs
> -
> 
>   3rdparty/zookeeper-3.4.8.patch 2eaa056dd5668d5842b5b59a42f83ae307d4aef0 
> 
> 
> Diff: https://reviews.apache.org/r/66384/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.

2018-04-03 Thread David Forsythe 


> On April 2, 2018, 5:06 p.m., Andrew Schwartzmeyer wrote:
> > 3rdparty/zookeeper-3.4.8.patch
> > Line 154 (original), 154 (patched)
> > 
> >
> > Also, if this change should go upstream to ZooKeeper (looks to me like 
> > it should) then let's make sure it does. Their process is [pretty 
> > similar](https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute).
> > 
> > If you don't want to, I can upstream it.
> 
> David Forsythe wrote:
> I can add it to my todo list.
> 
> Andrew Schwartzmeyer wrote:
> FWIW I can review/shepherd over on ZooKeeper too, though I can't commit 
> directly (yet). Michael is pretty good about it though.

I opened https://github.com/apache/zookeeper/pull/499 for 
https://issues.apache.org/jira/browse/ZOOKEEPER-3017


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66384/#review200292
---


On April 1, 2018, 2:32 a.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66384/
> ---
> 
> (Updated April 1, 2018, 2:32 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-4176
> https://issues.apache.org/jira/browse/MESOS-4176
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Link libm in ZooKeeper build on FreeBSD.
> 
> 
> Diffs
> -
> 
>   3rdparty/zookeeper-3.4.8.patch 2eaa056dd5668d5842b5b59a42f83ae307d4aef0 
> 
> 
> Diff: https://reviews.apache.org/r/66384/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.

2018-04-05 Thread David Forsythe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66384/
---

(Updated April 5, 2018, 6:41 p.m.)


Review request for mesos and Andrew Schwartzmeyer.


Bugs: MESOS-4176
https://issues.apache.org/jira/browse/MESOS-4176


Repository: mesos


Description
---

Link libm in ZooKeeper build on FreeBSD.


Diffs (updated)
-

  3rdparty/zookeeper-3.4.8.patch 2eaa056dd5668d5842b5b59a42f83ae307d4aef0 


Diff: https://reviews.apache.org/r/66384/diff/2/

Changes: https://reviews.apache.org/r/66384/diff/1-2/


Testing
---


Thanks,

David Forsythe

Re: Review Request 66384: Link libm in ZooKeeper build on FreeBSD.

2018-04-05 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66384/#review200570
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On April 5, 2018, 11:41 a.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66384/
> ---
> 
> (Updated April 5, 2018, 11:41 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-4176
> https://issues.apache.org/jira/browse/MESOS-4176
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Link libm in ZooKeeper build on FreeBSD.
> 
> 
> Diffs
> -
> 
>   3rdparty/zookeeper-3.4.8.patch 2eaa056dd5668d5842b5b59a42f83ae307d4aef0 
> 
> 
> Diff: https://reviews.apache.org/r/66384/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Forsythe
> 
>