Review Request 66683: Updated address field of new CLI config to accept URLs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-8025 https://issues.apache.org/jira/browse/MESOS-8025 Repository: mesos Description --- Updated address field of new CLI config to accept URLs. Diffs - src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 Diff: https://reviews.apache.org/r/66683/diff/1/ Testing --- Ran `mesos agent list` successfully with config: ``` [master] address = "http://.com:5061" ``` On the server providing `http://.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. Also ran `mesos-cli-tests` successfully. Thanks, Armand Grillet
Re: Review Request 66683: Updated address field of new CLI config to accept URLs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/#review201422 --- FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['66683']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66683 Relevant logs: - [libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66683/logs/libprocess-tests-cmake-stdout.log): ``` d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\evutil_time.c(499): warning C4244: '=': conversion from 'int64_t' to 'long', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj] d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\evutil_time.c(504): warning C4244: '=': conversion from 'time_t' to 'long', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj] d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(185): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj] d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(230): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj] d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(587): warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj] d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(598): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj] d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(654): warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj] d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(656): warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj] d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(675): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj] d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(755): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj] d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(763): warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj] d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(874): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj] d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(1275): warning C4244: 'function': conversion from 'intptr_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj] [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxpr
Re: Review Request 66683: Updated address field of new CLI config to accept URLs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/#review201439 --- Patch looks great! Reviews applied: [66683] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 18, 2018, 6:14 a.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66683/ > --- > > (Updated April 18, 2018, 6:14 a.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-8025 > https://issues.apache.org/jira/browse/MESOS-8025 > > > Repository: mesos > > > Description > --- > > Updated address field of new CLI config to accept URLs. > > > Diffs > - > > src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b > src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 > > > Diff: https://reviews.apache.org/r/66683/diff/1/ > > > Testing > --- > > Ran `mesos agent list` successfully with config: > ``` > [master] > address = "http://.com:5061" > ``` > On the server providing `http://.com` I had > a Mesos master running with `bash mesos-master.sh --port='5061' > --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. > > Also ran `mesos-cli-tests` successfully. > > > Thanks, > > Armand Grillet > >
Re: Review Request 66683: Updated address field of new CLI config to accept URLs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/#review201547 --- FAIL: Mesos binaries failed to build. Reviews applied: `['66683']` Failed command: `cmake.exe --build . --config Release -- /maxcpucount` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66683 Relevant logs: - [mesos-binaries-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66683/logs/mesos-binaries-cmake-stdout.log): ``` "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) -> "D:\DCOS\mesos\src\docker\mesos-docker-executor.vcxproj" (default target) (20) -> d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit': destructor never returns, potential memory leak [D:\DCOS\mesos\src\docker\mesos-docker-executor.vcxproj] "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) -> "D:\DCOS\mesos\src\launcher\mesos-default-executor.vcxproj" (default target) (26) -> d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit': destructor never returns, potential memory leak [D:\DCOS\mesos\src\launcher\mesos-default-executor.vcxproj] "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) -> "D:\DCOS\mesos\src\master\mesos-master.vcxproj" (default target) (35) -> d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit': destructor never returns, potential memory leak [D:\DCOS\mesos\src\master\mesos-master.vcxproj] "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) -> "D:\DCOS\mesos\src\slave\mesos-agent.vcxproj" (default target) (21) -> d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit': destructor never returns, potential memory leak [D:\DCOS\mesos\src\slave\mesos-agent.vcxproj] "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) -> "D:\DCOS\mesos\3rdparty\jemalloc-5.0.1.vcxproj" (default target) (7) -> (CustomBuild target) -> C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 9009. [D:\DCOS\mesos\3rdparty\jemalloc-5.0.1.vcxproj] 358 Warning(s) 1 Error(s) Time Elapsed 00:23:20.12 ``` - Mesos Reviewbot Windows On April 18, 2018, 6:14 a.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66683/ > --- > > (Updated April 18, 2018, 6:14 a.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-8025 > https://issues.apache.org/jira/browse/MESOS-8025 > > > Repository: mesos > > > Description > --- > > Updated address field of new CLI config to accept URLs. > > > Diffs > - > > src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b > src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 > > > Diff: https://reviews.apache.org/r/66683/diff/2/ > > > Testing > --- > > Ran `mesos agent list` successfully with config: > ``` > [master] > address = "http://.com:5061" > ``` > On the server providing `http://.com` I had > a Mesos master running with `bash mesos-master.sh --port='5061' > --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. > > Also ran `mesos-cli-tests` successfully. > > > Thanks, > > Armand Grillet > >
Re: Review Request 66683: Updated address field of new CLI config to accept URLs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/#review201590 --- Patch looks great! Reviews applied: [66683] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 18, 2018, 6:14 a.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66683/ > --- > > (Updated April 18, 2018, 6:14 a.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-8025 > https://issues.apache.org/jira/browse/MESOS-8025 > > > Repository: mesos > > > Description > --- > > Updated address field of new CLI config to accept URLs. > > > Diffs > - > > src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b > src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 > > > Diff: https://reviews.apache.org/r/66683/diff/2/ > > > Testing > --- > > Ran `mesos agent list` successfully with config: > ``` > [master] > address = "http://.com:5061" > ``` > On the server providing `http://.com` I had > a Mesos master running with `bash mesos-master.sh --port='5061' > --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. > > Also ran `mesos-cli-tests` successfully. > > > Thanks, > > Armand Grillet > >
Re: Review Request 66683: Updated address field of new CLI config to accept URLs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/#review202115 --- PASS: Mesos patch 66683 was successfully built and tested. Reviews applied: `['66683']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66683 - Mesos Reviewbot Windows On April 18, 2018, 1:14 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66683/ > --- > > (Updated April 18, 2018, 1:14 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-8025 > https://issues.apache.org/jira/browse/MESOS-8025 > > > Repository: mesos > > > Description > --- > > Updated address field of new CLI config to accept URLs. > > > Diffs > - > > src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b > src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 > > > Diff: https://reviews.apache.org/r/66683/diff/3/ > > > Testing > --- > > Ran `mesos agent list` successfully with config: > ``` > [master] > address = "http://.com:5061" > ``` > On the server providing `http://.com` I had > a Mesos master running with `bash mesos-master.sh --port='5061' > --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. > > Also ran `mesos-cli-tests` successfully. > > > Thanks, > > Armand Grillet > >
Re: Review Request 66683: Updated address field of new CLI config to accept URLs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/#review202123 --- Patch looks great! Reviews applied: [66683] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 18, 2018, 3:14 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66683/ > --- > > (Updated April 18, 2018, 3:14 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-8025 > https://issues.apache.org/jira/browse/MESOS-8025 > > > Repository: mesos > > > Description > --- > > Updated address field of new CLI config to accept URLs. > > > Diffs > - > > src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b > src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 > > > Diff: https://reviews.apache.org/r/66683/diff/3/ > > > Testing > --- > > Ran `mesos agent list` successfully with config: > ``` > [master] > address = "http://.com:5061" > ``` > On the server providing `http://.com` I had > a Mesos master running with `bash mesos-master.sh --port='5061' > --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. > > Also ran `mesos-cli-tests` successfully. > > > Thanks, > > Armand Grillet > >
Re: Review Request 66683: Updated address field of new CLI config to accept URLs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/ --- (Updated Oct. 5, 2018, 11:59 a.m.) Review request for mesos and Kevin Klues. Changes --- Rebased. Bugs: MESOS-8025 https://issues.apache.org/jira/browse/MESOS-8025 Repository: mesos Description --- Updated address field of new CLI config to accept URLs. Diffs (updated) - src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db src/python/cli_new/lib/cli/util.py 7cec7e49ab3c0926067626f5bd5dbba8bf4f44d7 Diff: https://reviews.apache.org/r/66683/diff/4/ Changes: https://reviews.apache.org/r/66683/diff/3-4/ Testing --- Ran `mesos agent list` successfully with config: ``` [master] address = "http://.com:5061" ``` On the server providing `http://.com` I had a Mesos master running with `bash mesos-master.sh --port='5061' --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. Also ran `mesos-cli-tests` successfully. Thanks, Armand Grillet
Re: Review Request 66683: Updated address field of new CLI config to accept URLs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/#review209257 --- PASS: Mesos patch 66683 was successfully built and tested. Reviews applied: `['66683']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2423/mesos-review-66683 - Mesos Reviewbot Windows On Oct. 5, 2018, 9:59 a.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66683/ > --- > > (Updated Oct. 5, 2018, 9:59 a.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-8025 > https://issues.apache.org/jira/browse/MESOS-8025 > > > Repository: mesos > > > Description > --- > > Updated address field of new CLI config to accept URLs. > > > Diffs > - > > src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db > src/python/cli_new/lib/cli/util.py 7cec7e49ab3c0926067626f5bd5dbba8bf4f44d7 > > > Diff: https://reviews.apache.org/r/66683/diff/4/ > > > Testing > --- > > Ran `mesos agent list` successfully with config: > ``` > [master] > address = "http://.com:5061" > ``` > On the server providing `http://.com` I had > a Mesos master running with `bash mesos-master.sh --port='5061' > --work_dir='/tmp/master1' --log_dir='/tmp/master1-log' --registry=in_memory`. > > Also ran `mesos-cli-tests` successfully. > > > Thanks, > > Armand Grillet > >
