Re: Review Request 67212: Used `*_SOME` macro for checking `Try` values.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67212/#review203978 --- PASS: Mesos patch 67212 was successfully built and tested. Reviews applied: `['67210', '67211', '67212']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67212 - Mesos Reviewbot Windows On May 29, 2018, 8:13 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67212/ > --- > > (Updated May 29, 2018, 8:13 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Repository: mesos > > > Description > --- > > Used `*_SOME` macro for checking `Try` values. > > > Diffs > - > > src/tests/master_quota_tests.cpp 0692e3148829738c736b47446fdebe013211b930 > src/tests/protobuf_io_tests.cpp 91c1806291fe5cd6b8ac0fcd864dce73de301fd8 > src/tests/resources_tests.cpp 1201efec3ff0abc268f896c1fe2330571390b3fd > src/tests/secret_generator_tests.cpp > 7fd649b2bb403d943955b5df1299c5c58b2c7582 > src/tests/state_tests.cpp 1a2bfb870da3e9044ee39da843da489fbe65586a > src/tests/zookeeper_tests.cpp f2f9858499f1093fb05b89d36d0e2d6711222e9f > src/tests/zookeeper_url_tests.cpp 498606a70e5e1ef726ea08fbb0d6775c7e14ec31 > > > Diff: https://reviews.apache.org/r/67212/diff/2/ > > > Testing > --- > > `make check` > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 67212: Used `*_SOME` macro for checking `Try` values.
> On May 18, 2018, 8:58 p.m., Chun-Hung Hsiao wrote: > > Haven't take a good at these but they might be candidates to use the new > > macros: > > ``` > > $ grep '(EXPECT\|ASSERT)_(TRUE\|FALSE)(.*is(Some\|Error\|None)())' src -r > > src/tests/containerizer/cgroups_isolator_tests.cpp: > > ASSERT_FALSE(check.isError()); > > src/tests/containerizer/cgroups_tests.cpp: > > ASSERT_FALSE(hierarchy.isError()); > > src/tests/containerizer/cgroups_tests.cpp: > > EXPECT_FALSE(cpuHierarchy.isError()); > > src/tests/containerizer/cgroups_tests.cpp: > > EXPECT_FALSE(memHierarchy.isError()); > > src/tests/containerizer/routing_tests.cpp: EXPECT_FALSE(eth0.isError()); > > src/tests/containerizer/routing_tests.cpp: EXPECT_FALSE(lo.isError()); > > src/tests/containerizer/routing_tests.cpp: EXPECT_FALSE(gateway.isError()); > > src/tests/master_quota_tests.cpp:ASSERT_FALSE(status.isError()); > > src/tests/master_quota_tests.cpp:ASSERT_FALSE(status.isError()); > > src/tests/master_quota_tests.cpp:ASSERT_FALSE(status.isError()); > > src/tests/master_quota_tests.cpp:ASSERT_FALSE(status.isError()); > > src/tests/master_quota_tests.cpp:ASSERT_FALSE(status.isError()); > > src/tests/master_quota_tests.cpp:ASSERT_FALSE(status.isError()); > > src/tests/mesos.cpp: ASSERT_FALSE(hierarchy.isError()); > > src/tests/protobuf_io_tests.cpp: ASSERT_TRUE(read.isNone()); > > src/tests/protobuf_io_tests.cpp: ASSERT_TRUE(read.isNone()); > > src/tests/resources_tests.cpp: EXPECT_TRUE(r.mem().isNone()); > > src/tests/resources_tests.cpp: EXPECT_TRUE(r.ports().isNone()); > > src/tests/state_tests.cpp: EXPECT_TRUE(future2->isNone()); > > src/tests/zookeeper_tests.cpp: ASSERT_TRUE(leader->isNone()); > > src/tests/zookeeper_url_tests.cpp: > > EXPECT_TRUE(url->authentication.isNone()); > > src/tests/zookeeper_url_tests.cpp: > > EXPECT_FALSE(url->authentication.isNone()); > > src/tests/zookeeper_url_tests.cpp: > > EXPECT_FALSE(url->authentication.isNone()); > > src/tests/zookeeper_url_tests.cpp: > > EXPECT_FALSE(url->authentication.isNone()); > > src/tests/zookeeper_url_tests.cpp: > > EXPECT_FALSE(url->authentication.isNone()); > > src/tests/zookeeper_url_tests.cpp: > > EXPECT_FALSE(url->authentication.isNone()); > > ``` > > We could fix them in a follow-up patch. I have updated this patch to fix some of these as well. Note in general the fix here does not apply to some checks we perform on `Result` values of the form (EXPECT\|ASSERT)_TRUE(.*isError) - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67212/#review203444 --- On May 29, 2018, 10:13 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67212/ > --- > > (Updated May 29, 2018, 10:13 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Repository: mesos > > > Description > --- > > Used `*_SOME` macro for checking `Try` values. > > > Diffs > - > > src/tests/master_quota_tests.cpp 0692e3148829738c736b47446fdebe013211b930 > src/tests/protobuf_io_tests.cpp 91c1806291fe5cd6b8ac0fcd864dce73de301fd8 > src/tests/resources_tests.cpp 1201efec3ff0abc268f896c1fe2330571390b3fd > src/tests/secret_generator_tests.cpp > 7fd649b2bb403d943955b5df1299c5c58b2c7582 > src/tests/state_tests.cpp 1a2bfb870da3e9044ee39da843da489fbe65586a > src/tests/zookeeper_tests.cpp f2f9858499f1093fb05b89d36d0e2d6711222e9f > src/tests/zookeeper_url_tests.cpp 498606a70e5e1ef726ea08fbb0d6775c7e14ec31 > > > Diff: https://reviews.apache.org/r/67212/diff/2/ > > > Testing > --- > > `make check` > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 67212: Used `*_SOME` macro for checking `Try` values.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67212/ --- (Updated May 29, 2018, 10:13 a.m.) Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Changes --- Fixed additional occurrences. Repository: mesos Description --- Used `*_SOME` macro for checking `Try` values. Diffs (updated) - src/tests/master_quota_tests.cpp 0692e3148829738c736b47446fdebe013211b930 src/tests/protobuf_io_tests.cpp 91c1806291fe5cd6b8ac0fcd864dce73de301fd8 src/tests/resources_tests.cpp 1201efec3ff0abc268f896c1fe2330571390b3fd src/tests/secret_generator_tests.cpp 7fd649b2bb403d943955b5df1299c5c58b2c7582 src/tests/state_tests.cpp 1a2bfb870da3e9044ee39da843da489fbe65586a src/tests/zookeeper_tests.cpp f2f9858499f1093fb05b89d36d0e2d6711222e9f src/tests/zookeeper_url_tests.cpp 498606a70e5e1ef726ea08fbb0d6775c7e14ec31 Diff: https://reviews.apache.org/r/67212/diff/2/ Changes: https://reviews.apache.org/r/67212/diff/1-2/ Testing --- `make check` Thanks, Benjamin Bannier
Re: Review Request 67212: Used `*_SOME` macro for checking `Try` values.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67212/#review203503 --- Bad patch! Reviews applied: [67212, 67211, 67210] Failed command: python support/apply-reviews.py -n -r 67211 Error: 2018-05-21 16:35:20 URL:https://reviews.apache.org/r/67211/diff/raw/ [3914/3914] -> "67211.patch" [1] error: patch failed: 3rdparty/libprocess/src/tests/jwt_tests.cpp:182 error: 3rdparty/libprocess/src/tests/jwt_tests.cpp: patch does not apply Full log: https://builds.apache.org/job/Mesos-Reviewbot/22503/console - Mesos Reviewbot On May 18, 2018, 3:35 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67212/ > --- > > (Updated May 18, 2018, 3:35 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Repository: mesos > > > Description > --- > > Used `*_SOME` macro for checking `Try` values. > > > Diffs > - > > src/tests/secret_generator_tests.cpp > 7fd649b2bb403d943955b5df1299c5c58b2c7582 > > > Diff: https://reviews.apache.org/r/67212/diff/1/ > > > Testing > --- > > `make check` > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 67212: Used `*_SOME` macro for checking `Try` values.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67212/#review203444 --- Ship it! Haven't take a good at these but they might be candidates to use the new macros: ``` $ grep '(EXPECT\|ASSERT)_(TRUE\|FALSE)(.*is(Some\|Error\|None)())' src -r src/tests/containerizer/cgroups_isolator_tests.cpp: ASSERT_FALSE(check.isError()); src/tests/containerizer/cgroups_tests.cpp: ASSERT_FALSE(hierarchy.isError()); src/tests/containerizer/cgroups_tests.cpp: EXPECT_FALSE(cpuHierarchy.isError()); src/tests/containerizer/cgroups_tests.cpp: EXPECT_FALSE(memHierarchy.isError()); src/tests/containerizer/routing_tests.cpp: EXPECT_FALSE(eth0.isError()); src/tests/containerizer/routing_tests.cpp: EXPECT_FALSE(lo.isError()); src/tests/containerizer/routing_tests.cpp: EXPECT_FALSE(gateway.isError()); src/tests/master_quota_tests.cpp:ASSERT_FALSE(status.isError()); src/tests/master_quota_tests.cpp:ASSERT_FALSE(status.isError()); src/tests/master_quota_tests.cpp:ASSERT_FALSE(status.isError()); src/tests/master_quota_tests.cpp:ASSERT_FALSE(status.isError()); src/tests/master_quota_tests.cpp:ASSERT_FALSE(status.isError()); src/tests/master_quota_tests.cpp:ASSERT_FALSE(status.isError()); src/tests/mesos.cpp: ASSERT_FALSE(hierarchy.isError()); src/tests/protobuf_io_tests.cpp: ASSERT_TRUE(read.isNone()); src/tests/protobuf_io_tests.cpp: ASSERT_TRUE(read.isNone()); src/tests/resources_tests.cpp: EXPECT_TRUE(r.mem().isNone()); src/tests/resources_tests.cpp: EXPECT_TRUE(r.ports().isNone()); src/tests/state_tests.cpp: EXPECT_TRUE(future2->isNone()); src/tests/zookeeper_tests.cpp: ASSERT_TRUE(leader->isNone()); src/tests/zookeeper_url_tests.cpp: EXPECT_TRUE(url->authentication.isNone()); src/tests/zookeeper_url_tests.cpp: EXPECT_FALSE(url->authentication.isNone()); src/tests/zookeeper_url_tests.cpp: EXPECT_FALSE(url->authentication.isNone()); src/tests/zookeeper_url_tests.cpp: EXPECT_FALSE(url->authentication.isNone()); src/tests/zookeeper_url_tests.cpp: EXPECT_FALSE(url->authentication.isNone()); src/tests/zookeeper_url_tests.cpp: EXPECT_FALSE(url->authentication.isNone()); ``` We could fix them in a follow-up patch. - Chun-Hung Hsiao On May 18, 2018, 10:35 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67212/ > --- > > (Updated May 18, 2018, 10:35 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Repository: mesos > > > Description > --- > > Used `*_SOME` macro for checking `Try` values. > > > Diffs > - > > src/tests/secret_generator_tests.cpp > 7fd649b2bb403d943955b5df1299c5c58b2c7582 > > > Diff: https://reviews.apache.org/r/67212/diff/1/ > > > Testing > --- > > `make check` > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 67212: Used `*_SOME` macro for checking `Try` values.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67212/#review203408 --- PASS: Mesos patch 67212 was successfully built and tested. Reviews applied: `['67210', '67211', '67212']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67212 - Mesos Reviewbot Windows On May 18, 2018, 10:35 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67212/ > --- > > (Updated May 18, 2018, 10:35 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Repository: mesos > > > Description > --- > > Used `*_SOME` macro for checking `Try` values. > > > Diffs > - > > src/tests/secret_generator_tests.cpp > 7fd649b2bb403d943955b5df1299c5c58b2c7582 > > > Diff: https://reviews.apache.org/r/67212/diff/1/ > > > Testing > --- > > `make check` > > > Thanks, > > Benjamin Bannier > >
Review Request 67212: Used `*_SOME` macro for checking `Try` values.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67212/ --- Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. Repository: mesos Description --- Used `*_SOME` macro for checking `Try` values. Diffs - src/tests/secret_generator_tests.cpp 7fd649b2bb403d943955b5df1299c5c58b2c7582 Diff: https://reviews.apache.org/r/67212/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier
