Re: Review Request 67282: Added python3 to list of Pylint excluded files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67282/#review203784 --- Ship it! Ship It! - Andrew Schwartzmeyer On May 24, 2018, 7:34 a.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67282/ > --- > > (Updated May 24, 2018, 7:34 a.m.) > > > Review request for mesos and Andrew Schwartzmeyer. > > > Bugs: MESOS-8770 > https://issues.apache.org/jira/browse/MESOS-8770 > > > Repository: mesos > > > Description > --- > > This change ensures that pylint will not try to lint the new Python 3 > support scripts if it is not run with Python 3. Having such a situation > results in unexpected errors such as "Unnecessary parens after 'print' > keyword". This change will not be applied in the Python 3 mesos-style. > > > Diffs > - > > support/mesos-style.py b7ee699e3898d795bfac97e88ad8e111392c0e3e > > > Diff: https://reviews.apache.org/r/67282/diff/1/ > > > Testing > --- > > Applied the entire chain, run some `git commit --amend` with and without > `export MESOSSUPPORTPYTHON=3` (rebuilding the virtualenv was also done > following this change) to see if the correct Python files were linted. > > > Thanks, > > Armand Grillet > >
Re: Review Request 67282: Added python3 to list of Pylint excluded files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67282/#review203770 --- FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['67247', '67099', '67282']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67282 Relevant logs: - [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67282/logs/mesos-tests-stdout.log): ``` [ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (110 ms) [--] 9 tests from Endpoint/SlaveEndpointTest (997 ms total) [--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (38 ms) [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (36 ms) [--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (76 ms total) [--] 1 test from IsolationFlag/CpuIsolatorTest [ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 [ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (785 ms) [--] 1 test from IsolationFlag/CpuIsolatorTest (811 ms total) [--] 1 test from IsolationFlag/MemoryIsolatorTest [ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 [ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (730 ms) [--] 1 test from IsolationFlag/MemoryIsolatorTest (754 ms total) [--] Global test environment tear-down [==] 981 tests from 95 test cases ran. (443620 ms total) [ PASSED ] 980 tests. [ FAILED ] 1 test, listed below: [ FAILED ] DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange 1 FAILED TEST YOU HAVE 220 DISABLED TESTS ``` - [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67282/logs/mesos-tests-stderr.log): ``` I0524 15:26:27.966481 15324 slave.cpp:3935] Shutting down framework 5d809c77-cd24-4d64-8e7f-8b04ac697a50- I0524 15:26:27.966481 16308 master.cpp:10843] Updating the state of task 667f58ea-9381-4ce8-bcdf-eddb3135a213 of framework 5d809c77-cd24-4d64-8e7f-8b04ac697a50- (latest state: TASK_KILLED, status update state: TASK_KILLED) I0524 15:26:27.9664I0524 15:26:27.801475 17168 exec.cpp:162] Version: 1.7.0 I0524 15:26:27.826457 9044 exec.cpp:236] Executor registered on agent 5d809c77-cd24-4d64-8e7f-8b04ac697a50-S0 I0524 15:26:27.830483 9168 executor.cpp:178] Received SUBSCRIBED event I0524 15:26:27.835469 9168 executor.cpp:182] Subscribed executor on windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net I0524 15:26:27.835469 9168 executor.cpp:178] Received LAUNCH event I0524 15:26:27.840473 9168 executor.cpp:665] Starting task 667f58ea-9381-4ce8-bcdf-eddb3135a213 I0524 15:26:27.921468 9168 executor.cpp:485] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch ' I0524 15:26:27.938468 9168 executor.cpp:678] Forked command at 8128 I0524 15:26:27.968438 19540 exec.cpp:445] Executor asked to shutdown I0524 15:26:27.968438 12604 executor.cpp:178] Received SHUTDOWN event I0524 15:26:27.969439 12604 executor.cpp:781] Shutting down I0524 15:26:27.969439 12604 executor.cpp:894] Sending SIGTERM to process tree at pid 81281 15324 slave.cpp:6656] Shutting down executor '667f58ea-9381-4ce8-bcdf-eddb3135a213' of framework 5d809c77-cd24-4d64-8e7f-8b04ac697a50- at executor(1)@192.10.1.6:63075 I0524 15:26:27.968438 15324 slave.cpp:929] Agent terminating W0524 15:26:27.968438 15324 slave.cpp:3931] Ignoring shutdown framework 5d809c77-cd24-4d64-8e7f-8b04ac697a50- because it is terminating I0524 15:26:27.968438 16308 master.cpp:10942] Removing task 667f58ea-9381-4ce8-bcdf-eddb3135a213 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 5d809c77-cd24-4d64-8e7f-8b04ac697a50- on agent 5d809c77-cd24-4d64-8e7f-8b04ac697a50-S0 at slave(448)@192.10.1.6:63054 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) I0524 15:26:27.971441 16308 master.cpp:1293] Agent 5d809c77-cd24-4d64-8e7f-8b04ac697a50-S0 at slave(448)@192.10.1.6:63054 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected I0524 15:26:27.972435 16308 master.cpp:3303] Disconnecting agent 5d809c77-cd24-4d64-8e7f-8b04ac697a50-S0 at slave(448)@192.10.1.6:63054 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) I0524 15:26:27.972435 19980 hierarchical.cpp:344] Removed framework 5d809c77-cd24-4d64-8e7f-8b04ac697a50- I0524 15:26:27.972435 16308 master.cpp:3322] Deactivating agent
Review Request 67282: Added python3 to list of Pylint excluded files.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67282/ --- Review request for mesos and Andrew Schwartzmeyer. Bugs: MESOS-8770 https://issues.apache.org/jira/browse/MESOS-8770 Repository: mesos Description --- This change ensures that pylint will not try to lint the new Python 3 support scripts if it is not run with Python 3. Having such a situation results in unexpected errors such as "Unnecessary parens after 'print' keyword". This change will not be applied in the Python 3 mesos-style. Diffs - support/mesos-style.py b7ee699e3898d795bfac97e88ad8e111392c0e3e Diff: https://reviews.apache.org/r/67282/diff/1/ Testing --- Applied the entire chain, run some `git commit --amend` with and without `export MESOSSUPPORTPYTHON=3` (rebuilding the virtualenv was also done following this change) to see if the correct Python files were linted. Thanks, Armand Grillet