Re: Review Request 68654: Enabled isort for src/python/lib.

2019-02-22 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68654/#review213086
---



Patch looks great!

Reviews applied: [68654]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Dec. 5, 2018, 5:26 p.m., Eric Chung wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68654/
> ---
> 
> (Updated Dec. 5, 2018, 5:26 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled isort for src/python/lib.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/.isort.cfg PRE-CREATION 
>   src/python/cli_new/bin/main.py 430add47d726b3de9cbd921d76b8fb17bebd4fdd 
>   src/python/cli_new/bin/settings.py 3de3387a4d4781aa784b1030f621fa2a41755a50 
>   src/python/cli_new/lib/cli/config.py 
> 7f41736357182550711dc05d83ecd6045b5559d6 
>   src/python/cli_new/lib/cli/docopt.py 
> c624175845a719c06e5c1b9840fc9eafad26907d 
>   src/python/cli_new/lib/cli/http.py 1d8fc5fcbc2b3a027db7fa49bb03160a64d395d6 
>   src/python/cli_new/lib/cli/plugins/base.py 
> e0fcbbf6250eac97f9e989a7c0852734d107dc34 
>   src/python/cli_new/lib/cli/plugins/config/main.py 
> 41bdb60e6abcb05104ffb78e7e57c4959433ab1a 
>   src/python/cli_new/lib/cli/tests/agent.py 
> 31e3e3f17fa81bdbea2e3fd41588d2a65a06e07e 
>   src/python/cli_new/lib/cli/tests/base.py 
> e3104fe1b1e76cbcf0ce6994a9bfea703b54d1d1 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 60aa4e8bdcf15bf9b9174e21a2470d15b23d81dc 
>   src/python/cli_new/tests/main.py ef02fdd6ae30ef4eaaf7fb534baed594b28349e6 
>   src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7 
>   src/python/lib/.isort.cfg PRE-CREATION 
>   src/python/lib/mesos/http.py 5a8016da50b2e1e5a81710f10a7ef65d6f4198bd 
>   src/python/lib/tests/test_exceptions.py 
> 096eab82311e02b0fa829101b6ad1b23e42ce088 
>   src/python/lib/tests/test_http.py 41a52f511318cb69c8e9976f09e2f142327544ab 
>   src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 
> 
> 
> Diff: https://reviews.apache.org/r/68654/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eric Chung
> 
>

Re: Review Request 68654: Enabled isort for src/python/lib.

2018-12-05 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68654/#review211082
---



PASS: Mesos patch 68654 was successfully built and tested.

Reviews applied: `['68654']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2675/mesos-review-68654

- Mesos Reviewbot Windows


On Dec. 6, 2018, 1:26 a.m., Eric Chung wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68654/
> ---
> 
> (Updated Dec. 6, 2018, 1:26 a.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled isort for src/python/lib.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/.isort.cfg PRE-CREATION 
>   src/python/cli_new/bin/main.py 430add47d726b3de9cbd921d76b8fb17bebd4fdd 
>   src/python/cli_new/bin/settings.py 3de3387a4d4781aa784b1030f621fa2a41755a50 
>   src/python/cli_new/lib/cli/config.py 
> 7f41736357182550711dc05d83ecd6045b5559d6 
>   src/python/cli_new/lib/cli/docopt.py 
> c624175845a719c06e5c1b9840fc9eafad26907d 
>   src/python/cli_new/lib/cli/http.py 1d8fc5fcbc2b3a027db7fa49bb03160a64d395d6 
>   src/python/cli_new/lib/cli/plugins/base.py 
> e0fcbbf6250eac97f9e989a7c0852734d107dc34 
>   src/python/cli_new/lib/cli/plugins/config/main.py 
> 41bdb60e6abcb05104ffb78e7e57c4959433ab1a 
>   src/python/cli_new/lib/cli/tests/agent.py 
> 31e3e3f17fa81bdbea2e3fd41588d2a65a06e07e 
>   src/python/cli_new/lib/cli/tests/base.py 
> e3104fe1b1e76cbcf0ce6994a9bfea703b54d1d1 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 60aa4e8bdcf15bf9b9174e21a2470d15b23d81dc 
>   src/python/cli_new/tests/main.py ef02fdd6ae30ef4eaaf7fb534baed594b28349e6 
>   src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7 
>   src/python/lib/.isort.cfg PRE-CREATION 
>   src/python/lib/mesos/http.py 5a8016da50b2e1e5a81710f10a7ef65d6f4198bd 
>   src/python/lib/tests/test_exceptions.py 
> 096eab82311e02b0fa829101b6ad1b23e42ce088 
>   src/python/lib/tests/test_http.py 41a52f511318cb69c8e9976f09e2f142327544ab 
>   src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 
> 
> 
> Diff: https://reviews.apache.org/r/68654/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eric Chung
> 
>

Re: Review Request 68654: Enabled isort for src/python/lib.

2018-12-05 Thread Eric Chung 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68654/
---

(Updated Dec. 6, 2018, 1:26 a.m.)


Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.


Repository: mesos


Description
---

Enabled isort for src/python/lib.


Diffs (updated)
-

  src/python/cli_new/.isort.cfg PRE-CREATION 
  src/python/cli_new/bin/main.py 430add47d726b3de9cbd921d76b8fb17bebd4fdd 
  src/python/cli_new/bin/settings.py 3de3387a4d4781aa784b1030f621fa2a41755a50 
  src/python/cli_new/lib/cli/config.py 7f41736357182550711dc05d83ecd6045b5559d6 
  src/python/cli_new/lib/cli/docopt.py c624175845a719c06e5c1b9840fc9eafad26907d 
  src/python/cli_new/lib/cli/http.py 1d8fc5fcbc2b3a027db7fa49bb03160a64d395d6 
  src/python/cli_new/lib/cli/plugins/base.py 
e0fcbbf6250eac97f9e989a7c0852734d107dc34 
  src/python/cli_new/lib/cli/plugins/config/main.py 
41bdb60e6abcb05104ffb78e7e57c4959433ab1a 
  src/python/cli_new/lib/cli/tests/agent.py 
31e3e3f17fa81bdbea2e3fd41588d2a65a06e07e 
  src/python/cli_new/lib/cli/tests/base.py 
e3104fe1b1e76cbcf0ce6994a9bfea703b54d1d1 
  src/python/cli_new/lib/cli/tests/tests.py 
60aa4e8bdcf15bf9b9174e21a2470d15b23d81dc 
  src/python/cli_new/tests/main.py ef02fdd6ae30ef4eaaf7fb534baed594b28349e6 
  src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7 
  src/python/lib/.isort.cfg PRE-CREATION 
  src/python/lib/mesos/http.py 5a8016da50b2e1e5a81710f10a7ef65d6f4198bd 
  src/python/lib/tests/test_exceptions.py 
096eab82311e02b0fa829101b6ad1b23e42ce088 
  src/python/lib/tests/test_http.py 41a52f511318cb69c8e9976f09e2f142327544ab 
  src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 


Diff: https://reviews.apache.org/r/68654/diff/4/

Changes: https://reviews.apache.org/r/68654/diff/3-4/


Testing
---


Thanks,

Eric Chung

Re: Review Request 68654: Enabled isort for src/python/lib.

2018-09-19 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68654/#review208752
---



PASS: Mesos patch 68654 was successfully built and tested.

Reviews applied: `['68654']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2356/mesos-review-68654

- Mesos Reviewbot Windows


On Sept. 19, 2018, 7:05 a.m., Eric Chung wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68654/
> ---
> 
> (Updated Sept. 19, 2018, 7:05 a.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled isort for src/python/lib.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/.isort.cfg PRE-CREATION 
>   src/python/cli_new/bin/main.py 27783caf4eab6ea18eee5a7b90b0dd368c8b4020 
>   src/python/cli_new/bin/settings.py 3de3387a4d4781aa784b1030f621fa2a41755a50 
>   src/python/cli_new/lib/cli/config.py 
> c88952b9f87f1cf558d7aef44803d7a24873d8bf 
>   src/python/cli_new/lib/cli/docopt.py 
> c624175845a719c06e5c1b9840fc9eafad26907d 
>   src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> fc62d9fe62001e31d254a038cd7056751c846541 
>   src/python/cli_new/lib/cli/plugins/base.py 
> 6cba828d886dcc2e1d0a00514f62d87634aafe9e 
>   src/python/cli_new/lib/cli/plugins/config/main.py 
> 41bdb60e6abcb05104ffb78e7e57c4959433ab1a 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> 644e256ce898784ce3511c30a373595ace149db9 
>   src/python/cli_new/lib/cli/tests/agent.py 
> 31e3e3f17fa81bdbea2e3fd41588d2a65a06e07e 
>   src/python/cli_new/lib/cli/tests/base.py 
> 3fb471c1f49e930d908322055bb9a188f88ee602 
>   src/python/cli_new/lib/cli/tests/task.py 
> b54ade557f579a489e459f6022807146e0211fb0 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 60aa4e8bdcf15bf9b9174e21a2470d15b23d81dc 
>   src/python/cli_new/lib/cli/util.py 7cec7e49ab3c0926067626f5bd5dbba8bf4f44d7 
>   src/python/cli_new/tests/main.py ef02fdd6ae30ef4eaaf7fb534baed594b28349e6 
>   src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7 
>   src/python/lib/.isort.cfg PRE-CREATION 
>   src/python/lib/mesos/http.py cd1587797db7d75c6b839851f0f3e5671269307c 
>   src/python/lib/setup.py 08f854f43681d1f694bb48604773256be7ce927b 
>   src/python/lib/tests/test_exceptions.py 
> 096eab82311e02b0fa829101b6ad1b23e42ce088 
>   src/python/lib/tests/test_http.py 41a52f511318cb69c8e9976f09e2f142327544ab 
>   src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 
> 
> 
> Diff: https://reviews.apache.org/r/68654/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eric Chung
> 
>

Re: Review Request 68654: Enabled isort for src/python/lib.

2018-09-19 Thread Eric Chung 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68654/
---

(Updated Sept. 19, 2018, 7:05 a.m.)


Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.


Repository: mesos


Description
---

Enabled isort for src/python/lib.


Diffs (updated)
-

  src/python/cli_new/.isort.cfg PRE-CREATION 
  src/python/cli_new/bin/main.py 27783caf4eab6ea18eee5a7b90b0dd368c8b4020 
  src/python/cli_new/bin/settings.py 3de3387a4d4781aa784b1030f621fa2a41755a50 
  src/python/cli_new/lib/cli/config.py c88952b9f87f1cf558d7aef44803d7a24873d8bf 
  src/python/cli_new/lib/cli/docopt.py c624175845a719c06e5c1b9840fc9eafad26907d 
  src/python/cli_new/lib/cli/http.py d1faac19cbe2b52ef941053ec6e2e52a1bfcd3db 
  src/python/cli_new/lib/cli/plugins/agent/main.py 
fc62d9fe62001e31d254a038cd7056751c846541 
  src/python/cli_new/lib/cli/plugins/base.py 
6cba828d886dcc2e1d0a00514f62d87634aafe9e 
  src/python/cli_new/lib/cli/plugins/config/main.py 
41bdb60e6abcb05104ffb78e7e57c4959433ab1a 
  src/python/cli_new/lib/cli/plugins/task/main.py 
644e256ce898784ce3511c30a373595ace149db9 
  src/python/cli_new/lib/cli/tests/agent.py 
31e3e3f17fa81bdbea2e3fd41588d2a65a06e07e 
  src/python/cli_new/lib/cli/tests/base.py 
3fb471c1f49e930d908322055bb9a188f88ee602 
  src/python/cli_new/lib/cli/tests/task.py 
b54ade557f579a489e459f6022807146e0211fb0 
  src/python/cli_new/lib/cli/tests/tests.py 
60aa4e8bdcf15bf9b9174e21a2470d15b23d81dc 
  src/python/cli_new/lib/cli/util.py 7cec7e49ab3c0926067626f5bd5dbba8bf4f44d7 
  src/python/cli_new/tests/main.py ef02fdd6ae30ef4eaaf7fb534baed594b28349e6 
  src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7 
  src/python/lib/.isort.cfg PRE-CREATION 
  src/python/lib/mesos/http.py cd1587797db7d75c6b839851f0f3e5671269307c 
  src/python/lib/setup.py 08f854f43681d1f694bb48604773256be7ce927b 
  src/python/lib/tests/test_exceptions.py 
096eab82311e02b0fa829101b6ad1b23e42ce088 
  src/python/lib/tests/test_http.py 41a52f511318cb69c8e9976f09e2f142327544ab 
  src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 


Diff: https://reviews.apache.org/r/68654/diff/3/

Changes: https://reviews.apache.org/r/68654/diff/2-3/


Testing
---


Thanks,

Eric Chung

Re: Review Request 68654: Enabled isort for src/python/lib.

2018-09-18 Thread Eric Chung 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68654/
---

(Updated Sept. 19, 2018, 6:30 a.m.)


Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.


Repository: mesos


Description
---

Enabled isort for src/python/lib.


Diffs (updated)
-

  src/python/lib/mesos/http.py cd1587797db7d75c6b839851f0f3e5671269307c 
  src/python/lib/setup.cfg PRE-CREATION 
  src/python/lib/setup.py 08f854f43681d1f694bb48604773256be7ce927b 
  src/python/lib/tests/test_exceptions.py 
096eab82311e02b0fa829101b6ad1b23e42ce088 
  src/python/lib/tests/test_http.py 41a52f511318cb69c8e9976f09e2f142327544ab 
  src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 


Diff: https://reviews.apache.org/r/68654/diff/2/

Changes: https://reviews.apache.org/r/68654/diff/1-2/


Testing
---


Thanks,

Eric Chung

Re: Review Request 68654: Enabled isort for src/python/lib.

2018-09-13 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68654/#review208594
---




src/python/lib/mesos/http.py
Line 33 (original), 31 (patched)


Can we set an option in `isort` to keep these imports the same as before? I 
know that klueska wanted to keep this style.



src/python/lib/setup.cfg
Lines 1 (patched)


Let's rename this file `.isort.cfg` according to the otpions offered by 
https://github.com/timothycrosley/isort/wiki/isort-Settings



src/python/lib/tox.ini
Lines 22 (patched)


Let's use the latest version, `4.3.4`.


- Armand Grillet


On Sept. 6, 2018, 9:37 a.m., Eric Chung wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68654/
> ---
> 
> (Updated Sept. 6, 2018, 9:37 a.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled isort for src/python/lib.
> 
> 
> Diffs
> -
> 
>   src/python/lib/mesos/http.py cd1587797db7d75c6b839851f0f3e5671269307c 
>   src/python/lib/setup.cfg PRE-CREATION 
>   src/python/lib/tests/test_exceptions.py 
> 096eab82311e02b0fa829101b6ad1b23e42ce088 
>   src/python/lib/tests/test_http.py 41a52f511318cb69c8e9976f09e2f142327544ab 
>   src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 
> 
> 
> Diff: https://reviews.apache.org/r/68654/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eric Chung
> 
>

Re: Review Request 68654: Enabled isort for src/python/lib.

2018-09-06 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68654/#review208401
---



PASS: Mesos patch 68654 was successfully built and tested.

Reviews applied: `['68654']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2302/mesos-review-68654

- Mesos Reviewbot Windows


On Sept. 6, 2018, 7:37 a.m., Eric Chung wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68654/
> ---
> 
> (Updated Sept. 6, 2018, 7:37 a.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled isort for src/python/lib.
> 
> 
> Diffs
> -
> 
>   src/python/lib/mesos/http.py cd1587797db7d75c6b839851f0f3e5671269307c 
>   src/python/lib/setup.cfg PRE-CREATION 
>   src/python/lib/tests/test_exceptions.py 
> 096eab82311e02b0fa829101b6ad1b23e42ce088 
>   src/python/lib/tests/test_http.py 41a52f511318cb69c8e9976f09e2f142327544ab 
>   src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 
> 
> 
> Diff: https://reviews.apache.org/r/68654/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Eric Chung
> 
>

Review Request 68654: Enabled isort for src/python/lib.

2018-09-06 Thread Eric Chung 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68654/
---

Review request for mesos, Armand Grillet, Jason Lai, and Kevin Klues.


Repository: mesos


Description
---

Enabled isort for src/python/lib.


Diffs
-

  src/python/lib/mesos/http.py cd1587797db7d75c6b839851f0f3e5671269307c 
  src/python/lib/setup.cfg PRE-CREATION 
  src/python/lib/tests/test_exceptions.py 
096eab82311e02b0fa829101b6ad1b23e42ce088 
  src/python/lib/tests/test_http.py 41a52f511318cb69c8e9976f09e2f142327544ab 
  src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69 


Diff: https://reviews.apache.org/r/68654/diff/1/


Testing
---


Thanks,

Eric Chung