Re: Review Request 70208: Added test for reconciliation of multiple operations.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70208/
---

(Updated March 20, 2019, 11:23 p.m.)


Review request for mesos, Gastón Kleiman, Joseph Wu, Megha Sharma, and Jiang 
Yan Xu.


Bugs: MESOS-9648
https://issues.apache.org/jira/browse/MESOS-9648


Repository: mesos


Description
---

Added test for reconciliation of multiple operations.


Diffs (updated)
-

  src/tests/operation_reconciliation_tests.cpp 
6a815ad694e2a608ce324715c920833f825793a0 


Diff: https://reviews.apache.org/r/70208/diff/4/

Changes: https://reviews.apache.org/r/70208/diff/3-4/


Testing
---

`bin/mesos-tests.sh --gtest_filter="*PendingAndFinishedOperations*" 
--gtest_repeat=-1 --gtest_break_on_failure`


Thanks,

Greg Mann

Re: Review Request 70208: Added test for reconciliation of multiple operations.

[Greg Mann]

> On March 20, 2019, 10:07 p.m., Joseph Wu wrote:
> > src/tests/operation_reconciliation_tests.cpp
> > Lines 233-234 (patched)
> > 
> >
> > This is un-used now.

Thanks Joseph!!


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70208/#review213858
---


On March 20, 2019, 11:23 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70208/
> ---
> 
> (Updated March 20, 2019, 11:23 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Joseph Wu, Megha Sharma, and Jiang 
> Yan Xu.
> 
> 
> Bugs: MESOS-9648
> https://issues.apache.org/jira/browse/MESOS-9648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for reconciliation of multiple operations.
> 
> 
> Diffs
> -
> 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
> 
> 
> Diff: https://reviews.apache.org/r/70208/diff/4/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh --gtest_filter="*PendingAndFinishedOperations*" 
> --gtest_repeat=-1 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70208: Added test for reconciliation of multiple operations.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70208/#review213858
---


Fix it, then Ship it!





src/tests/operation_reconciliation_tests.cpp
Lines 233-234 (patched)


This is un-used now.


- Joseph Wu


On March 15, 2019, 4:16 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70208/
> ---
> 
> (Updated March 15, 2019, 4:16 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Joseph Wu, Megha Sharma, and Jiang 
> Yan Xu.
> 
> 
> Bugs: MESOS-9648
> https://issues.apache.org/jira/browse/MESOS-9648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for reconciliation of multiple operations.
> 
> 
> Diffs
> -
> 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
> 
> 
> Diff: https://reviews.apache.org/r/70208/diff/3/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh --gtest_filter="*PendingAndFinishedOperations*" 
> --gtest_repeat=-1 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70208: Added test for reconciliation of multiple operations.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70208/#review213757
---



Patch looks great!

Reviews applied: [70200, 70208]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 15, 2019, 11:16 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70208/
> ---
> 
> (Updated March 15, 2019, 11:16 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Joseph Wu, Megha Sharma, and Jiang 
> Yan Xu.
> 
> 
> Bugs: MESOS-9648
> https://issues.apache.org/jira/browse/MESOS-9648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for reconciliation of multiple operations.
> 
> 
> Diffs
> -
> 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
> 
> 
> Diff: https://reviews.apache.org/r/70208/diff/3/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh --gtest_filter="*PendingAndFinishedOperations*" 
> --gtest_repeat=-1 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70208: Added test for reconciliation of multiple operations.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70208/
---

(Updated March 15, 2019, 11:16 p.m.)


Review request for mesos, Gastón Kleiman, Joseph Wu, Megha Sharma, and Jiang 
Yan Xu.


Bugs: MESOS-9648
https://issues.apache.org/jira/browse/MESOS-9648


Repository: mesos


Description
---

Added test for reconciliation of multiple operations.


Diffs (updated)
-

  src/tests/operation_reconciliation_tests.cpp 
6a815ad694e2a608ce324715c920833f825793a0 


Diff: https://reviews.apache.org/r/70208/diff/3/

Changes: https://reviews.apache.org/r/70208/diff/2-3/


Testing
---

`bin/mesos-tests.sh --gtest_filter="*PendingAndFinishedOperations*" 
--gtest_repeat=-1 --gtest_break_on_failure`


Thanks,

Greg Mann

Re: Review Request 70208: Added test for reconciliation of multiple operations.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70208/#review213756
---


Fix it, then Ship it!





src/tests/operation_reconciliation_tests.cpp
Lines 284-293 (patched)


We could remove this if the first operation also reserved 0.1 CPUs


- Gastón Kleiman


On March 15, 2019, 3:53 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70208/
> ---
> 
> (Updated March 15, 2019, 3:53 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Joseph Wu, Megha Sharma, and Jiang 
> Yan Xu.
> 
> 
> Bugs: MESOS-9648
> https://issues.apache.org/jira/browse/MESOS-9648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for reconciliation of multiple operations.
> 
> 
> Diffs
> -
> 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
> 
> 
> Diff: https://reviews.apache.org/r/70208/diff/2/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh --gtest_filter="*PendingAndFinishedOperations*" 
> --gtest_repeat=-1 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70208: Added test for reconciliation of multiple operations.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70208/
---

(Updated March 15, 2019, 10:53 p.m.)


Review request for mesos, Gastón Kleiman, Joseph Wu, Megha Sharma, and Jiang 
Yan Xu.


Bugs: MESOS-9648
https://issues.apache.org/jira/browse/MESOS-9648


Repository: mesos


Description (updated)
---

Added test for reconciliation of multiple operations.


Diffs (updated)
-

  src/tests/operation_reconciliation_tests.cpp 
6a815ad694e2a608ce324715c920833f825793a0 


Diff: https://reviews.apache.org/r/70208/diff/2/

Changes: https://reviews.apache.org/r/70208/diff/1-2/


Testing
---

`bin/mesos-tests.sh --gtest_filter="*PendingAndFinishedOperations*" 
--gtest_repeat=-1 --gtest_break_on_failure`


Thanks,

Greg Mann

Re: Review Request 70208: Added test for reconciliation of multiple operations.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70208/#review213753
---



Tnis test looks good — however in my experience tests which send only `RESERVE` 
opertions don't need a resource provider. Removing the instantiation of the RP 
would make remove a lot of boilerplate and some amount of clock manipulation, 
thus making the test much shorter, readable and less prone to races.

- Gastón Kleiman


On March 13, 2019, 6:41 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70208/
> ---
> 
> (Updated March 13, 2019, 6:41 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Joseph Wu, Megha Sharma, and Jiang 
> Yan Xu.
> 
> 
> Bugs: MESOS-9648
> https://issues.apache.org/jira/browse/MESOS-9648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a test to verify that operation reconciliation
> via the v1 scheduler API works correctly when multiple
> operations in different states are reconciled at the same time.
> 
> 
> Diffs
> -
> 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
> 
> 
> Diff: https://reviews.apache.org/r/70208/diff/1/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh --gtest_filter="*PendingAndFinishedOperations*" 
> --gtest_repeat=-1 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70208: Added test for reconciliation of multiple operations.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70208/#review213724
---



PASS: Mesos patch 70208 was successfully built and tested.

Reviews applied: `['70200', '70208']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2964/mesos-review-70208

- Mesos Reviewbot Windows


On March 14, 2019, 1:41 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70208/
> ---
> 
> (Updated March 14, 2019, 1:41 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Joseph Wu, Megha Sharma, and Jiang 
> Yan Xu.
> 
> 
> Bugs: MESOS-9648
> https://issues.apache.org/jira/browse/MESOS-9648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a test to verify that operation reconciliation
> via the v1 scheduler API works correctly when multiple
> operations in different states are reconciled at the same time.
> 
> 
> Diffs
> -
> 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
> 
> 
> Diff: https://reviews.apache.org/r/70208/diff/1/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh --gtest_filter="*PendingAndFinishedOperations*" 
> --gtest_repeat=-1 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70208: Added test for reconciliation of multiple operations.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70208/#review213723
---



Patch looks great!

Reviews applied: [70200, 70208]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On March 14, 2019, 1:41 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70208/
> ---
> 
> (Updated March 14, 2019, 1:41 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Joseph Wu, Megha Sharma, and Jiang 
> Yan Xu.
> 
> 
> Bugs: MESOS-9648
> https://issues.apache.org/jira/browse/MESOS-9648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a test to verify that operation reconciliation
> via the v1 scheduler API works correctly when multiple
> operations in different states are reconciled at the same time.
> 
> 
> Diffs
> -
> 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
> 
> 
> Diff: https://reviews.apache.org/r/70208/diff/1/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh --gtest_filter="*PendingAndFinishedOperations*" 
> --gtest_repeat=-1 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 70208: Added test for reconciliation of multiple operations.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70208/#review213719
---



PASS: Mesos patch 70208 was successfully built and tested.

Reviews applied: `['70200', '70208']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2963/mesos-review-70208

- Mesos Reviewbot Windows


On March 14, 2019, 1:41 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70208/
> ---
> 
> (Updated March 14, 2019, 1:41 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Joseph Wu, Megha Sharma, and Jiang 
> Yan Xu.
> 
> 
> Bugs: MESOS-9648
> https://issues.apache.org/jira/browse/MESOS-9648
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a test to verify that operation reconciliation
> via the v1 scheduler API works correctly when multiple
> operations in different states are reconciled at the same time.
> 
> 
> Diffs
> -
> 
>   src/tests/operation_reconciliation_tests.cpp 
> 6a815ad694e2a608ce324715c920833f825793a0 
> 
> 
> Diff: https://reviews.apache.org/r/70208/diff/1/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh --gtest_filter="*PendingAndFinishedOperations*" 
> --gtest_repeat=-1 --gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 70208: Added test for reconciliation of multiple operations.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70208/
---

Review request for mesos, Gastón Kleiman, Joseph Wu, Megha Sharma, and Jiang 
Yan Xu.


Bugs: MESOS-9648
https://issues.apache.org/jira/browse/MESOS-9648


Repository: mesos


Description
---

This patch adds a test to verify that operation reconciliation
via the v1 scheduler API works correctly when multiple
operations in different states are reconciled at the same time.


Diffs
-

  src/tests/operation_reconciliation_tests.cpp 
6a815ad694e2a608ce324715c920833f825793a0 


Diff: https://reviews.apache.org/r/70208/diff/1/


Testing
---

`bin/mesos-tests.sh --gtest_filter="*PendingAndFinishedOperations*" 
--gtest_repeat=-1 --gtest_break_on_failure`


Thanks,

Greg Mann