Re: Review Request 70637: Updated CHECK messages in the heirarchical allocator.

2019-05-17 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70637/#review215318
---



Patch looks great!

Reviews applied: [70661, 70637]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 16, 2019, 11:47 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70637/
> ---
> 
> (Updated May 16, 2019, 11:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The hierarchical allocator a number of has CHECKs that enforce
> the invariants about the state of roles, agents and frameworks.
> This change adds the relevant IDs to the CHECK message so that
> it is easier to track down the root cause of failures.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 875cfcd091f5f58afb89e752da5100a75828dd67 
> 
> 
> Diff: https://reviews.apache.org/r/70637/diff/2/
> 
> 
> Testing
> ---
> 
> make check (Fedora 30)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 70637: Updated CHECK messages in the heirarchical allocator.

2019-05-17 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70637/
---

(Updated May 17, 2019, 6:47 a.m.)


Review request for mesos, Benjamin Mahler and Meng Zhu.


Repository: mesos


Description
---

The hierarchical allocator a number of has CHECKs that enforce
the invariants about the state of roles, agents and frameworks.
This change adds the relevant IDs to the CHECK message so that
it is easier to track down the root cause of failures.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
875cfcd091f5f58afb89e752da5100a75828dd67 


Diff: https://reviews.apache.org/r/70637/diff/2/

Changes: https://reviews.apache.org/r/70637/diff/1-2/


Testing
---

make check (Fedora 30)


Thanks,

James Peach

Re: Review Request 70637: Updated CHECK messages in the heirarchical allocator.

2019-05-14 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70637/#review215241
---



Patch looks great!

Reviews applied: [70637]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 14, 2019, 5:43 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70637/
> ---
> 
> (Updated May 14, 2019, 5:43 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The hierarchical allocator a number of has CHECKs that enforce
> the invariants about the state of roles, agents and frameworks.
> This change adds the relevant IDs to the CHECK message so that
> it is easier to track down the root cause of failures.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 875cfcd091f5f58afb89e752da5100a75828dd67 
> 
> 
> Diff: https://reviews.apache.org/r/70637/diff/1/
> 
> 
> Testing
> ---
> 
> make check (Fedora 30)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 70637: Updated CHECK messages in the heirarchical allocator.

2019-05-14 Thread Meng Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70637/#review215240
---


Fix it, then Ship it!




Thanks for adding this!


src/master/allocator/mesos/hierarchical.cpp
Lines 302 (patched)


I am not sure if there is any precedence of using `=`, maybe just a space?



src/master/allocator/mesos/hierarchical.cpp
Line 2565 (original), 2584 (patched)


Print both `frameworkId` and `role`?


- Meng Zhu


On May 13, 2019, 10:43 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70637/
> ---
> 
> (Updated May 13, 2019, 10:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The hierarchical allocator a number of has CHECKs that enforce
> the invariants about the state of roles, agents and frameworks.
> This change adds the relevant IDs to the CHECK message so that
> it is easier to track down the root cause of failures.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 875cfcd091f5f58afb89e752da5100a75828dd67 
> 
> 
> Diff: https://reviews.apache.org/r/70637/diff/1/
> 
> 
> Testing
> ---
> 
> make check (Fedora 30)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 70637: Updated CHECK messages in the heirarchical allocator.

2019-05-13 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70637/
---

Review request for mesos, Benjamin Mahler and Meng Zhu.


Repository: mesos


Description
---

The hierarchical allocator a number of has CHECKs that enforce
the invariants about the state of roles, agents and frameworks.
This change adds the relevant IDs to the CHECK message so that
it is easier to track down the root cause of failures.


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
875cfcd091f5f58afb89e752da5100a75828dd67 


Diff: https://reviews.apache.org/r/70637/diff/1/


Testing
---

make check (Fedora 30)


Thanks,

James Peach