Re: Review Request 70651: Notifies master `/api/v1` subscribers about recovered frameworks.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70651/#review215492
---



Patch looks great!

Reviews applied: [70702, 70651]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 23, 2019, 4:17 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70651/
> ---
> 
> (Updated May 23, 2019, 4:17 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-9785
> https://issues.apache.org/jira/browse/MESOS-9785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If one subscribes to master's `/api/v1` endpoint after a master failover
> but before an agent reregistration, frameworks recovered through the
> agent registration should be notified to the subscriber, otherwise
> recovered tasks will have framework IDs referring to frameworks unknown
> to the subscriber.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.cpp 8b252cb11e17356836988dfc44a63953579a1def 
>   src/master/master.cpp 4d7c37cf8814e45432b3fe15173f5343676a372b 
>   src/tests/api_tests.cpp 37d0cb11ddb24b32f1e83feefe168f2aa2eb659c 
> 
> 
> Diff: https://reviews.apache.org/r/70651/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70651: Notifies master `/api/v1` subscribers about recovered frameworks.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70651/#review215482
---



Patch looks great!

Reviews applied: [70702, 70651]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 23, 2019, 4:17 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70651/
> ---
> 
> (Updated May 23, 2019, 4:17 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-9785
> https://issues.apache.org/jira/browse/MESOS-9785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If one subscribes to master's `/api/v1` endpoint after a master failover
> but before an agent reregistration, frameworks recovered through the
> agent registration should be notified to the subscriber, otherwise
> recovered tasks will have framework IDs referring to frameworks unknown
> to the subscriber.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.cpp 8b252cb11e17356836988dfc44a63953579a1def 
>   src/master/master.cpp 4d7c37cf8814e45432b3fe15173f5343676a372b 
>   src/tests/api_tests.cpp 37d0cb11ddb24b32f1e83feefe168f2aa2eb659c 
> 
> 
> Diff: https://reviews.apache.org/r/70651/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70651: Notifies master `/api/v1` subscribers about recovered frameworks.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70651/
---

(Updated May 23, 2019, 4:17 a.m.)


Review request for mesos and Greg Mann.


Bugs: MESOS-9785
https://issues.apache.org/jira/browse/MESOS-9785


Repository: mesos


Description
---

If one subscribes to master's `/api/v1` endpoint after a master failover
but before an agent reregistration, frameworks recovered through the
agent registration should be notified to the subscriber, otherwise
recovered tasks will have framework IDs referring to frameworks unknown
to the subscriber.


Diffs
-

  src/common/protobuf_utils.cpp 8b252cb11e17356836988dfc44a63953579a1def 
  src/master/master.cpp 4d7c37cf8814e45432b3fe15173f5343676a372b 
  src/tests/api_tests.cpp 37d0cb11ddb24b32f1e83feefe168f2aa2eb659c 


Diff: https://reviews.apache.org/r/70651/diff/3/


Testing
---

make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 70651: Notifies master `/api/v1` subscribers about recovered frameworks.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70651/#review215479
---



Patch looks great!

Reviews applied: [70651]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 22, 2019, 9:41 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70651/
> ---
> 
> (Updated May 22, 2019, 9:41 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-9785
> https://issues.apache.org/jira/browse/MESOS-9785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If one subscribes to master's `/api/v1` endpoint after a master failover
> but before an agent reregistration, frameworks recovered through the
> agent registration should be notified to the subscriber, otherwise
> recovered tasks will have framework IDs referring to frameworks unknown
> to the subscriber.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.cpp 8b252cb11e17356836988dfc44a63953579a1def 
>   src/master/master.cpp 4d7c37cf8814e45432b3fe15173f5343676a372b 
>   src/tests/api_tests.cpp 37d0cb11ddb24b32f1e83feefe168f2aa2eb659c 
> 
> 
> Diff: https://reviews.apache.org/r/70651/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70651: Notifies master `/api/v1` subscribers about recovered frameworks.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70651/
---

(Updated May 22, 2019, 9:41 p.m.)


Review request for mesos and Greg Mann.


Changes
---

Addressed Greg's comments.


Bugs: MESOS-9785
https://issues.apache.org/jira/browse/MESOS-9785


Repository: mesos


Description
---

If one subscribes to master's `/api/v1` endpoint after a master failover
but before an agent reregistration, frameworks recovered through the
agent registration should be notified to the subscriber, otherwise
recovered tasks will have framework IDs referring to frameworks unknown
to the subscriber.


Diffs (updated)
-

  src/common/protobuf_utils.cpp 8b252cb11e17356836988dfc44a63953579a1def 
  src/master/master.cpp 4d7c37cf8814e45432b3fe15173f5343676a372b 
  src/tests/api_tests.cpp 37d0cb11ddb24b32f1e83feefe168f2aa2eb659c 


Diff: https://reviews.apache.org/r/70651/diff/2/

Changes: https://reviews.apache.org/r/70651/diff/1-2/


Testing
---

make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 70651: Notifies master `/api/v1` subscribers about recovered frameworks.

[Chun-Hung Hsiao]

> On May 17, 2019, 10:16 a.m., Greg Mann wrote:
> > src/tests/api_tests.cpp
> > Lines 2774 (patched)
> > 
> >
> > Nit: make this a const ref?
> 
> Chun-Hung Hsiao wrote:
> This is copied because `event` is overwritten later. Do you think that 
> it's okay to use a ref, since we don't access to it afterwards?
> 
> Greg Mann wrote:
> As long as `agentAdded` isn't modified, we can make it a const ref? I was 
> suggesting we do the same thing with `agentAdded` that we do previously in 
> this test with `getState`:
> ```
> const v1::master::Response::GetState& getState =
>   event->get().subscribed().get_state();
> ```
> 
> Chun-Hung Hsiao wrote:
> The problem is that `event->get()` will be destructed once `event` is 
> overwritten, so the ref, const or not, will no longer be valid. So making a 
> copy is a bit safer (if anyone touches this test in the future).
> 
> Greg Mann wrote:
> But it looks like we already use the const ref pattern in this test? It 
> seems best to me to just be consistent, but I don't have strong feelings. If 
> you don't want to change it, you can drop the issues.

Given that it's not very likely we'll change this test to access these 
references in the future, I'll take your suggestion for consistency :)


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70651/#review215319
---


On May 16, 2019, 5:11 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70651/
> ---
> 
> (Updated May 16, 2019, 5:11 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-9785
> https://issues.apache.org/jira/browse/MESOS-9785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If one subscribes to master's `/api/v1` endpoint after a master failover
> but before an agent reregistration, frameworks recovered through the
> agent registration should be notified to the subscriber, otherwise
> recovered tasks will have framework IDs referring to frameworks unknown
> to the subscriber.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.cpp 8b252cb11e17356836988dfc44a63953579a1def 
>   src/master/master.cpp 6c0e30bff3fbfe0ad1f3af44eb3df6f82048f0e1 
>   src/tests/api_tests.cpp bc19d7e9661f091aebf3072967548c7c3196239d 
> 
> 
> Diff: https://reviews.apache.org/r/70651/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70651: Notifies master `/api/v1` subscribers about recovered frameworks.

[Greg Mann]

> On May 17, 2019, 10:16 a.m., Greg Mann wrote:
> > src/tests/api_tests.cpp
> > Lines 2774 (patched)
> > 
> >
> > Nit: make this a const ref?
> 
> Chun-Hung Hsiao wrote:
> This is copied because `event` is overwritten later. Do you think that 
> it's okay to use a ref, since we don't access to it afterwards?
> 
> Greg Mann wrote:
> As long as `agentAdded` isn't modified, we can make it a const ref? I was 
> suggesting we do the same thing with `agentAdded` that we do previously in 
> this test with `getState`:
> ```
> const v1::master::Response::GetState& getState =
>   event->get().subscribed().get_state();
> ```
> 
> Chun-Hung Hsiao wrote:
> The problem is that `event->get()` will be destructed once `event` is 
> overwritten, so the ref, const or not, will no longer be valid. So making a 
> copy is a bit safer (if anyone touches this test in the future).

But it looks like we already use the const ref pattern in this test? It seems 
best to me to just be consistent, but I don't have strong feelings. If you 
don't want to change it, you can drop the issues.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70651/#review215319
---


On May 16, 2019, 5:11 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70651/
> ---
> 
> (Updated May 16, 2019, 5:11 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-9785
> https://issues.apache.org/jira/browse/MESOS-9785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If one subscribes to master's `/api/v1` endpoint after a master failover
> but before an agent reregistration, frameworks recovered through the
> agent registration should be notified to the subscriber, otherwise
> recovered tasks will have framework IDs referring to frameworks unknown
> to the subscriber.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.cpp 8b252cb11e17356836988dfc44a63953579a1def 
>   src/master/master.cpp 6c0e30bff3fbfe0ad1f3af44eb3df6f82048f0e1 
>   src/tests/api_tests.cpp bc19d7e9661f091aebf3072967548c7c3196239d 
> 
> 
> Diff: https://reviews.apache.org/r/70651/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70651: Notifies master `/api/v1` subscribers about recovered frameworks.

[Chun-Hung Hsiao]

> On May 17, 2019, 10:16 a.m., Greg Mann wrote:
> > src/tests/api_tests.cpp
> > Lines 2774 (patched)
> > 
> >
> > Nit: make this a const ref?
> 
> Chun-Hung Hsiao wrote:
> This is copied because `event` is overwritten later. Do you think that 
> it's okay to use a ref, since we don't access to it afterwards?
> 
> Greg Mann wrote:
> As long as `agentAdded` isn't modified, we can make it a const ref? I was 
> suggesting we do the same thing with `agentAdded` that we do previously in 
> this test with `getState`:
> ```
> const v1::master::Response::GetState& getState =
>   event->get().subscribed().get_state();
> ```

The problem is that `event->get()` will be destructed once `event` is 
overwritten, so the ref, const or not, will no longer be valid. So making a 
copy is a bit safer (if anyone touches this test in the future).


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70651/#review215319
---


On May 16, 2019, 5:11 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70651/
> ---
> 
> (Updated May 16, 2019, 5:11 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-9785
> https://issues.apache.org/jira/browse/MESOS-9785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If one subscribes to master's `/api/v1` endpoint after a master failover
> but before an agent reregistration, frameworks recovered through the
> agent registration should be notified to the subscriber, otherwise
> recovered tasks will have framework IDs referring to frameworks unknown
> to the subscriber.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.cpp 8b252cb11e17356836988dfc44a63953579a1def 
>   src/master/master.cpp 6c0e30bff3fbfe0ad1f3af44eb3df6f82048f0e1 
>   src/tests/api_tests.cpp bc19d7e9661f091aebf3072967548c7c3196239d 
> 
> 
> Diff: https://reviews.apache.org/r/70651/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70651: Notifies master `/api/v1` subscribers about recovered frameworks.

[Greg Mann]

> On May 17, 2019, 10:16 a.m., Greg Mann wrote:
> > src/tests/api_tests.cpp
> > Lines 2774 (patched)
> > 
> >
> > Nit: make this a const ref?
> 
> Chun-Hung Hsiao wrote:
> This is copied because `event` is overwritten later. Do you think that 
> it's okay to use a ref, since we don't access to it afterwards?

As long as `agentAdded` isn't modified, we can make it a const ref? I was 
suggesting we do the same thing with `agentAdded` that we do previously in this 
test with `getState`:
```
const v1::master::Response::GetState& getState =
  event->get().subscribed().get_state();
```


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70651/#review215319
---


On May 16, 2019, 5:11 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70651/
> ---
> 
> (Updated May 16, 2019, 5:11 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-9785
> https://issues.apache.org/jira/browse/MESOS-9785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If one subscribes to master's `/api/v1` endpoint after a master failover
> but before an agent reregistration, frameworks recovered through the
> agent registration should be notified to the subscriber, otherwise
> recovered tasks will have framework IDs referring to frameworks unknown
> to the subscriber.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.cpp 8b252cb11e17356836988dfc44a63953579a1def 
>   src/master/master.cpp 6c0e30bff3fbfe0ad1f3af44eb3df6f82048f0e1 
>   src/tests/api_tests.cpp bc19d7e9661f091aebf3072967548c7c3196239d 
> 
> 
> Diff: https://reviews.apache.org/r/70651/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70651: Notifies master `/api/v1` subscribers about recovered frameworks.

[Chun-Hung Hsiao]

> On May 17, 2019, 10:16 a.m., Greg Mann wrote:
> > src/tests/api_tests.cpp
> > Lines 2774 (patched)
> > 
> >
> > Nit: make this a const ref?

This is copied because `event` is overwritten later. Do you think that it's 
okay to use a ref, since we don't access to it afterwards?


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70651/#review215319
---


On May 16, 2019, 5:11 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70651/
> ---
> 
> (Updated May 16, 2019, 5:11 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-9785
> https://issues.apache.org/jira/browse/MESOS-9785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If one subscribes to master's `/api/v1` endpoint after a master failover
> but before an agent reregistration, frameworks recovered through the
> agent registration should be notified to the subscriber, otherwise
> recovered tasks will have framework IDs referring to frameworks unknown
> to the subscriber.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.cpp 8b252cb11e17356836988dfc44a63953579a1def 
>   src/master/master.cpp 6c0e30bff3fbfe0ad1f3af44eb3df6f82048f0e1 
>   src/tests/api_tests.cpp bc19d7e9661f091aebf3072967548c7c3196239d 
> 
> 
> Diff: https://reviews.apache.org/r/70651/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70651: Notifies master `/api/v1` subscribers about recovered frameworks.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70651/#review215319
---


Fix it, then Ship it!





src/tests/api_tests.cpp
Lines 2618 (patched)


s/notified/broadcast to subscribers/



src/tests/api_tests.cpp
Lines 2774 (patched)


Nit: make this a const ref?



src/tests/api_tests.cpp
Lines 2781 (patched)


Nit: const ref?



src/tests/api_tests.cpp
Line 2782 (original), 2792 (patched)


Nit: const ref?


- Greg Mann


On May 16, 2019, 5:11 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70651/
> ---
> 
> (Updated May 16, 2019, 5:11 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-9785
> https://issues.apache.org/jira/browse/MESOS-9785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If one subscribes to master's `/api/v1` endpoint after a master failover
> but before an agent reregistration, frameworks recovered through the
> agent registration should be notified to the subscriber, otherwise
> recovered tasks will have framework IDs referring to frameworks unknown
> to the subscriber.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.cpp 8b252cb11e17356836988dfc44a63953579a1def 
>   src/master/master.cpp 6c0e30bff3fbfe0ad1f3af44eb3df6f82048f0e1 
>   src/tests/api_tests.cpp bc19d7e9661f091aebf3072967548c7c3196239d 
> 
> 
> Diff: https://reviews.apache.org/r/70651/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 70651: Notifies master `/api/v1` subscribers about recovered frameworks.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70651/#review215295
---



Patch looks great!

Reviews applied: [70651]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On May 16, 2019, 5:11 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70651/
> ---
> 
> (Updated May 16, 2019, 5:11 a.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Bugs: MESOS-9785
> https://issues.apache.org/jira/browse/MESOS-9785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If one subscribes to master's `/api/v1` endpoint after a master failover
> but before an agent reregistration, frameworks recovered through the
> agent registration should be notified to the subscriber, otherwise
> recovered tasks will have framework IDs referring to frameworks unknown
> to the subscriber.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.cpp 8b252cb11e17356836988dfc44a63953579a1def 
>   src/master/master.cpp 6c0e30bff3fbfe0ad1f3af44eb3df6f82048f0e1 
>   src/tests/api_tests.cpp bc19d7e9661f091aebf3072967548c7c3196239d 
> 
> 
> Diff: https://reviews.apache.org/r/70651/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Review Request 70651: Notifies master `/api/v1` subscribers about recovered frameworks.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70651/
---

Review request for mesos and Greg Mann.


Bugs: MESOS-9785
https://issues.apache.org/jira/browse/MESOS-9785


Repository: mesos


Description
---

If one subscribes to master's `/api/v1` endpoint after a master failover
but before an agent reregistration, frameworks recovered through the
agent registration should be notified to the subscriber, otherwise
recovered tasks will have framework IDs referring to frameworks unknown
to the subscriber.


Diffs
-

  src/common/protobuf_utils.cpp 8b252cb11e17356836988dfc44a63953579a1def 
  src/master/master.cpp 6c0e30bff3fbfe0ad1f3af44eb3df6f82048f0e1 
  src/tests/api_tests.cpp bc19d7e9661f091aebf3072967548c7c3196239d 


Diff: https://reviews.apache.org/r/70651/diff/1/


Testing
---

make check


Thanks,

Chun-Hung Hsiao