Re: Review Request 70669: Made it possible to validate against `user` and `checkpoint` updates.

2019-05-22 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70669/#review215461
---


Ship it!




Thanks! Will make the minor adjustments and get this committed.


src/master/master.cpp
Line 2686 (original), 2686 (patched)


Looking at the call sites, can we just take this by rvalue reference 
instead to avoid the copying and extra variables?



src/master/master.cpp
Line 2918 (original), 2922 (patched)


Ditto here.



src/master/validation.cpp
Line 602 (original), 615 (patched)


another newline here



src/master/validation.cpp
Lines 625 (patched)


we avoid periods in log messages

`; see MESOS-703`

Ditto below


- Benjamin Mahler


On May 22, 2019, 1:48 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70669/
> ---
> 
> (Updated May 22, 2019, 1:48 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds `user` and `checkpoint` fields of `FrameworkInfo`
> into the `validateUpdate()` function for the purpose of using this
> function to implement the UPDATE_FRAMEWORK call. To preserve the legacy
> behaviour of re-subscription which silently ignores these fields,
> the re-subscription path now explicitly sets them to their old values.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 7c9d9c3d566e29d3f8a5781ee6cdf11973a755e6 
>   src/master/validation.hpp 97c24064b127b1625a58fbc8ac189f18599b0495 
>   src/master/validation.cpp 39f5bfdb39fd6944a3e893b1587e3c2e26818d27 
>   src/tests/master_validation_tests.cpp 
> f102906a4d4fd54328e91fef33eb1b34aa6ce646 
> 
> 
> Diff: https://reviews.apache.org/r/70669/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>

Re: Review Request 70669: Made it possible to validate against `user` and `checkpoint` updates.

2019-05-22 Thread Andrei Sekretenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70669/
---

(Updated May 22, 2019, 1:48 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Fixed indentation.


Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258


Repository: mesos


Description
---

This patch adds `user` and `checkpoint` fields of `FrameworkInfo`
into the `validateUpdate()` function for the purpose of using this
function to implement the UPDATE_FRAMEWORK call. To preserve the legacy
behaviour of re-subscription which silently ignores these fields,
the re-subscription path now explicitly sets them to their old values.


Diffs (updated)
-

  src/master/master.cpp 7c9d9c3d566e29d3f8a5781ee6cdf11973a755e6 
  src/master/validation.hpp 97c24064b127b1625a58fbc8ac189f18599b0495 
  src/master/validation.cpp 39f5bfdb39fd6944a3e893b1587e3c2e26818d27 
  src/tests/master_validation_tests.cpp 
f102906a4d4fd54328e91fef33eb1b34aa6ce646 


Diff: https://reviews.apache.org/r/70669/diff/3/

Changes: https://reviews.apache.org/r/70669/diff/2-3/


Testing
---


Thanks,

Andrei Sekretenko

Re: Review Request 70669: Made it possible to validate against `user` and `checkpoint` updates.

2019-05-21 Thread Andrei Sekretenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70669/
---

(Updated May 21, 2019, 1:49 p.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258


Repository: mesos


Description
---

This patch adds `user` and `checkpoint` fields of `FrameworkInfo`
into the `validateUpdate()` function for the purpose of using this
function to implement the UPDATE_FRAMEWORK call. To preserve the legacy
behaviour of re-subscription which silently ignores these fields,
the re-subscription path now explicitly sets them to their old values.


Diffs (updated)
-

  src/master/master.cpp 24bd9572741c033c02d03a3a3a35d7d4ed8b60de 
  src/master/validation.hpp 97c24064b127b1625a58fbc8ac189f18599b0495 
  src/master/validation.cpp 39f5bfdb39fd6944a3e893b1587e3c2e26818d27 
  src/tests/master_validation_tests.cpp 
f102906a4d4fd54328e91fef33eb1b34aa6ce646 


Diff: https://reviews.apache.org/r/70669/diff/2/

Changes: https://reviews.apache.org/r/70669/diff/1-2/


Testing
---


Thanks,

Andrei Sekretenko

Review Request 70669: Made it possible to validate against `user` and `checkpoint` updates.

2019-05-17 Thread Andrei Sekretenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70669/
---

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258


Repository: mesos


Description
---

This patch adds `user` and `checkpoint` fields of `FrameworkInfo`
into the `validateUpdate()` function for the purpose of using this
function to implement the UPDATE_FRAMEWORK call. To preserve the legacy
behaviour of re-subscription which silently ignores these fields,
the re-subscription path now explicitly sets them to their old values.


Diffs
-

  src/master/master.cpp c72b92656dddca63ee89abf676da66bd76f58a6d 
  src/master/validation.hpp 95638a17052ece6c957aa76e4cead8d7bfe82024 
  src/master/validation.cpp 9fb0850987ce385d345302cac9721adead7181b8 
  src/tests/master_validation_tests.cpp 
1b7a8273f2704e0a4dedf33c55ede33dc1b1a4af 


Diff: https://reviews.apache.org/r/70669/diff/1/


Testing
---


Thanks,

Andrei Sekretenko