Re: Review Request 71977: Added systemd support to domain socket agent flag.

2020-01-12 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71977/#review219230
---



Patch looks great!

Reviews applied: [71947, 71814, 71816, 71833, 71854, 71815, 71976, 71977]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Jan. 10, 2020, 1:48 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71977/
> ---
> 
> (Updated Jan. 10, 2020, 1:48 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the ability to specify a unix domain socket
> as `systemd:` for the `--domain_socket_location`
> agent flag.
> 
> This will instruct the agent to expect the domain socket
> being passed by systemd with the specified name.
> 
> 
> Diffs
> -
> 
>   src/slave/flags.cpp 50b09cf3b0cf89568a45afd3fe89fa16c6a79222 
>   src/slave/main.cpp fd58637cd680291e6794bcdb0655603bb97744c7 
> 
> 
> Diff: https://reviews.apache.org/r/71977/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 71977: Added systemd support to domain socket agent flag.

2020-01-11 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71977/#review219224
---


Fix it, then Ship it!





src/slave/main.cpp
Lines 50 (patched)


Outdated `todo`?



src/slave/main.cpp
Lines 653 (patched)


This can be simplified to `socketFds->size() == 1`.


- Benjamin Bannier


On Jan. 10, 2020, 2:48 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71977/
> ---
> 
> (Updated Jan. 10, 2020, 2:48 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the ability to specify a unix domain socket
> as `systemd:` for the `--domain_socket_location`
> agent flag.
> 
> This will instruct the agent to expect the domain socket
> being passed by systemd with the specified name.
> 
> 
> Diffs
> -
> 
>   src/slave/flags.cpp 50b09cf3b0cf89568a45afd3fe89fa16c6a79222 
>   src/slave/main.cpp fd58637cd680291e6794bcdb0655603bb97744c7 
> 
> 
> Diff: https://reviews.apache.org/r/71977/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 71977: Added systemd support to domain socket agent flag.

2020-01-10 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71977/#review219211
---



Patch looks great!

Reviews applied: [71947, 71814, 71815, 71816, 71833, 71854, 71976, 71977]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Jan. 10, 2020, 1:48 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71977/
> ---
> 
> (Updated Jan. 10, 2020, 1:48 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the ability to specify a unix domain socket
> as `systemd:` for the `--domain_socket_location`
> agent flag.
> 
> This will instruct the agent to expect the domain socket
> being passed by systemd with the specified name.
> 
> 
> Diffs
> -
> 
>   src/slave/flags.cpp 50b09cf3b0cf89568a45afd3fe89fa16c6a79222 
>   src/slave/main.cpp fd58637cd680291e6794bcdb0655603bb97744c7 
> 
> 
> Diff: https://reviews.apache.org/r/71977/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Review Request 71977: Added systemd support to domain socket agent flag.

2020-01-09 Thread Benno Evers 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71977/
---

Review request for mesos and Benjamin Bannier.


Repository: mesos


Description
---

Added the ability to specify a unix domain socket
as `systemd:` for the `--domain_socket_location`
agent flag.

This will instruct the agent to expect the domain socket
being passed by systemd with the specified name.


Diffs
-

  src/slave/flags.cpp 50b09cf3b0cf89568a45afd3fe89fa16c6a79222 
  src/slave/main.cpp fd58637cd680291e6794bcdb0655603bb97744c7 


Diff: https://reviews.apache.org/r/71977/diff/1/


Testing
---


Thanks,

Benno Evers