[GitHub] [spark] AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-539339757 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25979: [SPARK-29295][SQL] Insert overwrite to Hive external table partition should delete old data
AmplabJenkins removed a comment on issue #25979: [SPARK-29295][SQL] Insert overwrite to Hive external table partition should delete old data URL: https://github.com/apache/spark/pull/25979#issuecomment-539342607 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16856/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25979: [SPARK-29295][SQL] Insert overwrite to Hive external table partition should delete old data
AmplabJenkins removed a comment on issue #25979: [SPARK-29295][SQL] Insert overwrite to Hive external table partition should delete old data URL: https://github.com/apache/spark/pull/25979#issuecomment-539342601 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25979: [SPARK-29295][SQL] Insert overwrite to Hive external table partition should delete old data
AmplabJenkins commented on issue #25979: [SPARK-29295][SQL] Insert overwrite to Hive external table partition should delete old data URL: https://github.com/apache/spark/pull/25979#issuecomment-539342607 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16856/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25979: [SPARK-29295][SQL] Insert overwrite to Hive external table partition should delete old data
AmplabJenkins commented on issue #25979: [SPARK-29295][SQL] Insert overwrite to Hive external table partition should delete old data URL: https://github.com/apache/spark/pull/25979#issuecomment-539342601 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25979: [SPARK-29295][SQL] Insert overwrite to Hive external table partition should delete old data
SparkQA commented on issue #25979: [SPARK-29295][SQL] Insert overwrite to Hive external table partition should delete old data URL: https://github.com/apache/spark/pull/25979#issuecomment-539341845 **[Test build #111876 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111876/testReport)** for PR 25979 at commit [`4df8a79`](https://github.com/apache/spark/commit/4df8a791ccb10d1f3a0c2c7920abad90450aed2c). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
AmplabJenkins removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-539339766 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111865/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
SparkQA removed a comment on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-539289335 **[Test build #111865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111865/testReport)** for PR 25001 at commit [`134fd1f`](https://github.com/apache/spark/commit/134fd1f5651f1b05cd60e4deb47430a09593). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-539339757 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
AmplabJenkins commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-539339766 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111865/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] zhengruifeng commented on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs
zhengruifeng commented on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#issuecomment-539339480 @imatiach-msft Thanks for reviewing! As to the points on *weighted* prediction error: After previous discussions, we should sample the data without weights, and pass the weights into the base model (decision tree). So the input passed to a decsion tree, should contain the label (unweighted prediction error) and the instance weights (which will be also used in `minWeightFractionPerNode`). In this way, I guess we do not need to cache weighted error. Moreover, the code `predError.values.mean()` with weighted `predError` is not equal to the average weighted error in this PR. PS: If I recall correctly, XGBoost pass weighted gradients and hessions into base learner. It use minimum hession (`min_child_weight`) to limit tree growth, which is quite different from MLLIB. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
SparkQA commented on issue #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#issuecomment-539339256 **[Test build #111865 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111865/testReport)** for PR 25001 at commit [`134fd1f`](https://github.com/apache/spark/commit/134fd1f5651f1b05cd60e4deb47430a09593). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #26041: [WIP][SPARK-29378][INFRA][R] Make AppVeyor's SparkR with Arrow tests compatible with Arrow R 0.15
HyukjinKwon commented on issue #26041: [WIP][SPARK-29378][INFRA][R] Make AppVeyor's SparkR with Arrow tests compatible with Arrow R 0.15 URL: https://github.com/apache/spark/pull/26041#issuecomment-539336821 Hm, setting `ARROW_PRE_0_15_IPC_FORMAT` to `1` doesn't seem working in SparkR case. I tested this both in Windows (via AppVeyor) and Ubuntu This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)
AmplabJenkins commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1) URL: https://github.com/apache/spark/pull/25816#issuecomment-539336326 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)
AmplabJenkins removed a comment on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1) URL: https://github.com/apache/spark/pull/25816#issuecomment-539336330 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111862/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)
AmplabJenkins commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1) URL: https://github.com/apache/spark/pull/25816#issuecomment-539336330 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111862/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)
AmplabJenkins removed a comment on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1) URL: https://github.com/apache/spark/pull/25816#issuecomment-539336326 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #26050: [MINOR][BUILD] Fix an incorrect path in license file.
HyukjinKwon closed pull request #26050: [MINOR][BUILD] Fix an incorrect path in license file. URL: https://github.com/apache/spark/pull/26050 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)
SparkQA removed a comment on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1) URL: https://github.com/apache/spark/pull/25816#issuecomment-539279140 **[Test build #111862 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111862/testReport)** for PR 25816 at commit [`3a5825c`](https://github.com/apache/spark/commit/3a5825c277ecfdf7e504e4542e4b2c39cc0bd892). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #26050: [MINOR][BUILD] Fix an incorrect path in license file.
HyukjinKwon commented on issue #26050: [MINOR][BUILD] Fix an incorrect path in license file. URL: https://github.com/apache/spark/pull/26050#issuecomment-539336057 Merged to master and branch-2.4. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1)
SparkQA commented on issue #25816: [SPARK-29107][SQL][TESTS] Port window.sql (Part 1) URL: https://github.com/apache/spark/pull/25816#issuecomment-539335560 **[Test build #111862 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111862/testReport)** for PR 25816 at commit [`3a5825c`](https://github.com/apache/spark/commit/3a5825c277ecfdf7e504e4542e4b2c39cc0bd892). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2
AngersZh commented on a change in pull request #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2 URL: https://github.com/apache/spark/pull/25984#discussion_r332337523 ## File path: LICENSE-binary ## @@ -369,11 +369,6 @@ org.datanucleus:datanucleus-api-jdo org.datanucleus:datanucleus-core org.datanucleus:datanucleus-rdbms org.lz4:lz4-java -org.spark-project.hive:hive-beeline -org.spark-project.hive:hive-cli -org.spark-project.hive:hive-exec -org.spark-project.hive:hive-jdbc -org.spark-project.hive:hive-metastore Review comment: cc @srowen This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2
AngersZh commented on a change in pull request #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2 URL: https://github.com/apache/spark/pull/25984#discussion_r332337569 ## File path: NOTICE-binary ## @@ -1140,18 +1140,36 @@ limitations under the License. dropwizard-metrics-hadoop-metrics2-reporter Copyright 2016 Josh Elser +Hive Beeline +Copyright 2019 The Apache Software Foundation + +Hive CLI +Copyright 2019 The Apache Software Foundation + Hive Common Copyright 2019 The Apache Software Foundation +Hive JDBC +Copyright 2019 The Apache Software Foundation + +Hive Query Language +Copyright 2019 The Apache Software Foundation + Hive Llap Common Copyright 2019 The Apache Software Foundation +Hive Metastore +Copyright 2019 The Apache Software Foundation + Hive Serde Copyright 2019 The Apache Software Foundation Hive Service RPC Copyright 2019 The Apache Software Foundation +Hive Shims +Copyright 2019 The Apache Software Foundation + Review comment: @srowen Hive jar notice added This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] wangyum commented on issue #26014: [SPARK-29349][SQL] Support FETCH_PRIOR in Thriftserver fetch request
wangyum commented on issue #26014: [SPARK-29349][SQL] Support FETCH_PRIOR in Thriftserver fetch request URL: https://github.com/apache/spark/pull/26014#issuecomment-539326158 @juliuszsompolski Thank you for ping me. I will review it later. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] wangyum commented on issue #22903: [SPARK-24196][SQL] Implement Spark's own GetSchemasOperation
wangyum commented on issue #22903: [SPARK-24196][SQL] Implement Spark's own GetSchemasOperation URL: https://github.com/apache/spark/pull/22903#issuecomment-539323462 @shgriffi This is a new feature of Spark 3.0. We will release the Spark 3.0 preview soon. https://issues.apache.org/jira/browse/SPARK-28426 http://apache-spark-developers-list.1001551.n3.nabble.com/Spark-3-0-preview-release-feature-list-and-major-changes-td28050.html http://apache-spark-developers-list.1001551.n3.nabble.com/Spark-3-0-preview-release-on-going-features-discussion-td27957.html This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2
SparkQA commented on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2 URL: https://github.com/apache/spark/pull/25984#issuecomment-539321776 **[Test build #111875 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111875/testReport)** for PR 25984 at commit [`cc36db9`](https://github.com/apache/spark/commit/cc36db96f0d70c4dfb232e437ebf1d14f190738b). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2
AmplabJenkins removed a comment on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2 URL: https://github.com/apache/spark/pull/25984#issuecomment-539320091 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2
AmplabJenkins removed a comment on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2 URL: https://github.com/apache/spark/pull/25984#issuecomment-539320095 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16855/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2
AmplabJenkins commented on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2 URL: https://github.com/apache/spark/pull/25984#issuecomment-539320091 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2
AmplabJenkins commented on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2 URL: https://github.com/apache/spark/pull/25984#issuecomment-539320095 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16855/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2
SparkQA commented on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2 URL: https://github.com/apache/spark/pull/25984#issuecomment-539319570 **[Test build #111874 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111874/testReport)** for PR 25984 at commit [`143afd3`](https://github.com/apache/spark/commit/143afd3d0b6a2ad331fd2e9c16899e85f6449ee5). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method
HyukjinKwon closed pull request #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method URL: https://github.com/apache/spark/pull/26049 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method
dongjoon-hyun commented on issue #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method URL: https://github.com/apache/spark/pull/26049#issuecomment-539316714 Thank you so much, @HyukjinKwon ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method
HyukjinKwon commented on issue #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method URL: https://github.com/apache/spark/pull/26049#issuecomment-539316637 Merged to master. We don't run this in PR builder anyway. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method
dongjoon-hyun commented on issue #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method URL: https://github.com/apache/spark/pull/26049#issuecomment-539315396 Thank you for review and approval, @HyukjinKwon . This is the last one to resolve the umbrella issue, https://issues.apache.org/jira/browse/SPARK-25475 . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #25869: [SPARK-29189][SQL] Add an option to ignore block locations when listing file
wangyum commented on a change in pull request #25869: [SPARK-29189][SQL] Add an
option to ignore block locations when listing file
URL: https://github.com/apache/spark/pull/25869#discussion_r332331885
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##
@@ -832,6 +832,17 @@ object SQLConf {
.intConf
.createWithDefault(1)
+ val IGNORE_DATA_LOCALITY =
+buildConf("spark.sql.sources.ignore.datalocality")
Review comment:
@wangshisan Could you submit a follow-up PR to rename it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26050: [MINOR][BUILD] Fix an incorrect path in license file.
AmplabJenkins commented on issue #26050: [MINOR][BUILD] Fix an incorrect path in license file. URL: https://github.com/apache/spark/pull/26050#issuecomment-539314515 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16854/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26050: [MINOR][BUILD] Fix an incorrect path in license file.
AmplabJenkins commented on issue #26050: [MINOR][BUILD] Fix an incorrect path in license file. URL: https://github.com/apache/spark/pull/26050#issuecomment-539314502 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26050: [MINOR][BUILD] Fix an incorrect path in license file.
AmplabJenkins removed a comment on issue #26050: [MINOR][BUILD] Fix an incorrect path in license file. URL: https://github.com/apache/spark/pull/26050#issuecomment-539314515 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16854/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26050: [MINOR][BUILD] Fix an incorrect path in license file.
AmplabJenkins removed a comment on issue #26050: [MINOR][BUILD] Fix an incorrect path in license file. URL: https://github.com/apache/spark/pull/26050#issuecomment-539314502 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26050: [MINOR][BUILD] Fix an incorrect path in license file.
SparkQA commented on issue #26050: [MINOR][BUILD] Fix an incorrect path in license file. URL: https://github.com/apache/spark/pull/26050#issuecomment-539314031 **[Test build #111873 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111873/testReport)** for PR 26050 at commit [`dc45811`](https://github.com/apache/spark/commit/dc458114bce3046d549128aa7b0c70611e082753). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer opened a new pull request #26050: [MINOR][BUILD] Fix an incorrect path in license file.
beliefer opened a new pull request #26050: [MINOR][BUILD] Fix an incorrect path in license file. URL: https://github.com/apache/spark/pull/26050 ### What changes were proposed in this pull request? The `LICENSE` file exists a minor issue has an incorrect path. This PR will fix it. ### Why are the changes needed? This is a minor bug. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Exists UT. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26041: [SPARK-29378][INFRA][R] Make AppVeyor's SparkR with Arrow tests compatible with Arrow R 0.15
AmplabJenkins removed a comment on issue #26041: [SPARK-29378][INFRA][R] Make AppVeyor's SparkR with Arrow tests compatible with Arrow R 0.15 URL: https://github.com/apache/spark/pull/26041#issuecomment-539311823 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26041: [SPARK-29378][INFRA][R] Make AppVeyor's SparkR with Arrow tests compatible with Arrow R 0.15
AmplabJenkins removed a comment on issue #26041: [SPARK-29378][INFRA][R] Make AppVeyor's SparkR with Arrow tests compatible with Arrow R 0.15 URL: https://github.com/apache/spark/pull/26041#issuecomment-539311834 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16853/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26041: [SPARK-29378][INFRA][R] Make AppVeyor's SparkR with Arrow tests compatible with Arrow R 0.15
AmplabJenkins commented on issue #26041: [SPARK-29378][INFRA][R] Make AppVeyor's SparkR with Arrow tests compatible with Arrow R 0.15 URL: https://github.com/apache/spark/pull/26041#issuecomment-539311834 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16853/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26041: [SPARK-29378][INFRA][R] Make AppVeyor's SparkR with Arrow tests compatible with Arrow R 0.15
AmplabJenkins commented on issue #26041: [SPARK-29378][INFRA][R] Make AppVeyor's SparkR with Arrow tests compatible with Arrow R 0.15 URL: https://github.com/apache/spark/pull/26041#issuecomment-539311823 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2
AmplabJenkins removed a comment on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2 URL: https://github.com/apache/spark/pull/25984#issuecomment-539310814 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26041: [SPARK-29378][INFRA][R] Make AppVeyor's SparkR with Arrow tests compatible with Arrow R 0.15
SparkQA commented on issue #26041: [SPARK-29378][INFRA][R] Make AppVeyor's SparkR with Arrow tests compatible with Arrow R 0.15 URL: https://github.com/apache/spark/pull/26041#issuecomment-539311167 **[Test build #111872 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111872/testReport)** for PR 26041 at commit [`bea530f`](https://github.com/apache/spark/commit/bea530f6df1fe1d696e7cf414381a4c251c7bf6e). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2
AmplabJenkins removed a comment on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2 URL: https://github.com/apache/spark/pull/25984#issuecomment-539310822 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111861/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method
HyukjinKwon commented on issue #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method URL: https://github.com/apache/spark/pull/26049#issuecomment-539310655 Haven't tested but given the PR description looks making sense to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2
AmplabJenkins commented on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2 URL: https://github.com/apache/spark/pull/25984#issuecomment-539310822 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111861/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2
AmplabJenkins commented on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2 URL: https://github.com/apache/spark/pull/25984#issuecomment-539310814 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2
SparkQA removed a comment on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2 URL: https://github.com/apache/spark/pull/25984#issuecomment-539275997 **[Test build #111861 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111861/testReport)** for PR 25984 at commit [`c3b0069`](https://github.com/apache/spark/commit/c3b00698e89c20bc19e03b987c423fa38bf6c554). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2
SparkQA commented on issue #25984: [WIP][SPARK-29308][BUILD] Fix incorrect dep in dev/deps/spark-deps-hadoop-3.2 URL: https://github.com/apache/spark/pull/25984#issuecomment-539310186 **[Test build #111861 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111861/testReport)** for PR 25984 at commit [`c3b0069`](https://github.com/apache/spark/commit/c3b00698e89c20bc19e03b987c423fa38bf6c554). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25947: [SPARK-29269][PYTHON][ML] Pyspark ALSModel support getters/setters
AmplabJenkins removed a comment on issue #25947: [SPARK-29269][PYTHON][ML] Pyspark ALSModel support getters/setters URL: https://github.com/apache/spark/pull/25947#issuecomment-539309111 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25947: [SPARK-29269][PYTHON][ML] Pyspark ALSModel support getters/setters
AmplabJenkins commented on issue #25947: [SPARK-29269][PYTHON][ML] Pyspark ALSModel support getters/setters URL: https://github.com/apache/spark/pull/25947#issuecomment-539309122 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111866/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26041: [SPARK-29378][INFRA][R] Make AppVeyor's SparkR with Arrow tests compatible with Arrow R 0.15
AmplabJenkins commented on issue #26041: [SPARK-29378][INFRA][R] Make AppVeyor's SparkR with Arrow tests compatible with Arrow R 0.15 URL: https://github.com/apache/spark/pull/26041#issuecomment-539309126 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26041: [SPARK-29378][INFRA][R] Make AppVeyor's SparkR with Arrow tests compatible with Arrow R 0.15
AmplabJenkins removed a comment on issue #26041: [SPARK-29378][INFRA][R] Make AppVeyor's SparkR with Arrow tests compatible with Arrow R 0.15 URL: https://github.com/apache/spark/pull/26041#issuecomment-539309131 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16852/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25947: [SPARK-29269][PYTHON][ML] Pyspark ALSModel support getters/setters
AmplabJenkins removed a comment on issue #25947: [SPARK-29269][PYTHON][ML] Pyspark ALSModel support getters/setters URL: https://github.com/apache/spark/pull/25947#issuecomment-539309122 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111866/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26041: [SPARK-29378][INFRA][R] Make AppVeyor's SparkR with Arrow tests compatible with Arrow R 0.15
AmplabJenkins removed a comment on issue #26041: [SPARK-29378][INFRA][R] Make AppVeyor's SparkR with Arrow tests compatible with Arrow R 0.15 URL: https://github.com/apache/spark/pull/26041#issuecomment-539309126 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26041: [SPARK-29378][INFRA][R] Make AppVeyor's SparkR with Arrow tests compatible with Arrow R 0.15
AmplabJenkins commented on issue #26041: [SPARK-29378][INFRA][R] Make AppVeyor's SparkR with Arrow tests compatible with Arrow R 0.15 URL: https://github.com/apache/spark/pull/26041#issuecomment-539309131 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16852/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25947: [SPARK-29269][PYTHON][ML] Pyspark ALSModel support getters/setters
AmplabJenkins commented on issue #25947: [SPARK-29269][PYTHON][ML] Pyspark ALSModel support getters/setters URL: https://github.com/apache/spark/pull/25947#issuecomment-539309111 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25947: [SPARK-29269][PYTHON][ML] Pyspark ALSModel support getters/setters
SparkQA removed a comment on issue #25947: [SPARK-29269][PYTHON][ML] Pyspark ALSModel support getters/setters URL: https://github.com/apache/spark/pull/25947#issuecomment-539293074 **[Test build #111866 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111866/testReport)** for PR 25947 at commit [`1d1f041`](https://github.com/apache/spark/commit/1d1f041ba9fc048d5657bd8caf0adbd61e5f2066). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25947: [SPARK-29269][PYTHON][ML] Pyspark ALSModel support getters/setters
SparkQA commented on issue #25947: [SPARK-29269][PYTHON][ML] Pyspark ALSModel support getters/setters URL: https://github.com/apache/spark/pull/25947#issuecomment-539308735 **[Test build #111866 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111866/testReport)** for PR 25947 at commit [`1d1f041`](https://github.com/apache/spark/commit/1d1f041ba9fc048d5657bd8caf0adbd61e5f2066). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #26045: [SPARK-29367][DOC] Add compatibility note for Arrow 0.15.0 to SQL guide
HyukjinKwon commented on a change in pull request #26045: [SPARK-29367][DOC] Add compatibility note for Arrow 0.15.0 to SQL guide URL: https://github.com/apache/spark/pull/26045#discussion_r332328686 ## File path: docs/sql-pyspark-pandas-with-arrow.md ## @@ -219,3 +219,14 @@ Note that a standard UDF (non-Pandas) will load timestamp data as Python datetim different than a Pandas timestamp. It is recommended to use Pandas time series functionality when working with timestamps in `pandas_udf`s to get the best performance, see [here](https://pandas.pydata.org/pandas-docs/stable/timeseries.html) for details. + +### Compatibiliy Setting for PyArrow >= 0.15.0 and Spark 2.3.x, 2.4.x + +Since Arrow 0.15.0, a change in the binary IPC format requires an environment variable to be set in +Spark so that PySpark maintain compatibility with versions on PyArrow 0.15.0 and above. The following can be added to `conf/spark-env.sh` to use the legacy IPC format: + +``` +ARROW_PRE_0_15_IPC_FORMAT=1 +``` + +This will instruct PyArrow >= 0.15.0 to use the legacy IPC format with the older Arrow Java that is in Spark 2.3.x and 2.4.x. Review comment: Hm, @BryanCutler do you target to upgrade and also increase minimum versions of PyArrow at SPARK-29376 (and we upgrade in JVM one too; therefore, we don't need to set the environment variable)? If so, we don't have to deal with https://github.com/apache/spark/pull/26045/files#r332285077 since Arrow with R is new in Spark 3.0. If that's the case, increasing minimum version of Arrow R to 0.15.0 is fine to me too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #26045: [SPARK-29367][DOC] Add compatibility note for Arrow 0.15.0 to SQL guide
HyukjinKwon commented on a change in pull request #26045: [SPARK-29367][DOC] Add compatibility note for Arrow 0.15.0 to SQL guide URL: https://github.com/apache/spark/pull/26045#discussion_r332328686 ## File path: docs/sql-pyspark-pandas-with-arrow.md ## @@ -219,3 +219,14 @@ Note that a standard UDF (non-Pandas) will load timestamp data as Python datetim different than a Pandas timestamp. It is recommended to use Pandas time series functionality when working with timestamps in `pandas_udf`s to get the best performance, see [here](https://pandas.pydata.org/pandas-docs/stable/timeseries.html) for details. + +### Compatibiliy Setting for PyArrow >= 0.15.0 and Spark 2.3.x, 2.4.x + +Since Arrow 0.15.0, a change in the binary IPC format requires an environment variable to be set in +Spark so that PySpark maintain compatibility with versions on PyArrow 0.15.0 and above. The following can be added to `conf/spark-env.sh` to use the legacy IPC format: + +``` +ARROW_PRE_0_15_IPC_FORMAT=1 +``` + +This will instruct PyArrow >= 0.15.0 to use the legacy IPC format with the older Arrow Java that is in Spark 2.3.x and 2.4.x. Review comment: Hm, @BryanCutler do you target to upgrade and also increase minimum versions of PyArrow at SPARK-29376 (we upgrade in JVM one too; therefore, we don't need to set the environment variable)? If so, we don't have to deal with https://github.com/apache/spark/pull/26045/files#r332285077 since Arrow with R is new in Spark 3.0. If that's the case, increasing minimum version of Arrow R to 0.15.0 is fine to me too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #26045: [SPARK-29367][DOC] Add compatibility note for Arrow 0.15.0 to SQL guide
HyukjinKwon commented on a change in pull request #26045: [SPARK-29367][DOC] Add compatibility note for Arrow 0.15.0 to SQL guide URL: https://github.com/apache/spark/pull/26045#discussion_r332328686 ## File path: docs/sql-pyspark-pandas-with-arrow.md ## @@ -219,3 +219,14 @@ Note that a standard UDF (non-Pandas) will load timestamp data as Python datetim different than a Pandas timestamp. It is recommended to use Pandas time series functionality when working with timestamps in `pandas_udf`s to get the best performance, see [here](https://pandas.pydata.org/pandas-docs/stable/timeseries.html) for details. + +### Compatibiliy Setting for PyArrow >= 0.15.0 and Spark 2.3.x, 2.4.x + +Since Arrow 0.15.0, a change in the binary IPC format requires an environment variable to be set in +Spark so that PySpark maintain compatibility with versions on PyArrow 0.15.0 and above. The following can be added to `conf/spark-env.sh` to use the legacy IPC format: + +``` +ARROW_PRE_0_15_IPC_FORMAT=1 +``` + +This will instruct PyArrow >= 0.15.0 to use the legacy IPC format with the older Arrow Java that is in Spark 2.3.x and 2.4.x. Review comment: Hm, @BryanCutler do you target to upgrade and also increase minimum versions of PyArrow at SPARK-29376 (we upgrade in JVM one too; therefore, we don't need to set the environment variable in Spark 3.0)? If so, we don't have to deal with https://github.com/apache/spark/pull/26045/files#r332285077 since Arrow with R is new in Spark 3.0. If that's the case, increasing minimum version of Arrow R to 0.15.0 is fine to me too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #26045: [SPARK-29367][DOC] Add compatibility note for Arrow 0.15.0 to SQL guide
HyukjinKwon commented on a change in pull request #26045: [SPARK-29367][DOC] Add compatibility note for Arrow 0.15.0 to SQL guide URL: https://github.com/apache/spark/pull/26045#discussion_r332328686 ## File path: docs/sql-pyspark-pandas-with-arrow.md ## @@ -219,3 +219,14 @@ Note that a standard UDF (non-Pandas) will load timestamp data as Python datetim different than a Pandas timestamp. It is recommended to use Pandas time series functionality when working with timestamps in `pandas_udf`s to get the best performance, see [here](https://pandas.pydata.org/pandas-docs/stable/timeseries.html) for details. + +### Compatibiliy Setting for PyArrow >= 0.15.0 and Spark 2.3.x, 2.4.x + +Since Arrow 0.15.0, a change in the binary IPC format requires an environment variable to be set in +Spark so that PySpark maintain compatibility with versions on PyArrow 0.15.0 and above. The following can be added to `conf/spark-env.sh` to use the legacy IPC format: + +``` +ARROW_PRE_0_15_IPC_FORMAT=1 +``` + +This will instruct PyArrow >= 0.15.0 to use the legacy IPC format with the older Arrow Java that is in Spark 2.3.x and 2.4.x. Review comment: Hm, @BryanCutler do you target to upgrade and also increase minimum versions of PyArrow at SPARK-29376? If so, we don't have to deal with https://github.com/apache/spark/pull/26045/files#r332285077 since Arrow with R is new in Spark 3.0. If that's the case, increasing minimum version of Arrow R to 0.15.0 is fine to me too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization
AmplabJenkins commented on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization URL: https://github.com/apache/spark/pull/26041#issuecomment-539306296 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16851/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization
AmplabJenkins removed a comment on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization URL: https://github.com/apache/spark/pull/26041#issuecomment-539306277 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization
AmplabJenkins commented on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization URL: https://github.com/apache/spark/pull/26041#issuecomment-539306277 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization
AmplabJenkins removed a comment on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization URL: https://github.com/apache/spark/pull/26041#issuecomment-539306296 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16851/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization
SparkQA commented on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization URL: https://github.com/apache/spark/pull/26041#issuecomment-539305583 **[Test build #111871 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111871/testReport)** for PR 26041 at commit [`f969c17`](https://github.com/apache/spark/commit/f969c17b6e57b448a0a8957bb87d76056ffaf71e). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization
AmplabJenkins removed a comment on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization URL: https://github.com/apache/spark/pull/26041#issuecomment-539303412 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization
AmplabJenkins removed a comment on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization URL: https://github.com/apache/spark/pull/26041#issuecomment-539303417 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111868/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization
SparkQA removed a comment on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization URL: https://github.com/apache/spark/pull/26041#issuecomment-539296214 **[Test build #111868 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111868/testReport)** for PR 26041 at commit [`34da71d`](https://github.com/apache/spark/commit/34da71dd28919d6099c86a8ee0e543d798524cee). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization
AmplabJenkins commented on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization URL: https://github.com/apache/spark/pull/26041#issuecomment-539303417 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111868/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization
AmplabJenkins commented on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization URL: https://github.com/apache/spark/pull/26041#issuecomment-539303412 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization
SparkQA commented on issue #26041: [DO-NOT-MERGE] Investigate Arrow 0.15 with R Arrow optimization URL: https://github.com/apache/spark/pull/26041#issuecomment-539303348 **[Test build #111868 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111868/testReport)** for PR 26041 at commit [`34da71d`](https://github.com/apache/spark/commit/34da71dd28919d6099c86a8ee0e543d798524cee). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a change in pull request #25926: [SPARK-9612][ML] Add instance weight support for GBTs
zhengruifeng commented on a change in pull request #25926: [SPARK-9612][ML] Add
instance weight support for GBTs
URL: https://github.com/apache/spark/pull/25926#discussion_r332326534
##
File path:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala
##
@@ -197,41 +215,41 @@ private[spark] object GradientBoostedTrees extends
Logging {
* containing the first i+1 trees
*/
def evaluateEachIteration(
- data: RDD[LabeledPoint],
+ data: RDD[Instance],
trees: Array[DecisionTreeRegressionModel],
treeWeights: Array[Double],
loss: OldLoss,
algo: OldAlgo.Value): Array[Double] = {
val sc = data.sparkContext
val remappedData = algo match {
- case OldAlgo.Classification => data.map(x => new LabeledPoint((x.label *
2) - 1, x.features))
+ case OldAlgo.Classification =>
+data.map(x => Instance((x.label * 2) - 1, x.weight, x.features))
case _ => data
}
val broadcastTrees = sc.broadcast(trees)
val localTreeWeights = treeWeights
-val treesIndices = trees.indices
-
-val dataCount = remappedData.count()
-val evaluation = remappedData.map { point =>
- treesIndices.map { idx =>
-val prediction = broadcastTrees.value(idx)
- .rootNode
- .predictImpl(point.features)
- .prediction
-prediction * localTreeWeights(idx)
+val numTrees = trees.length
+
+val (errSum, weightSum) = remappedData.mapPartitions { iter =>
Review comment:
in this place, I just followed preivous impl. I am neutral on it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint
cloud-fan commented on issue #25971: [SPARK-29298][CORE] Separate block manager heartbeat endpoint from driver endpoint URL: https://github.com/apache/spark/pull/25971#issuecomment-539301737 @JoshRosen I think your concern is valid but it's an existing problem. The executor has a heartbeat thread, it's possible that this thread finds out heartbeat is timeout and decides to shutdown the executor, while the block manager of this executor is still dealing with some requests. It's good to know how this problem is resolved, but I think it's very unlikely that we have a long-standing bug here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] JkSelf commented on issue #25295: [SPARK-28560][SQL] Optimize shuffle reader to local shuffle reader when smj converted to bhj in adaptive execution
JkSelf commented on issue #25295: [SPARK-28560][SQL] Optimize shuffle reader to local shuffle reader when smj converted to bhj in adaptive execution URL: https://github.com/apache/spark/pull/25295#issuecomment-539301442 Resolve the conflicts. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener
HeartSaVioR commented on a change in pull request #25943:
[WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for
(SQL)AppStatusListener
URL: https://github.com/apache/spark/pull/25943#discussion_r332311914
##
File path: core/src/main/scala/org/apache/spark/status/storeTypes.scala
##
@@ -95,6 +151,65 @@ private[spark] class StageDataWrapper(
@JsonIgnore @KVIndex("completionTime")
private def completionTime: Long =
info.completionTime.map(_.getTime).getOrElse(-1L)
+
+ def toLiveStage(jobs: Seq[LiveJob]): LiveStage = {
+val liveStage = new LiveStage
+val firstLaunchTime = if (info.firstTaskLaunchedTime.isEmpty) {
+ Long.MaxValue
+} else {
+ info.firstTaskLaunchedTime.get.getTime
+}
+val metrics = LiveEntityHelpers.createMetrics(
+ info.executorDeserializeTime,
+ info.executorDeserializeCpuTime,
+ info.executorRunTime,
+ info.executorCpuTime,
+ info.resultSize,
+ info.jvmGcTime,
+ info.resultSerializationTime,
+ info.memoryBytesSpilled,
+ info.diskBytesSpilled,
+ info.peakExecutionMemory,
+ info.inputBytes,
+ info.inputRecords,
+ info.outputBytes,
+ info.outputRecords,
+ info.shuffleRemoteBlocksFetched,
+ info.shuffleLocalBlocksFetched,
+ info.shuffleFetchWaitTime,
+ info.shuffleRemoteBytesRead,
+ info.shuffleRemoteBytesReadToDisk,
+ info.shuffleLocalBytesRead,
+ info.shuffleReadRecords,
+ info.shuffleWriteBytes,
+ info.shuffleWriteTime,
+ info.shuffleWriteRecords
+)
+val stageInfo = new StageInfo(
+ info.stageId,
+ info.attemptId,
+ info.name,
+ info.numTasks,
+ Nil, // rddInfo
+ Nil, // parentIds
+ info.details)
+liveStage.jobs = jobs
+liveStage.jobIds = jobs.map(_.jobId).toSet
+liveStage.info = stageInfo
+liveStage.status = info.status
+liveStage.description = info.description
+liveStage.schedulingPool = info.schedulingPool
+liveStage.activeTasks = info.numActiveTasks
+liveStage.completedTasks = info.numCompleteTasks
+liveStage.failedTasks = info.numFailedTasks
+liveStage.completedIndicesNum = info.numCompletedIndices
+liveStage.killedTasks = info.numKilledTasks
+liveStage.killedSummary = info.killedTasksSummary
+liveStage.firstLaunchTime = firstLaunchTime
+liveStage.localitySummary = locality
+liveStage.metrics = metrics
Review comment:
It might be better to leave a comment that `executorSummaries`,
`activeTasksPerExecutor`, `blackListedExecutors`, and `savedTasks` are computed
later from `recoverLiveEntities`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener
HeartSaVioR commented on a change in pull request #25943:
[WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for
(SQL)AppStatusListener
URL: https://github.com/apache/spark/pull/25943#discussion_r332311018
##
File path: core/src/main/scala/org/apache/spark/status/storeTypes.scala
##
@@ -95,6 +151,65 @@ private[spark] class StageDataWrapper(
@JsonIgnore @KVIndex("completionTime")
private def completionTime: Long =
info.completionTime.map(_.getTime).getOrElse(-1L)
+
+ def toLiveStage(jobs: Seq[LiveJob]): LiveStage = {
+val liveStage = new LiveStage
+val firstLaunchTime = if (info.firstTaskLaunchedTime.isEmpty) {
+ Long.MaxValue
+} else {
+ info.firstTaskLaunchedTime.get.getTime
+}
+val metrics = LiveEntityHelpers.createMetrics(
+ info.executorDeserializeTime,
+ info.executorDeserializeCpuTime,
+ info.executorRunTime,
+ info.executorCpuTime,
+ info.resultSize,
+ info.jvmGcTime,
+ info.resultSerializationTime,
+ info.memoryBytesSpilled,
+ info.diskBytesSpilled,
+ info.peakExecutionMemory,
+ info.inputBytes,
+ info.inputRecords,
+ info.outputBytes,
+ info.outputRecords,
+ info.shuffleRemoteBlocksFetched,
+ info.shuffleLocalBlocksFetched,
+ info.shuffleFetchWaitTime,
+ info.shuffleRemoteBytesRead,
+ info.shuffleRemoteBytesReadToDisk,
+ info.shuffleLocalBytesRead,
+ info.shuffleReadRecords,
+ info.shuffleWriteBytes,
+ info.shuffleWriteTime,
+ info.shuffleWriteRecords
+)
+val stageInfo = new StageInfo(
+ info.stageId,
+ info.attemptId,
+ info.name,
+ info.numTasks,
+ Nil, // rddInfo
+ Nil, // parentIds
Review comment:
`parentIds`, `taskMetrics`, `taskLocalityPreference`, `shuffleDepId` are not
assigned here as well. May want to leave comments to ensure we're OK with this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener
HeartSaVioR commented on a change in pull request #25943:
[WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for
(SQL)AppStatusListener
URL: https://github.com/apache/spark/pull/25943#discussion_r332310588
##
File path: core/src/main/scala/org/apache/spark/status/storeTypes.scala
##
@@ -95,6 +151,65 @@ private[spark] class StageDataWrapper(
@JsonIgnore @KVIndex("completionTime")
private def completionTime: Long =
info.completionTime.map(_.getTime).getOrElse(-1L)
+
+ def toLiveStage(jobs: Seq[LiveJob]): LiveStage = {
+val liveStage = new LiveStage
+val firstLaunchTime = if (info.firstTaskLaunchedTime.isEmpty) {
+ Long.MaxValue
+} else {
+ info.firstTaskLaunchedTime.get.getTime
+}
+val metrics = LiveEntityHelpers.createMetrics(
+ info.executorDeserializeTime,
+ info.executorDeserializeCpuTime,
+ info.executorRunTime,
+ info.executorCpuTime,
+ info.resultSize,
+ info.jvmGcTime,
+ info.resultSerializationTime,
+ info.memoryBytesSpilled,
+ info.diskBytesSpilled,
+ info.peakExecutionMemory,
+ info.inputBytes,
+ info.inputRecords,
+ info.outputBytes,
+ info.outputRecords,
+ info.shuffleRemoteBlocksFetched,
+ info.shuffleLocalBlocksFetched,
+ info.shuffleFetchWaitTime,
+ info.shuffleRemoteBytesRead,
+ info.shuffleRemoteBytesReadToDisk,
+ info.shuffleLocalBytesRead,
+ info.shuffleReadRecords,
+ info.shuffleWriteBytes,
+ info.shuffleWriteTime,
+ info.shuffleWriteRecords
+)
+val stageInfo = new StageInfo(
+ info.stageId,
+ info.attemptId,
+ info.name,
+ info.numTasks,
+ Nil, // rddInfo
Review comment:
Seems like `rddInfo` must be available as `toApi()` requires it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener
HeartSaVioR commented on a change in pull request #25943:
[WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for
(SQL)AppStatusListener
URL: https://github.com/apache/spark/pull/25943#discussion_r332310268
##
File path: core/src/main/scala/org/apache/spark/status/LiveEntity.scala
##
@@ -370,6 +374,8 @@ private class LiveStage extends LiveEntity {
var completedTasks = 0
var failedTasks = 0
val completedIndices = new OpenHashSet[Int]()
+ // will only be set when recover LiveStage is needed.
Review comment:
same here: Could we add `completedIndices` into new KVStore entity class,
and restore LiveStage from both StageDataWrapper and new class? Adding it to
the `StageDataWrapper` is also fine for me.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on a change in pull request #25943: [WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for (SQL)AppStatusListener
HeartSaVioR commented on a change in pull request #25943:
[WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for
(SQL)AppStatusListener
URL: https://github.com/apache/spark/pull/25943#discussion_r332311510
##
File path: core/src/main/scala/org/apache/spark/status/storeTypes.scala
##
@@ -95,6 +151,65 @@ private[spark] class StageDataWrapper(
@JsonIgnore @KVIndex("completionTime")
private def completionTime: Long =
info.completionTime.map(_.getTime).getOrElse(-1L)
+
+ def toLiveStage(jobs: Seq[LiveJob]): LiveStage = {
+val liveStage = new LiveStage
+val firstLaunchTime = if (info.firstTaskLaunchedTime.isEmpty) {
+ Long.MaxValue
+} else {
+ info.firstTaskLaunchedTime.get.getTime
+}
+val metrics = LiveEntityHelpers.createMetrics(
+ info.executorDeserializeTime,
+ info.executorDeserializeCpuTime,
+ info.executorRunTime,
+ info.executorCpuTime,
+ info.resultSize,
+ info.jvmGcTime,
+ info.resultSerializationTime,
+ info.memoryBytesSpilled,
+ info.diskBytesSpilled,
+ info.peakExecutionMemory,
+ info.inputBytes,
+ info.inputRecords,
+ info.outputBytes,
+ info.outputRecords,
+ info.shuffleRemoteBlocksFetched,
+ info.shuffleLocalBlocksFetched,
+ info.shuffleFetchWaitTime,
+ info.shuffleRemoteBytesRead,
+ info.shuffleRemoteBytesReadToDisk,
+ info.shuffleLocalBytesRead,
+ info.shuffleReadRecords,
+ info.shuffleWriteBytes,
+ info.shuffleWriteTime,
+ info.shuffleWriteRecords
+)
+val stageInfo = new StageInfo(
+ info.stageId,
+ info.attemptId,
+ info.name,
+ info.numTasks,
+ Nil, // rddInfo
+ Nil, // parentIds
+ info.details)
+liveStage.jobs = jobs
+liveStage.jobIds = jobs.map(_.jobId).toSet
+liveStage.info = stageInfo
+liveStage.status = info.status
+liveStage.description = info.description
+liveStage.schedulingPool = info.schedulingPool
+liveStage.activeTasks = info.numActiveTasks
+liveStage.completedTasks = info.numCompleteTasks
+liveStage.failedTasks = info.numFailedTasks
+liveStage.completedIndicesNum = info.numCompletedIndices
Review comment:
Here `completedIndices` is not assigned as I commented in other place.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25963: [SPARK-28137][SQL] Add Postgresql function to_number.
AmplabJenkins removed a comment on issue #25963: [SPARK-28137][SQL] Add Postgresql function to_number. URL: https://github.com/apache/spark/pull/25963#issuecomment-539299964 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #26043: [SPARK-29374][SQL] do not allow arbitrary v2 catalog as session catalog
cloud-fan commented on issue #26043: [SPARK-29374][SQL] do not allow arbitrary v2 catalog as session catalog URL: https://github.com/apache/spark/pull/26043#issuecomment-539300131 @rdblue I spent more time thinking about it and changed my mind. Can you take a look at the `Why are the changes needed` section and see if it makes sense to you? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method
AmplabJenkins removed a comment on issue #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method URL: https://github.com/apache/spark/pull/26049#issuecomment-53925 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16849/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25963: [SPARK-28137][SQL] Add Postgresql function to_number.
AmplabJenkins removed a comment on issue #25963: [SPARK-28137][SQL] Add Postgresql function to_number. URL: https://github.com/apache/spark/pull/25963#issuecomment-539299972 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16850/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method
AmplabJenkins removed a comment on issue #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method URL: https://github.com/apache/spark/pull/26049#issuecomment-539299988 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method
AmplabJenkins commented on issue #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method URL: https://github.com/apache/spark/pull/26049#issuecomment-539299988 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method
AmplabJenkins commented on issue #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method URL: https://github.com/apache/spark/pull/26049#issuecomment-53925 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16849/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25963: [SPARK-28137][SQL] Add Postgresql function to_number.
AmplabJenkins commented on issue #25963: [SPARK-28137][SQL] Add Postgresql function to_number. URL: https://github.com/apache/spark/pull/25963#issuecomment-539299972 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16850/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25963: [SPARK-28137][SQL] Add Postgresql function to_number.
AmplabJenkins commented on issue #25963: [SPARK-28137][SQL] Add Postgresql function to_number. URL: https://github.com/apache/spark/pull/25963#issuecomment-539299964 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25963: [SPARK-28137][SQL] Add Postgresql function to_number.
SparkQA commented on issue #25963: [SPARK-28137][SQL] Add Postgresql function to_number. URL: https://github.com/apache/spark/pull/25963#issuecomment-539299724 **[Test build #111870 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111870/testReport)** for PR 25963 at commit [`2a7202a`](https://github.com/apache/spark/commit/2a7202a6d06627a8e5f9042830ebe4e1f3fef257). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method
SparkQA commented on issue #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method URL: https://github.com/apache/spark/pull/26049#issuecomment-539299692 **[Test build #111869 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111869/testReport)** for PR 26049 at commit [`47227ab`](https://github.com/apache/spark/commit/47227abb09bd7d7eb08e3698fe0d4db346fba674). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #26048: [SPARK-29373][SQL][WIP] DataSourceV2: Commands should not submit a spark job
cloud-fan commented on issue #26048: [SPARK-29373][SQL][WIP] DataSourceV2: Commands should not submit a spark job URL: https://github.com/apache/spark/pull/26048#issuecomment-539299448 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method
dongjoon-hyun commented on issue #26049: [SPARK-25668][SQL][TESTS] Refactor TPCDSQueryBenchmark to use main method URL: https://github.com/apache/spark/pull/26049#issuecomment-539298723 Could you review this, @maropu and @wangyum ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
