[GitHub] [spark] AmplabJenkins commented on pull request #29519: Revert "[SPARK-32646][SQL] ORC predicate pushdown should work with case-insensitive analysis"
AmplabJenkins commented on pull request #29519: URL: https://github.com/apache/spark/pull/29519#issuecomment-678738225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29484: [SPARK-32649][SQL] Optimize BHJ/SHJ inner/semi join with empty hashed relation
SparkQA commented on pull request #29484: URL: https://github.com/apache/spark/pull/29484#issuecomment-678738205 **[Test build #127799 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127799/testReport)** for PR 29484 at commit [`496eda7`](https://github.com/apache/spark/commit/496eda790c95b1c9895967b7181d582fa87da0ff). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29521: [SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
SparkQA removed a comment on pull request #29521: URL: https://github.com/apache/spark/pull/29521#issuecomment-678736687 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29520: [SPARK-32608][SQL][FOLLOW-UP] Script Transform ROW FORMAT DELIMIT value should format value
SparkQA commented on pull request #29520: URL: https://github.com/apache/spark/pull/29520#issuecomment-678738206 **[Test build #127800 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127800/testReport)** for PR 29520 at commit [`4920376`](https://github.com/apache/spark/commit/49203764cfdaabdda9a67c1dba555b8f3531286b). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29520: [SPARK-32608][SQL][FOLLOW-UP] Script Transform ROW FORMAT DELIMIT value should format value
AmplabJenkins commented on pull request #29520: URL: https://github.com/apache/spark/pull/29520#issuecomment-678738239 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29521: [SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
SparkQA commented on pull request #29521: URL: https://github.com/apache/spark/pull/29521#issuecomment-678738204 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29521: [SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
AmplabJenkins commented on pull request #29521: URL: https://github.com/apache/spark/pull/29521#issuecomment-678738215 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29519: Revert "[SPARK-32646][SQL] ORC predicate pushdown should work with case-insensitive analysis"
SparkQA commented on pull request #29519: URL: https://github.com/apache/spark/pull/29519#issuecomment-678738203 **[Test build #127797 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127797/testReport)** for PR 29519 at commit [`cfccfa6`](https://github.com/apache/spark/commit/cfccfa645949011781ae77c5f3c93bade294599a). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29484: [SPARK-32649][SQL] Optimize BHJ/SHJ inner/semi join with empty hashed relation
AmplabJenkins commented on pull request #29484: URL: https://github.com/apache/spark/pull/29484#issuecomment-678738237 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29484: [SPARK-32649][SQL] Optimize BHJ/SHJ inner/semi join with empty hashed relation
SparkQA removed a comment on pull request #29484: URL: https://github.com/apache/spark/pull/29484#issuecomment-678735260 **[Test build #127799 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127799/testReport)** for PR 29484 at commit [`496eda7`](https://github.com/apache/spark/commit/496eda790c95b1c9895967b7181d582fa87da0ff). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29521: [SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
AmplabJenkins removed a comment on pull request #29521: URL: https://github.com/apache/spark/pull/29521#issuecomment-678738215 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29484: [SPARK-32649][SQL] Optimize BHJ/SHJ inner/semi join with empty hashed relation
AmplabJenkins removed a comment on pull request #29484: URL: https://github.com/apache/spark/pull/29484#issuecomment-678738240 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] c21 commented on pull request #29484: [SPARK-32649][SQL] Optimize BHJ/SHJ inner/semi join with empty hashed relation
c21 commented on pull request #29484: URL: https://github.com/apache/spark/pull/29484#issuecomment-678738298 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29519: Revert "[SPARK-32646][SQL] ORC predicate pushdown should work with case-insensitive analysis"
SparkQA removed a comment on pull request #29519: URL: https://github.com/apache/spark/pull/29519#issuecomment-678732756 **[Test build #127797 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127797/testReport)** for PR 29519 at commit [`cfccfa6`](https://github.com/apache/spark/commit/cfccfa645949011781ae77c5f3c93bade294599a). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29519: Revert "[SPARK-32646][SQL] ORC predicate pushdown should work with case-insensitive analysis"
AmplabJenkins removed a comment on pull request #29519: URL: https://github.com/apache/spark/pull/29519#issuecomment-678738225 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29520: [SPARK-32608][SQL][FOLLOW-UP] Script Transform ROW FORMAT DELIMIT value should format value
AmplabJenkins removed a comment on pull request #29520: URL: https://github.com/apache/spark/pull/29520#issuecomment-678738239 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29521: [SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
viirya commented on pull request #29521: URL: https://github.com/apache/spark/pull/29521#issuecomment-678738304 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29520: [SPARK-32608][SQL][FOLLOW-UP] Script Transform ROW FORMAT DELIMIT value should format value
SparkQA removed a comment on pull request #29520: URL: https://github.com/apache/spark/pull/29520#issuecomment-678736177 **[Test build #127800 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127800/testReport)** for PR 29520 at commit [`4920376`](https://github.com/apache/spark/commit/49203764cfdaabdda9a67c1dba555b8f3531286b). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29484: [SPARK-32649][SQL] Optimize BHJ/SHJ inner/semi join with empty hashed relation
SparkQA commented on pull request #29484: URL: https://github.com/apache/spark/pull/29484#issuecomment-678738382 **[Test build #127804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127804/testReport)** for PR 29484 at commit [`496eda7`](https://github.com/apache/spark/commit/496eda790c95b1c9895967b7181d582fa87da0ff). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29521: [SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
SparkQA commented on pull request #29521: URL: https://github.com/apache/spark/pull/29521#issuecomment-678738376 **[Test build #127803 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127803/testReport)** for PR 29521 at commit [`0fed503`](https://github.com/apache/spark/commit/0fed50352f0892d54486ba7f72d05e5e3e402826). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29520: [SPARK-32608][SQL][FOLLOW-UP] Script Transform ROW FORMAT DELIMIT value should format value
AmplabJenkins removed a comment on pull request #29520: URL: https://github.com/apache/spark/pull/29520#issuecomment-678738242 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127800/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29519: Revert "[SPARK-32646][SQL] ORC predicate pushdown should work with case-insensitive analysis"
AmplabJenkins removed a comment on pull request #29519: URL: https://github.com/apache/spark/pull/29519#issuecomment-678738229 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127797/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29484: [SPARK-32649][SQL] Optimize BHJ/SHJ inner/semi join with empty hashed relation
AmplabJenkins commented on pull request #29484: URL: https://github.com/apache/spark/pull/29484#issuecomment-678738448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29521: [SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
AmplabJenkins commented on pull request #29521: URL: https://github.com/apache/spark/pull/29521#issuecomment-678738457 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29484: [SPARK-32649][SQL] Optimize BHJ/SHJ inner/semi join with empty hashed relation
AmplabJenkins removed a comment on pull request #29484: URL: https://github.com/apache/spark/pull/29484#issuecomment-678738448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29521: [SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
AmplabJenkins removed a comment on pull request #29521: URL: https://github.com/apache/spark/pull/29521#issuecomment-678738457 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28991: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
SparkQA commented on pull request #28991: URL: https://github.com/apache/spark/pull/28991#issuecomment-678739007 **[Test build #127805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127805/testReport)** for PR 28991 at commit [`da76e1a`](https://github.com/apache/spark/commit/da76e1a7ba25ca96495cbb2ce56377983ee9f74f). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on pull request #28991: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
maropu commented on pull request #28991: URL: https://github.com/apache/spark/pull/28991#issuecomment-678738908 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28991: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
AmplabJenkins commented on pull request #28991: URL: https://github.com/apache/spark/pull/28991#issuecomment-678739125 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28991: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
AmplabJenkins removed a comment on pull request #28991: URL: https://github.com/apache/spark/pull/28991#issuecomment-678739125 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28991: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
AmplabJenkins commented on pull request #28991: URL: https://github.com/apache/spark/pull/28991#issuecomment-678739447 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28991: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
SparkQA commented on pull request #28991: URL: https://github.com/apache/spark/pull/28991#issuecomment-678739444 **[Test build #127805 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127805/testReport)** for PR 28991 at commit [`da76e1a`](https://github.com/apache/spark/commit/da76e1a7ba25ca96495cbb2ce56377983ee9f74f). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28991: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
SparkQA removed a comment on pull request #28991: URL: https://github.com/apache/spark/pull/28991#issuecomment-678739007 **[Test build #127805 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127805/testReport)** for PR 28991 at commit [`da76e1a`](https://github.com/apache/spark/commit/da76e1a7ba25ca96495cbb2ce56377983ee9f74f). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28991: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
AmplabJenkins removed a comment on pull request #28991: URL: https://github.com/apache/spark/pull/28991#issuecomment-678739447 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28991: [SPARK-26533][SQL][test-hive1.2][test-hadoop2.7] Support query auto timeout cancel on thriftserver
AmplabJenkins removed a comment on pull request #28991: URL: https://github.com/apache/spark/pull/28991#issuecomment-678739448 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127805/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29521: [SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
viirya commented on pull request #29521: URL: https://github.com/apache/spark/pull/29521#issuecomment-678739934 Looks good pending test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] viirya edited a comment on pull request #29519: Revert "[SPARK-32646][SQL] ORC predicate pushdown should work with case-insensitive analysis"
viirya edited a comment on pull request #29519: URL: https://github.com/apache/spark/pull/29519#issuecomment-678736805 @maropu #29457 was not merged to branch-3.0, but only to master. Currently both master and branch-3.0 have some tests failed under hive-1.2 profile. #29457 isn't the cause of these failures, see https://github.com/apache/spark/pull/29518#issuecomment-678730061. But because #29457 missed a change in hive-1.2 code that causes compilation error, so it will block testing and debugging these failed test under hive-1.2 profile. I'd like to unblock fixing the failed tests asap, so going to revert this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29521: [SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
maropu commented on pull request #29521: URL: https://github.com/apache/spark/pull/29521#issuecomment-678740729 @AngersZh btw, I think you'd better to run tests w/ `[test-hadoop2.7][test-hive1.2]` for your open TRANSFORM-related PRs, too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29519: Revert "[SPARK-32646][SQL] ORC predicate pushdown should work with case-insensitive analysis"
viirya commented on pull request #29519: URL: https://github.com/apache/spark/pull/29519#issuecomment-678740996 @maropu Can you review this? GitHub Actions was passed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29519: Revert "[SPARK-32646][SQL] ORC predicate pushdown should work with case-insensitive analysis"
maropu commented on pull request #29519: URL: https://github.com/apache/spark/pull/29519#issuecomment-678741104 I just compared the diffs with the original PR and looks okay to revert it. Thanks, @viirya . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu edited a comment on pull request #29519: Revert "[SPARK-32646][SQL] ORC predicate pushdown should work with case-insensitive analysis"
maropu edited a comment on pull request #29519: URL: https://github.com/apache/spark/pull/29519#issuecomment-678741104 I just compared the diffs with the original PR and it looks okay to revert it. Thanks, @viirya . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29519: Revert "[SPARK-32646][SQL] ORC predicate pushdown should work with case-insensitive analysis"
viirya commented on pull request #29519: URL: https://github.com/apache/spark/pull/29519#issuecomment-678741167 Thanks @maropu! Merging this to master and unblock test fixing! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] viirya closed pull request #29519: Revert "[SPARK-32646][SQL] ORC predicate pushdown should work with case-insensitive analysis"
viirya closed pull request #29519: URL: https://github.com/apache/spark/pull/29519 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29520: [SPARK-32608][SQL][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
viirya commented on pull request #29520: URL: https://github.com/apache/spark/pull/29520#issuecomment-678741405 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] viirya commented on pull request #29520: [SPARK-32608][SQL][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
viirya commented on pull request #29520: URL: https://github.com/apache/spark/pull/29520#issuecomment-678741464 Looks ok pending test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29520: [SPARK-32608][SQL][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
SparkQA commented on pull request #29520: URL: https://github.com/apache/spark/pull/29520#issuecomment-678741520 **[Test build #127806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127806/testReport)** for PR 29520 at commit [`4920376`](https://github.com/apache/spark/commit/49203764cfdaabdda9a67c1dba555b8f3531286b). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29520: [SPARK-32608][SQL][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
AmplabJenkins removed a comment on pull request #29520: URL: https://github.com/apache/spark/pull/29520#issuecomment-678741628 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29520: [SPARK-32608][SQL][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
AmplabJenkins commented on pull request #29520: URL: https://github.com/apache/spark/pull/29520#issuecomment-678741628 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #29521: [SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
AngersZh commented on pull request #29521: URL: https://github.com/apache/spark/pull/29521#issuecomment-678744020 > @AngersZh btw, I think you'd better to run tests w/ `[test-hadoop2.7][test-hive1.2]` for your open TRANSFORM-related PRs, too. Yea, missing this point before. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29521: [SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
SparkQA commented on pull request #29521: URL: https://github.com/apache/spark/pull/29521#issuecomment-678747537 **[Test build #127803 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127803/testReport)** for PR 29521 at commit [`0fed503`](https://github.com/apache/spark/commit/0fed50352f0892d54486ba7f72d05e5e3e402826). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29521: [SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
SparkQA removed a comment on pull request #29521: URL: https://github.com/apache/spark/pull/29521#issuecomment-678738376 **[Test build #127803 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127803/testReport)** for PR 29521 at commit [`0fed503`](https://github.com/apache/spark/commit/0fed50352f0892d54486ba7f72d05e5e3e402826). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29521: [SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
AmplabJenkins commented on pull request #29521: URL: https://github.com/apache/spark/pull/29521#issuecomment-678747577 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29521: [SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
AmplabJenkins removed a comment on pull request #29521: URL: https://github.com/apache/spark/pull/29521#issuecomment-678747577 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29521: [SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
AmplabJenkins removed a comment on pull request #29521: URL: https://github.com/apache/spark/pull/29521#issuecomment-678747579 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127803/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #29521: [SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
AngersZh commented on pull request #29521: URL: https://github.com/apache/spark/pull/29521#issuecomment-678748708 @viirya the failed UT not realetd to this pr and seems existed issue, is there any jira refer to this problem or need to fix this . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #29515: [SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
tanelk commented on pull request #29515: URL: https://github.com/apache/spark/pull/29515#issuecomment-678751076 There is a related issue with -0.0: https://issues.apache.org/jira/browse/SPARK-32110 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on pull request #29521: [SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
maropu commented on pull request #29521: URL: https://github.com/apache/spark/pull/29521#issuecomment-678754002 I checked the commit history and https://github.com/apache/spark/pull/29409 and https://github.com/apache/spark/pull/29417 seem to be related to the failure: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127803/ @MaxGekk Could you check it? cc: @HyukjinKwon This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29515: [SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
AmplabJenkins commented on pull request #29515: URL: https://github.com/apache/spark/pull/29515#issuecomment-678754495 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29515: [SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
AmplabJenkins removed a comment on pull request #29515: URL: https://github.com/apache/spark/pull/29515#issuecomment-678754495 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29515: [SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
SparkQA commented on pull request #29515: URL: https://github.com/apache/spark/pull/29515#issuecomment-678755006 **[Test build #127807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127807/testReport)** for PR 29515 at commit [`818abe2`](https://github.com/apache/spark/commit/818abe2382ef57bb23177570d725662c0d6f1bf6). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #29515: [SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
tanelk commented on a change in pull request #29515:
URL: https://github.com/apache/spark/pull/29515#discussion_r475200193
##
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/LiteralGenerator.scala
##
@@ -70,14 +70,22 @@ object LiteralGenerator {
lazy val floatLiteralGen: Gen[Literal] =
for {
- f <- Gen.chooseNum(Float.MinValue / 2, Float.MaxValue / 2,
-Float.NaN, Float.PositiveInfinity, Float.NegativeInfinity)
+ f <- Gen.oneOf(
+Gen.oneOf(
+ Float.NaN, Float.PositiveInfinity, Float.NegativeInfinity,
Float.MinPositiveValue,
+ 0.0f, -0.0f, 1.0f, -1.0f),
Review comment:
Sure
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29515: [SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
maropu commented on a change in pull request #29515:
URL: https://github.com/apache/spark/pull/29515#discussion_r475200399
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##
@@ -793,7 +793,9 @@ case class EqualTo(left: Expression, right: Expression)
// | FALSE | FALSE | TRUE| UNKNOWN |
// | UNKNOWN | UNKNOWN | UNKNOWN | UNKNOWN |
// +-+-+-+-+
- protected override def nullSafeEval(left: Any, right: Any): Any =
ordering.equiv(left, right)
+ protected override def nullSafeEval(left: Any, right: Any): Any = {
+left == right || ordering.equiv(left, right)
Review comment:
At least, we shoud fix the existing test failures that we found in this
PR. But, this fix looks improper, so could we use `NormalizeNaNAndZero`
instead? cc: @cloud-fan @viirya
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #29515: [SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
tanelk commented on a change in pull request #29515:
URL: https://github.com/apache/spark/pull/29515#discussion_r475201468
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##
@@ -793,7 +793,9 @@ case class EqualTo(left: Expression, right: Expression)
// | FALSE | FALSE | TRUE| UNKNOWN |
// | UNKNOWN | UNKNOWN | UNKNOWN | UNKNOWN |
// +-+-+-+-+
- protected override def nullSafeEval(left: Any, right: Any): Any =
ordering.equiv(left, right)
+ protected override def nullSafeEval(left: Any, right: Any): Any = {
+left == right || ordering.equiv(left, right)
Review comment:
`NormalizeNaNAndZero` would not fix this, because
`checkConsistencyBetweenInterpretedAndCodegen` is done without optimizers.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #29515: [SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
tanelk commented on a change in pull request #29515:
URL: https://github.com/apache/spark/pull/29515#discussion_r475201468
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##
@@ -793,7 +793,9 @@ case class EqualTo(left: Expression, right: Expression)
// | FALSE | FALSE | TRUE| UNKNOWN |
// | UNKNOWN | UNKNOWN | UNKNOWN | UNKNOWN |
// +-+-+-+-+
- protected override def nullSafeEval(left: Any, right: Any): Any =
ordering.equiv(left, right)
+ protected override def nullSafeEval(left: Any, right: Any): Any = {
+left == right || ordering.equiv(left, right)
Review comment:
`NormalizeNaNAndZero` can't help here, because
`checkConsistencyBetweenInterpretedAndCodegen` is done without optimizers.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #29515: [SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
tanelk commented on a change in pull request #29515:
URL: https://github.com/apache/spark/pull/29515#discussion_r475201468
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##
@@ -793,7 +793,9 @@ case class EqualTo(left: Expression, right: Expression)
// | FALSE | FALSE | TRUE| UNKNOWN |
// | UNKNOWN | UNKNOWN | UNKNOWN | UNKNOWN |
// +-+-+-+-+
- protected override def nullSafeEval(left: Any, right: Any): Any =
ordering.equiv(left, right)
+ protected override def nullSafeEval(left: Any, right: Any): Any = {
+left == right || ordering.equiv(left, right)
Review comment:
`NormalizeNaNAndZero` can't help here, because
`checkConsistencyBetweenInterpretedAndCodegen` is done without optimizers.
Also it could introduce new correctness issues with `atan2(-0.0, x)` and
`1.0 / -0.0`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #29515: [SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
tanelk commented on a change in pull request #29515:
URL: https://github.com/apache/spark/pull/29515#discussion_r475201468
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##
@@ -793,7 +793,9 @@ case class EqualTo(left: Expression, right: Expression)
// | FALSE | FALSE | TRUE| UNKNOWN |
// | UNKNOWN | UNKNOWN | UNKNOWN | UNKNOWN |
// +-+-+-+-+
- protected override def nullSafeEval(left: Any, right: Any): Any =
ordering.equiv(left, right)
+ protected override def nullSafeEval(left: Any, right: Any): Any = {
+left == right || ordering.equiv(left, right)
Review comment:
`NormalizeNaNAndZero` can't help here, because
`checkConsistencyBetweenInterpretedAndCodegen` is done without optimizers.
Also it could introduce new correctness issues with `atan2` and `1.0 / -0.0`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #29515: [SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
tanelk commented on a change in pull request #29515:
URL: https://github.com/apache/spark/pull/29515#discussion_r475202250
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##
@@ -793,7 +793,9 @@ case class EqualTo(left: Expression, right: Expression)
// | FALSE | FALSE | TRUE| UNKNOWN |
// | UNKNOWN | UNKNOWN | UNKNOWN | UNKNOWN |
// +-+-+-+-+
- protected override def nullSafeEval(left: Any, right: Any): Any =
ordering.equiv(left, right)
+ protected override def nullSafeEval(left: Any, right: Any): Any = {
+left == right || ordering.equiv(left, right)
Review comment:
I assumed that `0.0 == -0.0` is the expected behavior, but if it is not,
then we could leave this as it was change the code gen path.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29520: [SPARK-32608][SQL][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
SparkQA commented on pull request #29520: URL: https://github.com/apache/spark/pull/29520#issuecomment-678757148 **[Test build #127806 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127806/testReport)** for PR 29520 at commit [`4920376`](https://github.com/apache/spark/commit/49203764cfdaabdda9a67c1dba555b8f3531286b). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29520: [SPARK-32608][SQL][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
SparkQA removed a comment on pull request #29520: URL: https://github.com/apache/spark/pull/29520#issuecomment-678741520 **[Test build #127806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127806/testReport)** for PR 29520 at commit [`4920376`](https://github.com/apache/spark/commit/49203764cfdaabdda9a67c1dba555b8f3531286b). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29520: [SPARK-32608][SQL][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
AmplabJenkins removed a comment on pull request #29520: URL: https://github.com/apache/spark/pull/29520#issuecomment-678757238 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29520: [SPARK-32608][SQL][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
AmplabJenkins commented on pull request #29520: URL: https://github.com/apache/spark/pull/29520#issuecomment-678757238 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29520: [SPARK-32608][SQL][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
AmplabJenkins removed a comment on pull request #29520: URL: https://github.com/apache/spark/pull/29520#issuecomment-678757240 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127806/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #29520: [SPARK-32608][SQL][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
AngersZh commented on pull request #29520: URL: https://github.com/apache/spark/pull/29520#issuecomment-678758274 @viirya Seems this ut failed because of your pr? https://github.com/apache/spark/pull/29520#issuecomment-678757148 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29484: [SPARK-32649][SQL] Optimize BHJ/SHJ inner/semi join with empty hashed relation
SparkQA commented on pull request #29484: URL: https://github.com/apache/spark/pull/29484#issuecomment-678762333 **[Test build #127804 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127804/testReport)** for PR 29484 at commit [`496eda7`](https://github.com/apache/spark/commit/496eda790c95b1c9895967b7181d582fa87da0ff). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29484: [SPARK-32649][SQL] Optimize BHJ/SHJ inner/semi join with empty hashed relation
SparkQA removed a comment on pull request #29484: URL: https://github.com/apache/spark/pull/29484#issuecomment-678738382 **[Test build #127804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127804/testReport)** for PR 29484 at commit [`496eda7`](https://github.com/apache/spark/commit/496eda790c95b1c9895967b7181d582fa87da0ff). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29484: [SPARK-32649][SQL] Optimize BHJ/SHJ inner/semi join with empty hashed relation
AmplabJenkins removed a comment on pull request #29484: URL: https://github.com/apache/spark/pull/29484#issuecomment-678762507 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29484: [SPARK-32649][SQL] Optimize BHJ/SHJ inner/semi join with empty hashed relation
AmplabJenkins commented on pull request #29484: URL: https://github.com/apache/spark/pull/29484#issuecomment-678762507 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29484: [SPARK-32649][SQL] Optimize BHJ/SHJ inner/semi join with empty hashed relation
AmplabJenkins removed a comment on pull request #29484: URL: https://github.com/apache/spark/pull/29484#issuecomment-678762509 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127804/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29515: [SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
maropu commented on a change in pull request #29515:
URL: https://github.com/apache/spark/pull/29515#discussion_r475211090
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##
@@ -793,7 +793,9 @@ case class EqualTo(left: Expression, right: Expression)
// | FALSE | FALSE | TRUE| UNKNOWN |
// | UNKNOWN | UNKNOWN | UNKNOWN | UNKNOWN |
// +-+-+-+-+
- protected override def nullSafeEval(left: Any, right: Any): Any =
ordering.equiv(left, right)
+ protected override def nullSafeEval(left: Any, right: Any): Any = {
+left == right || ordering.equiv(left, right)
Review comment:
But, how about `array(-0.0) == array(0.0)`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29515: [SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
maropu commented on a change in pull request #29515:
URL: https://github.com/apache/spark/pull/29515#discussion_r475211090
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##
@@ -793,7 +793,9 @@ case class EqualTo(left: Expression, right: Expression)
// | FALSE | FALSE | TRUE| UNKNOWN |
// | UNKNOWN | UNKNOWN | UNKNOWN | UNKNOWN |
// +-+-+-+-+
- protected override def nullSafeEval(left: Any, right: Any): Any =
ordering.equiv(left, right)
+ protected override def nullSafeEval(left: Any, right: Any): Any = {
+left == right || ordering.equiv(left, right)
Review comment:
But, how about the case `array(-0.0) == array(0.0)`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu edited a comment on pull request #29521: [SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
maropu edited a comment on pull request #29521: URL: https://github.com/apache/spark/pull/29521#issuecomment-678754002 I checked the commit history and https://github.com/apache/spark/pull/29417 seems to be related to the failure: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127803/ @MaxGekk Could you check it? cc: @HyukjinKwon This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu edited a comment on pull request #29521: [SPARK-32608][SQL][3.0][FOLLOW-UP][test-hadoop2.7][test-hive1.2] Script Transform ROW FORMAT DELIMIT value should format value
maropu edited a comment on pull request #29521: URL: https://github.com/apache/spark/pull/29521#issuecomment-678754002 I checked the commit history and https://github.com/apache/spark/pull/29409 and https://github.com/apache/spark/pull/29417 seem to be related to the failure: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127803/ @MaxGekk Could you check it? cc: @HyukjinKwon This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29515: [SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
AmplabJenkins commented on pull request #29515: URL: https://github.com/apache/spark/pull/29515#issuecomment-678769621 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29515: [SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
AmplabJenkins removed a comment on pull request #29515: URL: https://github.com/apache/spark/pull/29515#issuecomment-678769621 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #29515: [SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
tanelk commented on a change in pull request #29515:
URL: https://github.com/apache/spark/pull/29515#discussion_r475214881
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##
@@ -793,7 +793,9 @@ case class EqualTo(left: Expression, right: Expression)
// | FALSE | FALSE | TRUE| UNKNOWN |
// | UNKNOWN | UNKNOWN | UNKNOWN | UNKNOWN |
// +-+-+-+-+
- protected override def nullSafeEval(left: Any, right: Any): Any =
ordering.equiv(left, right)
+ protected override def nullSafeEval(left: Any, right: Any): Any = {
+left == right || ordering.equiv(left, right)
Review comment:
You are 100% correct.
It is an interesting problem, where the same comparator is used for both
sorting and equality check.
For sorting `-0.0` should be smaller than `0.0`, but in equality check they
should be equal.
Just for reference, it seems that both hive and mysql consider them equal in
the equality check:
https://issues.apache.org/jira/browse/HIVE-11174
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29515: [WIP][SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
SparkQA commented on pull request #29515: URL: https://github.com/apache/spark/pull/29515#issuecomment-678770269 **[Test build #127808 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127808/testReport)** for PR 29515 at commit [`1116d3d`](https://github.com/apache/spark/commit/1116d3d2e4e27c777176c11425ea5465e3a6ff7e). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata
AmplabJenkins removed a comment on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-678771160 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata
AmplabJenkins commented on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-678771160 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] guykhazma commented on pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata
guykhazma commented on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-678771791 @viirya @maropu can you please take a look and see if this can get in. thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29515: [WIP][SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
SparkQA commented on pull request #29515: URL: https://github.com/apache/spark/pull/29515#issuecomment-678775021 **[Test build #127808 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127808/testReport)** for PR 29515 at commit [`1116d3d`](https://github.com/apache/spark/commit/1116d3d2e4e27c777176c11425ea5465e3a6ff7e). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29515: [WIP][SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
AmplabJenkins commented on pull request #29515: URL: https://github.com/apache/spark/pull/29515#issuecomment-678775040 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29515: [WIP][SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
SparkQA removed a comment on pull request #29515: URL: https://github.com/apache/spark/pull/29515#issuecomment-678770269 **[Test build #127808 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127808/testReport)** for PR 29515 at commit [`1116d3d`](https://github.com/apache/spark/commit/1116d3d2e4e27c777176c11425ea5465e3a6ff7e). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29515: [WIP][SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
AmplabJenkins removed a comment on pull request #29515: URL: https://github.com/apache/spark/pull/29515#issuecomment-678775040 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29515: [WIP][SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
AmplabJenkins removed a comment on pull request #29515: URL: https://github.com/apache/spark/pull/29515#issuecomment-678775048 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127808/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #29516: [WIP][SPARK-32614][SQL] Don't apply comment processing if 'comment' unset for CSV
srowen commented on a change in pull request #29516:
URL: https://github.com/apache/spark/pull/29516#discussion_r475221331
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/CSVOptions.scala
##
@@ -220,7 +220,9 @@ class CSVOptions(
format.setQuote(quote)
format.setQuoteEscape(escape)
charToEscapeQuoteEscaping.foreach(format.setCharToEscapeQuoteEscaping)
-format.setComment(comment)
+if (isCommentSet) {
Review comment:
You are correct, but, this has never been a valid comment character, and
the flip side is the bug you describe: it's _always_ a comment character. I
think it's reasonable to fix as a bug. I don't think we need yet another
config, as I think it would be quite obscure to use this non-printing control
code for comments in a CSV file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata
AmplabJenkins commented on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-678782089 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28826: [SPARK-31988][SQL] Schema pruning may discard attribute metadata
AmplabJenkins removed a comment on pull request #28826: URL: https://github.com/apache/spark/pull/28826#issuecomment-678782089 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #29421: [SPARK-32388][SQL][test-hadoop2.7][test-hive1.2] TRANSFORM with schema-less mode should keep the same with hive
AngersZh commented on pull request #29421: URL: https://github.com/apache/spark/pull/29421#issuecomment-678782501 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29515: [WIP][SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
SparkQA commented on pull request #29515: URL: https://github.com/apache/spark/pull/29515#issuecomment-678782539 **[Test build #127807 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127807/testReport)** for PR 29515 at commit [`818abe2`](https://github.com/apache/spark/commit/818abe2382ef57bb23177570d725662c0d6f1bf6). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29515: [WIP][SPARK-32688][SQL][TESTS] Add special values to LiteralGenerator for float and double
SparkQA removed a comment on pull request #29515: URL: https://github.com/apache/spark/pull/29515#issuecomment-678755006 **[Test build #127807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127807/testReport)** for PR 29515 at commit [`818abe2`](https://github.com/apache/spark/commit/818abe2382ef57bb23177570d725662c0d6f1bf6). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
