[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/13867 cc @hvanhovell --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/13867 @ioana-delaney I lost track of this one. I am sorry about that. Could you update it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...
Github user ioana-delaney commented on the issue: https://github.com/apache/spark/pull/13867 @hvanhovell I rebased my changes to the latest build. Please take a look. Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13867 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13867 **[Test build #76985 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76985/consoleFull)** for PR 13867 at commit [`3d8af2a`](https://github.com/apache/spark/commit/3d8af2ad685a6933400c89b2ec463e337bb8ff09). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13867 **[Test build #76985 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76985/consoleFull)** for PR 13867 at commit [`3d8af2a`](https://github.com/apache/spark/commit/3d8af2ad685a6933400c89b2ec463e337bb8ff09). * This patch passes all tests. * This patch **does not merge cleanly**. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13867 Build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13867 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76985/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13867 ping @ioana-delaney --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...
Github user ioana-delaney commented on the issue: https://github.com/apache/spark/pull/13867 @gatorsmile There were changes to the subquery design since this PR was implemented, including changes in the error propagation. I will need to reinvestigate how this PR fits into the new sub-query design. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13867 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...
Github user ioana-delaney commented on the issue: https://github.com/apache/spark/pull/13867 With the ongoing changes to the subquery design, queries with deep correlation will return more meaningful errors. For example, the above mentioned query will issue the following error message: ```Cannot resolve '`t1.c2`' given input columns: [c1, c2]; line 5 pos 45 ``` The change seems to be due to SPARK-18863 which now calls ```checkAnalysis``` for a subquery tree. I've tested all the test cases introduced by the current PR, and they all result in similar error messages. Therefore, I will close this PR as resolved by SPARK-18863. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13867 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13867 **[Test build #3129 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3129/consoleFull)** for PR 13867 at commit [`c0c1caf`](https://github.com/apache/spark/commit/c0c1caf38cfc7d0e9e32fd08af240d1c7e6e8ebb). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13867 **[Test build #3129 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3129/consoleFull)** for PR 13867 at commit [`c0c1caf`](https://github.com/apache/spark/commit/c0c1caf38cfc7d0e9e32fd08af240d1c7e6e8ebb). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13867 cc @hvanhovell @davies Could you review this PR? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...
Github user ioana-delaney commented on the issue: https://github.com/apache/spark/pull/13867 @hvanhovell Thank you for reviewing the changes. I replied to your comments and made some updates. Please let me know. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...
Github user ioana-delaney commented on the issue: https://github.com/apache/spark/pull/13867 @hvanhovell Would you please let me know if you agree with my previous reply? An alternative design is to remove the try-catch expression from resolveOuterReferences() altogether. The two try-catch expressions (i.e. try-catch in withPosition() and the explicit try-catch in resolveOuterReferences()) are used in the original design. The purpose of the try-catch in the resolveOuterReferences() is to intercept any exceptions coming from resolve() and override them by returning the unresolved attribute. One exception is "ambiguous reference" but, in my opinion, that should be thrown as an exception since it is an incorrect sql at this point. Therefore, an alternative design is to remove the try-catch in the resolveOuterReference() and let withPosition() capture any exceptions, including the new one. Let me know your opinion. Or we can go with my previous proposal, which aligns with the original design. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...
Github user ioana-delaney commented on the issue: https://github.com/apache/spark/pull/13867 Can someone please review the changes? Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #13867: [SPARK-16161][SQL] Ambiguous error message for unsupport...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/13867 cc @hvanhovell @cloud-fan Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
