[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/14835 Thanks @tgravescs I'll quickly open a pr for 2.0.1 and ping you on it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/14835 Merged into 2.1 branch. I can see this being either defect or feature. If you or others want it in 2.0.1 will need a separate pr as there were conflicts with the change due to executor page going to datatables. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/14835 changes look good. thanks! One interesting thing I found while trying this out is that the number displayed in the table can actually be greater then the maxApplication config due to some applications possibly having multiple attempts. The rest api will return the correct number of applications, it just the datatable may split them based on sorting order. Not a big deal for this, just an observation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14835 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14835 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64664/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14835 **[Test build #64664 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64664/consoleFull)** for PR 14835 at commit [`8da22e3`](https://github.com/apache/spark/commit/8da22e30415a6f6baa536002f137eb0862a52d44). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/14835 @tgravescs I edited the wording, but I feel that the word "UI" needs to be there to make sure they understand that it's the UI being stored not some copy of the application. I though the phrase "UI data" got this across and I choose to move the sentence around to clear any misunderstandings --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14835 **[Test build #64664 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64664/consoleFull)** for PR 14835 at commit [`8da22e3`](https://github.com/apache/spark/commit/8da22e30415a6f6baa536002f137eb0862a52d44). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14835 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14835 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64601/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14835 **[Test build #64601 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64601/consoleFull)** for PR 14835 at commit [`bbb9718`](https://github.com/apache/spark/commit/bbb971826538487ca1058da084b03a1056cfe5dc). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14835 **[Test build #64601 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64601/consoleFull)** for PR 14835 at commit [`bbb9718`](https://github.com/apache/spark/commit/bbb971826538487ca1058da084b03a1056cfe5dc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/14835 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14835 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14835 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64595/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14835 **[Test build #64595 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64595/consoleFull)** for PR 14835 at commit [`bbb9718`](https://github.com/apache/spark/commit/bbb971826538487ca1058da084b03a1056cfe5dc). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14835 **[Test build #64595 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64595/consoleFull)** for PR 14835 at commit [`bbb9718`](https://github.com/apache/spark/commit/bbb971826538487ca1058da084b03a1056cfe5dc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/14835 @tgravescs pushed those doc updates if you want to take a look, I'm not 100% sure on my wording --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/14835 yep, I believe you are correct, and if so I think we should just update the docs for it to describe that. If you don't mind doing it along with this that would be great. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/14835 @tgravescs I'll double check but I believe `spark.history.retainedApplications` now affects the max number of cached applications not the total listed, I was under the same assumption previously and had suggested that workaround in the JIRA --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/14835 I need to look at in more details, but at one point (and it looks like this has changed) spark.history.retainedApplications I thought affected number being displayed as well. So in the very least I think we should update the docs to clarify what it is vs this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/14835 @QQshu1 I'm not sure what problem you're having but this pr is to solve the specific problem that the call to get the application list json when loading the history server takes too long when the application list is too long --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user QQshu1 commented on the issue: https://github.com/apache/spark/pull/14835 I may have a question ,if I just have a application,and it is very large .It also can't load it by this way. How to solve this kind of scene? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14835 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14835 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64508/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14835 **[Test build #64508 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64508/consoleFull)** for PR 14835 at commit [`172dc56`](https://github.com/apache/spark/commit/172dc56858ae35e70950aad78675dd932a9e4e93). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14835 **[Test build #64508 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64508/consoleFull)** for PR 14835 at commit [`172dc56`](https://github.com/apache/spark/commit/172dc56858ae35e70950aad78675dd932a9e4e93). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14835 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64502/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14835 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14835 **[Test build #64502 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64502/consoleFull)** for PR 14835 at commit [`6163f13`](https://github.com/apache/spark/commit/6163f132f686571707262eee2141f890a1de05d4). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/14835 So I decided to switch to my alternate implementation after thinking hard about how detrimental limiting the api would be. I also updated the docs with my new conf and api param. I will push these changes once I double check my tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/14835 @steveloughran Some follow up and clarifications: For you comments about people calling the REST API, you are correct that my change limits the applications available through the api on the history server. This was my intended behavior, but if you think it'd be better I can switch to my fallback implementation outlined below. Alternate implementation that only limits history server and not the api: I pass the conf value to the js file via a global js var with a getter and setter (I've done this previously with `threadDumpEnabled` in `ExecutorsPage.scala` going to `executors.js`) 1. I will add this 2. I added the one test already, for the test you referenced I'm a bit confused at what you're recommending. Why would `?limit=1` return 0? Or are you saying to call it after the last line where it deletes the log, if so how would that test the limit param? Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user steveloughran commented on the issue:
https://github.com/apache/spark/pull/14835
I'll let other people review the source code in detail, except note that
people calling the REST API may want to ask for all entries, even if the web
view asks for less.
1. the rest API is documented in docs/monitoring.md ; changes need to go in
there
1. Tests in `HistoryServerSuite`;
Test-wise, I'd add something to the end of `test("incomplete apps get
refreshed")`, making another API call on the app list through
`getContentAndCode` and set the ?limit=1 value to verify 0 comes back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14835 **[Test build #64502 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64502/consoleFull)** for PR 14835 at commit [`6163f13`](https://github.com/apache/spark/commit/6163f132f686571707262eee2141f890a1de05d4). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/14835 @srowen @steveloughran can you take a look at this, you two were the ones who commented on the JIRA, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #14835: [SPARK-17243] [Web UI] Spark 2.0 History Server won't lo...
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/14835 I ended up not using the limit param in my solution since getting a conf value to the js function that calls the api was not exactly simple (my biggest issue with switching to js based pages for the ui), but given it's overall usefulness I decided to leave it in this pr as a new feature, If you think I should open a separate JIRA/pr for it I can. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
