[GitHub] spark issue #16345: [SPARK-17755][Core]Use workerRef to send RegisterWorkerR...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/16345 Thanks. Merging to master. This seems risky to backport to other branches. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16345: [SPARK-17755][Core]Use workerRef to send RegisterWorkerR...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/16345 Ah, I see there's already other code that deals with retries and timeouts. LGTM then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16345: [SPARK-17755][Core]Use workerRef to send RegisterWorkerR...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/16345 > aren't you losing the timeout for the register RPC? That's true. However, calling `System.exit(1)` for any timeout doesn't make sense. In addition, since we will always retry to register with master, using `send` should be fine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16345: [SPARK-17755][Core]Use workerRef to send RegisterWorkerR...
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/16345 Hmm, I see... the worker needs to listen for RPC connections also, because executors connect to it for "fate sharing"... so that means that when it connects to the master, there are two TCP channels involved instead of one for "client mode" RpcEnv. But, with your change, aren't you losing the timeout for the register RPC? Basically the `case Failure(e)` in the code you're deleting from Worker.scala. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16345: [SPARK-17755][Core]Use workerRef to send RegisterWorkerR...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16345 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16345: [SPARK-17755][Core]Use workerRef to send RegisterWorkerR...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16345 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/70390/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16345: [SPARK-17755][Core]Use workerRef to send RegisterWorkerR...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16345 **[Test build #70390 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70390/testReport)** for PR 16345 at commit [`b4b5552`](https://github.com/apache/spark/commit/b4b55528edc5e9c92f28cf81ea81e72748790100). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16345: [SPARK-17755][Core]Use workerRef to send RegisterWorkerR...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16345 **[Test build #70390 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/70390/testReport)** for PR 16345 at commit [`b4b5552`](https://github.com/apache/spark/commit/b4b55528edc5e9c92f28cf81ea81e72748790100). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16345: [SPARK-17755][Core]Use workerRef to send RegisterWorkerR...
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/16345 cc @vanzin want to review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
