[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17108 Merging with master Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17108 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75118/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17108 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17108 **[Test build #75118 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75118/testReport)** for PR 17108 at commit [`7c540e5`](https://github.com/apache/spark/commit/7c540e5080aa10894d33cfa9924b65bd551375ab). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user thunterdb commented on the issue: https://github.com/apache/spark/pull/17108 Tickets created: - https://issues.apache.org/jira/browse/SPARK-20076 - https://issues.apache.org/jira/browse/SPARK-20077 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17108 LGTM will merge after tests Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17108 **[Test build #75118 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75118/testReport)** for PR 17108 at commit [`7c540e5`](https://github.com/apache/spark/commit/7c540e5080aa10894d33cfa9924b65bd551375ab). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17108 LGTM except for the one doc nit. When you update this, could you also please make and link JIRAs for the Python wrapper and doc update? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17108 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17108 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75060/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17108 **[Test build #75060 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75060/testReport)** for PR 17108 at commit [`2151e8a`](https://github.com/apache/spark/commit/2151e8a0204d628f3e77c782e03d4f17e1674109). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17108 **[Test build #75060 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75060/testReport)** for PR 17108 at commit [`2151e8a`](https://github.com/apache/spark/commit/2151e8a0204d628f3e77c782e03d4f17e1674109). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/17108 the code looks good to me, I added some minor comments, thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17108 Taking a look now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17108 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74627/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17108 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17108 **[Test build #74627 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74627/testReport)** for PR 17108 at commit [`2aeb6ee`](https://github.com/apache/spark/commit/2aeb6ee142fe8836eecaac1414f46715fd36cc24). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17108 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/74626/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17108 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17108 **[Test build #74626 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74626/testReport)** for PR 17108 at commit [`a85a889`](https://github.com/apache/spark/commit/a85a889b341b99393793b7558691d4b3029157ed). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17108 **[Test build #74627 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74627/testReport)** for PR 17108 at commit [`2aeb6ee`](https://github.com/apache/spark/commit/2aeb6ee142fe8836eecaac1414f46715fd36cc24). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user thunterdb commented on the issue: https://github.com/apache/spark/pull/17108 I moved the code `Correlations` as suggested. @imatiach-msft , I addressed your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17108 **[Test build #74626 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/74626/testReport)** for PR 17108 at commit [`a85a889`](https://github.com/apache/spark/commit/a85a889b341b99393793b7558691d4b3029157ed). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17108 Given further thought, I'd prefer we stick to the API specified in the design doc, with a Correlations object instead of a generic Statistics object. In the future, we may want optional Params such as weightCol, in which case we may switch to a builder pattern for Correlations and ChiSquare and move away from a shared Statistics object. I'm going to proceed with https://github.com/apache/spark/pull/17110 using a separate ChiSquare object. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/17108 The changes look good to me. I just had a few minor comments. I wish we could just natively implement the correlations in spark to avoid extra copying between the old and new implementations, but this seems like a move in the right direction. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17108 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17108 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73627/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17108 **[Test build #73627 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73627/testReport)** for PR 17108 at commit [`7d4ccfe`](https://github.com/apache/spark/commit/7d4ccfef4e6d3a7b65c3cca149afb250414aea4c). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #17108: [SPARK-19636][ML] Feature parity for correlation statist...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17108 **[Test build #73627 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73627/testReport)** for PR 17108 at commit [`7d4ccfe`](https://github.com/apache/spark/commit/7d4ccfef4e6d3a7b65c3cca149afb250414aea4c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
