[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-150038788 I've merged this to master. Thanks @navis! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8354 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8354#discussion_r42533445
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala
---
@@ -196,14 +194,8 @@ private[hive] object HiveShim {
if (instance != null) {
instance.asInstanceOf[UDFType]
} else {
-val func = Utils.getContextOrSparkClassLoader
+Utils.getContextOrSparkClassLoader
.loadClass(functionClassName).newInstance.asInstanceOf[UDFType]
-if (!func.isInstanceOf[UDF]) {
--- End diff --
Alright, sounds good. Would you mind making this change soon so that we can
try to merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-149738761 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-149738785 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-149739284 **[Test build #44021 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44021/consoleFull)** for PR 8354 at commit [`3595ce7`](https://github.com/apache/spark/commit/3595ce753d9005ee414a56a87cf737cc7bb7defc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-149755392 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-149755394 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44021/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-149755275 **[Test build #44021 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44021/consoleFull)** for PR 8354 at commit [`3595ce7`](https://github.com/apache/spark/commit/3595ce753d9005ee414a56a87cf737cc7bb7defc). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/8354#discussion_r42582796 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala --- @@ -592,10 +593,14 @@ class HiveContext private[hive]( ) } + private def functionOrMacroDDLPattern(command: String) = Pattern.compile( --- End diff -- Nit: How about return boolean directly? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-149781866 @navis @JoshRosen this change is much cleaner now, and LGTM, except a Nit, we can leave it for the further improvement. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/8354#discussion_r42583285 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala --- @@ -592,10 +593,14 @@ class HiveContext private[hive]( ) } + private def functionOrMacroDDLPattern(command: String) = Pattern.compile( --- End diff -- +1, good catch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-149782818 Yep, LGTM as well. @navis, thanks for helping to simplify this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8354#discussion_r42435326
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala
---
@@ -118,8 +118,8 @@ private[hive] object HiveShim {
*
* @param functionClassName UDF class name
*/
- private[hive] case class HiveFunctionWrapper(var functionClassName:
String)
-extends java.io.Externalizable {
+ private[hive] case class HiveFunctionWrapper(var functionClassName:
String,
+var instance: AnyRef = null) extends java.io.Externalizable with
Logging {
--- End diff --
Also, do you need to add the logging trait here? It looks like it's not
used anywhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8354#discussion_r42435310
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala
---
@@ -118,8 +118,8 @@ private[hive] object HiveShim {
*
* @param functionClassName UDF class name
*/
- private[hive] case class HiveFunctionWrapper(var functionClassName:
String)
-extends java.io.Externalizable {
+ private[hive] case class HiveFunctionWrapper(var functionClassName:
String,
+var instance: AnyRef = null) extends java.io.Externalizable with
Logging {
--- End diff --
Actually, why does instance need to be public here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8354#discussion_r42436121
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -547,10 +548,15 @@ class HiveContext(sc: SparkContext) extends
SQLContext(sc) with Logging {
)
}
+ @transient
+ private lazy val matcher = Pattern.compile(
+".*(create|drop)\\s+(temporary\\s+)?(function|macro).+",
Pattern.DOTALL).matcher("")
+
protected[hive] def runSqlHive(sql: String): Seq[String] = {
-if (sql.toLowerCase.contains("create temporary function")) {
+val command = sql.trim.toLowerCase
+if (matcher.reset(command).matches()) {
--- End diff --
Are matchers stateful? If so, I'm not sure that this is threadsafe.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user navis commented on a diff in the pull request:
https://github.com/apache/spark/pull/8354#discussion_r42444143
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -547,10 +548,15 @@ class HiveContext(sc: SparkContext) extends
SQLContext(sc) with Logging {
)
}
+ @transient
+ private lazy val matcher = Pattern.compile(
+".*(create|drop)\\s+(temporary\\s+)?(function|macro).+",
Pattern.DOTALL).matcher("")
+
protected[hive] def runSqlHive(sql: String): Seq[String] = {
-if (sql.toLowerCase.contains("create temporary function")) {
+val command = sql.trim.toLowerCase
+if (matcher.reset(command).matches()) {
--- End diff --
Didn't thought about that. Matcher should not be reused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-149370315 Hey @chenghao-intel, could you take a look at this PR? I'd like to get your feedback/review because this PR largely undoes some of the changes that you made in `HiveFunctionWrapper` (in #3640) and I'm not familiar enough with this code to know whether this is safe. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8354#discussion_r42434057
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala
---
@@ -118,8 +118,8 @@ private[hive] object HiveShim {
*
* @param functionClassName UDF class name
*/
- private[hive] case class HiveFunctionWrapper(var functionClassName:
String)
-extends java.io.Externalizable {
+ private[hive] case class HiveFunctionWrapper(var functionClassName:
String,
--- End diff --
Formatting nit: wrap these arguments one per line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8354#discussion_r42436286
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -547,10 +548,15 @@ class HiveContext(sc: SparkContext) extends
SQLContext(sc) with Logging {
)
}
+ @transient
+ private lazy val matcher = Pattern.compile(
--- End diff --
`matcher` is kind of a generic name; can you come up with something more
descriptive, like `functionOrMacroDDLPattern`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user navis commented on a diff in the pull request:
https://github.com/apache/spark/pull/8354#discussion_r42443991
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala
---
@@ -118,8 +118,8 @@ private[hive] object HiveShim {
*
* @param functionClassName UDF class name
*/
- private[hive] case class HiveFunctionWrapper(var functionClassName:
String)
-extends java.io.Externalizable {
+ private[hive] case class HiveFunctionWrapper(var functionClassName:
String,
+var instance: AnyRef = null) extends java.io.Externalizable with
Logging {
--- End diff --
For "instance", just conformed with "functionClassName", which is public.
For "Logging", I've used it in debugging and forgot to remove. I'll addressed
them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user navis commented on a diff in the pull request:
https://github.com/apache/spark/pull/8354#discussion_r42444696
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -547,10 +548,15 @@ class HiveContext(sc: SparkContext) extends
SQLContext(sc) with Logging {
)
}
+ @transient
+ private lazy val matcher = Pattern.compile(
--- End diff --
Will be removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-149412299 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-149413143 **[Test build #43960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43960/consoleFull)** for PR 8354 at commit [`75dbc2e`](https://github.com/apache/spark/commit/75dbc2e81a32b64ed162431ebc8041ecac0a9b9b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-149433675 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-149433676 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43960/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-149433614 **[Test build #43960 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43960/consoleFull)** for PR 8354 at commit [`75dbc2e`](https://github.com/apache/spark/commit/75dbc2e81a32b64ed162431ebc8041ecac0a9b9b). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user navis commented on a diff in the pull request:
https://github.com/apache/spark/pull/8354#discussion_r42450109
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala
---
@@ -196,14 +194,8 @@ private[hive] object HiveShim {
if (instance != null) {
instance.asInstanceOf[UDFType]
} else {
-val func = Utils.getContextOrSparkClassLoader
+Utils.getContextOrSparkClassLoader
.loadClass(functionClassName).newInstance.asInstanceOf[UDFType]
-if (!func.isInstanceOf[UDF]) {
--- End diff --
`instance` is now not null just for macro function, which contains detail
of how to handle input data. I've removed caching UDF because hive udf does not
coerces functions to be stateless, afaik. And I don't think creating UDF
instance will make any performance regression.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user navis commented on a diff in the pull request:
https://github.com/apache/spark/pull/8354#discussion_r42455359
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala
---
@@ -196,14 +194,8 @@ private[hive] object HiveShim {
if (instance != null) {
instance.asInstanceOf[UDFType]
} else {
-val func = Utils.getContextOrSparkClassLoader
+Utils.getContextOrSparkClassLoader
.loadClass(functionClassName).newInstance.asInstanceOf[UDFType]
-if (!func.isInstanceOf[UDF]) {
--- End diff --
Hm.. I missed that(#3640). Then it should be rolled back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-145420107 [Test build #43228 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43228/console) for PR 8354 at commit [`fd799a1`](https://github.com/apache/spark/commit/fd799a1163a47c2819ab8d91d2131968ab45871f). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-145420157 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43228/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-145420156 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-145407561 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-145407570 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-145408422 [Test build #43228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43228/consoleFull) for PR 8354 at commit [`fd799a1`](https://github.com/apache/spark/commit/fd799a1163a47c2819ab8d91d2131968ab45871f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-142495922 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-142495986 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-142499242 [Test build #42887 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42887/console) for PR 8354 at commit [`3223621`](https://github.com/apache/spark/commit/3223621ef093010d71686de104204a079c706105). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-142499258 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42887/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-142499257 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-142497425 [Test build #42887 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42887/consoleFull) for PR 8354 at commit [`3223621`](https://github.com/apache/spark/commit/3223621ef093010d71686de104204a079c706105). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-141905575 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-141905560 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-142187216 [Test build #42811 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42811/console) for PR 8354 at commit [`e074681`](https://github.com/apache/spark/commit/e07468170df1d6967b577ce569cde8acfbd02e0f). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-142177379 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-142177340 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-142178465 [Test build #42811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42811/consoleFull) for PR 8354 at commit [`e074681`](https://github.com/apache/spark/commit/e07468170df1d6967b577ce569cde8acfbd02e0f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-142187235 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42811/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-142187234 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-141932381 [Test build #42748 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42748/console) for PR 8354 at commit [`9d3dd3b`](https://github.com/apache/spark/commit/9d3dd3bb45431e24ea63f2ef645ee170aeadeb06). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-141932408 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-141932413 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42748/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-141906946 [Test build #42748 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42748/consoleFull) for PR 8354 at commit [`9d3dd3b`](https://github.com/apache/spark/commit/9d3dd3bb45431e24ea63f2ef645ee170aeadeb06). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user navis commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-141379396 @JoshRosen It isn't because spark does not support "create macro". I've tried to support that in new patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-141379468 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-141380026 [Test build #42651 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42651/consoleFull) for PR 8354 at commit [`e8983b9`](https://github.com/apache/spark/commit/e8983b927fe34115ac458c2b3737499362144bd7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-141408606 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-141408568 [Test build #42651 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42651/console) for PR 8354 at commit [`e8983b9`](https://github.com/apache/spark/commit/e8983b927fe34115ac458c2b3737499362144bd7). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-141408608 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42651/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-141379482 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-140554525 Is there a way to add a test for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-136857526 @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-133366793 [Test build #41360 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41360/console) for PR 8354 at commit [`e1ef530`](https://github.com/apache/spark/commit/e1ef5306006f28a6eed72a512b894334ef6fbd3e). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-133367307 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41360/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-133367304 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
GitHub user navis opened a pull request: https://github.com/apache/spark/pull/8354 [SPARK-10151] [SQL] Support invocation of hive macro Macro in hive (which is GenericUDFMacro) contains real function inside of it but it's not conveyed to tasks, resulting null-pointer exception. You can merge this pull request into a Git repository by running: $ git pull https://github.com/navis/spark SPARK-10151 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/8354.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8354 commit e1ef5306006f28a6eed72a512b894334ef6fbd3e Author: navis.ryu na...@apache.org Date: 2015-08-21T07:59:08Z [SPARK-10151] [SQL] Support invocation of hive macro --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-133326957 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-133326934 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10151] [SQL] Support invocation of hive...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8354#issuecomment-133327105 [Test build #41360 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41360/consoleFull) for PR 8354 at commit [`e1ef530`](https://github.com/apache/spark/commit/e1ef5306006f28a6eed72a512b894334ef6fbd3e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
