[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-135486169 Whoops forgot to push the last commit, the Strings and default list size should be there now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-135487161 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-135487130 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-135487780 [Test build #41701 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41701/consoleFull) for PR 8451 at commit [`0695e51`](https://github.com/apache/spark/commit/0695e5157ff8bd76d49769d787200f6b4799a294). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-135498467 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-135498471 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41701/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-135498118 [Test build #41701 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41701/console) for PR 8451 at commit [`0695e51`](https://github.com/apache/spark/commit/0695e5157ff8bd76d49769d787200f6b4799a294). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8451 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-135366571 The other sibling PRs look good and I can merge them. This looks good after the `Strings` change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-134860189 [Test build #41603 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41603/console) for PR 8451 at commit [`71757ca`](https://github.com/apache/spark/commit/71757cab314758de64aef447ddc11c58be470250). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-134860529 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-134860535 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41603/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-134868225 `Lists.newArrayList` - `Arrays.asList` look good to me. But I don't see why we need to replace `Strings` by `StringUtils` from commons-lang. Are we going to remove Guava from test scope? I think Guava is more careful about binary compatibility than Apache Commons. + @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/8451#discussion_r38009325 --- Diff: mllib/src/test/java/org/apache/spark/mllib/recommendation/JavaALSSuite.java --- @@ -56,8 +56,7 @@ void validatePrediction( double matchThreshold, boolean implicitPrefs, DoubleMatrix truePrefs) { -ListTuple2Integer, Integer localUsersProducts = - Lists.newArrayListWithCapacity(users * products); +ListTuple2Integer, Integer localUsersProducts = new ArrayList(); --- End diff -- sure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-135114426 OK, I will revert the changes s.t. we use Guava Strings over commons lang --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/8451#discussion_r37954720 --- Diff: mllib/src/test/java/org/apache/spark/mllib/recommendation/JavaALSSuite.java --- @@ -56,8 +56,7 @@ void validatePrediction( double matchThreshold, boolean implicitPrefs, DoubleMatrix truePrefs) { -ListTuple2Integer, Integer localUsersProducts = - Lists.newArrayListWithCapacity(users * products); +ListTuple2Integer, Integer localUsersProducts = new ArrayList(); --- End diff -- If you have to make any other changes on this PR, you could change one tiny thing here: preserve passing `users * products` as the initial capacity to this constructor. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/8451#discussion_r37954938 --- Diff: mllib/src/test/java/org/apache/spark/mllib/feature/JavaWord2VecSuite.java --- @@ -50,9 +50,9 @@ public void tearDown() { @SuppressWarnings(unchecked) public void word2Vec() { // The tests are to check Java compatibility. -String sentence = Strings.repeat(a b , 100) + Strings.repeat(a c , 10); -ListString words = Lists.newArrayList(sentence.split( )); -ListListString localDoc = Lists.newArrayList(words, words); +String sentence = StringUtils.repeat(a b , 100) + StringUtils.repeat(a c , 10); --- End diff -- There are a few issues here. This is using Commons Lang 2.x and would be better to use 3.x (`commons.lang3.*`). However, Spark doesn't generally depend on either of them; a few modules do but not MLlib. This happens to work because of transitive dependencies. Since we definitely do depend on Guava, and that won't go anywhere soon, and this is an internal use anyway, I think I might leave out this change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-134889417 Overall I'm in favor of this. I was actually preparing a PR that touches up a load of small issues like this in the Java test suites; a lot of the code can be slimmed down, simplified and standardized. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-134843830 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-134843757 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-134825362 [Test build #41591 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41591/consoleFull) for PR 8451 at commit [`a9b8b7a`](https://github.com/apache/spark/commit/a9b8b7a6d5fcfb19ceb58eb05f707eec4f2b5485). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-134835562 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-134835554 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-134843193 jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-134825151 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-134825158 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
GitHub user feynmanliang opened a pull request: https://github.com/apache/spark/pull/8451 [SPARK-10257][MLlib] Removes Guava from all spark.mllib Java tests * Replaces instances of `Lists.newArrayList` with `Arrays.asList` * Replaces `commons.lang.StringUtils` over `com.google.collections.Strings` * Replaces `List` interface over `ArrayList` implementations You can merge this pull request into a Git repository by running: $ git pull https://github.com/feynmanliang/spark SPARK-10257 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/8451.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8451 commit a9b8b7a6d5fcfb19ceb58eb05f707eec4f2b5485 Author: Feynman Liang fli...@databricks.com Date: 2015-08-26T04:25:28Z Removes Guava from all of mllib javatests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-134841994 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41601/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-134841987 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-134845930 [Test build #41603 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41603/consoleFull) for PR 8451 at commit [`71757ca`](https://github.com/apache/spark/commit/71757cab314758de64aef447ddc11c58be470250). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-134832326 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41591/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-134832325 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10257][MLlib] Removes Guava from all sp...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8451#issuecomment-134832306 [Test build #41591 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41591/console) for PR 8451 at commit [`a9b8b7a`](https://github.com/apache/spark/commit/a9b8b7a6d5fcfb19ceb58eb05f707eec4f2b5485). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org