[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-204104462 Then it seems that this patch is worth backporting into 1.6 since cluster mode does work there. @dragos @mgummelt @jayv Could one of you submit a patch for 1.6? I think the changes here are pretty isolated so it should be safe. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-204103757 Ah thanks, I forgot I merged that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user mgummelt commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-204092221 Mesos Cluster Mode works fine. It's dynamic allocation that was broken. I'm pretty sure this is the PR: https://github.com/apache/spark/pull/11272 @dragos @skonto can you verify that the Spark/Mesos dynamic allocation integration tests on master are passing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-204084763 @dragos @tnachen can you remind me on the status of Mesos cluster mode in 1.6? It was essentially unusable because of the external shuffle service right? Did we ever resolve that? (where is the patch?) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10370 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-204083684 Merged into master. Thanks for your patience and hard work everyone. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-203989761 LGTM! @andrewor14 please have a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-203695796 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-203695798 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54556/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-203695622 **[Test build #54556 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54556/consoleFull)** for PR 10370 at commit [`82cd03d`](https://github.com/apache/spark/commit/82cd03dfc794c960f48d8e2e91a239a885196161). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-203655090 Latest changes look pretty reasonable. Funny how mesos cluster mode is basically unusable before. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-203655043 **[Test build #54556 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54556/consoleFull)** for PR 10370 at commit [`82cd03d`](https://github.com/apache/spark/commit/82cd03dfc794c960f48d8e2e91a239a885196161). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-203654684 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-203609045 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54541/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-203609039 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-203608592 **[Test build #54541 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54541/consoleFull)** for PR 10370 at commit [`82cd03d`](https://github.com/apache/spark/commit/82cd03dfc794c960f48d8e2e91a239a885196161). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-203555799 **[Test build #54541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54541/consoleFull)** for PR 10370 at commit [`82cd03d`](https://github.com/apache/spark/commit/82cd03dfc794c960f48d8e2e91a239a885196161). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user jayv commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-203555239 @dragos rebased! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-203394562 @jayv can you please rebase? @andrewor14 the last issue (escaping characters for the shell command) has been fixed. Please take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-200570817 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-200570819 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53977/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-200570811 **[Test build #53977 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53977/consoleFull)** for PR 10370 at commit [`11b070d`](https://github.com/apache/spark/commit/11b070df733ec45432214691d7d83968c3d0e180). * This patch **fails R style tests**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-200569751 **[Test build #53977 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53977/consoleFull)** for PR 10370 at commit [`11b070d`](https://github.com/apache/spark/commit/11b070df733ec45432214691d7d83968c3d0e180). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-200406113 Yeap, I just opened a PR on your repo. If you merge it it should be reflected here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user jayv commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-199957820 Nice, will you pick this up @dragos or waiting for me? - can't commit any time this week --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-199886574 It works, but I found a couple of corner cases. I guess you need to escape `\` as well. For instance, a string ending in `\`, or a string like `\"?` won't be quoted correctly. Otherwise it looks good and the manual tests are passing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-199332959 I can pick this up tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-198558275 @jayv are you planning to update this PR with that commit? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user jayv commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-191369895 Sorry for the delay @dragos very busy indeed, maybe this can help https://github.com/jayv/spark/commit/8023da309df2e5440e244e12d449cb8107d15b00 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-187770505 @jayv please let me know if you will look into this one. If you're busy, I'm happy to take over, and will happily start with your escaping algorithm ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-187137035 OK, I retract that. We need to use `shell=true`, so @jayv if you have that character escape version, let's go that way. The reason why it won't work is `extraLibraryPath`: we need to prepend library path variables, like `LD_LIBRARY_PATH="path1:path2:$LD_LIBRARY_PATH"`. We could add this binding in the environment that we're building, but without a shell we can't refer to the old value of `LD_LIBRARY_PATH` (note that this has to stay an unevaluated reference to `LD_LIBRARY_PATH` because we're preparing the `CommandInfo` structure in the dispatcher, which is NOT the machine where the command will be executed). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-186542740 Shouldn't be a problem, I just missed it in my first try. I think it's not too hard to make it work with `shell=false`, I just need to spend a bit more time on this. I'll probably open a new PR then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-186443823 @dragos Ah yes if you need bash completion than we have to use shell = true. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-186283938 My commit is not working, BTW, I'll come back to this (the executable needs to be a complete path to `spark-class`, right now it's a bash-ism: `cd spark-1.*; ./bin/spark-class`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user jayv commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-184807346 @dragos Unfortunately not, I'll come back to this issue when I've done some more testing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-184761659 I pushed [this commit](https://github.com/dragos/spark/commit/a6f9df1) with the general idea, but I didn't get to test it much. I'll come back to it tomorrow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-184707515 @jayv did you have the chance to look at this again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-178502476 As far as I'm concerned, that's the only thing (I'll have to test again on a real Mesos cluster). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user jayv commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-178241777 Got an implementation that escapes all the things under linux shells, but had to suspend work on this, so was unable to test mesos' native escaping. I'll try to get back to it this week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-178230973 @jayv the closest thing I can think of is `Utils.splitCommandString`, which does the unescaping. Did you end up getting Mesos to escape things properly? E.g. does something like `spark.executor.extraJavaOptions` work? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-178231238 @dragos is the only thing that's left before this patch can be merged the escaping thing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/10370#discussion_r50812958
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -440,6 +446,9 @@ private[spark] class MesosClusterScheduler(
.mkString(",")
options ++= Seq("--py-files", formattedFiles)
}
+desc.schedulerProperties
+ .filter { case (key, _) => !replicatedOptionsBlacklist.contains(key)
}
+ .foreach { case (key, value) => options ++= Seq("--conf",
s"""$key="$value) }
--- End diff --
I think the Mesos way is more robust and requires less code. Hopefully :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/10370#discussion_r50803860
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -440,6 +446,9 @@ private[spark] class MesosClusterScheduler(
.mkString(",")
options ++= Seq("--py-files", formattedFiles)
}
+desc.schedulerProperties
+ .filter { case (key, _) => !replicatedOptionsBlacklist.contains(key)
}
+ .foreach { case (key, value) => options ++= Seq("--conf",
s"""$key="$value) }
--- End diff --
I guess Tim refers to [this
line](https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L387),
so we'd need to set `shell` to `false`. That's probably the simplest way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user jayv commented on a diff in the pull request:
https://github.com/apache/spark/pull/10370#discussion_r50805506
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -440,6 +446,9 @@ private[spark] class MesosClusterScheduler(
.mkString(",")
options ++= Seq("--py-files", formattedFiles)
}
+desc.schedulerProperties
+ .filter { case (key, _) => !replicatedOptionsBlacklist.contains(key)
}
+ .foreach { case (key, value) => options ++= Seq("--conf",
s"""$key="$value) }
--- End diff --
Ah OK, I can check that, I wrote a bunch of regexes and tests today to
solve escaping for most Unix shells. Was about to push a PR early morning.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user jayv commented on a diff in the pull request:
https://github.com/apache/spark/pull/10370#discussion_r50884168
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -440,6 +446,9 @@ private[spark] class MesosClusterScheduler(
.mkString(",")
options ++= Seq("--py-files", formattedFiles)
}
+desc.schedulerProperties
+ .filter { case (key, _) => !replicatedOptionsBlacklist.contains(key)
}
+ .foreach { case (key, value) => options ++= Seq("--conf",
s"""$key="$value) }
--- End diff --
The meat of it is only 5 lines :) but let's see if we can make it work
without side-effects and for my use-case with args with spaces.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user jayv commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-174626690 Today I will test the driver issue you mentioned, we also seem to have a rogue driver spinning up on workers, and work on better escaping. Isn't there code for this in spark-submit or something already? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10370#discussion_r50775070
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -440,6 +446,9 @@ private[spark] class MesosClusterScheduler(
.mkString(",")
options ++= Seq("--py-files", formattedFiles)
}
+desc.schedulerProperties
+ .filter { case (key, _) => !replicatedOptionsBlacklist.contains(key)
}
+ .foreach { case (key, value) => options ++= Seq("--conf",
s"""$key="$value) }
--- End diff --
Mesos should also handle spaces if you provide the arguments as args in the
CommandInfo even with spaces and other characters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-173875166 @jayv do you have time to work on this, or should I? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/10370#discussion_r50402728
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -440,6 +446,9 @@ private[spark] class MesosClusterScheduler(
.mkString(",")
options ++= Seq("--py-files", formattedFiles)
}
+desc.schedulerProperties
+ .filter { case (key, _) => !replicatedOptionsBlacklist.contains(key)
}
+ .foreach { case (key, value) => options ++= Seq("--conf",
s"""$key="$value) }
--- End diff --
That's a good point, `CommandInfo` is using `/bin/sh` to launch the
command. :confused:
Spaces should be ok, everything else won't be correctly escaped. Skimming
through Spark properties I think the only ones that could pose problems are
`spark.authenticate.secret` and the other passwords (SSL, etc.). Still, this
needs a solution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user mgummelt commented on a diff in the pull request:
https://github.com/apache/spark/pull/10370#discussion_r50300018
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -440,6 +446,9 @@ private[spark] class MesosClusterScheduler(
.mkString(",")
options ++= Seq("--py-files", formattedFiles)
}
+desc.schedulerProperties
+ .filter { case (key, _) => !replicatedOptionsBlacklist.contains(key)
}
+ .foreach { case (key, value) => options ++= Seq("--conf",
s"""$key="$value) }
--- End diff --
Are lines 437-443 now redundant? If setting --total-executor-cores is
identical to --conf spark.cores.max, then we don't need to set both.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10370#discussion_r50311950
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -440,6 +446,9 @@ private[spark] class MesosClusterScheduler(
.mkString(",")
options ++= Seq("--py-files", formattedFiles)
}
+desc.schedulerProperties
+ .filter { case (key, _) => !replicatedOptionsBlacklist.contains(key)
}
+ .foreach { case (key, value) => options ++= Seq("--conf",
s"""$key="$value) }
--- End diff --
does this escape quotes, double quotes, whitespaces and backslashes
correctly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-173346330 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-173350537 **[Test build #49806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49806/consoleFull)** for PR 10370 at commit [`4b2b8b1`](https://github.com/apache/spark/commit/4b2b8b178820288610a91c81dd5b60864f1c27d7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-173379735 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49806/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-173379733 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-173379447 **[Test build #49806 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49806/consoleFull)** for PR 10370 at commit [`4b2b8b1`](https://github.com/apache/spark/commit/4b2b8b178820288610a91c81dd5b60864f1c27d7). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user dragos commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-173165007 The failed test is in Spark Streaming, no doubt it's a flaky one. LGTM. @andrewor14 can you please have a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-173009915 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/49706/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-173009909 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-172983845 **[Test build #49706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49706/consoleFull)** for PR 10370 at commit [`4b2b8b1`](https://github.com/apache/spark/commit/4b2b8b178820288610a91c81dd5b60864f1c27d7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-173009722 **[Test build #49706 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49706/consoleFull)** for PR 10370 at commit [`4b2b8b1`](https://github.com/apache/spark/commit/4b2b8b178820288610a91c81dd5b60864f1c27d7). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-11327] [MESOS] Dispatcher does not resp...
Github user jayv commented on the pull request: https://github.com/apache/spark/pull/10370#issuecomment-172980362 @dragos I don't remember seeing these errors on the 1.5.x branch I tested against,but I may have missed them since I was focussing on the missing args. This looks totally reasonable to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
