[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12715 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-217115059 Merged to master/2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-216957437 I think the best option is to shade Jersey if you need a different version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user fabriziocucci commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-216956211 Thanks Sean. So, just to recap regarding [this](https://issues.apache.org/jira/browse/SPARK-11081), whoever is stuck trying to use spark in a web application based on Jersey 2 has currently the following options: - wait for spark 2.0; - rollback the web application to use Jersey 1.9 (to be consistent with spark); - rollback the spark version to be 1.3.1 (the only one that can be easily integrated by simply excluding the *jersey-server* dependecy); - replace Jersey 2 in the web application with something else (e.g. spring mvc). Is my understanding correct? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-216853889 No, it's too significant a change for a maintenance release. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user fabriziocucci commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-216853442 Question: will this be ported to the 1.6 branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-216814149 LGTM; let me leave this open a short while longer for comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-216777553 @srowen given that Jersey 1 isn't being distributed, this PR should be good to go? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-216609823 I didn't see any old-Jersey jars in the lib directory. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-216506757 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-216506761 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57622/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-216506591 **[Test build #57622 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57622/consoleFull)** for PR 12715 at commit [`70d4844`](https://github.com/apache/spark/commit/70d48440423e9f1da06ef92f4810e82f04c0d491). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-216506352 This is looking good. Regarding the license, it depends on whether the artifacts we distribute contain Jersey 1.x or not. I have the impression it isn't at the moment. If you have the build handy and can look at the assembly and grep its contents, that would help verify whether 1.x classes are still there or not. If not, this is fine. Otherwise just restore the Jersey 1.x license statements. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-216483325 **[Test build #57622 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57622/consoleFull)** for PR 12715 at commit [`70d4844`](https://github.com/apache/spark/commit/70d48440423e9f1da06ef92f4810e82f04c0d491). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-216480186 @srowen Should the NOTICE still contain Jersey 1 since I think we still pull it in explicitly for YARN unit tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12715#discussion_r61683914 --- Diff: yarn/pom.xml --- @@ -147,20 +147,34 @@ test + + com.sun.jersey jersey-core test + 1.9 --- End diff -- One last finishing touch .. you could define (in just this pom) a property for Jersey 1.x versions to make sure they're modified together. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215731898 Yeah you can update the following section of `NOTICE` to read as follows and that should be it: ``` Common Development and Distribution License 1.0 The following components are provided under the Common Development and Distribution License 1.0. See project link for details. (CDDL 1.0) Glassfish Jasper (org.mortbay.jetty:jsp-2.1:6.1.14 - http://jetty.mortbay.org/project/modules/jsp-2.1) (CDDL 1.0) JAX-RS (https://jax-rs-spec.java.net/) (CDDL 1.0) Servlet Specification 2.5 API (org.mortbay.jetty:servlet-api-2.5:6.1.14 - http://jetty.mortbay.org/project/modules/servlet-api-2.5) (CDDL 1.0) (GPL2 w/ CPE) javax.annotation API (https://glassfish.java.net/nonav/public/CDDL+GPL.html) (COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.0) (GNU General Public Library) Streaming API for XML (javax.xml.stream:stax-api:1.0-2 - no url defined) (Common Development and Distribution License (CDDL) v1.0) JavaBeans Activation Framework (JAF) (javax.activation:activation:1.1 - http://java.sun.com/products/javabeans/jaf/index.jsp) Common Development and Distribution License 1.1 The following components are provided under the Common Development and Distribution License 1.1. See project link for details. (CDDL 1.1) (GPL2 w/ CPE) org.glassfish.hk2 (https://hk2.java.net) (CDDL 1.1) (GPL2 w/ CPE) JAXB API bundle for GlassFish V3 (javax.xml.bind:jaxb-api:2.2.2 - https://jaxb.dev.java.net/) (CDDL 1.1) (GPL2 w/ CPE) JAXB RI (com.sun.xml.bind:jaxb-impl:2.2.3-1 - http://jaxb.java.net/) (CDDL 1.1) (GPL2 w/ CPE) Jersey 2 (https://jersey.java.net) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215519249 LGTM, I'll leave this for @srowen since he had a comment about licenses. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/12715#discussion_r61477968 --- Diff: dev/deps/spark-deps-hadoop-2.3 --- @@ -73,32 +74,41 @@ hadoop-yarn-client-2.3.0.jar hadoop-yarn-common-2.3.0.jar hadoop-yarn-server-common-2.3.0.jar hadoop-yarn-server-web-proxy-2.3.0.jar +hk2-api-2.4.0-b34.jar +hk2-locator-2.4.0-b34.jar +hk2-utils-2.4.0-b34.jar httpclient-4.3.2.jar httpcore-4.3.2.jar ivy-2.4.0.jar jackson-annotations-2.5.3.jar jackson-core-2.5.3.jar jackson-core-asl-1.9.13.jar jackson-databind-2.5.3.jar -jackson-jaxrs-1.9.13.jar +jackson-jaxrs-base-2.5.3.jar +jackson-jaxrs-json-provider-2.5.3.jar jackson-mapper-asl-1.9.13.jar +jackson-module-jaxb-annotations-2.5.3.jar jackson-module-scala_2.11-2.5.3.jar -jackson-xc-1.9.13.jar janino-2.7.8.jar java-xmlbuilder-1.0.jar +javassist-3.18.1-GA.jar +javax.annotation-api-1.2.jar javax.inject-1.jar +javax.inject-2.4.0-b34.jar --- End diff -- I wouldn't say problematic, but both provide the exact same set of classes, so it's at least redundant. Being a javax API, I at least assume the newer one is backwards compatible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215293153 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57196/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215293150 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215292845 **[Test build #57196 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57196/consoleFull)** for PR 12715 at commit [`5a95559`](https://github.com/apache/spark/commit/5a9555901970a2b8ad8f252ea6d7b4b1cbcbdabf). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215274497 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215274499 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57184/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215274363 **[Test build #57184 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57184/consoleFull)** for PR 12715 at commit [`5a95559`](https://github.com/apache/spark/commit/5a9555901970a2b8ad8f252ea6d7b4b1cbcbdabf). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215272874 **[Test build #57196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57196/consoleFull)** for PR 12715 at commit [`5a95559`](https://github.com/apache/spark/commit/5a9555901970a2b8ad8f252ea6d7b4b1cbcbdabf). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215272685 That particular one shouldn't be affected by these changes. I'll take a closer look at it separately. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215272442 Hm... Are SparkLauncher tests just flaky or could this change have directly affected that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215272455 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215269276 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215269277 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57182/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215269134 **[Test build #57182 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57182/consoleFull)** for PR 12715 at commit [`a199cb6`](https://github.com/apache/spark/commit/a199cb693190a1fd2523b0952373683973e80e7d). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215247454 **[Test build #57184 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57184/consoleFull)** for PR 12715 at commit [`5a95559`](https://github.com/apache/spark/commit/5a9555901970a2b8ad8f252ea6d7b4b1cbcbdabf). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215246070 **[Test build #57182 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57182/consoleFull)** for PR 12715 at commit [`a199cb6`](https://github.com/apache/spark/commit/a199cb693190a1fd2523b0952373683973e80e7d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215232941 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57177/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215232932 **[Test build #57177 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57177/consoleFull)** for PR 12715 at commit [`bfb178a`](https://github.com/apache/spark/commit/bfb178a5db17cc252f55b19a160e757ce364cbb2). * This patch **fails build dependency tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215232940 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215232181 **[Test build #57177 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57177/consoleFull)** for PR 12715 at commit [`bfb178a`](https://github.com/apache/spark/commit/bfb178a5db17cc252f55b19a160e757ce364cbb2). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215231624 **[Test build #57174 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57174/consoleFull)** for PR 12715 at commit [`bed5618`](https://github.com/apache/spark/commit/bed5618660ff06206e63b4aa55aa1d5f9dfd53dc). * This patch **fails build dependency tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215231632 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215231634 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57174/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/12715#discussion_r61337523 --- Diff: external/kafka-assembly/pom.xml --- @@ -66,13 +66,16 @@ provided - com.sun.jersey - jersey-server - provided + org.glassfish.jersey.core + jersey-client --- End diff -- Just poked a bit through the Git history and it's to not include the jars that the assembly already provides. Although we no longer use an assembly jar... this still applies since we'll get org.glassfish.jersey from the main Spark classpath as we were before, so I'll put provided back in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/12715#discussion_r61337280 --- Diff: external/kafka-assembly/pom.xml --- @@ -66,13 +66,16 @@ provided - com.sun.jersey - jersey-server - provided + org.glassfish.jersey.core + jersey-client --- End diff -- In fact, like the thrift server case, it may be the case that the explicit dependency isn't even needed. Just make sure the classes do not show up in the generated jar. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215230889 **[Test build #57174 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57174/consoleFull)** for PR 12715 at commit [`bed5618`](https://github.com/apache/spark/commit/bed5618660ff06206e63b4aa55aa1d5f9dfd53dc). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/12715#discussion_r61337129 --- Diff: external/kafka-assembly/pom.xml --- @@ -66,13 +66,16 @@ provided - com.sun.jersey - jersey-server - provided + org.glassfish.jersey.core + jersey-client --- End diff -- Because it's already packaged with Spark. And this assembly will run inside of Spark. So there's no need to package it again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/12715#discussion_r61336946 --- Diff: external/kafka-assembly/pom.xml --- @@ -66,13 +66,16 @@ provided - com.sun.jersey - jersey-server - provided + org.glassfish.jersey.core + jersey-client --- End diff -- I'd like to know more precisely why the dependency was marked as provided in the first place. Any ideas? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/12715#discussion_r61333101 --- Diff: pom.xml --- @@ -909,6 +958,18 @@ commons-logging commons-logging + --- End diff -- A primitive test to spin up a Spark shell in client mode worked. Cluster mode running SparkPi also worked. Hadoop cluster was just on my local machine running 2.5.0-CDH5.3.3. I built Spark against Hadoop 2.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215215618 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57155/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215215614 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215215406 **[Test build #57155 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57155/consoleFull)** for PR 12715 at commit [`c9b5c3b`](https://github.com/apache/spark/commit/c9b5c3b42f32bcca9892fb4699afb53cde0f5e26). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/12715#discussion_r61320744 --- Diff: sql/hive-thriftserver/pom.xml --- @@ -69,17 +69,21 @@ hive-beeline - com.sun.jersey - jersey-core + org.glassfish.jersey.core --- End diff -- It probably wouldn't build if the dependencies were missing and were needed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/12715#discussion_r61317719 --- Diff: pom.xml --- @@ -909,6 +958,18 @@ commons-logging commons-logging + --- End diff -- I'll give it a whirl today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/12715#discussion_r61317823 --- Diff: sql/hive-thriftserver/pom.xml --- @@ -69,17 +69,21 @@ hive-beeline - com.sun.jersey - jersey-core + org.glassfish.jersey.core --- End diff -- Unclear - would this be something that is caught in a unit test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215182752 **[Test build #57155 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57155/consoleFull)** for PR 12715 at commit [`c9b5c3b`](https://github.com/apache/spark/commit/c9b5c3b42f32bcca9892fb4699afb53cde0f5e26). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215182426 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-215182048 @JoshRosen I did not change the Jersey dependency for the docker-integration-tests project. Should we change that here or leave it alone? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/12715#discussion_r61309040 --- Diff: sql/hive-thriftserver/pom.xml --- @@ -69,17 +69,21 @@ hive-beeline - com.sun.jersey - jersey-core + org.glassfish.jersey.core --- End diff -- I know you're just doing a find / replace here, but are these dependencies even needed in this module? I don't see any explicit references to jersey in the code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/12715#discussion_r61308784 --- Diff: pom.xml --- @@ -909,6 +958,18 @@ commons-logging commons-logging + --- End diff -- It would be good to at least make sure YARN submission works outside unit tests. @mccheah can you do that? Otherwise I can try to find some time to build and test this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/12715#discussion_r61308277 --- Diff: external/kafka-assembly/pom.xml --- @@ -66,13 +66,16 @@ provided - com.sun.jersey - jersey-server - provided + org.glassfish.jersey.core + jersey-client --- End diff -- Should this (and the one below) be provided too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12715#discussion_r61220565 --- Diff: pom.xml --- @@ -909,6 +958,18 @@ commons-logging commons-logging + --- End diff -- I think it's the right thing to do; we'll have to see if excluding Jersey 1 breaks other things internal to Hadoop that we need that use Jersey 1. Looks like you caught one example for YARN testing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/12715#discussion_r61220471 --- Diff: dev/deps/spark-deps-hadoop-2.2 --- @@ -6,6 +6,7 @@ antlr-2.7.7.jar antlr-runtime-3.4.jar antlr4-runtime-4.5.2-1.jar aopalliance-1.0.jar +aopalliance-repackaged-2.4.0-b34.jar --- End diff -- We'll probably have to look at the impact on the LICENSE file for all these dependency changes. I can help do that bit if once we're pretty sure this will work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214972164 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214972166 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57082/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214972072 **[Test build #57082 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57082/consoleFull)** for PR 12715 at commit [`c9b5c3b`](https://github.com/apache/spark/commit/c9b5c3b42f32bcca9892fb4699afb53cde0f5e26). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214960489 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57070/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214960488 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214960402 **[Test build #57070 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57070/consoleFull)** for PR 12715 at commit [`c9b5c3b`](https://github.com/apache/spark/commit/c9b5c3b42f32bcca9892fb4699afb53cde0f5e26). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214959194 **[Test build #57082 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57082/consoleFull)** for PR 12715 at commit [`c9b5c3b`](https://github.com/apache/spark/commit/c9b5c3b42f32bcca9892fb4699afb53cde0f5e26). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214959134 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214958903 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214958905 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57067/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214958819 **[Test build #57067 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57067/consoleFull)** for PR 12715 at commit [`313401b`](https://github.com/apache/spark/commit/313401be95ede3591f605438052f6929e07ff52d). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214938772 **[Test build #57070 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57070/consoleFull)** for PR 12715 at commit [`c9b5c3b`](https://github.com/apache/spark/commit/c9b5c3b42f32bcca9892fb4699afb53cde0f5e26). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214938308 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57069/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214938306 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214938300 **[Test build #57069 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57069/consoleFull)** for PR 12715 at commit [`5793600`](https://github.com/apache/spark/commit/5793600a00f33c9a673900e75f92df7152179c78). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214938134 **[Test build #57069 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57069/consoleFull)** for PR 12715 at commit [`5793600`](https://github.com/apache/spark/commit/5793600a00f33c9a673900e75f92df7152179c78). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214937460 **[Test build #57067 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57067/consoleFull)** for PR 12715 at commit [`313401b`](https://github.com/apache/spark/commit/313401be95ede3591f605438052f6929e07ff52d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214929851 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57041/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214929735 **[Test build #57041 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57041/consoleFull)** for PR 12715 at commit [`e2dbf03`](https://github.com/apache/spark/commit/e2dbf03270b2db30eb28064408b5c794e7cb4939). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214929849 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/12715#discussion_r61183732 --- Diff: yarn/pom.xml --- @@ -148,20 +148,25 @@ test - com.sun.jersey - jersey-core + org.glassfish.jersey.core --- End diff -- Actually this doesn't work because the Mini YARN cluster needs Jersey 1 to start up. Since this is only in test scope we should be fine to keep the Jersey 1 dependency here - I'll add a comment to clarify that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/11223#issuecomment-214905547 Moved to #12715 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214904791 **[Test build #57041 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57041/consoleFull)** for PR 12715 at commit [`e2dbf03`](https://github.com/apache/spark/commit/e2dbf03270b2db30eb28064408b5c794e7cb4939). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214902315 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57039/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214902304 **[Test build #57039 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57039/consoleFull)** for PR 12715 at commit [`b4d72d8`](https://github.com/apache/spark/commit/b4d72d8d5e2e0c3d717553eeedca2e500b19c65d). * This patch **fails build dependency tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214902311 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214901567 **[Test build #57039 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57039/consoleFull)** for PR 12715 at commit [`b4d72d8`](https://github.com/apache/spark/commit/b4d72d8d5e2e0c3d717553eeedca2e500b19c65d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/12715#discussion_r61171580 --- Diff: dev/deps/spark-deps-hadoop-2.3 --- @@ -73,32 +74,41 @@ hadoop-yarn-client-2.3.0.jar hadoop-yarn-common-2.3.0.jar hadoop-yarn-server-common-2.3.0.jar hadoop-yarn-server-web-proxy-2.3.0.jar +hk2-api-2.4.0-b34.jar +hk2-locator-2.4.0-b34.jar +hk2-utils-2.4.0-b34.jar httpclient-4.3.2.jar httpcore-4.3.2.jar ivy-2.4.0.jar jackson-annotations-2.5.3.jar jackson-core-2.5.3.jar jackson-core-asl-1.9.13.jar jackson-databind-2.5.3.jar -jackson-jaxrs-1.9.13.jar +jackson-jaxrs-base-2.5.3.jar +jackson-jaxrs-json-provider-2.5.3.jar jackson-mapper-asl-1.9.13.jar +jackson-module-jaxb-annotations-2.5.3.jar jackson-module-scala_2.11-2.5.3.jar -jackson-xc-1.9.13.jar janino-2.7.8.jar java-xmlbuilder-1.0.jar +javassist-3.18.1-GA.jar +javax.annotation-api-1.2.jar javax.inject-1.jar +javax.inject-2.4.0-b34.jar --- End diff -- Is it problematic to have both javax.inject-1 and javax.inject-2.4.0? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214899572 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57035/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214899571 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214899564 **[Test build #57035 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57035/consoleFull)** for PR 12715 at commit [`b86ed6f`](https://github.com/apache/spark/commit/b86ed6f38fe0440bf7ad4ae9a304f88c64817989). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12715#issuecomment-214899315 **[Test build #57035 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57035/consoleFull)** for PR 12715 at commit [`b86ed6f`](https://github.com/apache/spark/commit/b86ed6f38fe0440bf7ad4ae9a304f88c64817989). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
GitHub user mccheah opened a pull request: https://github.com/apache/spark/pull/12715 [SPARK-12154] Upgrade to Jersey 2 ## What changes were proposed in this pull request? Replace com.sun.jersey with org.glassfish.jersey. Changes to the Spark Web UI code were required to compile. The changes were relatively standard Jersey migration things. ## How was this patch tested? I did a manual test for the standalone web APIs. Although I didn't test the functionality of the security filter itself, the code that changed non-trivially is how we actually register the filter. I attached a debugger to the Spark master and verified that the SecurityFilter code is indeed invoked upon hitting /api/v1/applications. You can merge this pull request into a Git repository by running: $ git pull https://github.com/palantir/spark feature/upgrade-jersey Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/12715.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12715 commit b86ed6f38fe0440bf7ad4ae9a304f88c64817989 Author: mcheah Date: 2016-04-26T20:48:00Z [SPARK-12154] Upgrade to Jersey 2 Changes to the Spark Web UI code were required to compile. The changes were relatively standard Jersey migration things. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/11223#issuecomment-214832428 Apologize for not following up here. Since writing the initial change I think there may have been a lot of shifting from underneath (merge conflicts) so I'm going to close this and rewrite it. I'm going to fix all the Jackson versions to the same 2.x dependency. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user mccheah closed the pull request at: https://github.com/apache/spark/pull/11223 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11223#issuecomment-214678267 @mccheah are you still able to pursue this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11223#issuecomment-192002245 For example: ``` jackson-annotations-2.5.3.jar jackson-core-2.5.3.jar jackson-core-asl-1.9.13.jar jackson-databind-2.5.3.jar jackson-jaxrs-base-2.5.4.jar jackson-jaxrs-json-provider-2.5.4.jar jackson-mapper-asl-1.9.13.jar jackson-module-jaxb-annotations-2.5.4.jar jackson-module-scala_2.11-2.5.3.jar ``` I know we're going to have 1.x and 2.x pulled in, but the 2.x versions don't totally align. I wouldn't mind managing them all to the same version for tidiness, even if it's ultimately a game of whack-a-mole. I don't have any specific reason to think 2.5.3 and 2.5.4 don't work, but if the Spark version goes to 2.6.x while others stay on 2.5.3 it could be a problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user mccheah commented on the pull request: https://github.com/apache/spark/pull/11223#issuecomment-191910118 I don't think I see any specific Jackson dependencies with different versions, but different Jackson modules have different versions being pulled in. How would I go about finding out if these different versions with play nicely with one another? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11223#issuecomment-191669921 This needs a few things -- a rebase of course. Next I'm concerned with dependency harmonization. For example I see differing versions of Jackson dependencies being pulled in. I think I expect to see both 1.x and 2.x dependencies, but not different versions of 1.x or 2.x. Likewise with Jersey, it seems like a few 1.x dependencies are still coming in. Figuring this out is the painful part. We also need to update LICENSE files to reflect new dependencies. More tests can't hurt; I don't know how to test the security aspect. Tests do in general basically exercise the web UI already. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org