[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-170847516 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-170878704 **[Test build #2369 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2369/consoleFull)** for PR 10587 at commit [`d045ea9`](https://github.com/apache/spark/commit/d045ea9cf80a13d98aeab6c9c79f14dca93e00d4). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-170905070 **[Test build #2369 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2369/consoleFull)** for PR 10587 at commit [`d045ea9`](https://github.com/apache/spark/commit/d045ea9cf80a13d98aeab6c9c79f14dca93e00d4). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10587 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-170909366 merged to master/1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-170756165 Same error with #10685. Wait hot fix #10704 take effect. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-170487015 **[Test build #2361 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2361/consoleFull)** for PR 10587 at commit [`d045ea9`](https://github.com/apache/spark/commit/d045ea9cf80a13d98aeab6c9c79f14dca93e00d4). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-170514576 **[Test build #2361 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2361/consoleFull)** for PR 10587 at commit [`d045ea9`](https://github.com/apache/spark/commit/d045ea9cf80a13d98aeab6c9c79f14dca93e00d4). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-170555928 I can't imagine it's related as it's just a doc change, so must be flaky tests, but let me just run it again --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-170541326 @srowen Do you know what happened? I check the failed log but don't know why. EVN issues? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-170549807 **[Test build #2363 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2363/consoleFull)** for PR 10587 at commit [`d045ea9`](https://github.com/apache/spark/commit/d045ea9cf80a13d98aeab6c9c79f14dca93e00d4). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-170556401 **[Test build #2364 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2364/consoleFull)** for PR 10587 at commit [`d045ea9`](https://github.com/apache/spark/commit/d045ea9cf80a13d98aeab6c9c79f14dca93e00d4). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-170516355 **[Test build #2363 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2363/consoleFull)** for PR 10587 at commit [`d045ea9`](https://github.com/apache/spark/commit/d045ea9cf80a13d98aeab6c9c79f14dca93e00d4). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-170587084 **[Test build #2364 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2364/consoleFull)** for PR 10587 at commit [`d045ea9`](https://github.com/apache/spark/commit/d045ea9cf80a13d98aeab6c9c79f14dca93e00d4). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-170423933 Thank you @srowen, I refine parameter explanation base on your suggestion. Pls take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/10587#discussion_r49174933 --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala --- @@ -1089,6 +1097,14 @@ abstract class RDD[T: ClassTag]( * and one operation for merging two U's, as in scala.TraversableOnce. Both of these functions are * allowed to modify and return their first argument instead of creating a new U to avoid memory * allocation. + * + * @param zeroValue the initial value for the accumulated result of each partition for the seqOp + * operator, and also the initial value for the combine results from different + * partitions for the conbOp operator. + * - this will typically be the neutral element. --- End diff -- There are some typos now, like conbOp instead of combOp. Also there's a dangling phrase in both starting with "-" which is supposed to join the previous sentence? while you're here you can back-tick `Nil` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-169839655 @srowen it pass test now. ready for merge. Thanks for review. Wenpei --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-169617160 It looks unrelated to your change, I agree. I can try retesting, but you may somehow need a rebase to work around it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-169615279 Fix it. But I found for jenkins result, line number did not march with correct line. For example, jenkins result [error] /home/jenkins/workspace/NewSparkPullRequestBuilder/core/src/main/scala/org/apache/spark/rdd/RDD.scala:976:58: Whitespace at end of line But real line number should be 1077. Is that a issues? Please test again, jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-169643784 **[Test build #2346 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2346/consoleFull)** for PR 10587 at commit [`11a929b`](https://github.com/apache/spark/commit/11a929bfb3223e5fc0c08b768837d6d438382bf8). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-169618254 **[Test build #2346 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2346/consoleFull)** for PR 10587 at commit [`11a929b`](https://github.com/apache/spark/commit/11a929bfb3223e5fc0c08b768837d6d438382bf8). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-169270733 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-169321253 **[Test build #2334 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2334/consoleFull)** for PR 10587 at commit [`35b4bc8`](https://github.com/apache/spark/commit/35b4bc86c9dac54d5990887095f82037d83568ef). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-169315605 thanks,@srowen @rxin There is no Jenkins report, anything need for me? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-169321019 **[Test build #2334 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2334/consoleFull)** for PR 10587 at commit [`35b4bc8`](https://github.com/apache/spark/commit/35b4bc86c9dac54d5990887095f82037d83568ef). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12638] [API DOC] Parameter explanation ...
Github user Wenpei commented on the pull request: https://github.com/apache/spark/pull/10587#issuecomment-169542618 Fix scala style test failed. Please test again, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
