[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11829 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-201811055 @rekhajoshm ha thanks I guess that was it. I'll merge this to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-201702668 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54246/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-201702667 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-201702555 **[Test build #54246 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54246/consoleFull)** for PR 11829 at commit [`6449b68`](https://github.com/apache/spark/commit/6449b684c26eb7f0cd5984c5ef1f11f6fa7f1dee). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-201663130 **[Test build #54246 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54246/consoleFull)** for PR 11829 at commit [`6449b68`](https://github.com/apache/spark/commit/6449b684c26eb7f0cd5984c5ef1f11f6fa7f1dee). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11829#discussion_r57470219 --- Diff: bin/pyspark --- @@ -49,7 +49,10 @@ if [[ -n "$IPYTHON_OPTS" || "$IPYTHON" == "1" ]]; then # If IPython options are specified, assume user wants to run IPython # (for backwards-compatibility) PYSPARK_DRIVER_PYTHON_OPTS="$PYSPARK_DRIVER_PYTHON_OPTS $IPYTHON_OPTS" - PYSPARK_DRIVER_PYTHON="ipython" + if [ -x "$(command -v jupyter)" ]; then +PYSPARK_DRIVER_PYTHON="jupyter" + else +PYSPARK_DRIVER_PYTHON="ipython" --- End diff -- @rekhajoshm I keep thinking the test failures are spurious, and clearly some of them are, but I'm now double-checking that this seemingly simple change is actually right. Do you not need a closing `fi` after this line? not sure if it's implicit but was speculating that maybe this is causing a failure in a mysterious way at the end when Pyspark tests start. Could be a wrong guess. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-201339819 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-201339820 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54176/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-201339654 **[Test build #54176 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54176/consoleFull)** for PR 11829 at commit [`e1a0c40`](https://github.com/apache/spark/commit/e1a0c40d4ec4101074f8e5310f357cedbdbec60a). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-201291268 **[Test build #54176 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54176/consoleFull)** for PR 11829 at commit [`e1a0c40`](https://github.com/apache/spark/commit/e1a0c40d4ec4101074f8e5310f357cedbdbec60a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-201289533 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200900065 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200899971 **[Test build #54035 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54035/consoleFull)** for PR 11829 at commit [`e1a0c40`](https://github.com/apache/spark/commit/e1a0c40d4ec4101074f8e5310f357cedbdbec60a). * This patch **fails from timeout after a configured wait of \`250m\`**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200900066 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54035/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200801756 **[Test build #54035 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54035/consoleFull)** for PR 11829 at commit [`e1a0c40`](https://github.com/apache/spark/commit/e1a0c40d4ec4101074f8e5310f357cedbdbec60a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200801043 Different failures each time; gotta be spurious --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200801057 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200799883 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54030/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200799881 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200799731 **[Test build #54030 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54030/consoleFull)** for PR 11829 at commit [`e1a0c40`](https://github.com/apache/spark/commit/e1a0c40d4ec4101074f8e5310f357cedbdbec60a). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200762400 **[Test build #54030 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/54030/consoleFull)** for PR 11829 at commit [`e1a0c40`](https://github.com/apache/spark/commit/e1a0c40d4ec4101074f8e5310f357cedbdbec60a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200760957 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200490475 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53944/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200490471 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200490127 **[Test build #53944 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53944/consoleFull)** for PR 11829 at commit [`e1a0c40`](https://github.com/apache/spark/commit/e1a0c40d4ec4101074f8e5310f357cedbdbec60a). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200435179 **[Test build #53944 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53944/consoleFull)** for PR 11829 at commit [`e1a0c40`](https://github.com/apache/spark/commit/e1a0c40d4ec4101074f8e5310f357cedbdbec60a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200434701 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200385863 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53928/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200385859 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200385764 **[Test build #53928 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53928/consoleFull)** for PR 11829 at commit [`e1a0c40`](https://github.com/apache/spark/commit/e1a0c40d4ec4101074f8e5310f357cedbdbec60a). * This patch **fails from timeout after a configured wait of \`250m\`**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200295780 **[Test build #53928 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53928/consoleFull)** for PR 11829 at commit [`e1a0c40`](https://github.com/apache/spark/commit/e1a0c40d4ec4101074f8e5310f357cedbdbec60a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-200294988 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/11829#discussion_r56720023 --- Diff: bin/pyspark --- @@ -49,7 +49,10 @@ if [[ -n "$IPYTHON_OPTS" || "$IPYTHON" == "1" ]]; then # If IPython options are specified, assume user wants to run IPython # (for backwards-compatibility) PYSPARK_DRIVER_PYTHON_OPTS="$PYSPARK_DRIVER_PYTHON_OPTS $IPYTHON_OPTS" - PYSPARK_DRIVER_PYTHON="ipython" + if [ -x "$(command -v jupyter)" ]; then +PYSPARK_DRIVER_PYTHON="jupyter" + elif --- End diff -- Should this line not be `else`? CC @davies --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-198535458 **[Test build #53561 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53561/consoleFull)** for PR 11829 at commit [`031f157`](https://github.com/apache/spark/commit/031f157c82616e5a7220e1f5aa206fae6ac07b1c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-198552372 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-198552276 **[Test build #53567 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53567/consoleFull)** for PR 11829 at commit [`e1a0c40`](https://github.com/apache/spark/commit/e1a0c40d4ec4101074f8e5310f357cedbdbec60a). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-198719803 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53616/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-198719802 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-198719764 **[Test build #53616 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53616/consoleFull)** for PR 11829 at commit [`e1a0c40`](https://github.com/apache/spark/commit/e1a0c40d4ec4101074f8e5310f357cedbdbec60a). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-198703377 **[Test build #53616 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53616/consoleFull)** for PR 11829 at commit [`e1a0c40`](https://github.com/apache/spark/commit/e1a0c40d4ec4101074f8e5310f357cedbdbec60a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-198703257 LGTM @davies any concerns about this? it would change beahvior if you don't specify an ipython driver, have both an old and new ipython installed. You'd use jupyter now instead of ipython as the command but that seems desirable in this situation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-198703225 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-198545701 **[Test build #53567 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53567/consoleFull)** for PR 11829 at commit [`e1a0c40`](https://github.com/apache/spark/commit/e1a0c40d4ec4101074f8e5310f357cedbdbec60a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
GitHub user rekhajoshm opened a pull request: https://github.com/apache/spark/pull/11829 [SPARK-13973] [PySpark]: `ipython notebook` is going away ## What changes were proposed in this pull request? https://issues.apache.org/jira/browse/SPARK-13973 ## How was this patch tested? Pyspark You can merge this pull request into a Git repository by running: $ git pull https://github.com/rekhajoshm/spark SPARK-13973 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/11829.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #11829 commit e3677c9fa9697e0d34f9df52442085a6a481c9e9 Author: Rekha Joshi Date: 2015-05-05T23:10:08Z Merge pull request #1 from apache/master Pulling functionality from apache spark commit 106fd8eee8f6a6f7c67cfc64f57c1161f76d8f75 Author: Rekha Joshi Date: 2015-05-08T21:49:09Z Merge pull request #2 from apache/master pull latest from apache spark commit 0be142d6becba7c09c6eba0b8ea1efe83d649e8c Author: Rekha Joshi Date: 2015-06-22T00:08:08Z Merge pull request #3 from apache/master Pulling functionality from apache spark commit 6c6ee12fd733e3f9902e10faf92ccb78211245e3 Author: Rekha Joshi Date: 2015-09-17T01:03:09Z Merge pull request #4 from apache/master Pulling functionality from apache spark commit b123c601e459d1ad17511fd91dd304032154882a Author: Rekha Joshi Date: 2015-11-25T18:50:32Z Merge pull request #5 from apache/master pull request from apache/master commit c73c32aadd6066e631956923725a48d98a18777e Author: Rekha Joshi Date: 2016-03-18T19:13:51Z Merge pull request #6 from apache/master pull latest from apache spark commit 031f157c82616e5a7220e1f5aa206fae6ac07b1c Author: Joshi Date: 2016-03-18T20:40:32Z pyspark for preferred jupyter over ipython if available --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-198565832 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-198565836 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53561/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-198565727 **[Test build #53561 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53561/consoleFull)** for PR 11829 at commit [`031f157`](https://github.com/apache/spark/commit/031f157c82616e5a7220e1f5aa206fae6ac07b1c). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13973] [PySpark]: `ipython notebook` is...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11829#issuecomment-198552377 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53567/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org