[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-215204718 Thank you so much, @hvanhovell ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12421 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-215203897 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-215203971 Merging to master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-215202725 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-215202728 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57149/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-215202447 **[Test build #57149 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57149/consoleFull)** for PR 12421 at commit [`b2ac335`](https://github.com/apache/spark/commit/b2ac335fedac91b7db710f38e2801a9ea756748e). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-215198684 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-215198685 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/57147/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-215198368 **[Test build #57147 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57147/consoleFull)** for PR 12421 at commit [`152c6c2`](https://github.com/apache/spark/commit/152c6c2c854e2f0628c7f945ef5900f129080e0d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-215172349 @hvanhovell . Thank you for squeezing your precious time for reviewing my PR several times. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-215171546 **[Test build #57149 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57149/consoleFull)** for PR 12421 at commit [`b2ac335`](https://github.com/apache/spark/commit/b2ac335fedac91b7db710f38e2801a9ea756748e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-215170046 **[Test build #57147 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57147/consoleFull)** for PR 12421 at commit [`152c6c2`](https://github.com/apache/spark/commit/152c6c2c854e2f0628c7f945ef5900f129080e0d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12421#discussion_r61304575
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1343,17 +1343,32 @@ object DecimalAggregates extends Rule[LogicalPlan] {
/** Maximum number of decimal digits representable precisely in a Double
*/
private val MAX_DOUBLE_DIGITS = 15
- def apply(plan: LogicalPlan): LogicalPlan = plan transformAllExpressions
{
-case ae @ AggregateExpression(Sum(e @ DecimalType.Expression(prec,
scale)), _, _, _)
- if prec + 10 <= MAX_LONG_DIGITS =>
- MakeDecimal(ae.copy(aggregateFunction = Sum(UnscaledValue(e))), prec
+ 10, scale)
-
-case ae @ AggregateExpression(Average(e @ DecimalType.Expression(prec,
scale)), _, _, _)
- if prec + 4 <= MAX_DOUBLE_DIGITS =>
- val newAggExpr = ae.copy(aggregateFunction =
Average(UnscaledValue(e)))
- Cast(
-Divide(newAggExpr, Literal.create(math.pow(10.0, scale),
DoubleType)),
-DecimalType(prec + 4, scale + 4))
+ def apply(plan: LogicalPlan): LogicalPlan = plan transform {
--- End diff --
Indeed, those pattern matchings are too deep.
I'll remove some duplication caused by hierarchy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12421#discussion_r61298823
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WindowExec.scala ---
@@ -177,6 +177,8 @@ case class WindowExec(
case e @ WindowExpression(function, spec) =>
val frame =
spec.frameSpecification.asInstanceOf[SpecifiedWindowFrame]
function match {
+case MakeDecimal(AggregateExpression(f, _, _, _), prec, scale)
=>
--- End diff --
Oh, my bad. You're right.
I missed recovering that. I'll remove this.
WindowExec.scala is solid and there is no need to be changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12421#discussion_r61295168
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -430,4 +430,13 @@ class DataFrameAggregateSuite extends QueryTest with
SharedSQLContext {
expr("kurtosis(a)")),
Row(null, null, null, null, null))
}
+
+ test("SPARK-14664: Decimal sum/avg over window should work.") {
+checkAnswer(
+ sqlContext.sql("select sum(a) over () from (select
explode(array(1.0,2.0,3.0)) a) t"),
--- End diff --
Thank you. I will use this consice form.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-215058208 @dongjoon-hyun The PR is in pretty good shape. I left a few small comments/questions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12421#discussion_r61242062
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1343,17 +1343,32 @@ object DecimalAggregates extends Rule[LogicalPlan] {
/** Maximum number of decimal digits representable precisely in a Double
*/
private val MAX_DOUBLE_DIGITS = 15
- def apply(plan: LogicalPlan): LogicalPlan = plan transformAllExpressions
{
-case ae @ AggregateExpression(Sum(e @ DecimalType.Expression(prec,
scale)), _, _, _)
- if prec + 10 <= MAX_LONG_DIGITS =>
- MakeDecimal(ae.copy(aggregateFunction = Sum(UnscaledValue(e))), prec
+ 10, scale)
-
-case ae @ AggregateExpression(Average(e @ DecimalType.Expression(prec,
scale)), _, _, _)
- if prec + 4 <= MAX_DOUBLE_DIGITS =>
- val newAggExpr = ae.copy(aggregateFunction =
Average(UnscaledValue(e)))
- Cast(
-Divide(newAggExpr, Literal.create(math.pow(10.0, scale),
DoubleType)),
-DecimalType(prec + 4, scale + 4))
+ def apply(plan: LogicalPlan): LogicalPlan = plan transform {
--- End diff --
MINOR: I don't suppose there are ways to make this a bit more
concise/readable?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12421#discussion_r61241988
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WindowExec.scala ---
@@ -177,6 +177,8 @@ case class WindowExec(
case e @ WindowExpression(function, spec) =>
val frame =
spec.frameSpecification.asInstanceOf[SpecifiedWindowFrame]
function match {
+case MakeDecimal(AggregateExpression(f, _, _, _), prec, scale)
=>
--- End diff --
When does a `WindowExpression` contain a `MakeDecimal`? As I understand
your code correctly, the following things can happen:
# Sum
The following input:
```Scala
WindowExpression(AggregateExpression(Sum(x), ...), spec)
```
is rewritten into:
```scala
MakeDecimal(WindowExpression(AggregateExpression(Sum(UnscaledValue(x)),
...), spec), prec + 10, scale)
```
# Average
The following input:
```Scala
WindowExpression(AggregateExpression(Average(x), ...), spec)
```
is rewritten into:
```scala
Cast(Divide(WindowExpression(AggregateExpression(Average(UnscaledValue(x)),
...), spec), Literal.create(math.pow(10.0, scale), DoubleType)),
DecimalType(prec + 4, scale + 4))
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/12421#discussion_r61240023
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -430,4 +430,13 @@ class DataFrameAggregateSuite extends QueryTest with
SharedSQLContext {
expr("kurtosis(a)")),
Row(null, null, null, null, null))
}
+
+ test("SPARK-14664: Decimal sum/avg over window should work.") {
+checkAnswer(
+ sqlContext.sql("select sum(a) over () from (select
explode(array(1.0,2.0,3.0)) a) t"),
--- End diff --
Note: you can also use `select sum(a) over () from values 1.0, 2.0, 3.0
x(a)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-215021880 @dongjoon-hyun I am gonna get to this today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-215012244 Hi, @rxin . Could you review and merge this PR? This fixes `RuntimeException` error for Window aggregation queries. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-214812007 Hi, @hvanhovell . Could you review this PR when you have some time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-214628538 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-214628541 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56968/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-214628385 **[Test build #56968 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56968/consoleFull)** for PR 12421 at commit [`14fe6b9`](https://github.com/apache/spark/commit/14fe6b978be9740feb4df4f4bd5c4dc1206af60b). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-214617100 **[Test build #56968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56968/consoleFull)** for PR 12421 at commit [`14fe6b9`](https://github.com/apache/spark/commit/14fe6b978be9740feb4df4f4bd5c4dc1206af60b). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-214616662 Rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-214570700 More test cases are added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-214569512 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/56935/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-214569510 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-214569373 **[Test build #56935 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56935/consoleFull)** for PR 12421 at commit [`45beddd`](https://github.com/apache/spark/commit/45beddd5316e32ecf9eb5eaf356a772366697191). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-214554325 **[Test build #56935 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56935/consoleFull)** for PR 12421 at commit [`45beddd`](https://github.com/apache/spark/commit/45beddd5316e32ecf9eb5eaf356a772366697191). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14664][SQL] Implement DecimalAggregates...
Github user dongjoon-hyun commented on the pull request: https://github.com/apache/spark/pull/12421#issuecomment-214207072 Hi, @hvanhovell . Now, it's ready for review again. Thank you so much. I couldn't fix this without your help. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
