[GitHub] spark pull request: [SPARK-15537] [SQL] fix dir delete issue

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/13304


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15537] [SQL] fix dir delete issue

[rxin]

Github user rxin commented on the pull request:

https://github.com/apache/spark/pull/13304#issuecomment-221796545
  
Thanks - merging in master/2.0.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15537] [SQL] fix dir delete issue

[srowen]

Github user srowen commented on the pull request:

https://github.com/apache/spark/pull/13304#issuecomment-221752391
  
LGTM, and I don't see other instances of this pattern.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15537] [SQL] fix dir delete issue

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13304#issuecomment-221740836
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59306/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15537] [SQL] fix dir delete issue

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13304#issuecomment-221740641
  
**[Test build #59306 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59306/consoleFull)**
 for PR 13304 at commit 
[`9b9ba5f`](https://github.com/apache/spark/commit/9b9ba5f9065c5a8eda6b7642c12a37e5e41853fc).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15537] [SQL] fix dir delete issue

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13304#issuecomment-221740835
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15537] [SQL] fix dir delete issue

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13304#issuecomment-221730596
  
**[Test build #59306 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59306/consoleFull)**
 for PR 13304 at commit 
[`9b9ba5f`](https://github.com/apache/spark/commit/9b9ba5f9065c5a8eda6b7642c12a37e5e41853fc).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15537] [SQL] fix dir delete issue

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13304#issuecomment-221730126
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15537] [SQL] fix dir delete issue

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13304#issuecomment-221730127
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59298/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15537] [SQL] fix dir delete issue

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13304#issuecomment-221729933
  
**[Test build #59298 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59298/consoleFull)**
 for PR 13304 at commit 
[`878b0cc`](https://github.com/apache/spark/commit/878b0cca355b21e84f08e8fc32f195485f1df14a).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15537] [SQL] fix dir delete issue

[bomeng]

Github user bomeng commented on a diff in the pull request:

https://github.com/apache/spark/pull/13304#discussion_r64665909
  
--- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcSourceSuite.scala ---
@@ -38,12 +39,12 @@ abstract class OrcSuite extends QueryTest with 
TestHiveSingleton with BeforeAndA
 super.beforeAll()
 
 orcTableAsDir = File.createTempFile("orctests", "sparksql")
-orcTableAsDir.delete()
+Utils.deleteRecursively(orcTableAsDir)
--- End diff --

Thanks for the comments. I will update the code shortly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15537] [SQL] fix dir delete issue

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13304#issuecomment-221721611
  
**[Test build #59299 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59299/consoleFull)**
 for PR 13304 at commit 
[`a776a42`](https://github.com/apache/spark/commit/a776a4296c80023985c2752db58aff70364b537f).
 * This patch **fails MiMa tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15537] [SQL] fix dir delete issue

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13304#issuecomment-221721636
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15537] [SQL] fix dir delete issue

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/13304#issuecomment-221721638
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59299/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15537] [SQL] fix dir delete issue

[srowen]

Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/13304#discussion_r64660855
  
--- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcSourceSuite.scala ---
@@ -38,12 +39,12 @@ abstract class OrcSuite extends QueryTest with 
TestHiveSingleton with BeforeAndA
 super.beforeAll()
 
 orcTableAsDir = File.createTempFile("orctests", "sparksql")
-orcTableAsDir.delete()
+Utils.deleteRecursively(orcTableAsDir)
--- End diff --

Use `Utils.createTempDir` rather than this which is hacky. It will be 
automatically cleaned up too. We shouldn't have to reinvent this logic


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15537] [SQL] fix dir delete issue

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13304#issuecomment-221719251
  
**[Test build #59299 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59299/consoleFull)**
 for PR 13304 at commit 
[`a776a42`](https://github.com/apache/spark/commit/a776a4296c80023985c2752db58aff70364b537f).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15537] [SQL] fix dir delete issue

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/13304#issuecomment-221716901
  
**[Test build #59298 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59298/consoleFull)**
 for PR 13304 at commit 
[`878b0cc`](https://github.com/apache/spark/commit/878b0cca355b21e84f08e8fc32f195485f1df14a).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-15537] [SQL] fix dir delete issue

[bomeng]

GitHub user bomeng opened a pull request:

https://github.com/apache/spark/pull/13304

[SPARK-15537] [SQL] fix dir delete issue

## What changes were proposed in this pull request?

For some of the test cases, e.g. OrcSourceSuite, it will create temp 
folders and temp files inside them. But after tests finish, the folders are not 
removed. This will cause lots of temp files created and space occupied, if we 
keep running the test cases.

The reason is dir.delete() won't work if dir is not empty. We need to 
recursively delete the content before deleting the folder.

## How was this patch tested?

Manually checked the temp folder to make sure the temp files were deleted.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bomeng/spark SPARK-15537

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/13304.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13304


commit 878b0cca355b21e84f08e8fc32f195485f1df14a
Author: Bo Meng 
Date:   2016-05-25T21:35:28Z

fix dir delete issue




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org