[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-56137301 @liancheng Ah, I saw sometimes Jenkins ignores us... but recently he is friendly :D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-56098496 @sarutak Actually Jenkins only listens to a limited group of people, and sometimes he even ignores this group for unknown reasons. Lots of work led by Josh had been done in the past weeks to make Jenkins happy, I think he'll be much more friendly and responsive soon :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2421 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-56023011 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20535/consoleFull) for PR 2421 at commit [`645a22a`](https://github.com/apache/spark/commit/645a22a3fe995bcdf0e0748a844591b92cbb3905). * This patch **passes** unit tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-56020425 @sarutak Thanks I see, thought only commiters can do it this way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-56019226 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20533/consoleFull) for PR 2421 at commit [`645a22a`](https://github.com/apache/spark/commit/645a22a3fe995bcdf0e0748a844591b92cbb3905). * This patch **passes** unit tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-56015001 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20535/consoleFull) for PR 2421 at commit [`645a22a`](https://github.com/apache/spark/commit/645a22a3fe995bcdf0e0748a844591b92cbb3905). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-56014536 @WangTaoTheTonic You can let Jenkins works by saying like "retest this please" or "test this please" without extra push. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-56010532 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20533/consoleFull) for PR 2421 at commit [`645a22a`](https://github.com/apache/spark/commit/645a22a3fe995bcdf0e0748a844591b92cbb3905). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-55999652 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20525/consoleFull) for PR 2421 at commit [`d6ae559`](https://github.com/apache/spark/commit/d6ae5591d0a3d7ab8de308159f94e6f2bc537f24). * This patch **fails** unit tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-55995533 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20525/consoleFull) for PR 2421 at commit [`d6ae559`](https://github.com/apache/spark/commit/d6ae5591d0a3d7ab8de308159f94e6f2bc537f24). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-55995237 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-55991903 Gosh, the test failed. I looked "block generator throttling" in NetworkReceiverSuite.scala but couldn't see why. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-55990357 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20518/consoleFull) for PR 2421 at commit [`d6ae559`](https://github.com/apache/spark/commit/d6ae5591d0a3d7ab8de308159f94e6f2bc537f24). * This patch **fails** unit tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-55989137 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20511/consoleFull) for PR 2421 at commit [`a2d6465`](https://github.com/apache/spark/commit/a2d6465cbf99c74969c4c3fc85be04810df76427). * This patch **passes** unit tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-55986533 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20518/consoleFull) for PR 2421 at commit [`d6ae559`](https://github.com/apache/spark/commit/d6ae5591d0a3d7ab8de308159f94e6f2bc537f24). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-55986443 Sorry for not noticnig "If a command is not found, the child process created to execute it returns a status of 127. If a command is found but is not executable, the return status is 126". Now using 101. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-55985869 @WangTaoTheTonic According to the wiki page @vanzin pointed out, values above 125 are used by bash for special purposes. Since the purpose of this PR is to reduce the possibility of exit code collision, just choose any value that is not too common and doesn't violate bash rules, not necessary to be prime :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2421#discussion_r17704596 --- Diff: sbin/start-thriftserver.sh --- @@ -27,7 +27,7 @@ set -o posix FWDIR="$(cd "`dirname "$0"`"/..; pwd)" CLASS="org.apache.spark.sql.hive.thriftserver.HiveThriftServer2" -CLASS_NOT_FOUND_EXIT_STATUS=1 +CLASS_NOT_FOUND_EXIT_STATUS=1024 --- End diff -- Thanks for the reference! Good to know, didn't know these specific rules before. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-55984246 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20511/consoleFull) for PR 2421 at commit [`a2d6465`](https://github.com/apache/spark/commit/a2d6465cbf99c74969c4c3fc85be04810df76427). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-55984128 Use 127 instead, it is the biggest prime number in those less than 128. How about it, guys? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/2421#discussion_r17700696 --- Diff: sbin/start-thriftserver.sh --- @@ -27,7 +27,7 @@ set -o posix FWDIR="$(cd "`dirname "$0"`"/..; pwd)" CLASS="org.apache.spark.sql.hive.thriftserver.HiveThriftServer2" -CLASS_NOT_FOUND_EXIT_STATUS=1 +CLASS_NOT_FOUND_EXIT_STATUS=1024 --- End diff -- Please keep error codes < 128. From http://en.wikipedia.org/wiki/Exit_status: When a command terminates on a fatal signal whose number is N, Bash uses the value 128+N as the exit status. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2421#discussion_r17700240 --- Diff: sbin/start-thriftserver.sh --- @@ -27,7 +27,7 @@ set -o posix FWDIR="$(cd "`dirname "$0"`"/..; pwd)" CLASS="org.apache.spark.sql.hive.thriftserver.HiveThriftServer2" -CLASS_NOT_FOUND_EXIT_STATUS=1 +CLASS_NOT_FOUND_EXIT_STATUS=1024 --- End diff -- Ah, good point! The integer is converted to an unsigned byte under bash. And for 1024, the converted value is actually 0, which is definitely not acceptable... Maybe some prime number like 251 instead? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user sarutak commented on a diff in the pull request: https://github.com/apache/spark/pull/2421#discussion_r17699917 --- Diff: sbin/start-thriftserver.sh --- @@ -27,7 +27,7 @@ set -o posix FWDIR="$(cd "`dirname "$0"`"/..; pwd)" CLASS="org.apache.spark.sql.hive.thriftserver.HiveThriftServer2" -CLASS_NOT_FOUND_EXIT_STATUS=1 +CLASS_NOT_FOUND_EXIT_STATUS=1024 --- End diff -- Exit code should be between 0 - 255. It's Bash's specification. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-55967900 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-55850909 Hmm, considering that `SparkSubmit` can be used to start any user application, which may call `System.exit(Int)` at any time with an arbitrary integer, it can a good idea to pick a more special exit code. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-55846456 **[Tests timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20442/consoleFull)** after a configured wait of `120m`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-55843315 @liancheng What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3547]Using a special exit code instead ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2421#issuecomment-55839702 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20442/consoleFull) for PR 2421 at commit [`fbb232f`](https://github.com/apache/spark/commit/fbb232f39271b7c0e41396c61a31bd8d9c4b32b5). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
