[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-28 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/4082


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-28 Thread JoshRosen
Github user JoshRosen commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-71894126
  
LGTM, so I'm going to pull this in for 1.3 so that we don't have to add 
backwards-compatibility code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-28 Thread squito
Github user squito commented on a diff in the pull request:

https://github.com/apache/spark/pull/4082#discussion_r23712334
  
--- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackend.scala
 ---
@@ -369,7 +369,7 @@ private[spark] class MesosSchedulerBackend(
   private def recordSlaveLost(d: SchedulerDriver, slaveId: SlaveID, 
reason: ExecutorLossReason) {
 inClassLoader() {
   logInfo("Mesos slave lost: " + slaveId.getValue)
-  removeExecutor(slaveId.getValue)
+  removeExecutor(slaveId.getValue, reason.toString)
--- End diff --

yes, sorry I wasn't meaning that it should hold up this PR -- I'm just 
pointing out with this alone, its far less useful than you might expect


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-28 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request:

https://github.com/apache/spark/pull/4082#discussion_r23711946
  
--- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackend.scala
 ---
@@ -369,7 +369,7 @@ private[spark] class MesosSchedulerBackend(
   private def recordSlaveLost(d: SchedulerDriver, slaveId: SlaveID, 
reason: ExecutorLossReason) {
 inClassLoader() {
   logInfo("Mesos slave lost: " + slaveId.getValue)
-  removeExecutor(slaveId.getValue)
+  removeExecutor(slaveId.getValue, reason.toString)
--- End diff --

I think improving the descriptiveness of the reasons is a separate concern 
from adding the plumbing to be able to record them in the log; we can improve / 
enhance the reason description in a separate followup PR if it turns out to be 
necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-28 Thread vanzin
Github user vanzin commented on a diff in the pull request:

https://github.com/apache/spark/pull/4082#discussion_r23709145
  
--- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackend.scala
 ---
@@ -369,7 +369,7 @@ private[spark] class MesosSchedulerBackend(
   private def recordSlaveLost(d: SchedulerDriver, slaveId: SlaveID, 
reason: ExecutorLossReason) {
 inClassLoader() {
   logInfo("Mesos slave lost: " + slaveId.getValue)
-  removeExecutor(slaveId.getValue)
+  removeExecutor(slaveId.getValue, reason.toString)
--- End diff --

This method is called in two different places with different reasons. 
Perhaps there are other situations where we'd want a more precise reason, but 
that shouldn't really affect this particular PR, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-28 Thread squito
Github user squito commented on a diff in the pull request:

https://github.com/apache/spark/pull/4082#discussion_r23708804
  
--- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackend.scala
 ---
@@ -369,7 +369,7 @@ private[spark] class MesosSchedulerBackend(
   private def recordSlaveLost(d: SchedulerDriver, slaveId: SlaveID, 
reason: ExecutorLossReason) {
 inClassLoader() {
   logInfo("Mesos slave lost: " + slaveId.getValue)
-  removeExecutor(slaveId.getValue)
+  removeExecutor(slaveId.getValue, reason.toString)
--- End diff --

does mesos ever actually give us a useful reason?  though it would be nice 
to have an actual reason for the executor being remove, it seems we'll end up 
with the "reason" for the executor removed event is just "Executor Lost", which 
is pretty useless.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-28 Thread vanzin
Github user vanzin commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-71868462
  
@JoshRosen could we get some eyes on this please? It'd be great to not miss 
1.3 and then have to add backwards compatibility cruft...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-71786315
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26204/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-27 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-71786313
  
  [Test build #26204 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26204/consoleFull)
 for   PR 4082 at commit 
[`a026ff2`](https://github.com/apache/spark/commit/a026ff236510c1ab242e71981102c7d0590c8dd6).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `case class SparkListenerExecutorAdded(time: Long, executorId: String, 
executorInfo: ExecutorInfo)`
  * `case class SparkListenerExecutorRemoved(time: Long, executorId: 
String, reason: String)`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-27 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-71781550
  
  [Test build #26204 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26204/consoleFull)
 for   PR 4082 at commit 
[`a026ff2`](https://github.com/apache/spark/commit/a026ff236510c1ab242e71981102c7d0590c8dd6).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-23 Thread ksakellis
Github user ksakellis commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-71282577
  
LGTM - nice addition. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-23 Thread vanzin
Github user vanzin commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-71272446
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-23 Thread vanzin
Github user vanzin commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-71248520
  
@ksakellis 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-71158431
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26000/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-22 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-71158426
  
  [Test build #26000 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26000/consoleFull)
 for   PR 4082 at commit 
[`979dfe1`](https://github.com/apache/spark/commit/979dfe174becaf6cad0d3b3a04e491189c2fe3ca).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `case class SparkListenerExecutorAdded(time: Long, executorId: String, 
executorInfo: ExecutorInfo)`
  * `case class SparkListenerExecutorRemoved(time: Long, executorId: 
String, reason: String)`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-22 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-71153614
  
  [Test build #26000 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26000/consoleFull)
 for   PR 4082 at commit 
[`979dfe1`](https://github.com/apache/spark/commit/979dfe174becaf6cad0d3b3a04e491189c2fe3ca).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-22 Thread sarutak
Github user sarutak commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-71153562
  
retest this please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-22 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-71139719
  
  [Test build #25988 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25988/consoleFull)
 for   PR 4082 at commit 
[`979dfe1`](https://github.com/apache/spark/commit/979dfe174becaf6cad0d3b3a04e491189c2fe3ca).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `case class SparkListenerExecutorAdded(time: Long, executorId: String, 
executorInfo: ExecutorInfo)`
  * `case class SparkListenerExecutorRemoved(time: Long, executorId: 
String, reason: String)`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-71139722
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25988/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-22 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-71135708
  
  [Test build #25988 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25988/consoleFull)
 for   PR 4082 at commit 
[`979dfe1`](https://github.com/apache/spark/commit/979dfe174becaf6cad0d3b3a04e491189c2fe3ca).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-70705999
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25825/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-20 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-70705989
  
  [Test build #25825 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25825/consoleFull)
 for   PR 4082 at commit 
[`cf9f908`](https://github.com/apache/spark/commit/cf9f9080ab6de652689e7ba5fa3f306f0d964c03).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `case class SparkListenerExecutorAdded(time: Long, executorId: String, 
executorInfo: ExecutorInfo)`
  * `case class SparkListenerExecutorRemoved(time: Long, executorId: 
String, reason: String)`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-20 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-70694161
  
  [Test build #25825 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25825/consoleFull)
 for   PR 4082 at commit 
[`cf9f908`](https://github.com/apache/spark/commit/cf9f9080ab6de652689e7ba5fa3f306f0d964c03).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-70691505
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25823/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-20 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-70691498
  
  [Test build #25823 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25823/consoleFull)
 for   PR 4082 at commit 
[`1f2a89b`](https://github.com/apache/spark/commit/1f2a89bfdd4bb5caa3b7ff215943466c90d79873).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `case class SparkListenerExecutorAdded(time: Long, executorId: String, 
executorInfo: ExecutorInfo)`
  * `case class SparkListenerExecutorRemoved(time: Long, executorId: 
String, reason: String)`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-20 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-70684473
  
  [Test build #25823 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25823/consoleFull)
 for   PR 4082 at commit 
[`1f2a89b`](https://github.com/apache/spark/commit/1f2a89bfdd4bb5caa3b7ff215943466c90d79873).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-16 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-70355982
  
  [Test build #25695 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25695/consoleFull)
 for   PR 4082 at commit 
[`243f2a6`](https://github.com/apache/spark/commit/243f2a600a2e42f806696208df9f969a5593ea5f).
 * This patch **passes all tests**.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `case class SparkListenerExecutorAdded(time: Long, executorId: String, 
executorInfo: ExecutorInfo)`
  * `case class SparkListenerExecutorRemoved(time: Long, executorId: 
String, reason: String)`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-70355983
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25695/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-16 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-70354556
  
  [Test build #25695 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25695/consoleFull)
 for   PR 4082 at commit 
[`243f2a6`](https://github.com/apache/spark/commit/243f2a600a2e42f806696208df9f969a5593ea5f).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-16 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-70352050
  
  [Test build #25691 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25691/consoleFull)
 for   PR 4082 at commit 
[`a527c35`](https://github.com/apache/spark/commit/a527c3564cfa62edef6b642d3db17d269e8f86a6).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `case class SparkListenerJobEnd(`
  * `case class SparkListenerExecutorAdded(time: Long, executorId: String, 
executorInfo: ExecutorInfo)`
  * `case class SparkListenerExecutorRemoved(time: Long, executorId: 
String, reason: String)`
  * `class SparkILoop(`
  * `   * @param id The id (variable name, method name, class name, etc) 
whose`
  * `   * Retrieves the class representing the id (variable name, method 
name,`
  * `   * @param id The id (variable name, method name, class name, etc) 
whose`
  * `   * @return Some containing term name (id) class if exists, else None`
  * `   * @param id The id (variable name, method name, class name, etc) 
whose`
  * `   * @param id The id (variable name, method name, class name, etc) 
whose`
  * `   * Retrieves the runtime class and type representing the id 
(variable name,`
  * `   * @param id The id (variable name, method name, class name, etc) 
whose`
  * `   * @param id The id (variable name, method name, class name, etc) 
whose`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-70352051
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25691/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-16 Thread SparkQA
Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/4082#issuecomment-70350295
  
  [Test build #25691 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25691/consoleFull)
 for   PR 4082 at commit 
[`a527c35`](https://github.com/apache/spark/commit/a527c3564cfa62edef6b642d3db17d269e8f86a6).
 * This patch merges cleanly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request: [SPARK-5291][CORE] Add timestamp and reason wh...

2015-01-16 Thread sarutak
GitHub user sarutak opened a pull request:

https://github.com/apache/spark/pull/4082

[SPARK-5291][CORE] Add timestamp and reason why an executor is removed to 
SparkListenerExecutorAdded and SparkListenerExecutorRemoved

Recently `SparkListenerExecutorAdded` and `SparkListenerExecutorRemoved` 
are added.
I think it's useful if they have timestamp and the reason why an executor 
is removed.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sarutak/spark SPARK-5291

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/4082.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4082


commit a527c3564cfa62edef6b642d3db17d269e8f86a6
Author: Kousuke Saruta 
Date:   2015-01-17T02:02:57Z

Added timestamp to SparkListenerExecutorAdded

Added timestamp and reason for removing to SparkListenerExecutorRemoved




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org