[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/7088#issuecomment-117380154 Oh, then it's OK --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/7088#issuecomment-117375453 @andrewor14 this is because #7082 is not merged into branch-1.4. Do you think if it's worth to merge into branch-1.4? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/7088#issuecomment-117342240 @zsxwing looks like this doesn't merge cleanly into branch-1.4. Can you open a new patch against that branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7088 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/7088#issuecomment-117275919 Looks great. I'm merging this into master and 1.4. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/7088#issuecomment-117187618 I think, we can merge this. @andrewor14 do you think this is ready to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7088#issuecomment-117037666 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7088#issuecomment-117037572 [Test build #36093 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36093/console) for PR 7088 at commit [`9ee4ef5`](https://github.com/apache/spark/commit/9ee4ef56a3721162c579ffa0012eed74fea9f6b5). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7088#issuecomment-116971300 [Test build #36093 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36093/consoleFull) for PR 7088 at commit [`9ee4ef5`](https://github.com/apache/spark/commit/9ee4ef56a3721162c579ffa0012eed74fea9f6b5). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7088#issuecomment-116969987 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7088#issuecomment-116970024 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/7088#issuecomment-116970124 Addressed comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/7088#discussion_r33541345
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
@@ -570,6 +570,35 @@ private[ui] class StagePage(parent: StagesTab) extends
WebUIPage("stage") {
val index = taskInfo.index
val attempt = taskInfo.attempt
+
+val svgTag =
+ if (totalExecutionTime == 0) {
+""
+ }
+ else {
+ s"""
+ |
--- End diff --
Good catch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7088#issuecomment-116799458 [Test build #36000 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36000/console) for PR 7088 at commit [`ef2ecfa`](https://github.com/apache/spark/commit/ef2ecfa285f38efbadafe91f21aae21a8159be9c). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7088#issuecomment-116799501 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/7088#discussion_r33492287
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
@@ -570,6 +570,35 @@ private[ui] class StagePage(parent: StagesTab) extends
WebUIPage("stage") {
val index = taskInfo.index
val attempt = taskInfo.attempt
+
+val svgTag =
--- End diff --
can you add a short comment here that links against the JIRA:
```
SPARK-8705: Avoid invalid attribute error in JavaScript if execution time
is 0
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/7088#discussion_r33491939
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
@@ -570,6 +570,35 @@ private[ui] class StagePage(parent: StagesTab) extends
WebUIPage("stage") {
val index = taskInfo.index
val attempt = taskInfo.attempt
+
+val svgTag =
+ if (totalExecutionTime == 0) {
+""
+ }
+ else {
--- End diff --
this should go on the previous line
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/7088#discussion_r33491885
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
@@ -570,6 +570,35 @@ private[ui] class StagePage(parent: StagesTab) extends
WebUIPage("stage") {
val index = taskInfo.index
val attempt = taskInfo.attempt
+
+val svgTag =
+ if (totalExecutionTime == 0) {
+""
+ }
+ else {
+ s"""
+ |
--- End diff --
is there an extra `"` here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/7088#issuecomment-116760825 Ah, that is after patch applied. O.K, I'll merge once the test finish successfully. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/7088#issuecomment-116759370 > could you show a screen shot in the case of totalExecutionTime == 0 ? I have already put a screenshot in the PR description. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/7088#issuecomment-116758162 LGTM, but just in case, could you show a screen shot in the case of `totalExecutionTime == 0` ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7088#issuecomment-116754818 [Test build #36000 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36000/consoleFull) for PR 7088 at commit [`ef2ecfa`](https://github.com/apache/spark/commit/ef2ecfa285f38efbadafe91f21aae21a8159be9c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7088#issuecomment-116753571 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7088#issuecomment-116753470 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
GitHub user zsxwing opened a pull request: https://github.com/apache/spark/pull/7088 [SPARK-8705][WebUI]Don't display rects when totalExecutionTime is 0 Because `System.currentTimeMillis()` is not accurate for tasks that only need several milliseconds, sometimes `totalExecutionTime` in `makeTimeline` will be 0. If `totalExecutionTime` is 0, there will the following error in the console.  This PR fixes it by using an empty svg tag when `totalExecutionTime` is 0. This is a screenshot for a task that its totalExecutionTime is 0 after fixing it.  You can merge this pull request into a Git repository by running: $ git pull https://github.com/zsxwing/spark SPARK-8705 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/7088.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #7088 commit ef2ecfa285f38efbadafe91f21aae21a8159be9c Author: zsxwing Date: 2015-06-29T16:29:41Z Don't display rects when totalExecutionTime is 0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8705][WebUI]Don't display rects when to...
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/7088#issuecomment-116751759 /cc @sarutak --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
