[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7750 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126414664 LGTM. Merging this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126315194 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126315107 [Test build #39039 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39039/console) for PR 7750 at commit [`29493f1`](https://github.com/apache/spark/commit/29493f12720dd9f02e8f199046f98f7a548756ea). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126308741 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126308704 [Test build #162 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SlowSparkPullRequestBuilder/162/console) for PR 7750 at commit [`29493f1`](https://github.com/apache/spark/commit/29493f12720dd9f02e8f199046f98f7a548756ea). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126271282 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126271392 [Test build #39039 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39039/consoleFull) for PR 7750 at commit [`29493f1`](https://github.com/apache/spark/commit/29493f12720dd9f02e8f199046f98f7a548756ea). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126271326 [Test build #162 has started](https://amplab.cs.berkeley.edu/jenkins/job/SlowSparkPullRequestBuilder/162/consoleFull) for PR 7750 at commit [`29493f1`](https://github.com/apache/spark/commit/29493f12720dd9f02e8f199046f98f7a548756ea). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126271268 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126270792 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126270806 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user squito commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126270650 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126167140 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126167113 [Test build #38932 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38932/console) for PR 7750 at commit [`29493f1`](https://github.com/apache/spark/commit/29493f12720dd9f02e8f199046f98f7a548756ea). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126164641 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126164478 [Test build #149 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SlowSparkPullRequestBuilder/149/console) for PR 7750 at commit [`29493f1`](https://github.com/apache/spark/commit/29493f12720dd9f02e8f199046f98f7a548756ea). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126142860 [Test build #38932 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38932/consoleFull) for PR 7750 at commit [`29493f1`](https://github.com/apache/spark/commit/29493f12720dd9f02e8f199046f98f7a548756ea). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126141717 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126141622 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126141028 [Test build #149 has started](https://amplab.cs.berkeley.edu/jenkins/job/SlowSparkPullRequestBuilder/149/consoleFull) for PR 7750 at commit [`29493f1`](https://github.com/apache/spark/commit/29493f12720dd9f02e8f199046f98f7a548756ea). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126140892 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126140940 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user squito commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126140616 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126116880 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126116843 [Test build #38877 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38877/console) for PR 7750 at commit [`29493f1`](https://github.com/apache/spark/commit/29493f12720dd9f02e8f199046f98f7a548756ea). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126115261 Yeah its tricky to add a test case for this -- We could do it by refactoring the code and testing a smaller function which takes in the array size as an argument etc. but that'll be a much bigger code change. Since this is a more contained change I'd actually recommend just merging the current diff for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user squito commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126095693 `s1` & `s2` are already longs, which means so is `size` -- so no change needed there. (not that I had checked this before you mentioned it ...) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126093097 Does the `val size = math.min(s1, s2)` line need `toLong` too? it gets multiplied by a big number before being divided by one. I could be missing why it's not needed or can't be done but seemed like a possible issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126089865 [Test build #38877 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38877/consoleFull) for PR 7750 at commit [`29493f1`](https://github.com/apache/spark/commit/29493f12720dd9f02e8f199046f98f7a548756ea). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126088376 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126088345 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user squito commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126087430 @shivaram good idea. I updated one more spot where it seems there could be overflow -- I will admit I don't completely understand what is going on there, but the change seems safe. the only other place its called is https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/util/SizeEstimator.scala#L217 which is not going to overflow. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126050652 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126050512 [Test build #38853 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38853/console) for PR 7750 at commit [`bc1cb82`](https://github.com/apache/spark/commit/bc1cb82f3a8386fd5ca2dafedf5fd648077bdafe). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126024536 LGTM. Could we also check all the other instances where alignSize is called ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126007092 [Test build #38853 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38853/consoleFull) for PR 7750 at commit [`bc1cb82`](https://github.com/apache/spark/commit/bc1cb82f3a8386fd5ca2dafedf5fd648077bdafe). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126006851 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user squito commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126006883 any suggestions on a test that doesn't require 2 GB of memory? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7750#issuecomment-126006881 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9437][core] avoid overflow in SizeEstim...
GitHub user squito opened a pull request: https://github.com/apache/spark/pull/7750 [SPARK-9437][core] avoid overflow in SizeEstimator https://issues.apache.org/jira/browse/SPARK-9437 You can merge this pull request into a Git repository by running: $ git pull https://github.com/squito/spark SPARK-9437_size_estimator_overflow Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/7750.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #7750 commit bc1cb82f3a8386fd5ca2dafedf5fd648077bdafe Author: Imran Rashid Date: 2015-07-29T16:19:22Z avoid overflow --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
