[GitHub] spark pull request: [SPARK-9980][BUILD] Fix SBT publishLocal error...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8209 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9980][BUILD] Fix SBT publishLocal error...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8209#issuecomment-131264579 [Test build #1607 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1607/console) for PR 8209 at commit [`9111dc0`](https://github.com/apache/spark/commit/9111dc0ab244eafd225c2cf700257cbae9dfe7db). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9980][BUILD] Fix SBT publishLocal error...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8209#issuecomment-131230888 [Test build #1607 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1607/consoleFull) for PR 8209 at commit [`9111dc0`](https://github.com/apache/spark/commit/9111dc0ab244eafd225c2cf700257cbae9dfe7db). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9980][BUILD] Fix SBT publishLocal error...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8209#issuecomment-131229840 [Test build #40896 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40896/console) for PR 8209 at commit [`4a743c2`](https://github.com/apache/spark/commit/4a743c2cb7e6a4aa86e693f6b48e5528334ce5d6). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9980][BUILD] Fix SBT publishLocal error...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8209#issuecomment-13122 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40896/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9980][BUILD] Fix SBT publishLocal error...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8209#issuecomment-131229994 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9980][BUILD] Fix SBT publishLocal error...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/8209#issuecomment-131210873 I'd rather leave the scala source alone for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9980][BUILD] Fix SBT publishLocal error...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8209#issuecomment-131206852 Hm, still seems better for consistency and/or to future-proof; to the extent the docs are read as HTML it isn't valid. I don't feel super strongly about addressing it now though if it's not causing an error. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9980][BUILD] Fix SBT publishLocal error...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/8209#issuecomment-131206616 I have replaced `` tags by `` in all java files I could find them in. I haven't touched the ```BytesToByteMap```, ```Bin``` and ```PagedTable``` classes because these are written scala and Scaladoc has no problem with ```<<```'s. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9980][BUILD] Fix SBT publishLocal error...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8209#discussion_r37103923
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -211,10 +211,10 @@ public SparkLauncher addSparkArg(String arg) {
* Adds an argument with a value to the Spark invocation. If the
argument name corresponds to
* a known argument, the code validates that the argument actually
expects a value, and throws
* an exception otherwise.
- *
+ *
--- End diff --
Hm I though that's because it now required valid HTML, like `...`.
Well, if it fixes an error, obviously that's better than an error. There seem
to be ~17 occurrences of this in the code base though -- worth fixing it in one
go?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9980][BUILD] Fix SBT publishLocal error...
Github user hvanhovell commented on the pull request: https://github.com/apache/spark/pull/8209#issuecomment-131198780 I'll change those as well. It is strange that these didn't create problems; I guess it has something to do with the position of the << in the line. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9980][BUILD] Fix SBT publishLocal error...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/8209#discussion_r37103311
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -211,10 +211,10 @@ public SparkLauncher addSparkArg(String arg) {
* Adds an argument with a value to the Spark invocation. If the
argument name corresponds to
* a known argument, the code validates that the argument actually
expects a value, and throws
* an exception otherwise.
- *
+ *
--- End diff --
So it turns out that javadoc in java 8 doesn't allow self-closing elements
(`` and ``) any more:
http://stackoverflow.com/questions/26049329/javadoc-in-jdk-8-invalid-self-closing-element-not-allowed
http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#format
`` is the preferred seperator for a paragraph. So its is not HTML
but Javadoc we are talking about. Sorry about the confusion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9980][BUILD] Fix SBT publishLocal error...
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/8209#issuecomment-131195350 I found several instances of a similar javadoc problem in: - BytesToBytesMap - Bin - PagedTable Let's clean those up along the way? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9980][BUILD] Fix SBT publishLocal error...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8209#discussion_r37101619
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -211,10 +211,10 @@ public SparkLauncher addSparkArg(String arg) {
* Adds an argument with a value to the Spark invocation. If the
argument name corresponds to
* a known argument, the code validates that the argument actually
expects a value, and throws
* an exception otherwise.
- *
+ *
--- End diff --
I think this isn't more valid as HTML. Was this just an extraneous change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9980][BUILD] Fix SBT publishLocal error...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8209#issuecomment-131193368 [Test build #40896 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40896/consoleFull) for PR 8209 at commit [`4a743c2`](https://github.com/apache/spark/commit/4a743c2cb7e6a4aa86e693f6b48e5528334ce5d6). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9980][BUILD] Fix SBT publishLocal error...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8209#issuecomment-131193050 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9980][BUILD] Fix SBT publishLocal error...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8209#issuecomment-131193079 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9980][BUILD] Fix SBT publishLocal error...
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/8209#issuecomment-131192668 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9980][BUILD] Fix SBT publishLocal error...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8209#issuecomment-131191189 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9980][BUILD] Fix SBT publishLocal error...
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/8209 [SPARK-9980][BUILD] Fix SBT publishLocal error due to invalid characters in doc Tiny modification to a few comments ```sbt publishLocal``` work again. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hvanhovell/spark SPARK-9980 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/8209.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8209 commit 500fe15c3ef7c6e835d09dc9d9025c58c3467a76 Author: Herman van Hovell Date: 2015-08-14T17:18:42Z Replace << by HTML friendly << commit 4a743c2cb7e6a4aa86e693f6b48e5528334ce5d6 Author: Herman van Hovell Date: 2015-08-14T17:33:09Z Replace self closing statements witt . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
