[GitHub] spark pull request: SPARK-3926 [CORE] Reopened: result of JavaRDD ...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3587#issuecomment-67385606 I've merged this into `branch-1.2`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-3926 [CORE] Reopened: result of JavaRDD ...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3587#issuecomment-66213074 LGTM, too. Merging into `master` and tagging for `branch-1.2` backport. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-3926 [CORE] Reopened: result of JavaRDD ...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3587 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-3926 [CORE] Reopened: result of JavaRDD ...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3587#issuecomment-66213344 Merged to `branch-1.1`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-3926 [CORE] Reopened: result of JavaRDD ...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3587#discussion_r21372796
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaUtils.scala ---
@@ -32,7 +33,65 @@ private[spark] object JavaUtils {
def mapAsSerializableJavaMap[A, B](underlying: collection.Map[A, B]) =
new SerializableMapWrapper(underlying)
+ // Implementation is copied from
scala.collection.convert.Wrappers.MapWrapper,
--- End diff --
Good question. It appears to be licensed just like the rest of the Scala
code (http://www.scala-lang.org/license.html) Spark already integrates some
Scala code and has the proper entries in `LICENSE` as a result. I can modify
the text to clearly call out that part of `MapWrapper` was copied, for good
measure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-3926 [CORE] Reopened: result of JavaRDD ...
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3587#discussion_r21377699
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaUtils.scala ---
@@ -32,7 +33,65 @@ private[spark] object JavaUtils {
def mapAsSerializableJavaMap[A, B](underlying: collection.Map[A, B]) =
new SerializableMapWrapper(underlying)
+ // Implementation is copied from
scala.collection.convert.Wrappers.MapWrapper,
+ // but implements java.io.Serializable and adds a no-arg constructor
class SerializableMapWrapper[A, B](underlying: collection.Map[A, B])
-extends MapWrapper(underlying) with java.io.Serializable
+extends ju.AbstractMap[A, B] with java.io.Serializable { self =
+// Add no-arg constructor just for serialization
+def this() = this(null)
--- End diff --
Hm, so it does. Maybe I misunderstood the original error. It's complaining
about the _superclass_ (`MapWrapper`) not having a no-arg constructor? So
copying the class works, since we no longer subclass `MapWrapper`, but the copy
in `SerializableMapWrapper` need not define a no-arg constructor. OK, that line
can be removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-3926 [CORE] Reopened: result of JavaRDD ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3587#issuecomment-65805992 [Test build #24184 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24184/consoleFull) for PR 3587 at commit [`8586bb9`](https://github.com/apache/spark/commit/8586bb9c72047e378366fa429d4e1e75a44c0d63). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-3926 [CORE] Reopened: result of JavaRDD ...
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/3587#issuecomment-65806925 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-3926 [CORE] Reopened: result of JavaRDD ...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3587#issuecomment-65819459 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24184/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-3926 [CORE] Reopened: result of JavaRDD ...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3587#issuecomment-65819448 [Test build #24184 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24184/consoleFull) for PR 3587 at commit [`8586bb9`](https://github.com/apache/spark/commit/8586bb9c72047e378366fa429d4e1e75a44c0d63). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: SPARK-3926 [CORE] Reopened: result of JavaRDD ...
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/3587#discussion_r21352968
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaUtils.scala ---
@@ -32,7 +33,65 @@ private[spark] object JavaUtils {
def mapAsSerializableJavaMap[A, B](underlying: collection.Map[A, B]) =
new SerializableMapWrapper(underlying)
+ // Implementation is copied from
scala.collection.convert.Wrappers.MapWrapper,
--- End diff --
Does this create any licensing issues? Do we need to add a separate header
somewhere?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
