[GitHub] spark pull request: Scala version switching build enhancements
Github user mallman commented on the pull request: https://github.com/apache/spark/pull/6832#issuecomment-112477102 @srowen Will create a Jira ticket. @ScrapCodes This is what I get with (presumably BSD) sed on OS X: ``` [msa@Michaels-MacBook-Pro spark-1.4]$ ./dev/change-version-to-2.11.sh [msa@Michaels-MacBook-Pro spark-1.4]$ gst On branch scala-versions Your branch and 'vamp/scala-versions' have diverged, and have 7 and 4 different commits each, respectively. (use git pull to merge the remote branch into yours) Changes not staged for commit: (use git add file... to update what will be committed) (use git checkout -- file... to discard changes in working directory) modified: assembly/pom.xml modified: bagel/pom.xml modified: core/pom.xml modified: dev/change-scala-version.sh modified: docs/_plugins/copy_api_dirs.rb modified: examples/pom.xml modified: external/flume-sink/pom.xml modified: external/flume/pom.xml modified: external/kafka-assembly/pom.xml modified: external/kafka/pom.xml modified: external/mqtt/pom.xml modified: external/twitter/pom.xml modified: external/zeromq/pom.xml modified: extras/java8-tests/pom.xml modified: extras/kinesis-asl/pom.xml modified: extras/spark-ganglia-lgpl/pom.xml modified: graphx/pom.xml modified: launcher/pom.xml modified: mllib/pom.xml modified: network/common/pom.xml modified: network/shuffle/pom.xml modified: network/yarn/pom.xml modified: pom.xml modified: repl/pom.xml modified: sql/catalyst/pom.xml modified: sql/core/pom.xml modified: sql/hive-thriftserver/pom.xml modified: sql/hive/pom.xml modified: streaming/pom.xml modified: tools/pom.xml modified: unsafe/pom.xml modified: yarn/pom.xml Untracked files: (use git add file... to include in what will be committed) assembly/pom.xml-e bagel/pom.xml-e core/pom.xml-e dev/audit-release/blank_maven_build/pom.xml-e dev/audit-release/maven_app_core/pom.xml-e docs/_plugins/copy_api_dirs.rb-e examples/pom.xml-e external/flume-sink/pom.xml-e external/flume/pom.xml-e external/kafka-assembly/pom.xml-e external/kafka/pom.xml-e external/mqtt/pom.xml-e external/twitter/pom.xml-e external/zeromq/pom.xml-e extras/java8-tests/pom.xml-e extras/kinesis-asl/pom.xml-e extras/spark-ganglia-lgpl/pom.xml-e graphx/pom.xml-e launcher/pom.xml-e mllib/pom.xml-e network/common/pom.xml-e network/shuffle/pom.xml-e network/yarn/pom.xml-e pom.xml-e repl/pom.xml-e sql/catalyst/pom.xml-e sql/core/pom.xml-e sql/hive-thriftserver/pom.xml-e sql/hive/pom.xml-e streaming/pom.xml-e tools/pom.xml-e unsafe/pom.xml-e yarn/pom.xml-e no changes added to commit (use git add and/or git commit -a) ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Scala version switching build enhancements
Github user mallman commented on the pull request: https://github.com/apache/spark/pull/6832#issuecomment-112478712 @srowen Should I create one Jira ticket for this or multiple? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Scala version switching build enhancements
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/6832#issuecomment-112522218 One JIRA is fine. Yes I see the same problem with OS X `sed`, so falling back to `gsed` is probably good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Scala version switching build enhancements
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/6832#issuecomment-112306270 @mallman Have a look at https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark please CC @ScrapCodes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Scala version switching build enhancements
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/6832#issuecomment-112308999 I am Ok with 1. Is there a reason we should restrict ourselves to GNU SED ? I suppose our scripts were posix complaint. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Scala version switching build enhancements
GitHub user mallman opened a pull request:
https://github.com/apache/spark/pull/6832
Scala version switching build enhancements
These commits address a few minor issues in the Scala cross-version support
in the build:
1. Correct two missing `${scala.binary.version}` pom file substitutions.
2. Don't update `scala.binary.version` in parent POM. This property is
set through profiles.
3. Update the source of the generated scaladocs in
`docs/_plugins/copy_api_dirs.rb`.
4. Factor common code out of `dev/change-version-to-*.sh` and add some
validation. We also test `sed` to see if it's GNU sed and try `gsed` as an
alternative if not. This prevents the script from running with a non-GNU sed.
This is my first contribution to Spark. After reading the contributor
guidelines I wasn't sure if this qualified for a Jira ticket, or if I should
split these commits into separate contributions. I'm happy to amend my pull
request or file a Jira ticket as requested.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/VideoAmp/spark-1 scala-versions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/6832.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6832
commit 475088e7423b59dd7a9ef4b0ab426ebcc3e555ba
Author: Michael Allman mich...@videoamp.com
Date: 2015-06-14T19:17:56Z
Replace jackson-module-scala_2.10 with
jackson-module-scala_${scala.binary.version}
commit e5a675e3411bdfa3e6e387f6688f330fb8e5067b
Author: Michael Allman mich...@videoamp.com
Date: 2015-06-14T19:20:36Z
Don't update scala.binary.version in parent POM. This property is set
through profiles
commit a896dfdff26e56f8c6f0a4769b1d576e3494a524
Author: Michael Allman mich...@videoamp.com
Date: 2015-06-14T19:34:57Z
Update source of scaladocs when changing Scala version
commit 2b926205ff863c1132f3e1d923ff4715ee566bbc
Author: Michael Allman mich...@videoamp.com
Date: 2015-06-14T19:36:10Z
Factor change-scala-version.sh out of change-version-to-*.sh, adding
command line argument validation and testing for GNU sed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: Scala version switching build enhancements
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6832#issuecomment-112243794 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
