[GitHub] spark pull request #14749: [SPARK-17182][SQL] Mark Collect as non-determinis...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14749 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14749: [SPARK-17182][SQL] Mark Collect as non-determinis...
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/14749#discussion_r75783595
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/collect.scala
---
@@ -54,6 +54,10 @@ abstract class Collect extends ImperativeAggregate {
override def inputAggBufferAttributes: Seq[AttributeReference] = Nil
+ // Both `CollectList` and `CollectSet` are non-deterministic since their
results depend on the
+ // actual order of input rows.
+ override def deterministic: Boolean = false
--- End diff --
Yea. Also, there's no set type in Spark SQL, thus the result set is
actually just a list without duplicated elements.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14749: [SPARK-17182][SQL] Mark Collect as non-determinis...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14749#discussion_r75767484
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/collect.scala
---
@@ -54,6 +54,10 @@ abstract class Collect extends ImperativeAggregate {
override def inputAggBufferAttributes: Seq[AttributeReference] = Nil
+ // Both `CollectList` and `CollectSet` are non-deterministic since their
results depend on the
+ // actual order of input rows.
+ override def deterministic: Boolean = false
--- End diff --
NVM. Actually iteration over a set is non-deterministic for values in the
same hash bucket.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14749: [SPARK-17182][SQL] Mark Collect as non-determinis...
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14749#discussion_r75699347
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/collect.scala
---
@@ -54,6 +54,10 @@ abstract class Collect extends ImperativeAggregate {
override def inputAggBufferAttributes: Seq[AttributeReference] = Nil
+ // Both `CollectList` and `CollectSet` are non-deterministic since their
results depend on the
+ // actual order of input rows.
+ override def deterministic: Boolean = false
--- End diff --
Is `collect_set` non deterministic? It is backed by a `HashSet`, and the
way elements are iterated over does not rely on the input order.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #14749: [SPARK-17182][SQL] Mark Collect as non-determinis...
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/14749 [SPARK-17182][SQL] Mark Collect as non-deterministic ## What changes were proposed in this pull request? This PR marks the abstract class `Collect` as non-deterministic since the results of `CollectList` and `CollectSet` depend on the actual order of input rows. ## How was this patch tested? Existing test cases should be enough. You can merge this pull request into a Git repository by running: $ git pull https://github.com/liancheng/spark spark-17182-non-deterministic-collect Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/14749.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14749 commit 0045128166dc09d02f6ea454b29e6a7b5999 Author: Cheng Lian Date: 2016-08-22T10:29:21Z Mark Collect as non-deterministic --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
