[GitHub] spark pull request #16707: [SPARK-19338][SQL] Add UDF names in explain
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16707 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16707: [SPARK-19338][SQL] Add UDF names in explain
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/16707#discussion_r97937869
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala ---
@@ -125,7 +125,7 @@ class UDFRegistration private[sql] (functionRegistry:
FunctionRegistry) extends
def register[RT: TypeTag](name: String, func: Function0[RT]):
UserDefinedFunction = {
val dataType = ScalaReflection.schemaFor[RT].dataType
val inputTypes = Try(Nil).toOption
-def builder(e: Seq[Expression]) = ScalaUDF(func, dataType, e,
inputTypes.getOrElse(Nil))
+def builder(e: Seq[Expression]) = ScalaUDF(func, dataType, e,
inputTypes.getOrElse(Nil), Some(name))
--- End diff --
oh, yea, you're right. Thanks! I'll fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16707: [SPARK-19338][SQL] Add UDF names in explain
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16707#discussion_r97937744
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala ---
@@ -125,7 +125,7 @@ class UDFRegistration private[sql] (functionRegistry:
FunctionRegistry) extends
def register[RT: TypeTag](name: String, func: Function0[RT]):
UserDefinedFunction = {
val dataType = ScalaReflection.schemaFor[RT].dataType
val inputTypes = Try(Nil).toOption
-def builder(e: Seq[Expression]) = ScalaUDF(func, dataType, e,
inputTypes.getOrElse(Nil))
+def builder(e: Seq[Expression]) = ScalaUDF(func, dataType, e,
inputTypes.getOrElse(Nil), Some(name))
--- End diff --
Oh, I remember I was told that we should remove or fix the comments above
to generate this codes too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16707: [SPARK-19338][SQL] Add UDF names in explain
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/16707 [SPARK-19338][SQL] Add UDF names in explain ## What changes were proposed in this pull request? This pr added a variable for a UDF name in `ScalaUDF`. Then, if the variable filled, `DataFrame#explain` prints the name. ## How was this patch tested? Added a test in `UDFSuite`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/maropu/spark SPARK-19338 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/16707.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #16707 commit 1b705611925eefb30fbf5483ce1b976958192b01 Author: Takeshi YAMAMURO Date: 2017-01-24T15:21:07Z Add UDF names in explain --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
